You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hcatalog-commits@incubator.apache.org by "Jakob Homan (JIRA)" <ji...@apache.org> on 2011/05/02 22:29:03 UTC
[jira] [Updated] (HCATALOG-17) Shouldn't be able to add an
HCatFieldSchema with the same name as existing
[ https://issues.apache.org/jira/browse/HCATALOG-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HCATALOG-17:
--------------------------------
Attachment: dupe_fields.patch
Same patch as on github. Verified against trunk. All tests pass, except TestHiveCompatibility, which fails without patch as well.
> Shouldn't be able to add an HCatFieldSchema with the same name as existing
> --------------------------------------------------------------------------
>
> Key: HCATALOG-17
> URL: https://issues.apache.org/jira/browse/HCATALOG-17
> Project: HCatalog
> Issue Type: Bug
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: dupe_fields.patch
>
>
> (cloning from https://github.com/yahoo/howl/pull/6)
> As noted in HowlSchema.java, one should not be able to append an a field schema with the same name. The code says that this requires Comparable, which is not correct, since we're not doing ordering. Technically, this requires a correct equals, but since we don't want multiple fields with the same name in a schema (particularly since we index it via the name in the accompanying map), the correct check is just based on the name. This adds the check and throws a HowlException if this occurs.
> Unit test to verify is included.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira