You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by oliversalzburg <gi...@git.apache.org> on 2014/10/21 15:48:47 UTC

[GitHub] cordova-lib pull request: Fix xcode project manipulation on Window...

GitHub user oliversalzburg opened a pull request:

    https://github.com/apache/cordova-lib/pull/109

    Fix xcode project manipulation on Windows OS

    When adding plugins on Windows, plugman will insert incorrect paths, which also contain backslashes into the xcode project files. This breaks builds of the iOS app in Xcode and requires manual editing of the project file.
    
    On all non-Windows platforms, where the path separator is already `/`, the performed replace should be a noop, on Windows it fixes the paths in the project file.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/oliversalzburg/cordova-lib fix/windows-xcode

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/109.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #109
    
----
commit dcba1046eaa6cf6d0e5cb043d42426306c5827e7
Author: Oliver Salzburg <ol...@gmail.com>
Date:   2014-10-21T13:48:29Z

    Fix xcode project manipulation on Windows OS
    
    When adding plugins on Windows, plugman will insert incorrect paths, which also contain backslashes into the xcode project files. This breaks builds of the iOS app in Xcode and requires manual editing of the project file.
    
    On all non-Windows platforms, where the path separator is already `/`, the performed replace should be a noop, on Windows it fixes the paths in the project file.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-lib pull request: Fix xcode project manipulation on Window...

Posted by oliversalzburg <gi...@git.apache.org>.
Github user oliversalzburg commented on the pull request:

    https://github.com/apache/cordova-lib/pull/109#issuecomment-59930309
  
    Relates to https://issues.apache.org/jira/browse/CB-7311


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-lib pull request: Fix xcode project manipulation on Window...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-lib/pull/109


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org