[jira] [Commented] (ARROW-1821) Add integration test case to explicitly check for optional validity buffer

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254489#comment-16254489 ] 

ASF GitHub Bot commented on ARROW-1821:
---------------------------------------

BryanCutler opened a new pull request #1323: ARROW-1821: [INTEGRATION] Add integration test case for when Field has zero null count and optional validity buffer
URL: https://github.com/apache/arrow/pull/1323
 
 
   Currently when a Field has null count = 0, C++ will omit the validity buffer as it is optional in this case.  Testing for #1316 was failing because Java was not handling this properly.  This PR adds an explicit test to ensure this is being tested and easier to locate possible issues. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add integration test case to explicitly check for optional validity buffer
> --------------------------------------------------------------------------
>
>                 Key: ARROW-1821
>                 URL: https://issues.apache.org/jira/browse/ARROW-1821
>             Project: Apache Arrow
>          Issue Type: Test
>            Reporter: Bryan Cutler
>            Assignee: Bryan Cutler
>              Labels: pull-request-available
>             Fix For: 0.8.0
>
>
> When the null count of a Field is 0 the validity buffer is optional in a RecordBatch message. From ARROW-1476, integration tests were failing because of this (see discussion here https://github.com/apache/arrow/pull/1316#issuecomment-344439955). The failure occurred due to chance of the random seed for generating the validity buffer. We should explicitly test this case for integration testing in the future.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)