You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2022/09/01 09:08:03 UTC
[GitHub] [shenyu] dragon-zhang opened a new pull request, #3903: [type: refactor] use broader interface
dragon-zhang opened a new pull request, #3903:
URL: https://github.com/apache/shenyu/pull/3903
see https://github.com/apache/dubbo/pull/10414
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #3903: [type: refactor] use broader interface
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3903:
URL: https://github.com/apache/shenyu/pull/3903#issuecomment-1234022597
# [Codecov](https://codecov.io/gh/apache/shenyu/pull/3903?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3903](https://codecov.io/gh/apache/shenyu/pull/3903?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (936ff93) into [master](https://codecov.io/gh/apache/shenyu/commit/7a559676ba51bc9fccb5423eec94e3abc4c2eb30?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a55967) will **decrease** coverage by `0.40%`.
> The diff coverage is `76.92%`.
```diff
@@ Coverage Diff @@
## master #3903 +/- ##
============================================
- Coverage 70.89% 70.48% -0.41%
+ Complexity 6760 6744 -16
============================================
Files 906 912 +6
Lines 25109 25326 +217
Branches 2249 2271 +22
============================================
+ Hits 17801 17852 +51
- Misses 5931 6093 +162
- Partials 1377 1381 +4
```
| [Impacted Files](https://codecov.io/gh/apache/shenyu/pull/3903?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...g/apache/shenyu/common/concurrent/AbortPolicy.java](https://codecov.io/gh/apache/shenyu/pull/3903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9jb25jdXJyZW50L0Fib3J0UG9saWN5LmphdmE=) | `100.00% <ø> (ø)` | |
| [.../shenyu/common/concurrent/DiscardOldestPolicy.java](https://codecov.io/gh/apache/shenyu/pull/3903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9jb25jdXJyZW50L0Rpc2NhcmRPbGRlc3RQb2xpY3kuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...apache/shenyu/common/concurrent/DiscardPolicy.java](https://codecov.io/gh/apache/shenyu/pull/3903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9jb25jdXJyZW50L0Rpc2NhcmRQb2xpY3kuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...ogging/common/constant/GenericLoggingConstant.java](https://codecov.io/gh/apache/shenyu/pull/3903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9sb2dnaW5nL2NvbW1vbi9jb25zdGFudC9HZW5lcmljTG9nZ2luZ0NvbnN0YW50LmphdmE=) | `0.00% <ø> (ø)` | |
| [...tencent/cls/client/TencentClsLogCollectClient.java](https://codecov.io/gh/apache/shenyu/pull/3903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLXRlbmNlbnQtY2xzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL3RlbmNlbnQvY2xzL2NsaWVudC9UZW5jZW50Q2xzTG9nQ29sbGVjdENsaWVudC5qYXZh) | `67.77% <67.77%> (ø)` | |
| [...in/tencent/cls/config/TencentLogCollectConfig.java](https://codecov.io/gh/apache/shenyu/pull/3903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLXRlbmNlbnQtY2xzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL3RlbmNlbnQvY2xzL2NvbmZpZy9UZW5jZW50TG9nQ29sbGVjdENvbmZpZy5qYXZh) | `76.19% <76.19%> (ø)` | |
| [...ls/handler/LoggingTencentClsPluginDataHandler.java](https://codecov.io/gh/apache/shenyu/pull/3903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLXRlbmNlbnQtY2xzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL3RlbmNlbnQvY2xzL2hhbmRsZXIvTG9nZ2luZ1RlbmNlbnRDbHNQbHVnaW5EYXRhSGFuZGxlci5qYXZh) | `84.21% <84.21%> (ø)` | |
| [...he/shenyu/loadbalancer/spi/RandomLoadBalancer.java](https://codecov.io/gh/apache/shenyu/pull/3903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWxvYWRiYWxhbmNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2xvYWRiYWxhbmNlci9zcGkvUmFuZG9tTG9hZEJhbGFuY2VyLmphdmE=) | `91.66% <88.23%> (-1.44%)` | :arrow_down: |
| [...ava/org/apache/shenyu/common/enums/PluginEnum.java](https://codecov.io/gh/apache/shenyu/pull/3903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9lbnVtcy9QbHVnaW5FbnVtLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...yu/plugin/tencent/cls/LoggingTencentClsPlugin.java](https://codecov.io/gh/apache/shenyu/pull/3903/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWxvZ2dpbmcvc2hlbnl1LXBsdWdpbi1sb2dnaW5nLXRlbmNlbnQtY2xzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL3RlbmNlbnQvY2xzL0xvZ2dpbmdUZW5jZW50Q2xzUGx1Z2luLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [46 more](https://codecov.io/gh/apache/shenyu/pull/3903/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] yu199195 merged pull request #3903: [type: refactor] use broader interface
Posted by GitBox <gi...@apache.org>.
yu199195 merged PR #3903:
URL: https://github.com/apache/shenyu/pull/3903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org