You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2018/08/21 21:42:34 UTC
Review Request 68458: Fixed the lib_logrotate inappropriate
UNSET_CLOEXEC via ChildHook.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68458/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao, Jie Yu, and James Peach.
Repository: mesos
Description
-------
Previously, we call os::unsetCloexec() on write fd for both outfds and
errfds. Basically, this is not needed because all stdout and stderr
fds will be closed at childMain() method. As a result, no need to do
unsetCloexec() either from the parent process side or UNSET_CLOEXEC
via the ChildHook.
Diffs
-----
src/slave/container_loggers/lib_logrotate.cpp 6a2839e07e0ea759ec16cb879ef0602341fd9f5c
Diff: https://reviews.apache.org/r/68458/diff/1/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 68458: Fixed the lib_logrotate inappropriate
UNSET_CLOEXEC via ChildHook.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68458/#review207715
-----------------------------------------------------------
Ship it!
Ship It!
- James Peach
On Aug. 21, 2018, 10:03 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68458/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 10:03 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Jie Yu, and James Peach.
>
>
> Bugs: MESOS-9151
> https://issues.apache.org/jira/browse/MESOS-9151
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, we call os::unsetCloexec() on write fd for both outfds and
> errfds. Basically, this is not needed because all stdout and stderr
> fds will be closed at childMain() method. As a result, no need to do
> unsetCloexec() either from the parent process side or UNSET_CLOEXEC
> via the ChildHook.
>
>
> Diffs
> -----
>
> src/slave/container_loggers/lib_logrotate.cpp 6a2839e07e0ea759ec16cb879ef0602341fd9f5c
>
>
> Diff: https://reviews.apache.org/r/68458/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 68458: Fixed the lib_logrotate inappropriate
UNSET_CLOEXEC via ChildHook.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68458/#review207720
-----------------------------------------------------------
PASS: Mesos patch 68458 was successfully built and tested.
Reviews applied: `['68458']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2213/mesos-review-68458
- Mesos Reviewbot Windows
On Aug. 21, 2018, 10:03 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68458/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 10:03 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Jie Yu, and James Peach.
>
>
> Bugs: MESOS-9151
> https://issues.apache.org/jira/browse/MESOS-9151
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, we call os::unsetCloexec() on write fd for both outfds and
> errfds. Basically, this is not needed because all stdout and stderr
> fds will be closed at childMain() method. As a result, no need to do
> unsetCloexec() either from the parent process side or UNSET_CLOEXEC
> via the ChildHook.
>
>
> Diffs
> -----
>
> src/slave/container_loggers/lib_logrotate.cpp 6a2839e07e0ea759ec16cb879ef0602341fd9f5c
>
>
> Diff: https://reviews.apache.org/r/68458/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 68458: Fixed the lib_logrotate inappropriate
UNSET_CLOEXEC via ChildHook.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68458/
-----------------------------------------------------------
(Updated Aug. 21, 2018, 10:03 p.m.)
Review request for mesos, Chun-Hung Hsiao, Jie Yu, and James Peach.
Bugs: MESOS-9151
https://issues.apache.org/jira/browse/MESOS-9151
Repository: mesos
Description
-------
Previously, we call os::unsetCloexec() on write fd for both outfds and
errfds. Basically, this is not needed because all stdout and stderr
fds will be closed at childMain() method. As a result, no need to do
unsetCloexec() either from the parent process side or UNSET_CLOEXEC
via the ChildHook.
Diffs
-----
src/slave/container_loggers/lib_logrotate.cpp 6a2839e07e0ea759ec16cb879ef0602341fd9f5c
Diff: https://reviews.apache.org/r/68458/diff/1/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 68458: Fixed the lib_logrotate inappropriate
UNSET_CLOEXEC via ChildHook.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68458/#review207703
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Aug. 21, 2018, 9:42 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68458/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 9:42 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Jie Yu, and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, we call os::unsetCloexec() on write fd for both outfds and
> errfds. Basically, this is not needed because all stdout and stderr
> fds will be closed at childMain() method. As a result, no need to do
> unsetCloexec() either from the parent process side or UNSET_CLOEXEC
> via the ChildHook.
>
>
> Diffs
> -----
>
> src/slave/container_loggers/lib_logrotate.cpp 6a2839e07e0ea759ec16cb879ef0602341fd9f5c
>
>
> Diff: https://reviews.apache.org/r/68458/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 68458: Fixed the lib_logrotate inappropriate
UNSET_CLOEXEC via ChildHook.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68458/#review207702
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On Aug. 21, 2018, 9:42 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68458/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 9:42 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Jie Yu, and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, we call os::unsetCloexec() on write fd for both outfds and
> errfds. Basically, this is not needed because all stdout and stderr
> fds will be closed at childMain() method. As a result, no need to do
> unsetCloexec() either from the parent process side or UNSET_CLOEXEC
> via the ChildHook.
>
>
> Diffs
> -----
>
> src/slave/container_loggers/lib_logrotate.cpp 6a2839e07e0ea759ec16cb879ef0602341fd9f5c
>
>
> Diff: https://reviews.apache.org/r/68458/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>