You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Abhishek Dasgupta <a1...@linux.vnet.ibm.com> on 2016/02/18 12:53:26 UTC

Review Request 43715: Title for endpoint documentation.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/
-----------------------------------------------------------

Review request for mesos, Kevin Klues and Neil Conway.


Repository: mesos


Description
-------

Title for endpoint documentation.


Diffs
-----

  support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 

Diff: https://reviews.apache.org/r/43715/diff/


Testing
-------

This is the patch for support/generate-endpoint-help.py to include the generated files with titles.
Tested using "rake dev" on a live site.


Thanks,

Abhishek Dasgupta


Re: Review Request 43715: Title for endpoint documentation.

Posted by Kevin Klues <kl...@gmail.com>.

> On Feb. 18, 2016, 7:41 p.m., Kevin Klues wrote:
> > support/generate-endpoint-help.py, lines 47-53
> > <https://reviews.apache.org/r/43715/diff/2/?file=1254731#file1254731line47>
> >
> >     I would rewrite this as:
> >     
> >     ```
> >     MARKDOWN_HEADER = (
> >     """<!--- This is an automatically generated file. DO NOT EDIT! --->
> >     
> >     ---
> >     title: %s
> >     layout: documentation
> >     ---
> >     """
> >     )
> >     ```
> >     
> >     (Notice the %s in there...)
> >     
> >     Then modify how this is used down below (as demonstrated in a follow up comment)
> 
> Abhishek Dasgupta wrote:
>     Hi Kevin,
>     First line of the markdown file needs to be:
>     ---
>     title: %s
>     layout: documentation
>     ---
>     Otherwise, title does not appear in the generated HTML. So I put <!--- This is an automatically generated file. DO NOT EDIT! ---> after title and layout declaration. Is it okay?

Yeah, of course. That makes sense.  Seems like a weird requirement, but if that's how it has to be, that's how it has to be, I guess.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/#review119678
-----------------------------------------------------------


On Feb. 18, 2016, 8:32 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43715/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 8:32 p.m.)
> 
> 
> Review request for mesos, Kevin Klues and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Title for endpoint documentation.
> 
> 
> Diffs
> -----
> 
>   support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 
> 
> Diff: https://reviews.apache.org/r/43715/diff/
> 
> 
> Testing
> -------
> 
> This is the patch for support/generate-endpoint-help.py to include the generated files with titles.
> Tested using "rake dev" on a live site.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Re: Review Request 43715: Title for endpoint documentation.

Posted by Abhishek Dasgupta <a1...@linux.vnet.ibm.com>.

> On Feb. 18, 2016, 7:41 p.m., Kevin Klues wrote:
> > support/generate-endpoint-help.py, lines 47-53
> > <https://reviews.apache.org/r/43715/diff/2/?file=1254731#file1254731line47>
> >
> >     I would rewrite this as:
> >     
> >     ```
> >     MARKDOWN_HEADER = (
> >     """<!--- This is an automatically generated file. DO NOT EDIT! --->
> >     
> >     ---
> >     title: %s
> >     layout: documentation
> >     ---
> >     """
> >     )
> >     ```
> >     
> >     (Notice the %s in there...)
> >     
> >     Then modify how this is used down below (as demonstrated in a follow up comment)

Hi Kevin,
First line of the markdown file needs to be:
---
title: %s
layout: documentation
---
Otherwise, title does not appear in the generated HTML. So I put <!--- This is an automatically generated file. DO NOT EDIT! ---> after title and layout declaration. Is it okay?


- Abhishek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/#review119678
-----------------------------------------------------------


On Feb. 18, 2016, 8:32 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43715/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 8:32 p.m.)
> 
> 
> Review request for mesos, Kevin Klues and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Title for endpoint documentation.
> 
> 
> Diffs
> -----
> 
>   support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 
> 
> Diff: https://reviews.apache.org/r/43715/diff/
> 
> 
> Testing
> -------
> 
> This is the patch for support/generate-endpoint-help.py to include the generated files with titles.
> Tested using "rake dev" on a live site.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Re: Review Request 43715: Title for endpoint documentation.

Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/#review119678
-----------------------------------------------------------



A commit addressing all my comments can be seen here:

https://github.com/klueska-mesosphere/mesos/commit/23f571376ff6dfffaf1a09a0d8081da1d323a2f3

Feel free to simply apply it and push it out for review again if you agree with everything.


support/generate-endpoint-help.py (lines 47 - 53)
<https://reviews.apache.org/r/43715/#comment181016>

    I would rewrite this as:
    
    ```
    MARKDOWN_HEADER = (
    """<!--- This is an automatically generated file. DO NOT EDIT! --->
    
    ---
    title: %s
    layout: documentation
    ---
    """
    )
    ```
    
    (Notice the %s in there...)
    
    Then modify how this is used down below (as demonstrated in a follow up comment)



support/generate-endpoint-help.py (line 56)
<https://reviews.apache.org/r/43715/#comment181024>

    We should add a new global here:
    
    ```
    MARKDOWN_TITLE = "Mesos - HTTP Endpoints%s"
    ```
    
    where we can fill in the %s on a per call-site basis.



support/generate-endpoint-help.py (line 178)
<https://reviews.apache.org/r/43715/#comment181019>

    I would rename this field from `name` to `title` and then use it as described in a comment below.
    
    It should also not take a default value of "".



support/generate-endpoint-help.py (lines 187 - 190)
<https://reviews.apache.org/r/43715/#comment181017>

    This should no longer be necessary, given the previous comments and the ones to follow.



support/generate-endpoint-help.py (lines 194 - 199)
<https://reviews.apache.org/r/43715/#comment181021>

    This should be simplified to:
    
    ```
    output = (MARKDOWN_HEADER % title) + '\n' + output.rstrip()
    ```



support/generate-endpoint-help.py (lines 217 - 218)
<https://reviews.apache.org/r/43715/#comment181030>

    While we are fixing things, we should remove this extra newline here at the beginning:
    
    """
    # HTTP Endpoints #
    
    should become:
    
    """# HTTP Endpoints #



support/generate-endpoint-help.py (line 283)
<https://reviews.apache.org/r/43715/#comment181026>

    Here we should change this to:
    
    ```
    write_markdown(path, output, MARKDOWN_TITLE % "")
    ```



support/generate-endpoint-help.py (lines 296 - 300)
<https://reviews.apache.org/r/43715/#comment181041>

    here we should add an extra variable title as:
    ```
    title = get_endpoint_path(id, name)
    ```
    
    And then change the `write_markdown()` line to:
    
    ```
    write_markdown(path, text, MARKDOWN_TITLE_TEMPLATE % (" - " + title))
    ```


- Kevin Klues


On Feb. 18, 2016, 6:36 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43715/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 6:36 p.m.)
> 
> 
> Review request for mesos, Kevin Klues and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Title for endpoint documentation.
> 
> 
> Diffs
> -----
> 
>   support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 
> 
> Diff: https://reviews.apache.org/r/43715/diff/
> 
> 
> Testing
> -------
> 
> This is the patch for support/generate-endpoint-help.py to include the generated files with titles.
> Tested using "rake dev" on a live site.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Re: Review Request 43715: Title for endpoint documentation.

Posted by Abhishek Dasgupta <a1...@linux.vnet.ibm.com>.

> On Feb. 19, 2016, 7:52 a.m., Kevin Klues wrote:
> > support/generate-endpoint-help.py, line 147
> > <https://reviews.apache.org/r/43715/diff/3/?file=1258995#file1258995line147>
> >
> >     What are all these whitespace changes. Is it a glitch in reviewboard?  I don't seem them when I pull down locally.

Yes, this is a glitch probably. post-reviews.py behaving oddly while I try to update the endpoint doc files!!


- Abhishek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/#review119831
-----------------------------------------------------------


On Feb. 19, 2016, 7:08 a.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43715/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 7:08 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Title for endpoint documentation.
> 
> 
> Diffs
> -----
> 
>   support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 
> 
> Diff: https://reviews.apache.org/r/43715/diff/
> 
> 
> Testing
> -------
> 
> This is the patch for support/generate-endpoint-help.py to include the generated files with titles.
> Tested using "rake dev" on a live site.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Re: Review Request 43715: Title for endpoint documentation.

Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/#review119831
-----------------------------------------------------------




support/generate-endpoint-help.py (line 52)
<https://reviews.apache.org/r/43715/#comment181188>

    We want a newline at the bottom of this. i.e. 
    
    ```
    <!--- This is an automatically generated file. DO NOT EDIT! --->
    """
    ```



support/generate-endpoint-help.py 
<https://reviews.apache.org/r/43715/#comment181189>

    What are all these whitespace changes. Is it a glitch in reviewboard?  I don't seem them when I pull down locally.


- Kevin Klues


On Feb. 19, 2016, 7:08 a.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43715/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 7:08 a.m.)
> 
> 
> Review request for mesos, Kevin Klues and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Title for endpoint documentation.
> 
> 
> Diffs
> -----
> 
>   support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 
> 
> Diff: https://reviews.apache.org/r/43715/diff/
> 
> 
> Testing
> -------
> 
> This is the patch for support/generate-endpoint-help.py to include the generated files with titles.
> Tested using "rake dev" on a live site.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Re: Review Request 43715: Title for endpoint documentation.

Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/#review119960
-----------------------------------------------------------


Ship it!




Ship It!

- Kevin Klues


On Feb. 19, 2016, 7:46 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43715/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 7:46 p.m.)
> 
> 
> Review request for mesos, Kevin Klues and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Title for endpoint documentation.
> 
> 
> Diffs
> -----
> 
>   support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 
> 
> Diff: https://reviews.apache.org/r/43715/diff/
> 
> 
> Testing
> -------
> 
> This is the patch for support/generate-endpoint-help.py to include the generated files with titles.
> Tested using "rake dev" on a live site.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Re: Review Request 43715: Updated support/generate-endpoint-help.py to include title in generated markdown files.

Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/#review120536
-----------------------------------------------------------


Ship it!




Ship It!

- Kevin Klues


On Feb. 24, 2016, 6:49 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43715/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2016, 6:49 p.m.)
> 
> 
> Review request for mesos, Kevin Klues and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> support/generate-endpoint-help.py is adding a title to every generated endpoint markdown file.
> 
> 
> Diffs
> -----
> 
>   support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 
> 
> Diff: https://reviews.apache.org/r/43715/diff/
> 
> 
> Testing
> -------
> 
> This is the patch for support/generate-endpoint-help.py to include the generated files with titles.
> Tested using "rake dev" on a live site.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Re: Review Request 43715: Updated support/generate-endpoint-help.py to include title in generated markdown files.

Posted by Abhishek Dasgupta <a1...@linux.vnet.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/
-----------------------------------------------------------

(Updated Feb. 24, 2016, 6:49 p.m.)


Review request for mesos, Kevin Klues and Neil Conway.


Summary (updated)
-----------------

Updated support/generate-endpoint-help.py to include title in generated markdown files.


Repository: mesos


Description (updated)
-------

support/generate-endpoint-help.py is adding a title to every generated endpoint markdown file.


Diffs
-----

  support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 

Diff: https://reviews.apache.org/r/43715/diff/


Testing
-------

This is the patch for support/generate-endpoint-help.py to include the generated files with titles.
Tested using "rake dev" on a live site.


Thanks,

Abhishek Dasgupta


Re: Review Request 43715: Title for endpoint documentation.

Posted by Abhishek Dasgupta <a1...@linux.vnet.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/
-----------------------------------------------------------

(Updated Feb. 24, 2016, 6:44 p.m.)


Review request for mesos, Kevin Klues and Neil Conway.


Summary (updated)
-----------------

Title for endpoint documentation.


Repository: mesos


Description (updated)
-------

Title for endpoint documentation.


Diffs (updated)
-----

  support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 

Diff: https://reviews.apache.org/r/43715/diff/


Testing
-------

This is the patch for support/generate-endpoint-help.py to include the generated files with titles.
Tested using "rake dev" on a live site.


Thanks,

Abhishek Dasgupta


Re: Review Request 43715: To include title generation in endpoint generator file.

Posted by Abhishek Dasgupta <a1...@linux.vnet.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/
-----------------------------------------------------------

(Updated Feb. 19, 2016, 8:06 p.m.)


Review request for mesos, Kevin Klues and Neil Conway.


Summary (updated)
-----------------

To include title generation in endpoint generator file.


Repository: mesos


Description (updated)
-------

This patch updates generate-endpoint-help.py file to include titles for every generated markdown file for endpoint help.


Diffs
-----

  support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 

Diff: https://reviews.apache.org/r/43715/diff/


Testing
-------

This is the patch for support/generate-endpoint-help.py to include the generated files with titles.
Tested using "rake dev" on a live site.


Thanks,

Abhishek Dasgupta


Re: Review Request 43715: Title for endpoint documentation.

Posted by Abhishek Dasgupta <a1...@linux.vnet.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/
-----------------------------------------------------------

(Updated Feb. 19, 2016, 7:46 p.m.)


Review request for mesos, Kevin Klues and Neil Conway.


Repository: mesos


Description
-------

Title for endpoint documentation.


Diffs (updated)
-----

  support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 

Diff: https://reviews.apache.org/r/43715/diff/


Testing
-------

This is the patch for support/generate-endpoint-help.py to include the generated files with titles.
Tested using "rake dev" on a live site.


Thanks,

Abhishek Dasgupta


Re: Review Request 43715: Title for endpoint documentation.

Posted by Abhishek Dasgupta <a1...@linux.vnet.ibm.com>.

> On Feb. 19, 2016, 4:26 p.m., Kevin Klues wrote:
> > support/generate-endpoint-help.py, line 147
> > <https://reviews.apache.org/r/43715/diff/3/?file=1258995#file1258995line147>
> >
> >     Actually, I was wrong, when I pull down locally, all of these newlines are removed (and they sbouldn't be).
> >     
> >     Can you patch things up to reinsert these newlines? If I had commit rights, I would just make this trivial change myself before pushing back to master. Since I don't though, it would be good to get everything as clean as possible before a shepherd takes over.
> >     
> >     Other than that, everything looks good now.

I am extremely sorry. This was my bad. Somehow, I messed up your patch and all the newlines were gone. Moreover, there is some weired thing happenning whenever I try to post-review this particular patch. It says, to commit the changes on endpoint docs, whereas, the endpoint docs were not yet modified. Anyway, fixed everything and I pulled again and applied your patch with my changes. So, this time, I hope everything is right. Thank you for your patience.


- Abhishek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/#review119893
-----------------------------------------------------------


On Feb. 19, 2016, 7:46 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43715/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 7:46 p.m.)
> 
> 
> Review request for mesos, Kevin Klues and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Title for endpoint documentation.
> 
> 
> Diffs
> -----
> 
>   support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 
> 
> Diff: https://reviews.apache.org/r/43715/diff/
> 
> 
> Testing
> -------
> 
> This is the patch for support/generate-endpoint-help.py to include the generated files with titles.
> Tested using "rake dev" on a live site.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Re: Review Request 43715: Title for endpoint documentation.

Posted by Kevin Klues <kl...@gmail.com>.

> On Feb. 19, 2016, 4:26 p.m., Kevin Klues wrote:
> > support/generate-endpoint-help.py, line 147
> > <https://reviews.apache.org/r/43715/diff/3/?file=1258995#file1258995line147>
> >
> >     Actually, I was wrong, when I pull down locally, all of these newlines are removed (and they sbouldn't be).
> >     
> >     Can you patch things up to reinsert these newlines? If I had commit rights, I would just make this trivial change myself before pushing back to master. Since I don't though, it would be good to get everything as clean as possible before a shepherd takes over.
> >     
> >     Other than that, everything looks good now.
> 
> Abhishek Dasgupta wrote:
>     I am extremely sorry. This was my bad. Somehow, I messed up your patch and all the newlines were gone. Moreover, there is some weired thing happenning whenever I try to post-review this particular patch. It says, to commit the changes on endpoint docs, whereas, the endpoint docs were not yet modified. Anyway, fixed everything and I pulled again and applied your patch with my changes. So, this time, I hope everything is right. Thank you for your patience.

No worries. I wish there was a way for me to easilyjust patch thing sup so we don't have to go back and forth for trivial changes like this :). The only other comment I have is the wording of the summary and description for this paatch, as mentioned in this review: https://reviews.apache.org/r/43328/ I have a feeling whoever commits this back will just fix this, but it's good to know for future reference when submitting something for review to the mesos project.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/#review119893
-----------------------------------------------------------


On Feb. 19, 2016, 7:46 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43715/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 7:46 p.m.)
> 
> 
> Review request for mesos, Kevin Klues and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Title for endpoint documentation.
> 
> 
> Diffs
> -----
> 
>   support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 
> 
> Diff: https://reviews.apache.org/r/43715/diff/
> 
> 
> Testing
> -------
> 
> This is the patch for support/generate-endpoint-help.py to include the generated files with titles.
> Tested using "rake dev" on a live site.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Re: Review Request 43715: Title for endpoint documentation.

Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/#review119893
-----------------------------------------------------------


Fix it, then Ship it!




The summary and description will need to change, but other than that, and the comment below, things look good.


support/generate-endpoint-help.py 
<https://reviews.apache.org/r/43715/#comment181285>

    Actually, I was wrong, when I pull down locally, all of these newlines are removed (and they sbouldn't be).
    
    Can you patch things up to reinsert these newlines? If I had commit rights, I would just make this trivial change myself before pushing back to master. Since I don't though, it would be good to get everything as clean as possible before a shepherd takes over.
    
    Other than that, everything looks good now.


- Kevin Klues


On Feb. 19, 2016, 12:04 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43715/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 12:04 p.m.)
> 
> 
> Review request for mesos, Kevin Klues and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Title for endpoint documentation.
> 
> 
> Diffs
> -----
> 
>   support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 
> 
> Diff: https://reviews.apache.org/r/43715/diff/
> 
> 
> Testing
> -------
> 
> This is the patch for support/generate-endpoint-help.py to include the generated files with titles.
> Tested using "rake dev" on a live site.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>


Re: Review Request 43715: Title for endpoint documentation.

Posted by Abhishek Dasgupta <a1...@linux.vnet.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/
-----------------------------------------------------------

(Updated Feb. 19, 2016, 12:04 p.m.)


Review request for mesos, Kevin Klues and Neil Conway.


Repository: mesos


Description
-------

Title for endpoint documentation.


Diffs (updated)
-----

  support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 

Diff: https://reviews.apache.org/r/43715/diff/


Testing
-------

This is the patch for support/generate-endpoint-help.py to include the generated files with titles.
Tested using "rake dev" on a live site.


Thanks,

Abhishek Dasgupta


Re: Review Request 43715: Title for endpoint documentation.

Posted by Abhishek Dasgupta <a1...@linux.vnet.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/
-----------------------------------------------------------

(Updated Feb. 19, 2016, 7:08 a.m.)


Review request for mesos, Kevin Klues and Neil Conway.


Repository: mesos


Description
-------

Title for endpoint documentation.


Diffs
-----

  support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 

Diff: https://reviews.apache.org/r/43715/diff/


Testing
-------

This is the patch for support/generate-endpoint-help.py to include the generated files with titles.
Tested using "rake dev" on a live site.


Thanks,

Abhishek Dasgupta


Re: Review Request 43715: Title for endpoint documentation.

Posted by Abhishek Dasgupta <a1...@linux.vnet.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/
-----------------------------------------------------------

(Updated Feb. 19, 2016, 7:06 a.m.)


Review request for mesos, Kevin Klues and Neil Conway.


Repository: mesos


Description
-------

Title for endpoint documentation.


Diffs (updated)
-----

  support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 

Diff: https://reviews.apache.org/r/43715/diff/


Testing
-------

This is the patch for support/generate-endpoint-help.py to include the generated files with titles.
Tested using "rake dev" on a live site.


Thanks,

Abhishek Dasgupta


Re: Review Request 43715: Title for endpoint documentation.

Posted by Abhishek Dasgupta <a1...@linux.vnet.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/
-----------------------------------------------------------

(Updated Feb. 18, 2016, 8:32 p.m.)


Review request for mesos, Kevin Klues and Neil Conway.


Changes
-------

Please stop making a cyclical dependency.


Repository: mesos


Description
-------

Title for endpoint documentation.


Diffs
-----

  support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 

Diff: https://reviews.apache.org/r/43715/diff/


Testing
-------

This is the patch for support/generate-endpoint-help.py to include the generated files with titles.
Tested using "rake dev" on a live site.


Thanks,

Abhishek Dasgupta


Re: Review Request 43715: Title for endpoint documentation.

Posted by Abhishek Dasgupta <a1...@linux.vnet.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/
-----------------------------------------------------------

(Updated Feb. 18, 2016, 6:36 p.m.)


Review request for mesos, Kevin Klues and Neil Conway.


Repository: mesos


Description
-------

Title for endpoint documentation.


Diffs
-----

  support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 

Diff: https://reviews.apache.org/r/43715/diff/


Testing
-------

This is the patch for support/generate-endpoint-help.py to include the generated files with titles.
Tested using "rake dev" on a live site.


Thanks,

Abhishek Dasgupta


Re: Review Request 43715: Title for endpoint documentation.

Posted by Abhishek Dasgupta <a1...@linux.vnet.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/
-----------------------------------------------------------

(Updated Feb. 18, 2016, 6:35 p.m.)


Review request for mesos, Kevin Klues and Neil Conway.


Repository: mesos


Description
-------

Title for endpoint documentation.


Diffs (updated)
-----

  support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 

Diff: https://reviews.apache.org/r/43715/diff/


Testing
-------

This is the patch for support/generate-endpoint-help.py to include the generated files with titles.
Tested using "rake dev" on a live site.


Thanks,

Abhishek Dasgupta


Re: Review Request 43715: Title for endpoint documentation.

Posted by Abhishek Dasgupta <a1...@linux.vnet.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/
-----------------------------------------------------------

(Updated Feb. 18, 2016, 4:49 p.m.)


Review request for mesos, Kevin Klues and Neil Conway.


Repository: mesos


Description
-------

Title for endpoint documentation.


Diffs
-----

  support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 

Diff: https://reviews.apache.org/r/43715/diff/


Testing
-------

This is the patch for support/generate-endpoint-help.py to include the generated files with titles.
Tested using "rake dev" on a live site.


Thanks,

Abhishek Dasgupta


Re: Review Request 43715: Title for endpoint documentation.

Posted by Abhishek Dasgupta <a1...@linux.vnet.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/
-----------------------------------------------------------

(Updated Feb. 18, 2016, 2:17 p.m.)


Review request for mesos, Kevin Klues and Neil Conway.


Repository: mesos


Description
-------

Title for endpoint documentation.


Diffs
-----

  support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 

Diff: https://reviews.apache.org/r/43715/diff/


Testing
-------

This is the patch for support/generate-endpoint-help.py to include the generated files with titles.
Tested using "rake dev" on a live site.


Thanks,

Abhishek Dasgupta


Re: Review Request 43715: Title for endpoint documentation.

Posted by Abhishek Dasgupta <a1...@linux.vnet.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43715/
-----------------------------------------------------------

(Updated Feb. 18, 2016, 11:54 a.m.)


Review request for mesos, Kevin Klues and Neil Conway.


Repository: mesos


Description
-------

Title for endpoint documentation.


Diffs
-----

  support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 

Diff: https://reviews.apache.org/r/43715/diff/


Testing
-------

This is the patch for support/generate-endpoint-help.py to include the generated files with titles.
Tested using "rake dev" on a live site.


Thanks,

Abhishek Dasgupta