svn commit: r619352 - /myfaces/orchestra/trunk/core/src/main/java/org/apache/myfaces/orchestra/lib/jsf/FacesContextWrapper.java

[sk...@apache.org]

Author: skitching
Date: Thu Feb  7 02:42:44 2008
New Revision: 619352

URL: http://svn.apache.org/viewvc?rev=619352&view=rev
Log:
Make some stuff final for performance (minor tweak)

Modified:
    myfaces/orchestra/trunk/core/src/main/java/org/apache/myfaces/orchestra/lib/jsf/FacesContextWrapper.java

Modified: myfaces/orchestra/trunk/core/src/main/java/org/apache/myfaces/orchestra/lib/jsf/FacesContextWrapper.java
URL: http://svn.apache.org/viewvc/myfaces/orchestra/trunk/core/src/main/java/org/apache/myfaces/orchestra/lib/jsf/FacesContextWrapper.java?rev=619352&r1=619351&r2=619352&view=diff
==============================================================================
--- myfaces/orchestra/trunk/core/src/main/java/org/apache/myfaces/orchestra/lib/jsf/FacesContextWrapper.java (original)
+++ myfaces/orchestra/trunk/core/src/main/java/org/apache/myfaces/orchestra/lib/jsf/FacesContextWrapper.java Thu Feb  7 02:42:44 2008
@@ -29,121 +29,129 @@
 
 /**
  * Convenient class to wrap the current FacesContext.
+ * <p>
+ * Any methods that do not actually need to be overridden are declared final
+ * in order to improve performance (helps the JVM to optimise away the call).
+ * 
+ * @since 1.1
+ * 
  * @author Manfred Geiler (latest modification by $Author$)
  * @author Anton Koinov
  * @version $Revision$ $Date$
  */
-public class FacesContextWrapper extends FacesContext
+class FacesContextWrapper extends FacesContext
 {
-    //~ Instance fields ----------------------------------------------------------------------------
+    //~ Instance fields -------------------------------------------------------
 
-    private FacesContext _facesContext;
+    private final FacesContext _facesContext;
 
-    //~ Constructors -------------------------------------------------------------------------------
+    //~ Constructors ----------------------------------------------------------
 
     public FacesContextWrapper(FacesContext facesContext)
     {
         _facesContext = facesContext;
     }
 
-    //~ Methods ------------------------------------------------------------------------------------
+    //~ Non-Final Methods -----------------------------------------------------
 
-    public Application getApplication()
+    public void release()
+    {
+        _facesContext.release();
+    }
+
+    //~ Final Methods ---------------------------------------------------------
+
+    public final Application getApplication()
     {
         return _facesContext.getApplication();
     }
 
-    public Iterator getClientIdsWithMessages()
+    public final Iterator getClientIdsWithMessages()
     {
         return _facesContext.getClientIdsWithMessages();
     }
 
-    public ExternalContext getExternalContext()
+    public final ExternalContext getExternalContext()
     {
         return _facesContext.getExternalContext();
     }
 
-    public FacesMessage.Severity getMaximumSeverity()
+    public final FacesMessage.Severity getMaximumSeverity()
     {
         return _facesContext.getMaximumSeverity();
     }
 
-    public Iterator getMessages()
+    public final Iterator getMessages()
     {
         return _facesContext.getMessages();
     }
 
-    public Iterator getMessages(String clientId)
+    public final Iterator getMessages(String clientId)
     {
         return _facesContext.getMessages(clientId);
     }
 
-    public RenderKit getRenderKit()
+    public final RenderKit getRenderKit()
     {
         return _facesContext.getRenderKit();
     }
 
-    public boolean getRenderResponse()
+    public final boolean getRenderResponse()
     {
         return _facesContext.getRenderResponse();
     }
 
-    public boolean getResponseComplete()
+    public final boolean getResponseComplete()
     {
         return _facesContext.getResponseComplete();
     }
 
-    public void setResponseStream(ResponseStream responsestream)
+    public final void setResponseStream(ResponseStream responsestream)
     {
         _facesContext.setResponseStream(responsestream);
     }
 
-    public ResponseStream getResponseStream()
+    public final ResponseStream getResponseStream()
     {
         return _facesContext.getResponseStream();
     }
 
-    public void setResponseWriter(ResponseWriter responsewriter)
+    public final void setResponseWriter(ResponseWriter responsewriter)
     {
         _facesContext.setResponseWriter(responsewriter);
     }
 
-    public ResponseWriter getResponseWriter()
+    public final ResponseWriter getResponseWriter()
     {
         return _facesContext.getResponseWriter();
     }
 
-    public void setViewRoot(UIViewRoot viewRoot)
+    public final void setViewRoot(UIViewRoot viewRoot)
     {
         _facesContext.setViewRoot(viewRoot);
     }
 
-    public UIViewRoot getViewRoot()
+    public final UIViewRoot getViewRoot()
     {
         return _facesContext.getViewRoot();
     }
 
-    public void addMessage(String clientId, FacesMessage message)
+    public final void addMessage(String clientId, FacesMessage message)
     {
         _facesContext.addMessage(clientId, message);
     }
 
-    public void release()
-    {
-        _facesContext.release();
-    }
-
-    public void renderResponse()
+    public final void renderResponse()
     {
         _facesContext.renderResponse();
     }
 
-    public void responseComplete()
+    public final void responseComplete()
     {
         _facesContext.responseComplete();
     }
 
-    public ELContext getELContext()
+    public final ELContext getELContext()
     {
         return _facesContext.getELContext();
     }