You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/01/05 07:38:45 UTC

[GitHub] wujimin commented on a change in pull request #1049: [SCB-1101] support IPv6 address format

wujimin commented on a change in pull request #1049: [SCB-1101] support IPv6 address format
URL: https://github.com/apache/servicecomb-java-chassis/pull/1049#discussion_r245470251
 
 

 ##########
 File path: foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/net/NetUtils.java
 ##########
 @@ -58,6 +60,8 @@
     doGetHostNameAndHostAddress();
   }
 
+  static Pattern ipv6Pattern = Pattern.compile("[\\[][0-9a-fA-F:]*:[0-9a-fA-F:]*:.*[]]");
 
 Review comment:
   why not just let system to check?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services