You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2021/07/23 02:13:37 UTC

[Impala-ASF-CR] IMPALA-10819: Fix index overflow in FindUtf8PosBackward 

Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17717


Change subject: IMPALA-10819: Fix index overflow in FindUtf8PosBackward
......................................................................

IMPALA-10819: Fix index overflow in FindUtf8PosBackward

In FindUtf8PosBackward, the first part of the while-loop is finding the
start byte of an UTF-8 character. We should check pos before using it.

Tests
 - Manually ran string-util-test in ASAN build.

Change-Id: I9fab6a0b1a8e3a6fbe55fb45b04e86e9034f3ba7
---
M be/src/util/string-util.cc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/17717/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9fab6a0b1a8e3a6fbe55fb45b04e86e9034f3ba7
Gerrit-Change-Number: 17717
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-10819: Fix index overflow in FindUtf8PosBackward

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17717 )

Change subject: IMPALA-10819: Fix index overflow in FindUtf8PosBackward
......................................................................

IMPALA-10819: Fix index overflow in FindUtf8PosBackward

In FindUtf8PosBackward, the first part of the while-loop is finding the
start byte of an UTF-8 character. We should check pos before using it.

Tests
 - Manually ran string-util-test in ASAN build.

Change-Id: I9fab6a0b1a8e3a6fbe55fb45b04e86e9034f3ba7
Reviewed-on: http://gerrit.cloudera.org:8080/17717
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/string-util.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Wenzhe Zhou: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/17717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9fab6a0b1a8e3a6fbe55fb45b04e86e9034f3ba7
Gerrit-Change-Number: 17717
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-10819: Fix index overflow in FindUtf8PosBackward

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17717 )

Change subject: IMPALA-10819: Fix index overflow in FindUtf8PosBackward
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fab6a0b1a8e3a6fbe55fb45b04e86e9034f3ba7
Gerrit-Change-Number: 17717
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Jul 2021 18:02:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10819: Fix index overflow in FindUtf8PosBackward

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17717 )

Change subject: IMPALA-10819: Fix index overflow in FindUtf8PosBackward
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fab6a0b1a8e3a6fbe55fb45b04e86e9034f3ba7
Gerrit-Change-Number: 17717
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Jul 2021 03:38:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10819: Fix index overflow in FindUtf8PosBackward

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17717 )

Change subject: IMPALA-10819: Fix index overflow in FindUtf8PosBackward
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7339/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fab6a0b1a8e3a6fbe55fb45b04e86e9034f3ba7
Gerrit-Change-Number: 17717
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Jul 2021 06:58:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10819: Fix index overflow in FindUtf8PosBackward

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17717 )

Change subject: IMPALA-10819: Fix index overflow in FindUtf8PosBackward
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9149/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fab6a0b1a8e3a6fbe55fb45b04e86e9034f3ba7
Gerrit-Change-Number: 17717
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Jul 2021 02:35:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10819: Fix index overflow in FindUtf8PosBackward

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17717 )

Change subject: IMPALA-10819: Fix index overflow in FindUtf8PosBackward
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7339/


-- 
To view, visit http://gerrit.cloudera.org:8080/17717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fab6a0b1a8e3a6fbe55fb45b04e86e9034f3ba7
Gerrit-Change-Number: 17717
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Jul 2021 11:27:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10819: Fix index overflow in FindUtf8PosBackward

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17717 )

Change subject: IMPALA-10819: Fix index overflow in FindUtf8PosBackward
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7341/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17717
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fab6a0b1a8e3a6fbe55fb45b04e86e9034f3ba7
Gerrit-Change-Number: 17717
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Jul 2021 11:50:39 +0000
Gerrit-HasComments: No