You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Ross Gardler <rg...@apache.org> on 2007/01/02 23:20:59 UTC
2.0 trunk is broken
The commit at [1] has broken the 2.0 trunk:
http://svn.apache.org/viewvc/incubator/wicket/trunk/wicket/src/main/java/wicket/markup/MarkupCache.java?r1=490933&r2=491544&diff_format=h
changing the return statement to
return new DefaultMarkupLoader(application);
enables things to compile but a whole bunch of the tests fail, since 2.0
is in development I have no idea if these tests are supposed to pass
and/or if the above change makes any sense.
Ross
Re: 2.0 trunk is broken
Posted by Juergen Donnerstag <ju...@gmail.com>.
Not according to my svn client. I even cleaned SVN up and it is still
showing no (0) differences. I'll make a clean checkout.
Juergen
On 1/3/07, Igor Vaynberg <ig...@gmail.com> wrote:
> 2.0 is really broken. there are 106 unit test failures
>
> juergen you probably forgot to commit a whole bunch of changes
>
> -igor
>
>
> On 1/2/07, Igor Vaynberg <ig...@gmail.com> wrote:
> >
> > fixed
> >
> > juergen take a second look in case its not how it is supposed to be
> >
> > -igor
> >
> >
> > On 1/2/07, Ross Gardler < rgardler@apache.org> wrote:
> > >
> > > Juergen Donnerstag wrote:
> > > > Anyone else having problems? It is fine on my machine except 4 (minor)
> > >
> > > > errors
> > >
> > > I suspect that either you have an uncommitted local change or you are
> > > not at SVN head. DefaultMarkupLoader in SVN head [1] does not contain a
> > > no argument constructor as used in the commit at [2].
> > >
> > > Ross
> > >
> > > [1]
> > > http://svn.apache.org/viewvc/incubator/wicket/trunk/wicket/src/main/java/wicket/markup/loader/DefaultMarkupLoader.java?diff_format=h&revision=473918&view=markup
> > >
> > > [2]
> > > http://svn.apache.org/viewvc/incubator/wicket/trunk/wicket/src/main/java/wicket/markup/MarkupCache.java?r1=490933&r2=491544&diff_format=h
> > >
> > >
> >
> >
>
>
Re: 2.0 trunk is broken
Posted by Igor Vaynberg <ig...@gmail.com>.
2.0 is really broken. there are 106 unit test failures
juergen you probably forgot to commit a whole bunch of changes
-igor
On 1/2/07, Igor Vaynberg <ig...@gmail.com> wrote:
>
> fixed
>
> juergen take a second look in case its not how it is supposed to be
>
> -igor
>
>
> On 1/2/07, Ross Gardler < rgardler@apache.org> wrote:
> >
> > Juergen Donnerstag wrote:
> > > Anyone else having problems? It is fine on my machine except 4 (minor)
> >
> > > errors
> >
> > I suspect that either you have an uncommitted local change or you are
> > not at SVN head. DefaultMarkupLoader in SVN head [1] does not contain a
> > no argument constructor as used in the commit at [2].
> >
> > Ross
> >
> > [1]
> > http://svn.apache.org/viewvc/incubator/wicket/trunk/wicket/src/main/java/wicket/markup/loader/DefaultMarkupLoader.java?diff_format=h&revision=473918&view=markup
> >
> > [2]
> > http://svn.apache.org/viewvc/incubator/wicket/trunk/wicket/src/main/java/wicket/markup/MarkupCache.java?r1=490933&r2=491544&diff_format=h
> >
> >
>
>
Re: 2.0 trunk is broken
Posted by Igor Vaynberg <ig...@gmail.com>.
fixed
juergen take a second look in case its not how it is supposed to be
-igor
On 1/2/07, Ross Gardler <rg...@apache.org> wrote:
>
> Juergen Donnerstag wrote:
> > Anyone else having problems? It is fine on my machine except 4 (minor)
> > errors
>
> I suspect that either you have an uncommitted local change or you are
> not at SVN head. DefaultMarkupLoader in SVN head [1] does not contain a
> no argument constructor as used in the commit at [2].
>
> Ross
>
> [1]
>
> http://svn.apache.org/viewvc/incubator/wicket/trunk/wicket/src/main/java/wicket/markup/loader/DefaultMarkupLoader.java?diff_format=h&revision=473918&view=markup
> [2]
>
> http://svn.apache.org/viewvc/incubator/wicket/trunk/wicket/src/main/java/wicket/markup/MarkupCache.java?r1=490933&r2=491544&diff_format=h
>
Re: 2.0 trunk is broken
Posted by Ross Gardler <rg...@apache.org>.
Juergen Donnerstag wrote:
> Anyone else having problems? It is fine on my machine except 4 (minor)
> errors
I suspect that either you have an uncommitted local change or you are
not at SVN head. DefaultMarkupLoader in SVN head [1] does not contain a
no argument constructor as used in the commit at [2].
Ross
[1]
http://svn.apache.org/viewvc/incubator/wicket/trunk/wicket/src/main/java/wicket/markup/loader/DefaultMarkupLoader.java?diff_format=h&revision=473918&view=markup
[2]
http://svn.apache.org/viewvc/incubator/wicket/trunk/wicket/src/main/java/wicket/markup/MarkupCache.java?r1=490933&r2=491544&diff_format=h
Re: 2.0 trunk is broken
Posted by Juergen Donnerstag <ju...@gmail.com>.
Anyone else having problems? It is fine on my machine except 4 (minor) errors
Juergen
On 1/2/07, Ross Gardler <rg...@apache.org> wrote:
> The commit at [1] has broken the 2.0 trunk:
>
> http://svn.apache.org/viewvc/incubator/wicket/trunk/wicket/src/main/java/wicket/markup/MarkupCache.java?r1=490933&r2=491544&diff_format=h
>
> changing the return statement to
>
> return new DefaultMarkupLoader(application);
>
> enables things to compile but a whole bunch of the tests fail, since 2.0
> is in development I have no idea if these tests are supposed to pass
> and/or if the above change makes any sense.
>
> Ross
>