You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@daffodil.apache.org by GitBox <gi...@apache.org> on 2018/07/12 14:59:44 UTC

[GitHub] jadams-tresys commented on a change in pull request #79: TDMLRunner explicit roundTrip="twoPass" feature.

jadams-tresys commented on a change in pull request #79: TDMLRunner explicit roundTrip="twoPass" feature.
URL: https://github.com/apache/incubator-daffodil/pull/79#discussion_r202067491
 
 

 ##########
 File path: daffodil-lib/src/main/resources/org/apache/daffodil/xsd/tdml.xsd
 ##########
 @@ -151,12 +151,22 @@
     <attribute name="root" type="xs:NCName" use="optional"/> <!-- only needed when there is no infoset. -->
     <attribute name="model" type="xs:string" use="optional"/> <!-- is there a type for a path/uri? -->
     <attribute name="config" type="xs:string" use="optional"/> <!-- is there a type for a path/uri? -->
-    <attribute name="roundTrip" type="xs:boolean" use="optional"/>
+    <attribute name="roundTrip" type="tns:roundTripType" use="optional"/>
     <attribute name="description" type="xs:string" use="optional"/>
     <attribute name="unsupported" type="xs:boolean" use="optional" default="false"/>
     <attribute name="validation" type="tns:validationType" use="optional"/>
   </attributeGroup>
 
+  <simpleType name="roundTripType">
+    <restriction base="xs:token">
+      <enumeration value="false"/> <!-- means same as none -->
+      <enumeration value="none"/>
+      <enumeration value="true"/> <!-- means same as simple -->
+      <enumeration value="simple"/> <!--  parse, compare infoset, unparse - compare data -->
+      <enumeration value="twoPass"/> <!-- parse, unparse, reparse - compare infoset -->
 
 Review comment:
   I agree, onePass is more clear.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services