You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2025/09/09 11:37:47 UTC

(tomcat) branch main updated: Add getters for group and signature info.

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
     new e0836c8d42 Add getters for group and signature info.
e0836c8d42 is described below

commit e0836c8d42b90b4ed8b66d9aec6e519b1e1fefbf
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Tue Sep 9 10:24:27 2025 +0100

    Add getters for group and signature info.
    
    Silences IDE warnings and are be needed so the info can be used in the
    future.
---
 .../tomcat/util/net/TLSClientHelloExtractor.java       | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/java/org/apache/tomcat/util/net/TLSClientHelloExtractor.java b/java/org/apache/tomcat/util/net/TLSClientHelloExtractor.java
index d84942e586..fbbbb79896 100644
--- a/java/org/apache/tomcat/util/net/TLSClientHelloExtractor.java
+++ b/java/org/apache/tomcat/util/net/TLSClientHelloExtractor.java
@@ -264,6 +264,24 @@ public class TLSClientHelloExtractor {
     }
 
 
+    public List<Group> getClientSupportedGroups() {
+        if (result == ExtractorResult.COMPLETE || result == ExtractorResult.NOT_PRESENT) {
+            return clientSupportedGroups;
+        } else {
+            throw new IllegalStateException(sm.getString("sniExtractor.tooEarly"));
+        }
+    }
+
+
+    public List<SignatureAlgorithm> getClientSignatureAlgorithms() {
+        if (result == ExtractorResult.COMPLETE || result == ExtractorResult.NOT_PRESENT) {
+            return clientSignatureAlgorithms;
+        } else {
+            throw new IllegalStateException(sm.getString("sniExtractor.tooEarly"));
+        }
+    }
+
+
     private static ExtractorResult handleIncompleteRead(ByteBuffer bb) {
         if (bb.limit() == bb.capacity()) {
             // Buffer not big enough


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: (tomcat) branch main updated: Add getters for group and signature info.

Posted by Rémy Maucherat <re...@apache.org>.
On Tue, Sep 9, 2025 at 1:38 PM <ma...@apache.org> wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> markt pushed a commit to branch main
> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>
>
> The following commit(s) were added to refs/heads/main by this push:
>      new e0836c8d42 Add getters for group and signature info.
> e0836c8d42 is described below
>
> commit e0836c8d42b90b4ed8b66d9aec6e519b1e1fefbf
> Author: Mark Thomas <ma...@apache.org>
> AuthorDate: Tue Sep 9 10:24:27 2025 +0100
>
>     Add getters for group and signature info.
>
>     Silences IDE warnings and are be needed so the info can be used in the
>     future.

I had that locally ;)

Rémy

> ---
>  .../tomcat/util/net/TLSClientHelloExtractor.java       | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/java/org/apache/tomcat/util/net/TLSClientHelloExtractor.java b/java/org/apache/tomcat/util/net/TLSClientHelloExtractor.java
> index d84942e586..fbbbb79896 100644
> --- a/java/org/apache/tomcat/util/net/TLSClientHelloExtractor.java
> +++ b/java/org/apache/tomcat/util/net/TLSClientHelloExtractor.java
> @@ -264,6 +264,24 @@ public class TLSClientHelloExtractor {
>      }
>
>
> +    public List<Group> getClientSupportedGroups() {
> +        if (result == ExtractorResult.COMPLETE || result == ExtractorResult.NOT_PRESENT) {
> +            return clientSupportedGroups;
> +        } else {
> +            throw new IllegalStateException(sm.getString("sniExtractor.tooEarly"));
> +        }
> +    }
> +
> +
> +    public List<SignatureAlgorithm> getClientSignatureAlgorithms() {
> +        if (result == ExtractorResult.COMPLETE || result == ExtractorResult.NOT_PRESENT) {
> +            return clientSignatureAlgorithms;
> +        } else {
> +            throw new IllegalStateException(sm.getString("sniExtractor.tooEarly"));
> +        }
> +    }
> +
> +
>      private static ExtractorResult handleIncompleteRead(ByteBuffer bb) {
>          if (bb.limit() == bb.capacity()) {
>              // Buffer not big enough
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org