You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2016/02/12 12:42:13 UTC
Review Request 43525: Fixed an unsigned<->signed comparison.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43525/
-----------------------------------------------------------
Review request for mesos, Bernd Mathiske and Michael Park.
Repository: mesos
Description
-------
Fixed an unsigned<->signed comparison.
Diffs
-----
src/tests/resources_tests.cpp a0e674db61e95d582c860e097efe4d85f208e1ea
Diff: https://reviews.apache.org/r/43525/diff/
Testing
-------
make check (with GCC 5.3.1)
Thanks,
Jan Schlicht
Re: Review Request 43525: Fixed an unsigned<->signed comparison.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43525/#review119027
-----------------------------------------------------------
Ship it!
Ship It!
- Bernd Mathiske
On Feb. 12, 2016, 3:47 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43525/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2016, 3:47 a.m.)
>
>
> Review request for mesos, Bernd Mathiske and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/resources_tests.cpp a0e674db61e95d582c860e097efe4d85f208e1ea
>
> Diff: https://reviews.apache.org/r/43525/diff/
>
>
> Testing
> -------
>
> make check (with GCC 5.3.1)
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 43525: Fixed an unsigned<->signed comparison.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43525/#review119024
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43525]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 12, 2016, 11:47 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43525/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2016, 11:47 a.m.)
>
>
> Review request for mesos, Bernd Mathiske and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/resources_tests.cpp a0e674db61e95d582c860e097efe4d85f208e1ea
>
> Diff: https://reviews.apache.org/r/43525/diff/
>
>
> Testing
> -------
>
> make check (with GCC 5.3.1)
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 43525: Fixed an unsigned<->signed comparison.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43525/
-----------------------------------------------------------
(Updated Feb. 12, 2016, 12:47 p.m.)
Review request for mesos, Bernd Mathiske and Michael Park.
Repository: mesos
Description (updated)
-------
See summary.
Diffs
-----
src/tests/resources_tests.cpp a0e674db61e95d582c860e097efe4d85f208e1ea
Diff: https://reviews.apache.org/r/43525/diff/
Testing
-------
make check (with GCC 5.3.1)
Thanks,
Jan Schlicht