You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/24 01:50:21 UTC

[GitHub] [spark] Yikun commented on a diff in pull request #38354: [SPARK-40882][INFRA] Upgrade actions/setup-java to v3 with distribution specified

Yikun commented on code in PR #38354:
URL: https://github.com/apache/spark/pull/38354#discussion_r1002820197


##########
.github/workflows/build_and_test.yml:
##########
@@ -227,8 +227,9 @@ jobs:
         restore-keys: |
           ${{ matrix.java }}-${{ matrix.hadoop }}-coursier-
     - name: Install Java ${{ matrix.java }}
-      uses: actions/setup-java@v1
+      uses: actions/setup-java@v3
       with:
+        distribution: zulu

Review Comment:
   Yes, `temurin` is more 'standard', zulu is default used in v1, so I kept it same. But I also think `temurin` no problem. Let's see others idea.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org