You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/28 17:35:59 UTC

[GitHub] [spark] karenfeng commented on a change in pull request #34123: [SPARK-36870][SQL] Introduce INTERNAL_ERROR error class

karenfeng commented on a change in pull request #34123:
URL: https://github.com/apache/spark/pull/34123#discussion_r717817283



##########
File path: core/src/main/java/org/apache/spark/SparkThrowable.java
##########
@@ -39,4 +39,7 @@
   // Portable error identifier across SQL engines
   // If null, error class or SQLSTATE is not set
   String getSqlState();
+
+  // True if this error is an internal error.
+  boolean isInternalError();

Review comment:
       Oh, good to know. Just pushed a commit with default implementations for `getSqlState` and `isInternalError`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org