You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2016/10/04 19:36:06 UTC

Review Request 52524: GEODE-1927 backward compatibility support

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52524/
-----------------------------------------------------------

Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.


Bugs: GEODE-1927
    https://issues.apache.org/jira/browse/GEODE-1927


Repository: geode


Description
-------

This fixes a problem in BaseCommand encountered during integration testing.  The integration tests aren't checked in yet due to some Gradle issues I need to work out dealing with downloading old versions of GemFire to use in distributedTest runs.


Diffs
-----

  geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java 743632c6173eae5192b8805601c6b08d5e267f5c 
  geode-core/src/test/java/org/apache/geode/distributed/LocatorDUnitTest.java b073d87df37617418336a77ad3f0df240e950417 
  geode-core/src/test/java/org/apache/geode/distributed/LocatorUDPSecurityDUnitTest.java df5e0e095874c181fa72ec5ec7629aa7cea7f52e 
  geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java b8770b94087ed5bb7995e1f7076ec78fd0ddfc29 

Diff: https://reviews.apache.org/r/52524/diff/


Testing
-------

Integration tests (pending checkin)


Thanks,

Bruce Schuchardt


Re: Review Request 52524: GEODE-1927 backward compatibility support

Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52524/#review151388
-----------------------------------------------------------


Ship it!




Ship It!

- Hitesh Khamesra


On Oct. 4, 2016, 7:36 p.m., Bruce Schuchardt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52524/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2016, 7:36 p.m.)
> 
> 
> Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-1927
>     https://issues.apache.org/jira/browse/GEODE-1927
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> This fixes a problem in BaseCommand encountered during integration testing.  The integration tests aren't checked in yet due to some Gradle issues I need to work out dealing with downloading old versions of GemFire to use in distributedTest runs.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java 743632c6173eae5192b8805601c6b08d5e267f5c 
>   geode-core/src/test/java/org/apache/geode/distributed/LocatorDUnitTest.java b073d87df37617418336a77ad3f0df240e950417 
>   geode-core/src/test/java/org/apache/geode/distributed/LocatorUDPSecurityDUnitTest.java df5e0e095874c181fa72ec5ec7629aa7cea7f52e 
>   geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java b8770b94087ed5bb7995e1f7076ec78fd0ddfc29 
> 
> Diff: https://reviews.apache.org/r/52524/diff/
> 
> 
> Testing
> -------
> 
> Integration tests (pending checkin)
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>


Re: Review Request 52524: GEODE-1927 backward compatibility support

Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52524/#review151587
-----------------------------------------------------------


Ship it!




Ship It!

- Udo Kohlmeyer


On Oct. 4, 2016, 7:36 p.m., Bruce Schuchardt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52524/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2016, 7:36 p.m.)
> 
> 
> Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
> 
> 
> Bugs: GEODE-1927
>     https://issues.apache.org/jira/browse/GEODE-1927
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> This fixes a problem in BaseCommand encountered during integration testing.  The integration tests aren't checked in yet due to some Gradle issues I need to work out dealing with downloading old versions of GemFire to use in distributedTest runs.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java 743632c6173eae5192b8805601c6b08d5e267f5c 
>   geode-core/src/test/java/org/apache/geode/distributed/LocatorDUnitTest.java b073d87df37617418336a77ad3f0df240e950417 
>   geode-core/src/test/java/org/apache/geode/distributed/LocatorUDPSecurityDUnitTest.java df5e0e095874c181fa72ec5ec7629aa7cea7f52e 
>   geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java b8770b94087ed5bb7995e1f7076ec78fd0ddfc29 
> 
> Diff: https://reviews.apache.org/r/52524/diff/
> 
> 
> Testing
> -------
> 
> Integration tests (pending checkin)
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>