You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/08/05 01:51:05 UTC
Review Request 37105: Removed the code of checkpointing container root
filesystem path.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37105/
-----------------------------------------------------------
Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
Bugs: MESOS-3205
https://issues.apache.org/jira/browse/MESOS-3205
Repository: mesos
Description
-------
Removed the code of checkpointing container root filesystem path.
See ticket for the motivation.
Diffs
-----
src/common/protobuf_utils.hpp a4708ed286ef237f17d9fd7813be2f6e7218b42a
src/common/protobuf_utils.cpp 3cb684598d0492a2f57b46fabcf13565ff42f27a
src/slave/containerizer/mesos/containerizer.hpp 8851d30af56b4f9fb95450ac1f42ab550e3df9ff
src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1
src/slave/containerizer/provisioner.hpp cb4d511e8189b65df9b9803f23812dd98edc44ac
src/slave/paths.cpp 404c2143e70771747d356b15eac9137495fd9a75
src/slave/state.hpp cecf200e6e79172af57ae195a73a5161be7e604a
src/slave/state.cpp b9f2d8a0d6395b92bd50f1e0927f3ae9fd04b81c
Diff: https://reviews.apache.org/r/37105/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 37105: Removed the code of checkpointing container
root filesystem path.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37105/#review94598
-----------------------------------------------------------
Ship it!
Ship It!
- Jiang Yan Xu
On Aug. 5, 2015, 2:16 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37105/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2015, 2:16 p.m.)
>
>
> Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
>
>
> Bugs: MESOS-3205
> https://issues.apache.org/jira/browse/MESOS-3205
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed the code of checkpointing container root filesystem path.
>
> See ticket for the motivation.
>
>
> Diffs
> -----
>
> include/mesos/slave/isolator.proto 3d9222be5e9bd9e9f665fb2e57db6b7e925c8fbd
> src/common/protobuf_utils.hpp a4708ed286ef237f17d9fd7813be2f6e7218b42a
> src/common/protobuf_utils.cpp 3cb684598d0492a2f57b46fabcf13565ff42f27a
> src/slave/containerizer/mesos/containerizer.hpp 8851d30af56b4f9fb95450ac1f42ab550e3df9ff
> src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1
> src/slave/containerizer/provisioner.hpp cb4d511e8189b65df9b9803f23812dd98edc44ac
> src/slave/paths.cpp 404c2143e70771747d356b15eac9137495fd9a75
> src/slave/state.hpp cecf200e6e79172af57ae195a73a5161be7e604a
> src/slave/state.cpp b9f2d8a0d6395b92bd50f1e0927f3ae9fd04b81c
>
> Diff: https://reviews.apache.org/r/37105/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 37105: Removed the code of checkpointing container
root filesystem path.
Posted by Jie Yu <yu...@gmail.com>.
> On Aug. 6, 2015, 11:16 p.m., Jiang Yan Xu wrote:
> > src/slave/containerizer/mesos/containerizer.hpp, line 184
> > <https://reviews.apache.org/r/37105/diff/2/?file=1032855#file1032855line184>
> >
> > Simple documentation on the return value?
This code will be removed soon. So I'll just leave as it is right now.
> On Aug. 6, 2015, 11:16 p.m., Jiang Yan Xu wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, lines 637-643
> > <https://reviews.apache.org/r/37105/diff/2/?file=1032856#file1032856line637>
> >
> > Why can't `prepare()` be chained by `then()` anymore?
Same as above, this code will be removed in the subsequent patch.
> On Aug. 6, 2015, 11:16 p.m., Jiang Yan Xu wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, lines 689-690
> > <https://reviews.apache.org/r/37105/diff/2/?file=1032856#file1032856line689>
> >
> > This doesn't get implicitly converted to Option?
No. I tried.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37105/#review94153
-----------------------------------------------------------
On Aug. 5, 2015, 9:16 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37105/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2015, 9:16 p.m.)
>
>
> Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
>
>
> Bugs: MESOS-3205
> https://issues.apache.org/jira/browse/MESOS-3205
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed the code of checkpointing container root filesystem path.
>
> See ticket for the motivation.
>
>
> Diffs
> -----
>
> include/mesos/slave/isolator.proto 3d9222be5e9bd9e9f665fb2e57db6b7e925c8fbd
> src/common/protobuf_utils.hpp a4708ed286ef237f17d9fd7813be2f6e7218b42a
> src/common/protobuf_utils.cpp 3cb684598d0492a2f57b46fabcf13565ff42f27a
> src/slave/containerizer/mesos/containerizer.hpp 8851d30af56b4f9fb95450ac1f42ab550e3df9ff
> src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1
> src/slave/containerizer/provisioner.hpp cb4d511e8189b65df9b9803f23812dd98edc44ac
> src/slave/paths.cpp 404c2143e70771747d356b15eac9137495fd9a75
> src/slave/state.hpp cecf200e6e79172af57ae195a73a5161be7e604a
> src/slave/state.cpp b9f2d8a0d6395b92bd50f1e0927f3ae9fd04b81c
>
> Diff: https://reviews.apache.org/r/37105/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 37105: Removed the code of checkpointing container
root filesystem path.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37105/#review94153
-----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.hpp (line 184)
<https://reviews.apache.org/r/37105/#comment149014>
Simple documentation on the return value?
src/slave/containerizer/mesos/containerizer.cpp (line 632)
<https://reviews.apache.org/r/37105/#comment149072>
Why can't `prepare()` be chained by `then()` anymore?
src/slave/containerizer/mesos/containerizer.cpp (lines 674 - 675)
<https://reviews.apache.org/r/37105/#comment149060>
This doesn't get implicitly converted to Option?
- Jiang Yan Xu
On Aug. 5, 2015, 2:16 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37105/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2015, 2:16 p.m.)
>
>
> Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
>
>
> Bugs: MESOS-3205
> https://issues.apache.org/jira/browse/MESOS-3205
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed the code of checkpointing container root filesystem path.
>
> See ticket for the motivation.
>
>
> Diffs
> -----
>
> include/mesos/slave/isolator.proto 3d9222be5e9bd9e9f665fb2e57db6b7e925c8fbd
> src/common/protobuf_utils.hpp a4708ed286ef237f17d9fd7813be2f6e7218b42a
> src/common/protobuf_utils.cpp 3cb684598d0492a2f57b46fabcf13565ff42f27a
> src/slave/containerizer/mesos/containerizer.hpp 8851d30af56b4f9fb95450ac1f42ab550e3df9ff
> src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1
> src/slave/containerizer/provisioner.hpp cb4d511e8189b65df9b9803f23812dd98edc44ac
> src/slave/paths.cpp 404c2143e70771747d356b15eac9137495fd9a75
> src/slave/state.hpp cecf200e6e79172af57ae195a73a5161be7e604a
> src/slave/state.cpp b9f2d8a0d6395b92bd50f1e0927f3ae9fd04b81c
>
> Diff: https://reviews.apache.org/r/37105/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 37105: Removed the code of checkpointing container
root filesystem path.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37105/
-----------------------------------------------------------
(Updated Aug. 5, 2015, 9:16 p.m.)
Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
Changes
-------
Removed rootfs from ContainerState proto as well.
Bugs: MESOS-3205
https://issues.apache.org/jira/browse/MESOS-3205
Repository: mesos
Description
-------
Removed the code of checkpointing container root filesystem path.
See ticket for the motivation.
Diffs (updated)
-----
include/mesos/slave/isolator.proto 3d9222be5e9bd9e9f665fb2e57db6b7e925c8fbd
src/common/protobuf_utils.hpp a4708ed286ef237f17d9fd7813be2f6e7218b42a
src/common/protobuf_utils.cpp 3cb684598d0492a2f57b46fabcf13565ff42f27a
src/slave/containerizer/mesos/containerizer.hpp 8851d30af56b4f9fb95450ac1f42ab550e3df9ff
src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1
src/slave/containerizer/provisioner.hpp cb4d511e8189b65df9b9803f23812dd98edc44ac
src/slave/paths.cpp 404c2143e70771747d356b15eac9137495fd9a75
src/slave/state.hpp cecf200e6e79172af57ae195a73a5161be7e604a
src/slave/state.cpp b9f2d8a0d6395b92bd50f1e0927f3ae9fd04b81c
Diff: https://reviews.apache.org/r/37105/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 37105: Removed the code of checkpointing container
root filesystem path.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37105/#review94185
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36929, 36930, 36954, 36956, 37054, 37055, 37091, 37105]
All tests passed.
- Mesos ReviewBot
On Aug. 4, 2015, 11:51 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37105/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 11:51 p.m.)
>
>
> Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
>
>
> Bugs: MESOS-3205
> https://issues.apache.org/jira/browse/MESOS-3205
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed the code of checkpointing container root filesystem path.
>
> See ticket for the motivation.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp a4708ed286ef237f17d9fd7813be2f6e7218b42a
> src/common/protobuf_utils.cpp 3cb684598d0492a2f57b46fabcf13565ff42f27a
> src/slave/containerizer/mesos/containerizer.hpp 8851d30af56b4f9fb95450ac1f42ab550e3df9ff
> src/slave/containerizer/mesos/containerizer.cpp 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1
> src/slave/containerizer/provisioner.hpp cb4d511e8189b65df9b9803f23812dd98edc44ac
> src/slave/paths.cpp 404c2143e70771747d356b15eac9137495fd9a75
> src/slave/state.hpp cecf200e6e79172af57ae195a73a5161be7e604a
> src/slave/state.cpp b9f2d8a0d6395b92bd50f1e0927f3ae9fd04b81c
>
> Diff: https://reviews.apache.org/r/37105/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>