You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@grails.apache.org by "jdaugherty (via GitHub)" <gi...@apache.org> on 2026/02/11 16:48:29 UTC
[PR] restore the testapp profile creator [grails-spring-security]
jdaugherty opened a new pull request, #1201:
URL: https://github.com/apache/grails-spring-security/pull/1201
All this PR does is fix the test app profile to generate correctly. It does not restore the automated testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] restore the testapp profile creator [grails-spring-security]
Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on code in PR #1201:
URL: https://github.com/apache/grails-spring-security/pull/1201#discussion_r2794606213
##########
plugin-rest/spring-security-rest-testapp-profile/build.gradle:
##########
@@ -25,7 +25,7 @@ plugins {
group = 'org.apache.grails.profiles'
ext {
- publishArtifactId = 'spring-security-rest-testapp'
+ publishArtifactId = 'spring-security-rest-testapp-profile'
pomTitle = 'Grails Spring Security REST Plugin'
pomDescription = 'Grails plugin to implement token-based, RESTful authentication using Spring Security'
Review Comment:
Change title and description (or remove them if they are not mandatory for publishing).
Right now it's confusing.
##########
plugin-rest/spring-security-rest-testapp-profile/features/data1/skeleton/grails-app/conf/application.yml:
##########
@@ -24,20 +24,20 @@ dataSource:
driverClassName: org.h2.Driver
username: sa
password: ''
-
+ dialect: org.hibernate.dialect.H2Dialect
Review Comment:
Is the dialect necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] restore the testapp profile creator [grails-spring-security]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on code in PR #1201:
URL: https://github.com/apache/grails-spring-security/pull/1201#discussion_r2795932828
##########
plugin-rest/spring-security-rest-testapp-profile/features/data1/skeleton/grails-app/conf/application.yml:
##########
@@ -24,20 +24,20 @@ dataSource:
driverClassName: org.h2.Driver
username: sa
password: ''
-
+ dialect: org.hibernate.dialect.H2Dialect
Review Comment:
Without the dialect, boot run on the generated apps fails to start.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] restore the testapp profile creator [grails-spring-security]
Posted by "matrei (via GitHub)" <gi...@apache.org>.
matrei commented on code in PR #1201:
URL: https://github.com/apache/grails-spring-security/pull/1201#discussion_r2797211342
##########
plugin-rest/spring-security-rest-testapp-profile/features/data1/skeleton/grails-app/conf/application.yml:
##########
@@ -24,20 +24,20 @@ dataSource:
driverClassName: org.h2.Driver
username: sa
password: ''
-
+ dialect: org.hibernate.dialect.H2Dialect
Review Comment:
@jdaugherty OK, that's interesting. The `data1` and `data2` apps start fine for me when removing `dataSource.dialect`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] restore the testapp profile creator [grails-spring-security]
Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley commented on code in PR #1201:
URL: https://github.com/apache/grails-spring-security/pull/1201#discussion_r2795707560
##########
plugin-rest/spring-security-rest-testapp-profile/features/data2/feature.yml.tmpl:
##########
@@ -0,0 +1,12 @@
+description: Second configuration of Grails Data Mapping
+dependencies:
+ - scope: build
Review Comment:
These are different in data1
```
- scope: build
coords: "org.apache.grails:grails-data-hibernate5"
- scope: implementation
coords: "org.apache.grails:grails-data-hibernate5"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] restore the testapp profile creator [grails-spring-security]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty merged PR #1201:
URL: https://github.com/apache/grails-spring-security/pull/1201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org