You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "iamhucong (via GitHub)" <gi...@apache.org> on 2026/06/22 13:10:54 UTC

[PR] Fix encrypt INSERT VALUES temporal literal handling [shardingsphere]

iamhucong opened a new pull request, #38886:
URL: https://github.com/apache/shardingsphere/pull/38886

   ## Summary
   - Preserve SQL text for temporal literals parsed from INSERT VALUES.
   - Treat DATE/TIME/TIMESTAMP literals as typed literal expressions so encrypt rewrite can use raw literal values while keeping temporal SQL syntax where needed.
   - Preserve Oracle date-time literal quote metadata and align parser expected cases.
   
   ## Tests
   - `./mvnw spotless:apply -Pcheck -T1C`
   - `./mvnw -pl parser/sql/statement/core,features/encrypt/core -am -DskipITs -Dspotless.skip=true -Dtest=SQLUtilsTest,DateTimeLiteralValueTest,EncryptInsertValuesTokenGeneratorTest -Dsurefire.failIfNoSpecifiedTests=false test`
   - `./mvnw -pl parser/sql/engine/dialect/oracle,parser/sql/statement/core -am -DskipITs -Dspotless.skip=true -Dmaven.test.skip=true install`
   - `./mvnw -pl test/it/rewriter -am clean test -DskipITs -Dspotless.skip=true -Dtest=EncryptSQLRewriterIT -Dsurefire.failIfNoSpecifiedTests=false`
   - `./mvnw -pl test/it/parser -am clean test -DskipITs -Dspotless.skip=true -Dtest=org.apache.shardingsphere.test.it.sql.parser.oracle.InternalOracleParserIT -Dsurefire.failIfNoSpecifiedTests=false`
   - `./mvnw checkstyle:check -Pcheck -T1C`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix encrypt INSERT VALUES temporal literal handling [shardingsphere]

Posted by "iamhucong (via GitHub)" <gi...@apache.org>.
iamhucong commented on PR #38886:
URL: https://github.com/apache/shardingsphere/pull/38886#issuecomment-4774835275

   ### Summary
   
   **Review Result: Mergeable**
   
   Reason: The latest PR head fixes the temporal literal root-cause path at the parser value/model boundary and preserves the original SQL text through encrypt rewrite. The changed behavior has focused parser, rewrite, and E2E coverage, and I did not find a confirmed merge blocker in the reviewed scope.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix encrypt INSERT VALUES temporal literal handling [shardingsphere]

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #38886:
URL: https://github.com/apache/shardingsphere/pull/38886


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org