You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/03/29 22:20:35 UTC

[GitHub] [beam] y1chi opened a new pull request #17213: Add --dataflowServiceOptions=enable_prime to useUnifiedWorker conditions

y1chi opened a new pull request #17213:
URL: https://github.com/apache/beam/pull/17213


   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] y1chi commented on pull request #17213: Add --dataflowServiceOptions=enable_prime to useUnifiedWorker conditions

Posted by GitBox <gi...@apache.org>.
y1chi commented on pull request #17213:
URL: https://github.com/apache/beam/pull/17213#issuecomment-1082623784


   retest this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] y1chi commented on pull request #17213: Add --dataflowServiceOptions=enable_prime to useUnifiedWorker conditions

Posted by GitBox <gi...@apache.org>.
y1chi commented on pull request #17213:
URL: https://github.com/apache/beam/pull/17213#issuecomment-1083768204


   R: @emilymye 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] y1chi commented on pull request #17213: Add --dataflowServiceOptions=enable_prime to useUnifiedWorker conditions

Posted by GitBox <gi...@apache.org>.
y1chi commented on pull request #17213:
URL: https://github.com/apache/beam/pull/17213#issuecomment-1083425165


   R: @tvalentyn @kennknowles 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] y1chi commented on pull request #17213: Add --dataflowServiceOptions=enable_prime to useUnifiedWorker conditions

Posted by GitBox <gi...@apache.org>.
y1chi commented on pull request #17213:
URL: https://github.com/apache/beam/pull/17213#issuecomment-1084879251


   ping for review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] y1chi commented on pull request #17213: Add --dataflowServiceOptions=enable_prime to useUnifiedWorker conditions

Posted by GitBox <gi...@apache.org>.
y1chi commented on pull request #17213:
URL: https://github.com/apache/beam/pull/17213#issuecomment-1085060313


   > Do we need to do the same for other options as well? At minimum, shouldn't hurt.
   
   Do you mean options such as beam_fn_api, use_unified_worker and use_runner_v2? I guess they were never intended to be used as dataflow service option.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn commented on pull request #17213: Add --dataflowServiceOptions=enable_prime to useUnifiedWorker conditions

Posted by GitBox <gi...@apache.org>.
tvalentyn commented on pull request #17213:
URL: https://github.com/apache/beam/pull/17213#issuecomment-1085035823


   cc: @kileys 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org