[jira] [Commented] (KARAF-4607) ldap connection pool not created when using ssl (ldaps)

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KARAF-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362182#comment-15362182 ] 

ASF GitHub Bot commented on KARAF-4607:
---------------------------------------

GitHub user grgrzybek opened a pull request:

    https://github.com/apache/karaf/pull/206

    [KARAF-4607] Fix pooling scenarion with ldaps:// and default Sun prov…

    …ider
    
    (cherry picked from commit a0bb5cf1debff797ccd4da471ce12663c17bfbfe)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/grgrzybek/karaf master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/karaf/pull/206.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #206
    
----
commit 4cae1c3d18b52dd9ea699a3c0701b89cf7ea38e4
Author: Grzegorz Grzybek <gr...@gmail.com>
Date:   2016-07-05T07:28:29Z

    [KARAF-4607] Fix pooling scenarion with ldaps:// and default Sun provider
    
    (cherry picked from commit a0bb5cf1debff797ccd4da471ce12663c17bfbfe)

----


> ldap connection pool not created when using ssl (ldaps)
> -------------------------------------------------------
>
>                 Key: KARAF-4607
>                 URL: https://issues.apache.org/jira/browse/KARAF-4607
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-jndi
>    Affects Versions: 2.4.4, 4.0.5, 3.0.7
>            Reporter: Grzegorz Grzybek
>
> When {{org.apache.karaf.jaas.modules.ldap.LDAPLoginModule}} is used with {{ldaps://}} protocol and default (Sun) JNDI provider is used, LDAP connection pool is not used.
> The problem is that {{com.sun.jndi.ldap.LdapPoolManager#isPoolingAllowed()}} does several checks when custom {{java.naming.ldap.factory.socket}} (which is the case with Karaf). Such factory has to implement {{java.util.Comparator}} interface, but actually String objects ({{com.sun.jndi.ldap.ClientId#socketFactory()}}) are passed to {{compare()}} method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)