[GitHub] [arrow-rs] tustvold commented on pull request #1225: Skip building null mask in MutableArrayData (#1224)

[GitBox <gi...@apache.org>]

tustvold commented on pull request #1225:
URL: https://github.com/apache/arrow-rs/pull/1225#issuecomment-1019486970


   Benchmarks
   
   ```
   filter u8               time:   [289.42 us 290.41 us 291.38 us]                      
                           change: [-40.610% -40.339% -40.079%] (p = 0.00 < 0.05)
                           Performance has improved.
   
   filter u8 high selectivity                                                                             
                           time:   [5.2395 us 5.2626 us 5.2940 us]
                           change: [-58.224% -58.063% -57.846%] (p = 0.00 < 0.05)
                           Performance has improved.
   
   filter u8 low selectivity                                                                             
                           time:   [4.4407 us 4.4438 us 4.4476 us]
                           change: [-32.040% -27.787% -23.268%] (p = 0.00 < 0.05)
                           Performance has improved.
   
   filter context u8       time:   [105.87 us 105.90 us 105.92 us]                              
                           change: [-64.860% -64.836% -64.812%] (p = 0.00 < 0.05)
                           Performance has improved.
   
   filter context u8 high selectivity                                                                             
                           time:   [1.7448 us 1.8098 us 1.8646 us]
                           change: [-80.196% -79.460% -78.803%] (p = 0.00 < 0.05)
                           Performance has improved.
   
   filter context u8 low selectivity                                                                            
                           time:   [419.29 ns 419.96 ns 420.88 ns]
                           change: [-56.222% -55.769% -55.162%] (p = 0.00 < 0.05)
                           Performance has improved.
   ```
   
   So a little bit over 2x faster, performance for arrays containing nulls is unimpacted (as expected)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org