You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Andrea Del Bene <an...@gmail.com> on 2018/11/23 13:49:57 UTC
[VOTE] Release Apache Wicket 7.11.0
This is a vote to release Apache Wicket 7.11.0
Please download the source distributions found in our staging area
linked below.
I have included the signatures for both the source archives. This vote
lasts for 72 hours minimum.
[ ] Yes, release Apache Wicket 7.11.0
[ ] No, don't release Apache Wicket 7.11.0, because ...
Distributions, changelog, keys and signatures can be found at:
https://dist.apache.org/repos/dist/dev/wicket/7.11.0
Staging repository:
https://repository.apache.org/content/repositories/orgapachewicket-1115
The binaries are available in the above link, as are a staging
repository for Maven. Typically the vote is on the source, but should
you find a problem with one of the binaries, please let me know, I can
re-roll them some way or the other.
Staging git repository data:
Repository: git@github.com:bitstorm/wicket.git
Branch: build/wicket-7.11.0
Release tag: rel/wicket-7.11.0
========================================================================
The signatures for the source release artefacts:
Signature for apache-wicket-7.11.0.zip:
-----BEGIN PGP SIGNATURE-----
iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
VuEHeQ//VlvFvtQYKtD0e9Qcu1vmpvoVlV58ZKPrYBuTQO9oRE72VDIbr5q4kE+/
cwA8Wh1dHlichyGb3U1wQ3NAoYZaqukb00bv9H+GqOQCFCa//zOSohb34yQC7e8z
hfCCANcJtAhHihn2zeapysPCp5Pfsyq7UHUQHqaJiZKRq31EeePV6laT+7+J/IPV
6eV0Ow5QAkGXrwpv/i9vTscF620HWoT4iJxPXJatnDqwKeFQwM3Zpak6KOsKHtWF
Wn8KZcDNhZcsI/vaWW9KtndPDl2kTvo8n/ZdPyAoPTZMcAPULcyZT75VxiPRV8Ky
kQT/lFhnLQgbnfaGbfNwgIWybYt9tJ6JHjqt+xtSg+IBXM1aCY6bI5xqP43dS2xE
yuvTq4Z3UcS1jGVr4wiCwOEqVw2ZRQcioXDeDDAD0qZXbRkUi9tImkIx5k7ICxNu
4uAYI3QrMK1QU/QteUJwZnJFDlvDQyx4FshkKePRHrlZJ5N73G4u2ChF1XDO0e5c
NESit9hqIS3Dz3eXExt/0mQDTMWIMzdopb7R9/uVIZtCMNV618cUvuutZYGrvSd9
390+Z8fWoB1VroZumbOVbwE8DlsiN7YoNwTVEm1CESTavJw5dNcZnXumY3KWtaye
BDoN+YEQdTeVvOs2s+CAwjMXVBIxGp2KfY4eXZlis16D8SUVifA=
=WU+g
-----END PGP SIGNATURE-----
Signature for apache-wicket-7.11.0.tar.gz:
-----BEGIN PGP SIGNATURE-----
iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
VuG/SA//dX5ZJ/kLVy2pl2Wcqeo9nAiHGSLPjkhIdQQ5y4clGtKpyydb1pBtwNTp
ENMO/wNWeFEvphRM6KcA1D+z15FMZxCicuOc9JwbWCVnfujQFJF5dK3WX+nnJgX1
WyuxHvhxDnjUT3lFjGECfkoiua1yVh20QUzEcqC9S2ReqyREitjGKrh7sGWx+WCM
2ls7pE6cXkuIjkNZP49f8LwyTIs4epK+4lkgPvgf5YgcBOVZNXK4BJ4nR74Fdr49
qeRILeflhEk6vIK6a7quVeICnQ7bocku0wtnuy53xbipHSkcj6GwmE9bK3z+exa3
Djg11GaqdNo1U3awmK+n3nOOBlbq1B0zwTjvAeK2m9eCwbE8W6TP2/U7mFaqCH5u
e4hR84kTYXJ9f65URDyAZTcORRIfF1z8edEqGkVH2uI/P3U+Nwx7969PabQEWjM6
NCrnvaDnTpiQuIJ/4AVLtDOPEnWiN/Zd/ooE7q1TWx7GeF0/hsfAM3nN/u7o0IoW
MKPxodnPa4cX2549n/grUYsHG9PN0hKIVSk4b3O1kHZL4rFqxh1SzyAIi5UEeyhD
sZARZfw/XC8j3rrd4eL9FjOgNvz75lhRZuuWCqIuBhrUVGrtJ1tFoQf5WL/EopJd
9qI6Bh1ltlAWz39mxW/w6AW5LQmAA+SBAAsZS5Lx5lwwx6LxzI0=
=rLlH
-----END PGP SIGNATURE-----
========================================================================
CHANGELOG for 7.11.0:
** Bug
* [WICKET-6473] - Double slash break 404page
* [WICKET-6533] - Error while parsing xml using AjaxButton
* [WICKET-6546] - CssContentHeaderItem comments CSS code with HTML comments
* [WICKET-6551] - LazyInitProxyFactory doesn't work correctly at Weblogic
* [WICKET-6553] - SelectOptions doesn't html-encode option values
* [WICKET-6564] - PageStoreManager#clear() does not completely clear
* [WICKET-6568] - Wicket fails / does not encode request header
values in AjaxCalls
* [WICKET-6586] - Broken JavaScript due to fix charsetName in
JavaScriptPackageResource
* [WICKET-6589] - ClientInfo fails with NumberFormatException for
unusual browser versions
* [WICKET-6604] - Ajax repaint is not correctly handled when
component being repainted has an enclosure associated with it and is
not a child of the enclosure
* [WICKET-6614] - AbstractRangeValidator looks up string with the
wrong key if locale is Turkish
** Improvement
* [WICKET-6527] - no possibility to override fixed html appended
directly to response by FilterForm
* [WICKET-6605] - Allow AjaxFallbackButton to be stateless
** Task
* [WICKET-6594] - JavaDoc of redirectToInterceptPage in Component
urges to use redirectTo method when in a constructor
Re: [VOTE] Release Apache Wicket 7.11.0
Posted by Maxim Solodovnik <so...@gmail.com>.
Ok I'll double-check and will report back
WBR, Maxim
(from mobile, sorry for the typos)
On Sat, Nov 24, 2018, 21:23 Andrea Del Bene <an.delbene@gmail.com wrote:
> Hi Maxim,
>
> I wrongly confused the current Wicket 7 branch with the release code.
> Branch wicket-7.x doesn't contain yet the change to avoid the problem
> with JavaDoc, but the source distribution for 7.11.0 does and you should
> be able to build it from scratch. I've downloaded the source
> distribution, deleted ~/.m2/repository/* and successfully run 'mvn clean
> install -P buildbot'. For some reason you are experiencing a problem
> with maven repository and artifact org.apache:apache:pom:21, which is
> quite strange. Hopefully is a network problem that will be solved in a
> short time .I have no problem canceling the current vote and making a
> new one, but I think it wouldn't be very useful.
>
> On 24/11/18 11:18, Maxim Solodovnik wrote:
> > My vote is -0.5,
> > I believe we should create source distribution buildable without code
> > modification
> >
> > On Fri, 23 Nov 2018 at 20:50, Andrea Del Bene <an...@gmail.com>
> wrote:
> >
> >> This is a vote to release Apache Wicket 7.11.0
> >>
> >> Please download the source distributions found in our staging area
> >> linked below.
> >>
> >> I have included the signatures for both the source archives. This vote
> >> lasts for 72 hours minimum.
> >>
> >> [ ] Yes, release Apache Wicket 7.11.0
> >> [ ] No, don't release Apache Wicket 7.11.0, because ...
> >>
> >> Distributions, changelog, keys and signatures can be found at:
> >>
> >> https://dist.apache.org/repos/dist/dev/wicket/7.11.0
> >>
> >> Staging repository:
> >>
> >>
> >> https://repository.apache.org/content/repositories/orgapachewicket-1115
> >>
> >> The binaries are available in the above link, as are a staging
> >> repository for Maven. Typically the vote is on the source, but should
> >> you find a problem with one of the binaries, please let me know, I can
> >> re-roll them some way or the other.
> >>
> >> Staging git repository data:
> >>
> >> Repository: git@github.com:bitstorm/wicket.git
> >> Branch: build/wicket-7.11.0
> >> Release tag: rel/wicket-7.11.0
> >>
> >>
> >> ========================================================================
> >>
> >> The signatures for the source release artefacts:
> >>
> >>
> >> Signature for apache-wicket-7.11.0.zip:
> >>
> >> -----BEGIN PGP SIGNATURE-----
> >>
> >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
> >> VuEHeQ//VlvFvtQYKtD0e9Qcu1vmpvoVlV58ZKPrYBuTQO9oRE72VDIbr5q4kE+/
> >> cwA8Wh1dHlichyGb3U1wQ3NAoYZaqukb00bv9H+GqOQCFCa//zOSohb34yQC7e8z
> >> hfCCANcJtAhHihn2zeapysPCp5Pfsyq7UHUQHqaJiZKRq31EeePV6laT+7+J/IPV
> >> 6eV0Ow5QAkGXrwpv/i9vTscF620HWoT4iJxPXJatnDqwKeFQwM3Zpak6KOsKHtWF
> >> Wn8KZcDNhZcsI/vaWW9KtndPDl2kTvo8n/ZdPyAoPTZMcAPULcyZT75VxiPRV8Ky
> >> kQT/lFhnLQgbnfaGbfNwgIWybYt9tJ6JHjqt+xtSg+IBXM1aCY6bI5xqP43dS2xE
> >> yuvTq4Z3UcS1jGVr4wiCwOEqVw2ZRQcioXDeDDAD0qZXbRkUi9tImkIx5k7ICxNu
> >> 4uAYI3QrMK1QU/QteUJwZnJFDlvDQyx4FshkKePRHrlZJ5N73G4u2ChF1XDO0e5c
> >> NESit9hqIS3Dz3eXExt/0mQDTMWIMzdopb7R9/uVIZtCMNV618cUvuutZYGrvSd9
> >> 390+Z8fWoB1VroZumbOVbwE8DlsiN7YoNwTVEm1CESTavJw5dNcZnXumY3KWtaye
> >> BDoN+YEQdTeVvOs2s+CAwjMXVBIxGp2KfY4eXZlis16D8SUVifA=
> >> =WU+g
> >> -----END PGP SIGNATURE-----
> >>
> >> Signature for apache-wicket-7.11.0.tar.gz:
> >>
> >> -----BEGIN PGP SIGNATURE-----
> >>
> >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
> >> VuG/SA//dX5ZJ/kLVy2pl2Wcqeo9nAiHGSLPjkhIdQQ5y4clGtKpyydb1pBtwNTp
> >> ENMO/wNWeFEvphRM6KcA1D+z15FMZxCicuOc9JwbWCVnfujQFJF5dK3WX+nnJgX1
> >> WyuxHvhxDnjUT3lFjGECfkoiua1yVh20QUzEcqC9S2ReqyREitjGKrh7sGWx+WCM
> >> 2ls7pE6cXkuIjkNZP49f8LwyTIs4epK+4lkgPvgf5YgcBOVZNXK4BJ4nR74Fdr49
> >> qeRILeflhEk6vIK6a7quVeICnQ7bocku0wtnuy53xbipHSkcj6GwmE9bK3z+exa3
> >> Djg11GaqdNo1U3awmK+n3nOOBlbq1B0zwTjvAeK2m9eCwbE8W6TP2/U7mFaqCH5u
> >> e4hR84kTYXJ9f65URDyAZTcORRIfF1z8edEqGkVH2uI/P3U+Nwx7969PabQEWjM6
> >> NCrnvaDnTpiQuIJ/4AVLtDOPEnWiN/Zd/ooE7q1TWx7GeF0/hsfAM3nN/u7o0IoW
> >> MKPxodnPa4cX2549n/grUYsHG9PN0hKIVSk4b3O1kHZL4rFqxh1SzyAIi5UEeyhD
> >> sZARZfw/XC8j3rrd4eL9FjOgNvz75lhRZuuWCqIuBhrUVGrtJ1tFoQf5WL/EopJd
> >> 9qI6Bh1ltlAWz39mxW/w6AW5LQmAA+SBAAsZS5Lx5lwwx6LxzI0=
> >> =rLlH
> >> -----END PGP SIGNATURE-----
> >>
> >> ========================================================================
> >>
> >> CHANGELOG for 7.11.0:
> >>
> >> ** Bug
> >>
> >> * [WICKET-6473] - Double slash break 404page
> >> * [WICKET-6533] - Error while parsing xml using AjaxButton
> >> * [WICKET-6546] - CssContentHeaderItem comments CSS code with HTML
> >> comments
> >> * [WICKET-6551] - LazyInitProxyFactory doesn't work correctly at
> >> Weblogic
> >> * [WICKET-6553] - SelectOptions doesn't html-encode option values
> >> * [WICKET-6564] - PageStoreManager#clear() does not completely
> clear
> >> * [WICKET-6568] - Wicket fails / does not encode request header
> >> values in AjaxCalls
> >> * [WICKET-6586] - Broken JavaScript due to fix charsetName in
> >> JavaScriptPackageResource
> >> * [WICKET-6589] - ClientInfo fails with NumberFormatException for
> >> unusual browser versions
> >> * [WICKET-6604] - Ajax repaint is not correctly handled when
> >> component being repainted has an enclosure associated with it and is
> >> not a child of the enclosure
> >> * [WICKET-6614] - AbstractRangeValidator looks up string with the
> >> wrong key if locale is Turkish
> >>
> >> ** Improvement
> >>
> >> * [WICKET-6527] - no possibility to override fixed html appended
> >> directly to response by FilterForm
> >> * [WICKET-6605] - Allow AjaxFallbackButton to be stateless
> >>
> >> ** Task
> >>
> >> * [WICKET-6594] - JavaDoc of redirectToInterceptPage in Component
> >> urges to use redirectTo method when in a constructor
> >>
> >
>
Re: [VOTE] Release Apache Wicket 7.11.0
Posted by Martin Grigorov <mg...@apache.org>.
I was able to build successfully wicket-7.x with:
$ mvn7 clean install
where 'mvn7' is:
1 │ #!/usr/bin/fish
2 │
3 │ #set LC_ALL bg_BG.UTF-8
4 │ #set LANG bg_BG.UTF-8
5 │
6 │ set LC_ALL de_DE.UTF-8
7 │ set LANG de_DE.UTF-8
8 │
9 │
10 │ set JAVA_HOME $JAVA_7_HOME
11 │ set PATH $JAVA_HOME/bin $PATH
12 │
13 │ eval mvn $argv
$ mvn7 -version
Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
2018-10-24T21:41:47+03:00)
Maven home: /home/martin/devel/maven-latest
Java version: 1.7.0_72, vendor: Oracle Corporation, runtime:
/home/martin/devel/jdk1.7.0_72/jre
Default locale: de_DE, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-38-generic", arch: "amd64", family:
"unix"
eval $JAVA_7_HOME/bin/java -version
java version "1.7.0_72"
Java(TM) SE Runtime Environment (build 1.7.0_72-b14)
Java HotSpot(TM) 64-Bit Server VM (build 24.72-b04, mixed mode)
$ git show HEAD
commit e1ff3da3eead75852f54e225bdea1204e930184f (HEAD -> wicket-7.x,
origin/wicket-7.x)
Author: Andrea Del Bene <ad...@apache.org>
Date: Tue Oct 30 10:42:17 2018 +0100
WICKET-6605 Allow AjaxFallbackButton to be stateless
i.e. I didn't yet pull Maxim's commits
The build also passes with 'mvn8 clean install'
$ mvn8 -version
Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
2018-10-24T21:41:47+03:00)
Maven home: /home/martin/devel/maven-latest
Java version: 1.8.0_181, vendor: Oracle Corporation, runtime:
/usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-38-generic", arch: "amd64", family:
"unix"
In both cases it uses Maven toolchains to use
/home/martin/devel/jdk1.7.0_72 for the build.
So it must be something on your side with the javadoc errors.
On Sun, Nov 25, 2018 at 6:19 AM Maxim Solodovnik <so...@gmail.com>
wrote:
> Hello Andrea,
>
> Just have double-checked:
> 1) download fresh archive from
> https://dist.apache.org/repos/dist/dev/wicket/7.11.0
> 2) unpack
> 3) run: `mvn clean install -P buildbot`
> Result:
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 12.880 s
> [INFO] Finished at: 2018-11-25T10:56:22+07:00
> [INFO]
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:jar (attach-javadocs)
> on project wicket-util: MavenReportException: Error while generating
> Javadoc:
> [ERROR] Exit code: 1 - javadoc: error - invalid flag:
> --allow-script-in-comments
>
> Regular `mvn clean install`
> Lots of JavaDoc errors and build is failed
>
> Set JAVA_HOME and PATH to Oracle java7: same result as with `-Pbuildbot`
>
> What is your environment?
> Maybe maven version matters?
>
> I'm using:
> Apache Maven 3.6.0
>
> Java versions:
> Oracle java version "1.7.0_76"
> openjdk version "1.8.0_181"
> Oracle java version "1.8.0_191"
>
> BTW I have modified wicket-7.x branch it should be buildable using java7
> (via toolchains), java8 via `-Pjava8`
>
>
>
> On Sat, 24 Nov 2018 at 21:23, Andrea Del Bene <an...@gmail.com>
> wrote:
>
> > Hi Maxim,
> >
> > I wrongly confused the current Wicket 7 branch with the release code.
> > Branch wicket-7.x doesn't contain yet the change to avoid the problem
> > with JavaDoc, but the source distribution for 7.11.0 does and you should
> > be able to build it from scratch. I've downloaded the source
> > distribution, deleted ~/.m2/repository/* and successfully run 'mvn clean
> > install -P buildbot'. For some reason you are experiencing a problem
> > with maven repository and artifact org.apache:apache:pom:21, which is
> > quite strange. Hopefully is a network problem that will be solved in a
> > short time .I have no problem canceling the current vote and making a
> > new one, but I think it wouldn't be very useful.
> >
> > On 24/11/18 11:18, Maxim Solodovnik wrote:
> > > My vote is -0.5,
> > > I believe we should create source distribution buildable without code
> > > modification
> > >
> > > On Fri, 23 Nov 2018 at 20:50, Andrea Del Bene <an...@gmail.com>
> > wrote:
> > >
> > >> This is a vote to release Apache Wicket 7.11.0
> > >>
> > >> Please download the source distributions found in our staging area
> > >> linked below.
> > >>
> > >> I have included the signatures for both the source archives. This vote
> > >> lasts for 72 hours minimum.
> > >>
> > >> [ ] Yes, release Apache Wicket 7.11.0
> > >> [ ] No, don't release Apache Wicket 7.11.0, because ...
> > >>
> > >> Distributions, changelog, keys and signatures can be found at:
> > >>
> > >> https://dist.apache.org/repos/dist/dev/wicket/7.11.0
> > >>
> > >> Staging repository:
> > >>
> > >>
> > >>
> https://repository.apache.org/content/repositories/orgapachewicket-1115
> > >>
> > >> The binaries are available in the above link, as are a staging
> > >> repository for Maven. Typically the vote is on the source, but should
> > >> you find a problem with one of the binaries, please let me know, I can
> > >> re-roll them some way or the other.
> > >>
> > >> Staging git repository data:
> > >>
> > >> Repository: git@github.com:bitstorm/wicket.git
> > >> Branch: build/wicket-7.11.0
> > >> Release tag: rel/wicket-7.11.0
> > >>
> > >>
> > >>
> ========================================================================
> > >>
> > >> The signatures for the source release artefacts:
> > >>
> > >>
> > >> Signature for apache-wicket-7.11.0.zip:
> > >>
> > >> -----BEGIN PGP SIGNATURE-----
> > >>
> > >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
> > >> VuEHeQ//VlvFvtQYKtD0e9Qcu1vmpvoVlV58ZKPrYBuTQO9oRE72VDIbr5q4kE+/
> > >> cwA8Wh1dHlichyGb3U1wQ3NAoYZaqukb00bv9H+GqOQCFCa//zOSohb34yQC7e8z
> > >> hfCCANcJtAhHihn2zeapysPCp5Pfsyq7UHUQHqaJiZKRq31EeePV6laT+7+J/IPV
> > >> 6eV0Ow5QAkGXrwpv/i9vTscF620HWoT4iJxPXJatnDqwKeFQwM3Zpak6KOsKHtWF
> > >> Wn8KZcDNhZcsI/vaWW9KtndPDl2kTvo8n/ZdPyAoPTZMcAPULcyZT75VxiPRV8Ky
> > >> kQT/lFhnLQgbnfaGbfNwgIWybYt9tJ6JHjqt+xtSg+IBXM1aCY6bI5xqP43dS2xE
> > >> yuvTq4Z3UcS1jGVr4wiCwOEqVw2ZRQcioXDeDDAD0qZXbRkUi9tImkIx5k7ICxNu
> > >> 4uAYI3QrMK1QU/QteUJwZnJFDlvDQyx4FshkKePRHrlZJ5N73G4u2ChF1XDO0e5c
> > >> NESit9hqIS3Dz3eXExt/0mQDTMWIMzdopb7R9/uVIZtCMNV618cUvuutZYGrvSd9
> > >> 390+Z8fWoB1VroZumbOVbwE8DlsiN7YoNwTVEm1CESTavJw5dNcZnXumY3KWtaye
> > >> BDoN+YEQdTeVvOs2s+CAwjMXVBIxGp2KfY4eXZlis16D8SUVifA=
> > >> =WU+g
> > >> -----END PGP SIGNATURE-----
> > >>
> > >> Signature for apache-wicket-7.11.0.tar.gz:
> > >>
> > >> -----BEGIN PGP SIGNATURE-----
> > >>
> > >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
> > >> VuG/SA//dX5ZJ/kLVy2pl2Wcqeo9nAiHGSLPjkhIdQQ5y4clGtKpyydb1pBtwNTp
> > >> ENMO/wNWeFEvphRM6KcA1D+z15FMZxCicuOc9JwbWCVnfujQFJF5dK3WX+nnJgX1
> > >> WyuxHvhxDnjUT3lFjGECfkoiua1yVh20QUzEcqC9S2ReqyREitjGKrh7sGWx+WCM
> > >> 2ls7pE6cXkuIjkNZP49f8LwyTIs4epK+4lkgPvgf5YgcBOVZNXK4BJ4nR74Fdr49
> > >> qeRILeflhEk6vIK6a7quVeICnQ7bocku0wtnuy53xbipHSkcj6GwmE9bK3z+exa3
> > >> Djg11GaqdNo1U3awmK+n3nOOBlbq1B0zwTjvAeK2m9eCwbE8W6TP2/U7mFaqCH5u
> > >> e4hR84kTYXJ9f65URDyAZTcORRIfF1z8edEqGkVH2uI/P3U+Nwx7969PabQEWjM6
> > >> NCrnvaDnTpiQuIJ/4AVLtDOPEnWiN/Zd/ooE7q1TWx7GeF0/hsfAM3nN/u7o0IoW
> > >> MKPxodnPa4cX2549n/grUYsHG9PN0hKIVSk4b3O1kHZL4rFqxh1SzyAIi5UEeyhD
> > >> sZARZfw/XC8j3rrd4eL9FjOgNvz75lhRZuuWCqIuBhrUVGrtJ1tFoQf5WL/EopJd
> > >> 9qI6Bh1ltlAWz39mxW/w6AW5LQmAA+SBAAsZS5Lx5lwwx6LxzI0=
> > >> =rLlH
> > >> -----END PGP SIGNATURE-----
> > >>
> > >>
> ========================================================================
> > >>
> > >> CHANGELOG for 7.11.0:
> > >>
> > >> ** Bug
> > >>
> > >> * [WICKET-6473] - Double slash break 404page
> > >> * [WICKET-6533] - Error while parsing xml using AjaxButton
> > >> * [WICKET-6546] - CssContentHeaderItem comments CSS code with
> HTML
> > >> comments
> > >> * [WICKET-6551] - LazyInitProxyFactory doesn't work correctly at
> > >> Weblogic
> > >> * [WICKET-6553] - SelectOptions doesn't html-encode option values
> > >> * [WICKET-6564] - PageStoreManager#clear() does not completely
> > clear
> > >> * [WICKET-6568] - Wicket fails / does not encode request header
> > >> values in AjaxCalls
> > >> * [WICKET-6586] - Broken JavaScript due to fix charsetName in
> > >> JavaScriptPackageResource
> > >> * [WICKET-6589] - ClientInfo fails with NumberFormatException for
> > >> unusual browser versions
> > >> * [WICKET-6604] - Ajax repaint is not correctly handled when
> > >> component being repainted has an enclosure associated with it and is
> > >> not a child of the enclosure
> > >> * [WICKET-6614] - AbstractRangeValidator looks up string with the
> > >> wrong key if locale is Turkish
> > >>
> > >> ** Improvement
> > >>
> > >> * [WICKET-6527] - no possibility to override fixed html appended
> > >> directly to response by FilterForm
> > >> * [WICKET-6605] - Allow AjaxFallbackButton to be stateless
> > >>
> > >> ** Task
> > >>
> > >> * [WICKET-6594] - JavaDoc of redirectToInterceptPage in Component
> > >> urges to use redirectTo method when in a constructor
> > >>
> > >
> >
>
>
> --
> WBR
> Maxim aka solomax
>
Re: [VOTE] Release Apache Wicket 7.11.0
Posted by Maxim Solodovnik <so...@gmail.com>.
Hello Andrea,
Just have double-checked:
1) download fresh archive from
https://dist.apache.org/repos/dist/dev/wicket/7.11.0
2) unpack
3) run: `mvn clean install -P buildbot`
Result:
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 12.880 s
[INFO] Finished at: 2018-11-25T10:56:22+07:00
[INFO]
------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:jar (attach-javadocs)
on project wicket-util: MavenReportException: Error while generating
Javadoc:
[ERROR] Exit code: 1 - javadoc: error - invalid flag:
--allow-script-in-comments
Regular `mvn clean install`
Lots of JavaDoc errors and build is failed
Set JAVA_HOME and PATH to Oracle java7: same result as with `-Pbuildbot`
What is your environment?
Maybe maven version matters?
I'm using:
Apache Maven 3.6.0
Java versions:
Oracle java version "1.7.0_76"
openjdk version "1.8.0_181"
Oracle java version "1.8.0_191"
BTW I have modified wicket-7.x branch it should be buildable using java7
(via toolchains), java8 via `-Pjava8`
On Sat, 24 Nov 2018 at 21:23, Andrea Del Bene <an...@gmail.com> wrote:
> Hi Maxim,
>
> I wrongly confused the current Wicket 7 branch with the release code.
> Branch wicket-7.x doesn't contain yet the change to avoid the problem
> with JavaDoc, but the source distribution for 7.11.0 does and you should
> be able to build it from scratch. I've downloaded the source
> distribution, deleted ~/.m2/repository/* and successfully run 'mvn clean
> install -P buildbot'. For some reason you are experiencing a problem
> with maven repository and artifact org.apache:apache:pom:21, which is
> quite strange. Hopefully is a network problem that will be solved in a
> short time .I have no problem canceling the current vote and making a
> new one, but I think it wouldn't be very useful.
>
> On 24/11/18 11:18, Maxim Solodovnik wrote:
> > My vote is -0.5,
> > I believe we should create source distribution buildable without code
> > modification
> >
> > On Fri, 23 Nov 2018 at 20:50, Andrea Del Bene <an...@gmail.com>
> wrote:
> >
> >> This is a vote to release Apache Wicket 7.11.0
> >>
> >> Please download the source distributions found in our staging area
> >> linked below.
> >>
> >> I have included the signatures for both the source archives. This vote
> >> lasts for 72 hours minimum.
> >>
> >> [ ] Yes, release Apache Wicket 7.11.0
> >> [ ] No, don't release Apache Wicket 7.11.0, because ...
> >>
> >> Distributions, changelog, keys and signatures can be found at:
> >>
> >> https://dist.apache.org/repos/dist/dev/wicket/7.11.0
> >>
> >> Staging repository:
> >>
> >>
> >> https://repository.apache.org/content/repositories/orgapachewicket-1115
> >>
> >> The binaries are available in the above link, as are a staging
> >> repository for Maven. Typically the vote is on the source, but should
> >> you find a problem with one of the binaries, please let me know, I can
> >> re-roll them some way or the other.
> >>
> >> Staging git repository data:
> >>
> >> Repository: git@github.com:bitstorm/wicket.git
> >> Branch: build/wicket-7.11.0
> >> Release tag: rel/wicket-7.11.0
> >>
> >>
> >> ========================================================================
> >>
> >> The signatures for the source release artefacts:
> >>
> >>
> >> Signature for apache-wicket-7.11.0.zip:
> >>
> >> -----BEGIN PGP SIGNATURE-----
> >>
> >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
> >> VuEHeQ//VlvFvtQYKtD0e9Qcu1vmpvoVlV58ZKPrYBuTQO9oRE72VDIbr5q4kE+/
> >> cwA8Wh1dHlichyGb3U1wQ3NAoYZaqukb00bv9H+GqOQCFCa//zOSohb34yQC7e8z
> >> hfCCANcJtAhHihn2zeapysPCp5Pfsyq7UHUQHqaJiZKRq31EeePV6laT+7+J/IPV
> >> 6eV0Ow5QAkGXrwpv/i9vTscF620HWoT4iJxPXJatnDqwKeFQwM3Zpak6KOsKHtWF
> >> Wn8KZcDNhZcsI/vaWW9KtndPDl2kTvo8n/ZdPyAoPTZMcAPULcyZT75VxiPRV8Ky
> >> kQT/lFhnLQgbnfaGbfNwgIWybYt9tJ6JHjqt+xtSg+IBXM1aCY6bI5xqP43dS2xE
> >> yuvTq4Z3UcS1jGVr4wiCwOEqVw2ZRQcioXDeDDAD0qZXbRkUi9tImkIx5k7ICxNu
> >> 4uAYI3QrMK1QU/QteUJwZnJFDlvDQyx4FshkKePRHrlZJ5N73G4u2ChF1XDO0e5c
> >> NESit9hqIS3Dz3eXExt/0mQDTMWIMzdopb7R9/uVIZtCMNV618cUvuutZYGrvSd9
> >> 390+Z8fWoB1VroZumbOVbwE8DlsiN7YoNwTVEm1CESTavJw5dNcZnXumY3KWtaye
> >> BDoN+YEQdTeVvOs2s+CAwjMXVBIxGp2KfY4eXZlis16D8SUVifA=
> >> =WU+g
> >> -----END PGP SIGNATURE-----
> >>
> >> Signature for apache-wicket-7.11.0.tar.gz:
> >>
> >> -----BEGIN PGP SIGNATURE-----
> >>
> >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
> >> VuG/SA//dX5ZJ/kLVy2pl2Wcqeo9nAiHGSLPjkhIdQQ5y4clGtKpyydb1pBtwNTp
> >> ENMO/wNWeFEvphRM6KcA1D+z15FMZxCicuOc9JwbWCVnfujQFJF5dK3WX+nnJgX1
> >> WyuxHvhxDnjUT3lFjGECfkoiua1yVh20QUzEcqC9S2ReqyREitjGKrh7sGWx+WCM
> >> 2ls7pE6cXkuIjkNZP49f8LwyTIs4epK+4lkgPvgf5YgcBOVZNXK4BJ4nR74Fdr49
> >> qeRILeflhEk6vIK6a7quVeICnQ7bocku0wtnuy53xbipHSkcj6GwmE9bK3z+exa3
> >> Djg11GaqdNo1U3awmK+n3nOOBlbq1B0zwTjvAeK2m9eCwbE8W6TP2/U7mFaqCH5u
> >> e4hR84kTYXJ9f65URDyAZTcORRIfF1z8edEqGkVH2uI/P3U+Nwx7969PabQEWjM6
> >> NCrnvaDnTpiQuIJ/4AVLtDOPEnWiN/Zd/ooE7q1TWx7GeF0/hsfAM3nN/u7o0IoW
> >> MKPxodnPa4cX2549n/grUYsHG9PN0hKIVSk4b3O1kHZL4rFqxh1SzyAIi5UEeyhD
> >> sZARZfw/XC8j3rrd4eL9FjOgNvz75lhRZuuWCqIuBhrUVGrtJ1tFoQf5WL/EopJd
> >> 9qI6Bh1ltlAWz39mxW/w6AW5LQmAA+SBAAsZS5Lx5lwwx6LxzI0=
> >> =rLlH
> >> -----END PGP SIGNATURE-----
> >>
> >> ========================================================================
> >>
> >> CHANGELOG for 7.11.0:
> >>
> >> ** Bug
> >>
> >> * [WICKET-6473] - Double slash break 404page
> >> * [WICKET-6533] - Error while parsing xml using AjaxButton
> >> * [WICKET-6546] - CssContentHeaderItem comments CSS code with HTML
> >> comments
> >> * [WICKET-6551] - LazyInitProxyFactory doesn't work correctly at
> >> Weblogic
> >> * [WICKET-6553] - SelectOptions doesn't html-encode option values
> >> * [WICKET-6564] - PageStoreManager#clear() does not completely
> clear
> >> * [WICKET-6568] - Wicket fails / does not encode request header
> >> values in AjaxCalls
> >> * [WICKET-6586] - Broken JavaScript due to fix charsetName in
> >> JavaScriptPackageResource
> >> * [WICKET-6589] - ClientInfo fails with NumberFormatException for
> >> unusual browser versions
> >> * [WICKET-6604] - Ajax repaint is not correctly handled when
> >> component being repainted has an enclosure associated with it and is
> >> not a child of the enclosure
> >> * [WICKET-6614] - AbstractRangeValidator looks up string with the
> >> wrong key if locale is Turkish
> >>
> >> ** Improvement
> >>
> >> * [WICKET-6527] - no possibility to override fixed html appended
> >> directly to response by FilterForm
> >> * [WICKET-6605] - Allow AjaxFallbackButton to be stateless
> >>
> >> ** Task
> >>
> >> * [WICKET-6594] - JavaDoc of redirectToInterceptPage in Component
> >> urges to use redirectTo method when in a constructor
> >>
> >
>
--
WBR
Maxim aka solomax
Re: [VOTE] Release Apache Wicket 7.11.0
Posted by Andrea Del Bene <an...@gmail.com>.
Hi Maxim,
I wrongly confused the current Wicket 7 branch with the release code.
Branch wicket-7.x doesn't contain yet the change to avoid the problem
with JavaDoc, but the source distribution for 7.11.0 does and you should
be able to build it from scratch. I've downloaded the source
distribution, deleted ~/.m2/repository/* and successfully run 'mvn clean
install -P buildbot'. For some reason you are experiencing a problem
with maven repository and artifact org.apache:apache:pom:21, which is
quite strange. Hopefully is a network problem that will be solved in a
short time .I have no problem canceling the current vote and making a
new one, but I think it wouldn't be very useful.
On 24/11/18 11:18, Maxim Solodovnik wrote:
> My vote is -0.5,
> I believe we should create source distribution buildable without code
> modification
>
> On Fri, 23 Nov 2018 at 20:50, Andrea Del Bene <an...@gmail.com> wrote:
>
>> This is a vote to release Apache Wicket 7.11.0
>>
>> Please download the source distributions found in our staging area
>> linked below.
>>
>> I have included the signatures for both the source archives. This vote
>> lasts for 72 hours minimum.
>>
>> [ ] Yes, release Apache Wicket 7.11.0
>> [ ] No, don't release Apache Wicket 7.11.0, because ...
>>
>> Distributions, changelog, keys and signatures can be found at:
>>
>> https://dist.apache.org/repos/dist/dev/wicket/7.11.0
>>
>> Staging repository:
>>
>>
>> https://repository.apache.org/content/repositories/orgapachewicket-1115
>>
>> The binaries are available in the above link, as are a staging
>> repository for Maven. Typically the vote is on the source, but should
>> you find a problem with one of the binaries, please let me know, I can
>> re-roll them some way or the other.
>>
>> Staging git repository data:
>>
>> Repository: git@github.com:bitstorm/wicket.git
>> Branch: build/wicket-7.11.0
>> Release tag: rel/wicket-7.11.0
>>
>>
>> ========================================================================
>>
>> The signatures for the source release artefacts:
>>
>>
>> Signature for apache-wicket-7.11.0.zip:
>>
>> -----BEGIN PGP SIGNATURE-----
>>
>> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
>> VuEHeQ//VlvFvtQYKtD0e9Qcu1vmpvoVlV58ZKPrYBuTQO9oRE72VDIbr5q4kE+/
>> cwA8Wh1dHlichyGb3U1wQ3NAoYZaqukb00bv9H+GqOQCFCa//zOSohb34yQC7e8z
>> hfCCANcJtAhHihn2zeapysPCp5Pfsyq7UHUQHqaJiZKRq31EeePV6laT+7+J/IPV
>> 6eV0Ow5QAkGXrwpv/i9vTscF620HWoT4iJxPXJatnDqwKeFQwM3Zpak6KOsKHtWF
>> Wn8KZcDNhZcsI/vaWW9KtndPDl2kTvo8n/ZdPyAoPTZMcAPULcyZT75VxiPRV8Ky
>> kQT/lFhnLQgbnfaGbfNwgIWybYt9tJ6JHjqt+xtSg+IBXM1aCY6bI5xqP43dS2xE
>> yuvTq4Z3UcS1jGVr4wiCwOEqVw2ZRQcioXDeDDAD0qZXbRkUi9tImkIx5k7ICxNu
>> 4uAYI3QrMK1QU/QteUJwZnJFDlvDQyx4FshkKePRHrlZJ5N73G4u2ChF1XDO0e5c
>> NESit9hqIS3Dz3eXExt/0mQDTMWIMzdopb7R9/uVIZtCMNV618cUvuutZYGrvSd9
>> 390+Z8fWoB1VroZumbOVbwE8DlsiN7YoNwTVEm1CESTavJw5dNcZnXumY3KWtaye
>> BDoN+YEQdTeVvOs2s+CAwjMXVBIxGp2KfY4eXZlis16D8SUVifA=
>> =WU+g
>> -----END PGP SIGNATURE-----
>>
>> Signature for apache-wicket-7.11.0.tar.gz:
>>
>> -----BEGIN PGP SIGNATURE-----
>>
>> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
>> VuG/SA//dX5ZJ/kLVy2pl2Wcqeo9nAiHGSLPjkhIdQQ5y4clGtKpyydb1pBtwNTp
>> ENMO/wNWeFEvphRM6KcA1D+z15FMZxCicuOc9JwbWCVnfujQFJF5dK3WX+nnJgX1
>> WyuxHvhxDnjUT3lFjGECfkoiua1yVh20QUzEcqC9S2ReqyREitjGKrh7sGWx+WCM
>> 2ls7pE6cXkuIjkNZP49f8LwyTIs4epK+4lkgPvgf5YgcBOVZNXK4BJ4nR74Fdr49
>> qeRILeflhEk6vIK6a7quVeICnQ7bocku0wtnuy53xbipHSkcj6GwmE9bK3z+exa3
>> Djg11GaqdNo1U3awmK+n3nOOBlbq1B0zwTjvAeK2m9eCwbE8W6TP2/U7mFaqCH5u
>> e4hR84kTYXJ9f65URDyAZTcORRIfF1z8edEqGkVH2uI/P3U+Nwx7969PabQEWjM6
>> NCrnvaDnTpiQuIJ/4AVLtDOPEnWiN/Zd/ooE7q1TWx7GeF0/hsfAM3nN/u7o0IoW
>> MKPxodnPa4cX2549n/grUYsHG9PN0hKIVSk4b3O1kHZL4rFqxh1SzyAIi5UEeyhD
>> sZARZfw/XC8j3rrd4eL9FjOgNvz75lhRZuuWCqIuBhrUVGrtJ1tFoQf5WL/EopJd
>> 9qI6Bh1ltlAWz39mxW/w6AW5LQmAA+SBAAsZS5Lx5lwwx6LxzI0=
>> =rLlH
>> -----END PGP SIGNATURE-----
>>
>> ========================================================================
>>
>> CHANGELOG for 7.11.0:
>>
>> ** Bug
>>
>> * [WICKET-6473] - Double slash break 404page
>> * [WICKET-6533] - Error while parsing xml using AjaxButton
>> * [WICKET-6546] - CssContentHeaderItem comments CSS code with HTML
>> comments
>> * [WICKET-6551] - LazyInitProxyFactory doesn't work correctly at
>> Weblogic
>> * [WICKET-6553] - SelectOptions doesn't html-encode option values
>> * [WICKET-6564] - PageStoreManager#clear() does not completely clear
>> * [WICKET-6568] - Wicket fails / does not encode request header
>> values in AjaxCalls
>> * [WICKET-6586] - Broken JavaScript due to fix charsetName in
>> JavaScriptPackageResource
>> * [WICKET-6589] - ClientInfo fails with NumberFormatException for
>> unusual browser versions
>> * [WICKET-6604] - Ajax repaint is not correctly handled when
>> component being repainted has an enclosure associated with it and is
>> not a child of the enclosure
>> * [WICKET-6614] - AbstractRangeValidator looks up string with the
>> wrong key if locale is Turkish
>>
>> ** Improvement
>>
>> * [WICKET-6527] - no possibility to override fixed html appended
>> directly to response by FilterForm
>> * [WICKET-6605] - Allow AjaxFallbackButton to be stateless
>>
>> ** Task
>>
>> * [WICKET-6594] - JavaDoc of redirectToInterceptPage in Component
>> urges to use redirectTo method when in a constructor
>>
>
Re: [VOTE] Release Apache Wicket 7.11.0
Posted by Maxim Solodovnik <so...@gmail.com>.
My vote is -0.5,
I believe we should create source distribution buildable without code
modification
On Fri, 23 Nov 2018 at 20:50, Andrea Del Bene <an...@gmail.com> wrote:
> This is a vote to release Apache Wicket 7.11.0
>
> Please download the source distributions found in our staging area
> linked below.
>
> I have included the signatures for both the source archives. This vote
> lasts for 72 hours minimum.
>
> [ ] Yes, release Apache Wicket 7.11.0
> [ ] No, don't release Apache Wicket 7.11.0, because ...
>
> Distributions, changelog, keys and signatures can be found at:
>
> https://dist.apache.org/repos/dist/dev/wicket/7.11.0
>
> Staging repository:
>
>
> https://repository.apache.org/content/repositories/orgapachewicket-1115
>
> The binaries are available in the above link, as are a staging
> repository for Maven. Typically the vote is on the source, but should
> you find a problem with one of the binaries, please let me know, I can
> re-roll them some way or the other.
>
> Staging git repository data:
>
> Repository: git@github.com:bitstorm/wicket.git
> Branch: build/wicket-7.11.0
> Release tag: rel/wicket-7.11.0
>
>
> ========================================================================
>
> The signatures for the source release artefacts:
>
>
> Signature for apache-wicket-7.11.0.zip:
>
> -----BEGIN PGP SIGNATURE-----
>
> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
> VuEHeQ//VlvFvtQYKtD0e9Qcu1vmpvoVlV58ZKPrYBuTQO9oRE72VDIbr5q4kE+/
> cwA8Wh1dHlichyGb3U1wQ3NAoYZaqukb00bv9H+GqOQCFCa//zOSohb34yQC7e8z
> hfCCANcJtAhHihn2zeapysPCp5Pfsyq7UHUQHqaJiZKRq31EeePV6laT+7+J/IPV
> 6eV0Ow5QAkGXrwpv/i9vTscF620HWoT4iJxPXJatnDqwKeFQwM3Zpak6KOsKHtWF
> Wn8KZcDNhZcsI/vaWW9KtndPDl2kTvo8n/ZdPyAoPTZMcAPULcyZT75VxiPRV8Ky
> kQT/lFhnLQgbnfaGbfNwgIWybYt9tJ6JHjqt+xtSg+IBXM1aCY6bI5xqP43dS2xE
> yuvTq4Z3UcS1jGVr4wiCwOEqVw2ZRQcioXDeDDAD0qZXbRkUi9tImkIx5k7ICxNu
> 4uAYI3QrMK1QU/QteUJwZnJFDlvDQyx4FshkKePRHrlZJ5N73G4u2ChF1XDO0e5c
> NESit9hqIS3Dz3eXExt/0mQDTMWIMzdopb7R9/uVIZtCMNV618cUvuutZYGrvSd9
> 390+Z8fWoB1VroZumbOVbwE8DlsiN7YoNwTVEm1CESTavJw5dNcZnXumY3KWtaye
> BDoN+YEQdTeVvOs2s+CAwjMXVBIxGp2KfY4eXZlis16D8SUVifA=
> =WU+g
> -----END PGP SIGNATURE-----
>
> Signature for apache-wicket-7.11.0.tar.gz:
>
> -----BEGIN PGP SIGNATURE-----
>
> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
> VuG/SA//dX5ZJ/kLVy2pl2Wcqeo9nAiHGSLPjkhIdQQ5y4clGtKpyydb1pBtwNTp
> ENMO/wNWeFEvphRM6KcA1D+z15FMZxCicuOc9JwbWCVnfujQFJF5dK3WX+nnJgX1
> WyuxHvhxDnjUT3lFjGECfkoiua1yVh20QUzEcqC9S2ReqyREitjGKrh7sGWx+WCM
> 2ls7pE6cXkuIjkNZP49f8LwyTIs4epK+4lkgPvgf5YgcBOVZNXK4BJ4nR74Fdr49
> qeRILeflhEk6vIK6a7quVeICnQ7bocku0wtnuy53xbipHSkcj6GwmE9bK3z+exa3
> Djg11GaqdNo1U3awmK+n3nOOBlbq1B0zwTjvAeK2m9eCwbE8W6TP2/U7mFaqCH5u
> e4hR84kTYXJ9f65URDyAZTcORRIfF1z8edEqGkVH2uI/P3U+Nwx7969PabQEWjM6
> NCrnvaDnTpiQuIJ/4AVLtDOPEnWiN/Zd/ooE7q1TWx7GeF0/hsfAM3nN/u7o0IoW
> MKPxodnPa4cX2549n/grUYsHG9PN0hKIVSk4b3O1kHZL4rFqxh1SzyAIi5UEeyhD
> sZARZfw/XC8j3rrd4eL9FjOgNvz75lhRZuuWCqIuBhrUVGrtJ1tFoQf5WL/EopJd
> 9qI6Bh1ltlAWz39mxW/w6AW5LQmAA+SBAAsZS5Lx5lwwx6LxzI0=
> =rLlH
> -----END PGP SIGNATURE-----
>
> ========================================================================
>
> CHANGELOG for 7.11.0:
>
> ** Bug
>
> * [WICKET-6473] - Double slash break 404page
> * [WICKET-6533] - Error while parsing xml using AjaxButton
> * [WICKET-6546] - CssContentHeaderItem comments CSS code with HTML
> comments
> * [WICKET-6551] - LazyInitProxyFactory doesn't work correctly at
> Weblogic
> * [WICKET-6553] - SelectOptions doesn't html-encode option values
> * [WICKET-6564] - PageStoreManager#clear() does not completely clear
> * [WICKET-6568] - Wicket fails / does not encode request header
> values in AjaxCalls
> * [WICKET-6586] - Broken JavaScript due to fix charsetName in
> JavaScriptPackageResource
> * [WICKET-6589] - ClientInfo fails with NumberFormatException for
> unusual browser versions
> * [WICKET-6604] - Ajax repaint is not correctly handled when
> component being repainted has an enclosure associated with it and is
> not a child of the enclosure
> * [WICKET-6614] - AbstractRangeValidator looks up string with the
> wrong key if locale is Turkish
>
> ** Improvement
>
> * [WICKET-6527] - no possibility to override fixed html appended
> directly to response by FilterForm
> * [WICKET-6605] - Allow AjaxFallbackButton to be stateless
>
> ** Task
>
> * [WICKET-6594] - JavaDoc of redirectToInterceptPage in Component
> urges to use redirectTo method when in a constructor
>
--
WBR
Maxim aka solomax
Re: [VOTE] Release Apache Wicket 7.11.0
Posted by Andrea Del Bene <an...@gmail.com>.
This vote is cancelled. I will run a new one asap.
On Mon, Nov 26, 2018 at 6:35 PM Andrea Del Bene <an...@gmail.com>
wrote:
> I can remove it for you before restarting the release building.
>
> On Mon, Nov 26, 2018 at 1:35 PM Maxim Solodovnik <so...@gmail.com>
> wrote:
>
>> Shall I remove java8 profile from the pom.xml?
>>
>> On Mon, 26 Nov 2018 at 18:49, Andrea Del Bene <an...@gmail.com>
>> wrote:
>>
>> > +1 Looks fair to me!
>> >
>> > On Mon, Nov 26, 2018 at 12:23 PM Maxim Solodovnik <solomax666@gmail.com
>> >
>> > wrote:
>> >
>> > > Latest OpenJdk7 available is 7u95
>> > > I guess it is near to impossible to get update for java7 these days.
>> > >
>> > > maybe we should add some instructions to documentation and leave the
>> > build
>> > > as it is now
>> > > So wicket-7 build should work for most of the devs?
>> > >
>> > > On Mon, 26 Nov 2018 at 18:19, Andrea Del Bene <an...@gmail.com>
>> > > wrote:
>> > >
>> > > > Ok, I did further tests for this problem, but I think that is even
>> more
>> > > > complicated than we thought. As I said in previous email (see JDK
>> > release
>> > > > note below) the new policy about JavaDoc has been introduced at a
>> > certain
>> > > > point in all the three JDK available at that time: 6, 7 and 8. So
>> even
>> > > if
>> > > > I had JDK 7 as default distribution on my machine build, with the
>> > current
>> > > > wicket-7.x branch building process will fail if my JDK is
>> > '1.7.0_131-b12'
>> > > > or newer, requiring to have the this blessed
>> --allow-script-in-comments
>> > > > parameter set as additional parameter.
>> > > > And I guess we could have the same problem releasing Wicket 6.30.0.
>> > > >
>> > > >
>> > >
>> >
>> https://www.oracle.com/technetwork/java/javase/8u121-relnotes-3315208.html
>> > > >
>> > > > On Mon, Nov 26, 2018 at 11:40 AM Maxim Solodovnik <
>> > solomax666@gmail.com>
>> > > > wrote:
>> > > >
>> > > > > Actually it is implemented this way in wicket-7.x HEAD right now
>> ...
>> > > > >
>> > > > > On Mon, 26 Nov 2018 at 17:36, Emond Papegaaij <
>> > > > emond.papegaaij@topicus.nl>
>> > > > > wrote:
>> > > > >
>> > > > > > As Wicket 7 is supposed to be built with jdk7, why not simply
>> add
>> > the
>> > > > > > profile
>> > > > > > but not enable it by default when on jdk8? If you want build
>> with
>> > > jdk8
>> > > > > (or
>> > > > > > higher), you can enable the profile on the command line.
>> > > > > >
>> > > > > > Best regards,
>> > > > > > Emond
>> > > > > >
>> > > > > > On maandag 26 november 2018 10:43:55 CET Maxim Solodovnik wrote:
>> > > > > > > Hello Andrea,
>> > > > > > >
>> > > > > > > "extend the existing java8 profile activating it by default if
>> > our
>> > > > > > default
>> > > > > > > JDK is 1.8 or higher" will break toolchains build,
>> > > > > > > Here are the logs
>> > > > > > >
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>> https://ci.apache.org/builders/wicket-branch-7.x/builds/500/steps/compile/lo
>> > > > > > > gs/stdio (I
>> > > > > > > already tried it)
>> > > > > > >
>> > > > > > > On Mon, 26 Nov 2018 at 16:40, Andrea Del Bene <
>> > > an.delbene@gmail.com>
>> > > > > > wrote:
>> > > > > > > > Hi all,
>> > > > > > > >
>> > > > > > > > following the discussion about the issues related to the
>> > building
>> > > > of
>> > > > > > > > 7.11.0
>> > > > > > > > candidate, I suggest to do the following actions:
>> > > > > > > >
>> > > > > > > > -cancel this vote
>> > > > > > > > -remove the flag '--allow-script-in-comments' from JavaDoc
>> > plugin
>> > > > > > > > configuration
>> > > > > > > > -extend the existing java8 profile activating it by default
>> if
>> > > our
>> > > > > > default
>> > > > > > > > JDK is 1.8 or higher (with expresion '[1.8,)'). I now this
>> > > solution
>> > > > > > won't
>> > > > > > > > work for all 1.8 versions out there, but it should with most
>> > > recent
>> > > > > > > > versions of it. Honestly I can't find a better solution to
>> make
>> > > > > > everybody
>> > > > > > > > happy. This solution will NOT work only if somebody is
>> using an
>> > > > > > outdated
>> > > > > > > > version of JDK 1.8 as default JDK, but it should be ok in
>> all
>> > the
>> > > > > other
>> > > > > > > > cases.
>> > > > > > > > -...any suggestions?
>> > > > > > > >
>> > > > > > > >
>> > > > > > > >
>> > > > > > > > On Mon, Nov 26, 2018 at 10:09 AM Maxim Solodovnik <
>> > > > > > solomax666@gmail.com>
>> > > > > > > >
>> > > > > > > > wrote:
>> > > > > > > > > The error is something like:
>> > > > > > > > > "Invalid parameter --allow-script-in-comments" and javadoc
>> > will
>> > > > > fail
>> > > > > > > > >
>> > > > > > > > > It looks like java8 profile is activated, I was sure it
>> > > shouldn't
>> > > > > > since
>> > > > > > > > > java7 was selected using toolchains ...
>> > > > > > > > >
>> > > > > > > > > On Mon, 26 Nov 2018 at 15:54, Andrea Del Bene <
>> > > > > an.delbene@gmail.com>
>> > > > > > > > >
>> > > > > > > > > wrote:
>> > > > > > > > > > Hi Maxim
>> > > > > > > > > >
>> > > > > > > > > > On Mon, Nov 26, 2018 at 4:29 AM Maxim Solodovnik <
>> > > > > > solomax666@gmail.com
>> > > > > > > > > >
>> > > > > > > > > > wrote:
>> > > > > > > > > > > Hello Andrea,
>> > > > > > > > > > >
>> > > > > > > > > > > according to my tests this is not working if
>> toolchains
>> > > > plugin
>> > > > > is
>> > > > > > > >
>> > > > > > > > being
>> > > > > > > >
>> > > > > > > > > > > used, i.e.:
>> > > > > > > > > > > 1) java8 is set on the machine as default
>> > > > > > > > > > > 2) -Pbuildbot is used to activate java7 build
>> > > > > > > > > > > Result: java8 profile will be activated
>> > > > > > > > > >
>> > > > > > > > > > that's quite strange. Do you remember which error did
>> you
>> > > get
>> > > > > with
>> > > > > > > >
>> > > > > > > > this
>> > > > > > > >
>> > > > > > > > > > combination? I've searched through old mails but I
>> didn't
>> > > find
>> > > > > it.
>> > > > > > > > >
>> > > > > > > > > Anyway,
>> > > > > > > > >
>> > > > > > > > > > flag '--allow-script-in-comments' is supported in JDK 8
>> > only
>> > > > > > starting
>> > > > > > > > >
>> > > > > > > > > from
>> > > > > > > > >
>> > > > > > > > > > u121:
>> > > > > > > >
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>> https://www.oracle.com/technetwork/java/javase/8u121-relnotes-3315208.html
>> > > > > > > >
>> > > > > > > > > > > On Mon, 26 Nov 2018 at 04:22, Andrea Del Bene <
>> > > > > > an.delbene@gmail.com>
>> > > > > > > > > > >
>> > > > > > > > > > > wrote:
>> > > > > > > > > > > > I see that Maxim has already addressed this problem
>> > with
>> > > > > > > >
>> > > > > > > > WICKET-6615,
>> > > > > > > >
>> > > > > > > > > > or
>> > > > > > > > > >
>> > > > > > > > > > > > at least he partially did it. We should use a
>> profile
>> > > > which
>> > > > > is
>> > > > > > > > > > > > automatically activated when the JDK used to run
>> Maven
>> > is
>> > > > >=
>> > > > > > 1.8 .
>> > > > > > > > > > > >
>> > > > > > > > > > > > Something like this:
>> > > > > > > > > > > > <profile>
>> > > > > > > > > > > >
>> > > > > > > > > > > > <id>java8</id>
>> > > > > > > > > > > > <activation>
>> > > > > > > > > > > >
>> > > > > > > > > > > > <jdk>[1.8,)</jdk>
>> > > > > > > > > > > >
>> > > > > > > > > > > > </activation>
>> > > > > > > > > > > > <build>
>> > > > > > > > > > > >
>> > > > > > > > > > > > <pluginManagement>
>> > > > > > > > > > > >
>> > > > > > > > > > > > <plugins>
>> > > > > > > > > > > >
>> > > > > > > > > > > > <plugin>
>> > > > > > > > > > > >
>> > > > > > > > > > > > <groupId>org.apache.maven.plugins</groupId>
>> > > > > > > > > > > > <artifactId>maven-javadoc-plugin</artifactId>
>> > > > > > > > > > > >
>> > > > > > > > > > > > <configuration>
>> > > > > > > > > > > >
>> > > > > > > > > > > >
>> > > > <additionalparam>--allow-script-in-comments</additionalparam>
>> > > > > > > > > > > >
>> > > > > > > > > > > > </configuration>
>> > > > > > > > > > > >
>> > > > > > > > > > > > </plugin>
>> > > > > > > > > > > >
>> > > > > > > > > > > > </plugins>
>> > > > > > > > > > > >
>> > > > > > > > > > > > </pluginManagement>
>> > > > > > > > > > > >
>> > > > > > > > > > > > </build>
>> > > > > > > > > > > >
>> > > > > > > > > > > > </profile>
>> > > > > > > > > > > >
>> > > > > > > > > > > > A similar solution is described here:
>> > > > > > > >
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>> https://stackoverflow.com/questions/15886209/maven-is-not-working-in-java-
>> > > > > >
>> > > > > > > 8-when-javadoc-tags-are-incomplete>
>> > > > > > > > > > > > WDYT?
>> > > > > > > > > > > >
>> > > > > > > > > > > > > For me the build of
>> > > > > > > >
>> > > > > > > >
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>> https://dist.apache.org/repos/dist/dev/wicket/7.11.0/apache-wicket-7.11.0
>> .
>> > > > > > > > tar.gz>
>> > > > > > > > > > > > > fails with:
>> > > > > > > > > > > > >
>> > > > > > > > > > > > > [INFO]
>> > > > > > > > >
>> > > > > > > > >
>> > > > > >
>> > > >
>> > ------------------------------------------------------------------------
>> > > > > > > > >
>> > > > > > > > > > > > > [INFO] BUILD FAILURE
>> > > > > > > > > > > > > [INFO]
>> > > > > > > > >
>> > > > > > > > >
>> > > > > >
>> > > >
>> > ------------------------------------------------------------------------
>> > > > > > > > >
>> > > > > > > > > > > > > [INFO] Total time: 11.773 s
>> > > > > > > > > > > > > [INFO] Finished at: 2018-11-25T20:44:37+02:00
>> > > > > > > > > > > > > [INFO]
>> > > > > > > > >
>> > > > > > > > >
>> > > > > >
>> > > >
>> > ------------------------------------------------------------------------
>> > > > > > > > >
>> > > > > > > > > > > > > [ERROR] Failed to execute goal
>> > > > > > > > > > > > >
>> > > org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:jar
>> > > > > > > > > > > >
>> > > > > > > > > > > > (attach-javadocs)
>> > > > > > > > > > > >
>> > > > > > > > > > > > > on project wicket-util: MavenReportException:
>> Error
>> > > while
>> > > > > > > > >
>> > > > > > > > > generating
>> > > > > > > > >
>> > > > > > > > > > > > > Javadoc:
>> > > > > > > > > > > > > [ERROR] Exit code: 1 - javadoc: error - invalid
>> flag:
>> > > > > > > > > > > > > --allow-script-in-comments
>> > > > > > > > > > > > > [ERROR]
>> > > > > > > > > > > > > [ERROR] Command line was:
>> > > > > > /home/martin/devel/java-7/bin/javadoc
>> > > > > > > > > > > >
>> > > > > > > > > > > > -J-Xmx256m
>> > > > > > > > > > > >
>> > > > > > > > > > > > > -J-Xms128m @options @packages
>> > > > > > > > > > > > > [ERROR]
>> > > > > > > > > > > > > [ERROR] Refer to the generated Javadoc files in
>> > > > > > > > > > > > >
>> > > > '/tmp/w711/apache-wicket-7.11.0/wicket-util/target/apidocs'
>> > > > > > dir.
>> > > > > > > > > > > > >
>> > > > > > > > > > > > > My JDK 7 doesn't like the the newly added javadoc
>> > > > argument.
>> > > > > > > > > > > > >
>> > > > > > > > > > > > > java version "1.7.0_72"
>> > > > > > > > > > > > > Java(TM) SE Runtime Environment (build
>> 1.7.0_72-b14)
>> > > > > > > > > > > > > Java HotSpot(TM) 64-Bit Server VM (build
>> 24.72-b04,
>> > > mixed
>> > > > > > mode)
>> > > > > > > > > > > > >
>> > > > > > > > > > > > >
>> > > > > > > > > > > > > On Fri, Nov 23, 2018 at 3:50 PM Andrea Del Bene <
>> > > > > > > > > >
>> > > > > > > > > > an.delbene@gmail.com>
>> > > > > > > > > >
>> > > > > > > > > > > > > wrote:
>> > > > > > > > > > > > >> This is a vote to release Apache Wicket 7.11.0
>> > > > > > > > > > > > >>
>> > > > > > > > > > > > >> Please download the source distributions found in
>> > our
>> > > > > > staging
>> > > > > > > >
>> > > > > > > > area
>> > > > > > > >
>> > > > > > > > > > > > >> linked below.
>> > > > > > > > > > > > >>
>> > > > > > > > > > > > >> I have included the signatures for both the
>> source
>> > > > > archives.
>> > > > > > > >
>> > > > > > > > This
>> > > > > > > >
>> > > > > > > > > > vote
>> > > > > > > > > >
>> > > > > > > > > > > > >> lasts for 72 hours minimum.
>> > > > > > > > > > > > >>
>> > > > > > > > > > > > >> [ ] Yes, release Apache Wicket 7.11.0
>> > > > > > > > > > > > >> [ ] No, don't release Apache Wicket 7.11.0,
>> because
>> > > ...
>> > > > > > > > > > > > >>
>> > > > > > > > > > > > >> Distributions, changelog, keys and signatures
>> can be
>> > > > found
>> > > > > > at:
>> > > > > > > > > > > > >>
>> > > > https://dist.apache.org/repos/dist/dev/wicket/7.11.0
>> > > > > > > > > > > > >>
>> > > > > > > > > > > > >> Staging repository:
>> > > > > > > > >
>> > > > > >
>> > > >
>> > https://repository.apache.org/content/repositories/orgapachewicket-1115
>> > > > > > > > >
>> > > > > > > > > > > > >> The binaries are available in the above link, as
>> > are a
>> > > > > > staging
>> > > > > > > > > > > > >> repository for Maven. Typically the vote is on
>> the
>> > > > source,
>> > > > > > but
>> > > > > > > > > >
>> > > > > > > > > > should
>> > > > > > > > > >
>> > > > > > > > > > > > >> you find a problem with one of the binaries,
>> please
>> > > let
>> > > > me
>> > > > > > > >
>> > > > > > > > know, I
>> > > > > > > >
>> > > > > > > > > > can
>> > > > > > > > > >
>> > > > > > > > > > > > >> re-roll them some way or the other.
>> > > > > > > > > > > > >>
>> > > > > > > > > > > > >> Staging git repository data:
>> > > > > > > > > > > > >> Repository: git@github.com:
>> > bitstorm/wicket.git
>> > > > > > > > > > > > >> Branch: build/wicket-7.11.0
>> > > > > > > > > > > > >> Release tag: rel/wicket-7.11.0
>> > > > > > > > >
>> > > > > > > > >
>> > > > > >
>> > > >
>> > ========================================================================
>> > > > > > > > >
>> > > > > > > > > > > > >> The signatures for the source release
>> > artefacts:
>> > > > > > > > > > > > >> Signature for apache-wicket-7.11.0.zip:
>> > > > > > > > > > > > >> -----BEGIN PGP SIGNATURE-----
>> > > > > > > > > > > > >>
>> > > > > > > > > > > > >>
>> > > > > > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qj
>> > > > > > > > > > > > >> T
>> > > > > > > > > > > > >>
>> > > > > > VuEHeQ//VlvFvtQYKtD0e9Qcu1vmpvoVlV58ZKPrYBuTQO9oRE72VDIbr5q4kE+
>> > > > > > > > > > > > >> /
>> > > > > > > > > > > > >>
>> > > > > > cwA8Wh1dHlichyGb3U1wQ3NAoYZaqukb00bv9H+GqOQCFCa//zOSohb34yQC7e8
>> > > > > > > > > > > > >> z
>> > > > > > > > > > > > >>
>> > > > > > hfCCANcJtAhHihn2zeapysPCp5Pfsyq7UHUQHqaJiZKRq31EeePV6laT+7+J/IP
>> > > > > > > > > > > > >> V
>> > > > > > > > > > > > >>
>> > > > > > 6eV0Ow5QAkGXrwpv/i9vTscF620HWoT4iJxPXJatnDqwKeFQwM3Zpak6KOsKHtW
>> > > > > > > > > > > > >> F
>> > > > > > > > > > > > >>
>> > > > > > Wn8KZcDNhZcsI/vaWW9KtndPDl2kTvo8n/ZdPyAoPTZMcAPULcyZT75VxiPRV8K
>> > > > > > > > > > > > >> y
>> > > > > > > > > > > > >>
>> > > > > > kQT/lFhnLQgbnfaGbfNwgIWybYt9tJ6JHjqt+xtSg+IBXM1aCY6bI5xqP43dS2x
>> > > > > > > > > > > > >> E
>> > > > > > > > > > > > >>
>> > > > > > yuvTq4Z3UcS1jGVr4wiCwOEqVw2ZRQcioXDeDDAD0qZXbRkUi9tImkIx5k7ICxN
>> > > > > > > > > > > > >> u
>> > > > > > > > > > > > >>
>> > > > > > 4uAYI3QrMK1QU/QteUJwZnJFDlvDQyx4FshkKePRHrlZJ5N73G4u2ChF1XDO0e5
>> > > > > > > > > > > > >> c
>> > > > > > > > > > > > >>
>> > > > > > NESit9hqIS3Dz3eXExt/0mQDTMWIMzdopb7R9/uVIZtCMNV618cUvuutZYGrvSd
>> > > > > > > > > > > > >> 9
>> > > > > > > > > > > > >>
>> > > > > > 390+Z8fWoB1VroZumbOVbwE8DlsiN7YoNwTVEm1CESTavJw5dNcZnXumY3KWtay
>> > > > > > > > > > > > >> e
>> > > > > > > > > > > > >>
>> BDoN+YEQdTeVvOs2s+CAwjMXVBIxGp2KfY4eXZlis16D8SUVifA=
>> > > > > > > > > > > > >> =WU+g
>> > > > > > > > > > > > >> -----END PGP SIGNATURE-----
>> > > > > > > > > > > > >>
>> > > > > > > > > > > > >> Signature for apache-wicket-7.11.0.tar.gz:
>> > > > > > > > > > > > >> -----BEGIN PGP SIGNATURE-----
>> > > > > > > > > > > > >>
>> > > > > > > > > > > > >>
>> > > > > > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qj
>> > > > > > > > > > > > >> T
>> > > > > > > > > > > > >>
>> > > > > > VuG/SA//dX5ZJ/kLVy2pl2Wcqeo9nAiHGSLPjkhIdQQ5y4clGtKpyydb1pBtwNT
>> > > > > > > > > > > > >> p
>> > > > > > > > > > > > >>
>> > > > > > ENMO/wNWeFEvphRM6KcA1D+z15FMZxCicuOc9JwbWCVnfujQFJF5dK3WX+nnJgX
>> > > > > > > > > > > > >> 1
>> > > > > > > > > > > > >>
>> > > > > > WyuxHvhxDnjUT3lFjGECfkoiua1yVh20QUzEcqC9S2ReqyREitjGKrh7sGWx+WC
>> > > > > > > > > > > > >> M
>> > > > > > > > > > > > >>
>> > > > > > 2ls7pE6cXkuIjkNZP49f8LwyTIs4epK+4lkgPvgf5YgcBOVZNXK4BJ4nR74Fdr4
>> > > > > > > > > > > > >> 9
>> > > > > > > > > > > > >>
>> > > > > > qeRILeflhEk6vIK6a7quVeICnQ7bocku0wtnuy53xbipHSkcj6GwmE9bK3z+exa
>> > > > > > > > > > > > >> 3
>> > > > > > > > > > > > >>
>> > > > > > Djg11GaqdNo1U3awmK+n3nOOBlbq1B0zwTjvAeK2m9eCwbE8W6TP2/U7mFaqCH5
>> > > > > > > > > > > > >> u
>> > > > > > > > > > > > >>
>> > > > > > e4hR84kTYXJ9f65URDyAZTcORRIfF1z8edEqGkVH2uI/P3U+Nwx7969PabQEWjM
>> > > > > > > > > > > > >> 6
>> > > > > > > > > > > > >>
>> > > > > > NCrnvaDnTpiQuIJ/4AVLtDOPEnWiN/Zd/ooE7q1TWx7GeF0/hsfAM3nN/u7o0Io
>> > > > > > > > > > > > >> W
>> > > > > > > > > > > > >>
>> > > > > > MKPxodnPa4cX2549n/grUYsHG9PN0hKIVSk4b3O1kHZL4rFqxh1SzyAIi5UEeyh
>> > > > > > > > > > > > >> D
>> > > > > > > > > > > > >>
>> > > > > > sZARZfw/XC8j3rrd4eL9FjOgNvz75lhRZuuWCqIuBhrUVGrtJ1tFoQf5WL/EopJ
>> > > > > > > > > > > > >> d
>> > > > > > > > > > > > >>
>> 9qI6Bh1ltlAWz39mxW/w6AW5LQmAA+SBAAsZS5Lx5lwwx6LxzI0=
>> > > > > > > > > > > > >> =rLlH
>> > > > > > > > > > > > >> -----END PGP SIGNATURE-----
>> > > > > > > > >
>> > > > > > > > >
>> > > > > >
>> > > >
>> > ========================================================================
>> > > > > > > > >
>> > > > > > > > > > > > >> CHANGELOG for 7.11.0:
>> > > > > > > > > > > > >> ** Bug
>> > > > > > > > > > > > >>
>> > > > > > > > > > > > >> * [WICKET-6473] - Double slash break 404page
>> > > > > > > > > > > > >> * [WICKET-6533] - Error while parsing xml
>> using
>> > > > > > AjaxButton
>> > > > > > > > > > > > >> * [WICKET-6546] - CssContentHeaderItem
>> comments
>> > > CSS
>> > > > > > code
>> > > > > > > >
>> > > > > > > > with
>> > > > > > > >
>> > > > > > > > > > > HTML
>> > > > > > > > > > >
>> > > > > > > > > > > > >> comments
>> > > > > > > > > > > > >>
>> > > > > > > > > > > > >> * [WICKET-6551] - LazyInitProxyFactory
>> doesn't
>> > > work
>> > > > > > > >
>> > > > > > > > correctly
>> > > > > > > >
>> > > > > > > > > > at
>> > > > > > > > > >
>> > > > > > > > > > > > >> Weblogic
>> > > > > > > > > > > > >>
>> > > > > > > > > > > > >> * [WICKET-6553] - SelectOptions doesn't
>> > > html-encode
>> > > > > > option
>> > > > > > > > > >
>> > > > > > > > > > values
>> > > > > > > > > >
>> > > > > > > > > > > > >> * [WICKET-6564] - PageStoreManager#clear()
>> does
>> > > not
>> > > > > > > > >
>> > > > > > > > > completely
>> > > > > > > > >
>> > > > > > > > > > > > clear
>> > > > > > > > > > > >
>> > > > > > > > > > > > >> * [WICKET-6568] - Wicket fails / does not
>> > encode
>> > > > > > request
>> > > > > > > > >
>> > > > > > > > > header
>> > > > > > > > >
>> > > > > > > > > > > > >> values in AjaxCalls
>> > > > > > > > > > > > >>
>> > > > > > > > > > > > >> * [WICKET-6586] - Broken JavaScript due to
>> fix
>> > > > > > charsetName
>> > > > > > > >
>> > > > > > > > in
>> > > > > > > >
>> > > > > > > > > > > > >> JavaScriptPackageResource
>> > > > > > > > > > > > >>
>> > > > > > > > > > > > >> * [WICKET-6589] - ClientInfo fails with
>> > > > > > > >
>> > > > > > > > NumberFormatException
>> > > > > > > >
>> > > > > > > > > > for
>> > > > > > > > > >
>> > > > > > > > > > > > >> unusual browser versions
>> > > > > > > > > > > > >>
>> > > > > > > > > > > > >> * [WICKET-6604] - Ajax repaint is not
>> correctly
>> > > > > handled
>> > > > > > > >
>> > > > > > > > when
>> > > > > > > >
>> > > > > > > > > > > > >> component being repainted has an enclosure
>> > associated
>> > > > with
>> > > > > > it
>> > > > > > > >
>> > > > > > > > and
>> > > > > > > >
>> > > > > > > > > is
>> > > > > > > > >
>> > > > > > > > > > > > >> not a child of the enclosure
>> > > > > > > > > > > > >>
>> > > > > > > > > > > > >> * [WICKET-6614] - AbstractRangeValidator
>> looks
>> > up
>> > > > > > string
>> > > > > > > >
>> > > > > > > > with
>> > > > > > > >
>> > > > > > > > > > the
>> > > > > > > > > >
>> > > > > > > > > > > > >> wrong key if locale is Turkish
>> > > > > > > > > > > > >>
>> > > > > > > > > > > > >> ** Improvement
>> > > > > > > > > > > > >>
>> > > > > > > > > > > > >> * [WICKET-6527] - no possibility to override
>> > > fixed
>> > > > > html
>> > > > > > > > > >
>> > > > > > > > > > appended
>> > > > > > > > > >
>> > > > > > > > > > > > >> directly to response by FilterForm
>> > > > > > > > > > > > >>
>> > > > > > > > > > > > >> * [WICKET-6605] - Allow AjaxFallbackButton
>> to
>> > be
>> > > > > > stateless
>> > > > > > > > > > > > >>
>> > > > > > > > > > > > >> ** Task
>> > > > > > > > > > > > >>
>> > > > > > > > > > > > >> * [WICKET-6594] - JavaDoc of
>> > > > redirectToInterceptPage
>> > > > > in
>> > > > > > > > > >
>> > > > > > > > > > Component
>> > > > > > > > > >
>> > > > > > > > > > > > >> urges to use redirectTo method when in a
>> constructor
>> > > > > > > > > > >
>> > > > > > > > > > > --
>> > > > > > > > > > > WBR
>> > > > > > > > > > > Maxim aka solomax
>> > > > > > > > > >
>> > > > > > > > > > --
>> > > > > > > > > > Andrea Del Bene.
>> > > > > > > > > > Apache Wicket committer.
>> > > > > > > > >
>> > > > > > > > > --
>> > > > > > > > > WBR
>> > > > > > > > > Maxim aka solomax
>> > > > > > > >
>> > > > > > > > --
>> > > > > > > > Andrea Del Bene.
>> > > > > > > > Apache Wicket committer.
>> > > > > >
>> > > > > >
>> > > > > >
>> > > > > >
>> > > > > >
>> > > > >
>> > > > > --
>> > > > > WBR
>> > > > > Maxim aka solomax
>> > > > >
>> > > >
>> > > >
>> > > > --
>> > > > Andrea Del Bene.
>> > > > Apache Wicket committer.
>> > > >
>> > >
>> > >
>> > > --
>> > > WBR
>> > > Maxim aka solomax
>> > >
>> >
>> >
>> > --
>> > Andrea Del Bene.
>> > Apache Wicket committer.
>> >
>>
>>
>> --
>> WBR
>> Maxim aka solomax
>>
>
>
> --
> Andrea Del Bene.
> Apache Wicket committer.
>
--
Andrea Del Bene.
Apache Wicket committer.
Re: [VOTE] Release Apache Wicket 7.11.0
Posted by Andrea Del Bene <an...@gmail.com>.
I can remove it for you before restarting the release building.
On Mon, Nov 26, 2018 at 1:35 PM Maxim Solodovnik <so...@gmail.com>
wrote:
> Shall I remove java8 profile from the pom.xml?
>
> On Mon, 26 Nov 2018 at 18:49, Andrea Del Bene <an...@gmail.com>
> wrote:
>
> > +1 Looks fair to me!
> >
> > On Mon, Nov 26, 2018 at 12:23 PM Maxim Solodovnik <so...@gmail.com>
> > wrote:
> >
> > > Latest OpenJdk7 available is 7u95
> > > I guess it is near to impossible to get update for java7 these days.
> > >
> > > maybe we should add some instructions to documentation and leave the
> > build
> > > as it is now
> > > So wicket-7 build should work for most of the devs?
> > >
> > > On Mon, 26 Nov 2018 at 18:19, Andrea Del Bene <an...@gmail.com>
> > > wrote:
> > >
> > > > Ok, I did further tests for this problem, but I think that is even
> more
> > > > complicated than we thought. As I said in previous email (see JDK
> > release
> > > > note below) the new policy about JavaDoc has been introduced at a
> > certain
> > > > point in all the three JDK available at that time: 6, 7 and 8. So
> even
> > > if
> > > > I had JDK 7 as default distribution on my machine build, with the
> > current
> > > > wicket-7.x branch building process will fail if my JDK is
> > '1.7.0_131-b12'
> > > > or newer, requiring to have the this blessed
> --allow-script-in-comments
> > > > parameter set as additional parameter.
> > > > And I guess we could have the same problem releasing Wicket 6.30.0.
> > > >
> > > >
> > >
> >
> https://www.oracle.com/technetwork/java/javase/8u121-relnotes-3315208.html
> > > >
> > > > On Mon, Nov 26, 2018 at 11:40 AM Maxim Solodovnik <
> > solomax666@gmail.com>
> > > > wrote:
> > > >
> > > > > Actually it is implemented this way in wicket-7.x HEAD right now
> ...
> > > > >
> > > > > On Mon, 26 Nov 2018 at 17:36, Emond Papegaaij <
> > > > emond.papegaaij@topicus.nl>
> > > > > wrote:
> > > > >
> > > > > > As Wicket 7 is supposed to be built with jdk7, why not simply add
> > the
> > > > > > profile
> > > > > > but not enable it by default when on jdk8? If you want build with
> > > jdk8
> > > > > (or
> > > > > > higher), you can enable the profile on the command line.
> > > > > >
> > > > > > Best regards,
> > > > > > Emond
> > > > > >
> > > > > > On maandag 26 november 2018 10:43:55 CET Maxim Solodovnik wrote:
> > > > > > > Hello Andrea,
> > > > > > >
> > > > > > > "extend the existing java8 profile activating it by default if
> > our
> > > > > > default
> > > > > > > JDK is 1.8 or higher" will break toolchains build,
> > > > > > > Here are the logs
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://ci.apache.org/builders/wicket-branch-7.x/builds/500/steps/compile/lo
> > > > > > > gs/stdio (I
> > > > > > > already tried it)
> > > > > > >
> > > > > > > On Mon, 26 Nov 2018 at 16:40, Andrea Del Bene <
> > > an.delbene@gmail.com>
> > > > > > wrote:
> > > > > > > > Hi all,
> > > > > > > >
> > > > > > > > following the discussion about the issues related to the
> > building
> > > > of
> > > > > > > > 7.11.0
> > > > > > > > candidate, I suggest to do the following actions:
> > > > > > > >
> > > > > > > > -cancel this vote
> > > > > > > > -remove the flag '--allow-script-in-comments' from JavaDoc
> > plugin
> > > > > > > > configuration
> > > > > > > > -extend the existing java8 profile activating it by default
> if
> > > our
> > > > > > default
> > > > > > > > JDK is 1.8 or higher (with expresion '[1.8,)'). I now this
> > > solution
> > > > > > won't
> > > > > > > > work for all 1.8 versions out there, but it should with most
> > > recent
> > > > > > > > versions of it. Honestly I can't find a better solution to
> make
> > > > > > everybody
> > > > > > > > happy. This solution will NOT work only if somebody is using
> an
> > > > > > outdated
> > > > > > > > version of JDK 1.8 as default JDK, but it should be ok in all
> > the
> > > > > other
> > > > > > > > cases.
> > > > > > > > -...any suggestions?
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > On Mon, Nov 26, 2018 at 10:09 AM Maxim Solodovnik <
> > > > > > solomax666@gmail.com>
> > > > > > > >
> > > > > > > > wrote:
> > > > > > > > > The error is something like:
> > > > > > > > > "Invalid parameter --allow-script-in-comments" and javadoc
> > will
> > > > > fail
> > > > > > > > >
> > > > > > > > > It looks like java8 profile is activated, I was sure it
> > > shouldn't
> > > > > > since
> > > > > > > > > java7 was selected using toolchains ...
> > > > > > > > >
> > > > > > > > > On Mon, 26 Nov 2018 at 15:54, Andrea Del Bene <
> > > > > an.delbene@gmail.com>
> > > > > > > > >
> > > > > > > > > wrote:
> > > > > > > > > > Hi Maxim
> > > > > > > > > >
> > > > > > > > > > On Mon, Nov 26, 2018 at 4:29 AM Maxim Solodovnik <
> > > > > > solomax666@gmail.com
> > > > > > > > > >
> > > > > > > > > > wrote:
> > > > > > > > > > > Hello Andrea,
> > > > > > > > > > >
> > > > > > > > > > > according to my tests this is not working if toolchains
> > > > plugin
> > > > > is
> > > > > > > >
> > > > > > > > being
> > > > > > > >
> > > > > > > > > > > used, i.e.:
> > > > > > > > > > > 1) java8 is set on the machine as default
> > > > > > > > > > > 2) -Pbuildbot is used to activate java7 build
> > > > > > > > > > > Result: java8 profile will be activated
> > > > > > > > > >
> > > > > > > > > > that's quite strange. Do you remember which error did
> you
> > > get
> > > > > with
> > > > > > > >
> > > > > > > > this
> > > > > > > >
> > > > > > > > > > combination? I've searched through old mails but I didn't
> > > find
> > > > > it.
> > > > > > > > >
> > > > > > > > > Anyway,
> > > > > > > > >
> > > > > > > > > > flag '--allow-script-in-comments' is supported in JDK 8
> > only
> > > > > > starting
> > > > > > > > >
> > > > > > > > > from
> > > > > > > > >
> > > > > > > > > > u121:
> > > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://www.oracle.com/technetwork/java/javase/8u121-relnotes-3315208.html
> > > > > > > >
> > > > > > > > > > > On Mon, 26 Nov 2018 at 04:22, Andrea Del Bene <
> > > > > > an.delbene@gmail.com>
> > > > > > > > > > >
> > > > > > > > > > > wrote:
> > > > > > > > > > > > I see that Maxim has already addressed this problem
> > with
> > > > > > > >
> > > > > > > > WICKET-6615,
> > > > > > > >
> > > > > > > > > > or
> > > > > > > > > >
> > > > > > > > > > > > at least he partially did it. We should use a profile
> > > > which
> > > > > is
> > > > > > > > > > > > automatically activated when the JDK used to run
> Maven
> > is
> > > > >=
> > > > > > 1.8 .
> > > > > > > > > > > >
> > > > > > > > > > > > Something like this:
> > > > > > > > > > > > <profile>
> > > > > > > > > > > >
> > > > > > > > > > > > <id>java8</id>
> > > > > > > > > > > > <activation>
> > > > > > > > > > > >
> > > > > > > > > > > > <jdk>[1.8,)</jdk>
> > > > > > > > > > > >
> > > > > > > > > > > > </activation>
> > > > > > > > > > > > <build>
> > > > > > > > > > > >
> > > > > > > > > > > > <pluginManagement>
> > > > > > > > > > > >
> > > > > > > > > > > > <plugins>
> > > > > > > > > > > >
> > > > > > > > > > > > <plugin>
> > > > > > > > > > > >
> > > > > > > > > > > > <groupId>org.apache.maven.plugins</groupId>
> > > > > > > > > > > > <artifactId>maven-javadoc-plugin</artifactId>
> > > > > > > > > > > >
> > > > > > > > > > > > <configuration>
> > > > > > > > > > > >
> > > > > > > > > > > >
> > > > <additionalparam>--allow-script-in-comments</additionalparam>
> > > > > > > > > > > >
> > > > > > > > > > > > </configuration>
> > > > > > > > > > > >
> > > > > > > > > > > > </plugin>
> > > > > > > > > > > >
> > > > > > > > > > > > </plugins>
> > > > > > > > > > > >
> > > > > > > > > > > > </pluginManagement>
> > > > > > > > > > > >
> > > > > > > > > > > > </build>
> > > > > > > > > > > >
> > > > > > > > > > > > </profile>
> > > > > > > > > > > >
> > > > > > > > > > > > A similar solution is described here:
> > > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://stackoverflow.com/questions/15886209/maven-is-not-working-in-java-
> > > > > >
> > > > > > > 8-when-javadoc-tags-are-incomplete>
> > > > > > > > > > > > WDYT?
> > > > > > > > > > > >
> > > > > > > > > > > > > For me the build of
> > > > > > > >
> > > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/wicket/7.11.0/apache-wicket-7.11.0.
> > > > > > > > tar.gz>
> > > > > > > > > > > > > fails with:
> > > > > > > > > > > > >
> > > > > > > > > > > > > [INFO]
> > > > > > > > >
> > > > > > > > >
> > > > > >
> > > >
> > ------------------------------------------------------------------------
> > > > > > > > >
> > > > > > > > > > > > > [INFO] BUILD FAILURE
> > > > > > > > > > > > > [INFO]
> > > > > > > > >
> > > > > > > > >
> > > > > >
> > > >
> > ------------------------------------------------------------------------
> > > > > > > > >
> > > > > > > > > > > > > [INFO] Total time: 11.773 s
> > > > > > > > > > > > > [INFO] Finished at: 2018-11-25T20:44:37+02:00
> > > > > > > > > > > > > [INFO]
> > > > > > > > >
> > > > > > > > >
> > > > > >
> > > >
> > ------------------------------------------------------------------------
> > > > > > > > >
> > > > > > > > > > > > > [ERROR] Failed to execute goal
> > > > > > > > > > > > >
> > > org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:jar
> > > > > > > > > > > >
> > > > > > > > > > > > (attach-javadocs)
> > > > > > > > > > > >
> > > > > > > > > > > > > on project wicket-util: MavenReportException: Error
> > > while
> > > > > > > > >
> > > > > > > > > generating
> > > > > > > > >
> > > > > > > > > > > > > Javadoc:
> > > > > > > > > > > > > [ERROR] Exit code: 1 - javadoc: error - invalid
> flag:
> > > > > > > > > > > > > --allow-script-in-comments
> > > > > > > > > > > > > [ERROR]
> > > > > > > > > > > > > [ERROR] Command line was:
> > > > > > /home/martin/devel/java-7/bin/javadoc
> > > > > > > > > > > >
> > > > > > > > > > > > -J-Xmx256m
> > > > > > > > > > > >
> > > > > > > > > > > > > -J-Xms128m @options @packages
> > > > > > > > > > > > > [ERROR]
> > > > > > > > > > > > > [ERROR] Refer to the generated Javadoc files in
> > > > > > > > > > > > >
> > > > '/tmp/w711/apache-wicket-7.11.0/wicket-util/target/apidocs'
> > > > > > dir.
> > > > > > > > > > > > >
> > > > > > > > > > > > > My JDK 7 doesn't like the the newly added javadoc
> > > > argument.
> > > > > > > > > > > > >
> > > > > > > > > > > > > java version "1.7.0_72"
> > > > > > > > > > > > > Java(TM) SE Runtime Environment (build
> 1.7.0_72-b14)
> > > > > > > > > > > > > Java HotSpot(TM) 64-Bit Server VM (build 24.72-b04,
> > > mixed
> > > > > > mode)
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > > On Fri, Nov 23, 2018 at 3:50 PM Andrea Del Bene <
> > > > > > > > > >
> > > > > > > > > > an.delbene@gmail.com>
> > > > > > > > > >
> > > > > > > > > > > > > wrote:
> > > > > > > > > > > > >> This is a vote to release Apache Wicket 7.11.0
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> Please download the source distributions found in
> > our
> > > > > > staging
> > > > > > > >
> > > > > > > > area
> > > > > > > >
> > > > > > > > > > > > >> linked below.
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> I have included the signatures for both the source
> > > > > archives.
> > > > > > > >
> > > > > > > > This
> > > > > > > >
> > > > > > > > > > vote
> > > > > > > > > >
> > > > > > > > > > > > >> lasts for 72 hours minimum.
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> [ ] Yes, release Apache Wicket 7.11.0
> > > > > > > > > > > > >> [ ] No, don't release Apache Wicket 7.11.0,
> because
> > > ...
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> Distributions, changelog, keys and signatures can
> be
> > > > found
> > > > > > at:
> > > > > > > > > > > > >>
> > > > https://dist.apache.org/repos/dist/dev/wicket/7.11.0
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> Staging repository:
> > > > > > > > >
> > > > > >
> > > >
> > https://repository.apache.org/content/repositories/orgapachewicket-1115
> > > > > > > > >
> > > > > > > > > > > > >> The binaries are available in the above link, as
> > are a
> > > > > > staging
> > > > > > > > > > > > >> repository for Maven. Typically the vote is on the
> > > > source,
> > > > > > but
> > > > > > > > > >
> > > > > > > > > > should
> > > > > > > > > >
> > > > > > > > > > > > >> you find a problem with one of the binaries,
> please
> > > let
> > > > me
> > > > > > > >
> > > > > > > > know, I
> > > > > > > >
> > > > > > > > > > can
> > > > > > > > > >
> > > > > > > > > > > > >> re-roll them some way or the other.
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> Staging git repository data:
> > > > > > > > > > > > >> Repository: git@github.com:
> > bitstorm/wicket.git
> > > > > > > > > > > > >> Branch: build/wicket-7.11.0
> > > > > > > > > > > > >> Release tag: rel/wicket-7.11.0
> > > > > > > > >
> > > > > > > > >
> > > > > >
> > > >
> > ========================================================================
> > > > > > > > >
> > > > > > > > > > > > >> The signatures for the source release
> > artefacts:
> > > > > > > > > > > > >> Signature for apache-wicket-7.11.0.zip:
> > > > > > > > > > > > >> -----BEGIN PGP SIGNATURE-----
> > > > > > > > > > > > >>
> > > > > > > > > > > > >>
> > > > > > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qj
> > > > > > > > > > > > >> T
> > > > > > > > > > > > >>
> > > > > > VuEHeQ//VlvFvtQYKtD0e9Qcu1vmpvoVlV58ZKPrYBuTQO9oRE72VDIbr5q4kE+
> > > > > > > > > > > > >> /
> > > > > > > > > > > > >>
> > > > > > cwA8Wh1dHlichyGb3U1wQ3NAoYZaqukb00bv9H+GqOQCFCa//zOSohb34yQC7e8
> > > > > > > > > > > > >> z
> > > > > > > > > > > > >>
> > > > > > hfCCANcJtAhHihn2zeapysPCp5Pfsyq7UHUQHqaJiZKRq31EeePV6laT+7+J/IP
> > > > > > > > > > > > >> V
> > > > > > > > > > > > >>
> > > > > > 6eV0Ow5QAkGXrwpv/i9vTscF620HWoT4iJxPXJatnDqwKeFQwM3Zpak6KOsKHtW
> > > > > > > > > > > > >> F
> > > > > > > > > > > > >>
> > > > > > Wn8KZcDNhZcsI/vaWW9KtndPDl2kTvo8n/ZdPyAoPTZMcAPULcyZT75VxiPRV8K
> > > > > > > > > > > > >> y
> > > > > > > > > > > > >>
> > > > > > kQT/lFhnLQgbnfaGbfNwgIWybYt9tJ6JHjqt+xtSg+IBXM1aCY6bI5xqP43dS2x
> > > > > > > > > > > > >> E
> > > > > > > > > > > > >>
> > > > > > yuvTq4Z3UcS1jGVr4wiCwOEqVw2ZRQcioXDeDDAD0qZXbRkUi9tImkIx5k7ICxN
> > > > > > > > > > > > >> u
> > > > > > > > > > > > >>
> > > > > > 4uAYI3QrMK1QU/QteUJwZnJFDlvDQyx4FshkKePRHrlZJ5N73G4u2ChF1XDO0e5
> > > > > > > > > > > > >> c
> > > > > > > > > > > > >>
> > > > > > NESit9hqIS3Dz3eXExt/0mQDTMWIMzdopb7R9/uVIZtCMNV618cUvuutZYGrvSd
> > > > > > > > > > > > >> 9
> > > > > > > > > > > > >>
> > > > > > 390+Z8fWoB1VroZumbOVbwE8DlsiN7YoNwTVEm1CESTavJw5dNcZnXumY3KWtay
> > > > > > > > > > > > >> e
> > > > > > > > > > > > >>
> BDoN+YEQdTeVvOs2s+CAwjMXVBIxGp2KfY4eXZlis16D8SUVifA=
> > > > > > > > > > > > >> =WU+g
> > > > > > > > > > > > >> -----END PGP SIGNATURE-----
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> Signature for apache-wicket-7.11.0.tar.gz:
> > > > > > > > > > > > >> -----BEGIN PGP SIGNATURE-----
> > > > > > > > > > > > >>
> > > > > > > > > > > > >>
> > > > > > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qj
> > > > > > > > > > > > >> T
> > > > > > > > > > > > >>
> > > > > > VuG/SA//dX5ZJ/kLVy2pl2Wcqeo9nAiHGSLPjkhIdQQ5y4clGtKpyydb1pBtwNT
> > > > > > > > > > > > >> p
> > > > > > > > > > > > >>
> > > > > > ENMO/wNWeFEvphRM6KcA1D+z15FMZxCicuOc9JwbWCVnfujQFJF5dK3WX+nnJgX
> > > > > > > > > > > > >> 1
> > > > > > > > > > > > >>
> > > > > > WyuxHvhxDnjUT3lFjGECfkoiua1yVh20QUzEcqC9S2ReqyREitjGKrh7sGWx+WC
> > > > > > > > > > > > >> M
> > > > > > > > > > > > >>
> > > > > > 2ls7pE6cXkuIjkNZP49f8LwyTIs4epK+4lkgPvgf5YgcBOVZNXK4BJ4nR74Fdr4
> > > > > > > > > > > > >> 9
> > > > > > > > > > > > >>
> > > > > > qeRILeflhEk6vIK6a7quVeICnQ7bocku0wtnuy53xbipHSkcj6GwmE9bK3z+exa
> > > > > > > > > > > > >> 3
> > > > > > > > > > > > >>
> > > > > > Djg11GaqdNo1U3awmK+n3nOOBlbq1B0zwTjvAeK2m9eCwbE8W6TP2/U7mFaqCH5
> > > > > > > > > > > > >> u
> > > > > > > > > > > > >>
> > > > > > e4hR84kTYXJ9f65URDyAZTcORRIfF1z8edEqGkVH2uI/P3U+Nwx7969PabQEWjM
> > > > > > > > > > > > >> 6
> > > > > > > > > > > > >>
> > > > > > NCrnvaDnTpiQuIJ/4AVLtDOPEnWiN/Zd/ooE7q1TWx7GeF0/hsfAM3nN/u7o0Io
> > > > > > > > > > > > >> W
> > > > > > > > > > > > >>
> > > > > > MKPxodnPa4cX2549n/grUYsHG9PN0hKIVSk4b3O1kHZL4rFqxh1SzyAIi5UEeyh
> > > > > > > > > > > > >> D
> > > > > > > > > > > > >>
> > > > > > sZARZfw/XC8j3rrd4eL9FjOgNvz75lhRZuuWCqIuBhrUVGrtJ1tFoQf5WL/EopJ
> > > > > > > > > > > > >> d
> > > > > > > > > > > > >>
> 9qI6Bh1ltlAWz39mxW/w6AW5LQmAA+SBAAsZS5Lx5lwwx6LxzI0=
> > > > > > > > > > > > >> =rLlH
> > > > > > > > > > > > >> -----END PGP SIGNATURE-----
> > > > > > > > >
> > > > > > > > >
> > > > > >
> > > >
> > ========================================================================
> > > > > > > > >
> > > > > > > > > > > > >> CHANGELOG for 7.11.0:
> > > > > > > > > > > > >> ** Bug
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> * [WICKET-6473] - Double slash break 404page
> > > > > > > > > > > > >> * [WICKET-6533] - Error while parsing xml
> using
> > > > > > AjaxButton
> > > > > > > > > > > > >> * [WICKET-6546] - CssContentHeaderItem
> comments
> > > CSS
> > > > > > code
> > > > > > > >
> > > > > > > > with
> > > > > > > >
> > > > > > > > > > > HTML
> > > > > > > > > > >
> > > > > > > > > > > > >> comments
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> * [WICKET-6551] - LazyInitProxyFactory
> doesn't
> > > work
> > > > > > > >
> > > > > > > > correctly
> > > > > > > >
> > > > > > > > > > at
> > > > > > > > > >
> > > > > > > > > > > > >> Weblogic
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> * [WICKET-6553] - SelectOptions doesn't
> > > html-encode
> > > > > > option
> > > > > > > > > >
> > > > > > > > > > values
> > > > > > > > > >
> > > > > > > > > > > > >> * [WICKET-6564] - PageStoreManager#clear()
> does
> > > not
> > > > > > > > >
> > > > > > > > > completely
> > > > > > > > >
> > > > > > > > > > > > clear
> > > > > > > > > > > >
> > > > > > > > > > > > >> * [WICKET-6568] - Wicket fails / does not
> > encode
> > > > > > request
> > > > > > > > >
> > > > > > > > > header
> > > > > > > > >
> > > > > > > > > > > > >> values in AjaxCalls
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> * [WICKET-6586] - Broken JavaScript due to
> fix
> > > > > > charsetName
> > > > > > > >
> > > > > > > > in
> > > > > > > >
> > > > > > > > > > > > >> JavaScriptPackageResource
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> * [WICKET-6589] - ClientInfo fails with
> > > > > > > >
> > > > > > > > NumberFormatException
> > > > > > > >
> > > > > > > > > > for
> > > > > > > > > >
> > > > > > > > > > > > >> unusual browser versions
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> * [WICKET-6604] - Ajax repaint is not
> correctly
> > > > > handled
> > > > > > > >
> > > > > > > > when
> > > > > > > >
> > > > > > > > > > > > >> component being repainted has an enclosure
> > associated
> > > > with
> > > > > > it
> > > > > > > >
> > > > > > > > and
> > > > > > > >
> > > > > > > > > is
> > > > > > > > >
> > > > > > > > > > > > >> not a child of the enclosure
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> * [WICKET-6614] - AbstractRangeValidator
> looks
> > up
> > > > > > string
> > > > > > > >
> > > > > > > > with
> > > > > > > >
> > > > > > > > > > the
> > > > > > > > > >
> > > > > > > > > > > > >> wrong key if locale is Turkish
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> ** Improvement
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> * [WICKET-6527] - no possibility to override
> > > fixed
> > > > > html
> > > > > > > > > >
> > > > > > > > > > appended
> > > > > > > > > >
> > > > > > > > > > > > >> directly to response by FilterForm
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> * [WICKET-6605] - Allow AjaxFallbackButton to
> > be
> > > > > > stateless
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> ** Task
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> * [WICKET-6594] - JavaDoc of
> > > > redirectToInterceptPage
> > > > > in
> > > > > > > > > >
> > > > > > > > > > Component
> > > > > > > > > >
> > > > > > > > > > > > >> urges to use redirectTo method when in a
> constructor
> > > > > > > > > > >
> > > > > > > > > > > --
> > > > > > > > > > > WBR
> > > > > > > > > > > Maxim aka solomax
> > > > > > > > > >
> > > > > > > > > > --
> > > > > > > > > > Andrea Del Bene.
> > > > > > > > > > Apache Wicket committer.
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > WBR
> > > > > > > > > Maxim aka solomax
> > > > > > > >
> > > > > > > > --
> > > > > > > > Andrea Del Bene.
> > > > > > > > Apache Wicket committer.
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > > --
> > > > > WBR
> > > > > Maxim aka solomax
> > > > >
> > > >
> > > >
> > > > --
> > > > Andrea Del Bene.
> > > > Apache Wicket committer.
> > > >
> > >
> > >
> > > --
> > > WBR
> > > Maxim aka solomax
> > >
> >
> >
> > --
> > Andrea Del Bene.
> > Apache Wicket committer.
> >
>
>
> --
> WBR
> Maxim aka solomax
>
--
Andrea Del Bene.
Apache Wicket committer.
Re: [VOTE] Release Apache Wicket 7.11.0
Posted by Maxim Solodovnik <so...@gmail.com>.
Shall I remove java8 profile from the pom.xml?
On Mon, 26 Nov 2018 at 18:49, Andrea Del Bene <an...@gmail.com> wrote:
> +1 Looks fair to me!
>
> On Mon, Nov 26, 2018 at 12:23 PM Maxim Solodovnik <so...@gmail.com>
> wrote:
>
> > Latest OpenJdk7 available is 7u95
> > I guess it is near to impossible to get update for java7 these days.
> >
> > maybe we should add some instructions to documentation and leave the
> build
> > as it is now
> > So wicket-7 build should work for most of the devs?
> >
> > On Mon, 26 Nov 2018 at 18:19, Andrea Del Bene <an...@gmail.com>
> > wrote:
> >
> > > Ok, I did further tests for this problem, but I think that is even more
> > > complicated than we thought. As I said in previous email (see JDK
> release
> > > note below) the new policy about JavaDoc has been introduced at a
> certain
> > > point in all the three JDK available at that time: 6, 7 and 8. So even
> > if
> > > I had JDK 7 as default distribution on my machine build, with the
> current
> > > wicket-7.x branch building process will fail if my JDK is
> '1.7.0_131-b12'
> > > or newer, requiring to have the this blessed --allow-script-in-comments
> > > parameter set as additional parameter.
> > > And I guess we could have the same problem releasing Wicket 6.30.0.
> > >
> > >
> >
> https://www.oracle.com/technetwork/java/javase/8u121-relnotes-3315208.html
> > >
> > > On Mon, Nov 26, 2018 at 11:40 AM Maxim Solodovnik <
> solomax666@gmail.com>
> > > wrote:
> > >
> > > > Actually it is implemented this way in wicket-7.x HEAD right now ...
> > > >
> > > > On Mon, 26 Nov 2018 at 17:36, Emond Papegaaij <
> > > emond.papegaaij@topicus.nl>
> > > > wrote:
> > > >
> > > > > As Wicket 7 is supposed to be built with jdk7, why not simply add
> the
> > > > > profile
> > > > > but not enable it by default when on jdk8? If you want build with
> > jdk8
> > > > (or
> > > > > higher), you can enable the profile on the command line.
> > > > >
> > > > > Best regards,
> > > > > Emond
> > > > >
> > > > > On maandag 26 november 2018 10:43:55 CET Maxim Solodovnik wrote:
> > > > > > Hello Andrea,
> > > > > >
> > > > > > "extend the existing java8 profile activating it by default if
> our
> > > > > default
> > > > > > JDK is 1.8 or higher" will break toolchains build,
> > > > > > Here are the logs
> > > > > >
> > > > >
> > > >
> > >
> >
> https://ci.apache.org/builders/wicket-branch-7.x/builds/500/steps/compile/lo
> > > > > > gs/stdio (I
> > > > > > already tried it)
> > > > > >
> > > > > > On Mon, 26 Nov 2018 at 16:40, Andrea Del Bene <
> > an.delbene@gmail.com>
> > > > > wrote:
> > > > > > > Hi all,
> > > > > > >
> > > > > > > following the discussion about the issues related to the
> building
> > > of
> > > > > > > 7.11.0
> > > > > > > candidate, I suggest to do the following actions:
> > > > > > >
> > > > > > > -cancel this vote
> > > > > > > -remove the flag '--allow-script-in-comments' from JavaDoc
> plugin
> > > > > > > configuration
> > > > > > > -extend the existing java8 profile activating it by default if
> > our
> > > > > default
> > > > > > > JDK is 1.8 or higher (with expresion '[1.8,)'). I now this
> > solution
> > > > > won't
> > > > > > > work for all 1.8 versions out there, but it should with most
> > recent
> > > > > > > versions of it. Honestly I can't find a better solution to make
> > > > > everybody
> > > > > > > happy. This solution will NOT work only if somebody is using an
> > > > > outdated
> > > > > > > version of JDK 1.8 as default JDK, but it should be ok in all
> the
> > > > other
> > > > > > > cases.
> > > > > > > -...any suggestions?
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On Mon, Nov 26, 2018 at 10:09 AM Maxim Solodovnik <
> > > > > solomax666@gmail.com>
> > > > > > >
> > > > > > > wrote:
> > > > > > > > The error is something like:
> > > > > > > > "Invalid parameter --allow-script-in-comments" and javadoc
> will
> > > > fail
> > > > > > > >
> > > > > > > > It looks like java8 profile is activated, I was sure it
> > shouldn't
> > > > > since
> > > > > > > > java7 was selected using toolchains ...
> > > > > > > >
> > > > > > > > On Mon, 26 Nov 2018 at 15:54, Andrea Del Bene <
> > > > an.delbene@gmail.com>
> > > > > > > >
> > > > > > > > wrote:
> > > > > > > > > Hi Maxim
> > > > > > > > >
> > > > > > > > > On Mon, Nov 26, 2018 at 4:29 AM Maxim Solodovnik <
> > > > > solomax666@gmail.com
> > > > > > > > >
> > > > > > > > > wrote:
> > > > > > > > > > Hello Andrea,
> > > > > > > > > >
> > > > > > > > > > according to my tests this is not working if toolchains
> > > plugin
> > > > is
> > > > > > >
> > > > > > > being
> > > > > > >
> > > > > > > > > > used, i.e.:
> > > > > > > > > > 1) java8 is set on the machine as default
> > > > > > > > > > 2) -Pbuildbot is used to activate java7 build
> > > > > > > > > > Result: java8 profile will be activated
> > > > > > > > >
> > > > > > > > > that's quite strange. Do you remember which error did you
> > get
> > > > with
> > > > > > >
> > > > > > > this
> > > > > > >
> > > > > > > > > combination? I've searched through old mails but I didn't
> > find
> > > > it.
> > > > > > > >
> > > > > > > > Anyway,
> > > > > > > >
> > > > > > > > > flag '--allow-script-in-comments' is supported in JDK 8
> only
> > > > > starting
> > > > > > > >
> > > > > > > > from
> > > > > > > >
> > > > > > > > > u121:
> > > > > > >
> > > > >
> > > >
> > >
> >
> https://www.oracle.com/technetwork/java/javase/8u121-relnotes-3315208.html
> > > > > > >
> > > > > > > > > > On Mon, 26 Nov 2018 at 04:22, Andrea Del Bene <
> > > > > an.delbene@gmail.com>
> > > > > > > > > >
> > > > > > > > > > wrote:
> > > > > > > > > > > I see that Maxim has already addressed this problem
> with
> > > > > > >
> > > > > > > WICKET-6615,
> > > > > > >
> > > > > > > > > or
> > > > > > > > >
> > > > > > > > > > > at least he partially did it. We should use a profile
> > > which
> > > > is
> > > > > > > > > > > automatically activated when the JDK used to run Maven
> is
> > > >=
> > > > > 1.8 .
> > > > > > > > > > >
> > > > > > > > > > > Something like this:
> > > > > > > > > > > <profile>
> > > > > > > > > > >
> > > > > > > > > > > <id>java8</id>
> > > > > > > > > > > <activation>
> > > > > > > > > > >
> > > > > > > > > > > <jdk>[1.8,)</jdk>
> > > > > > > > > > >
> > > > > > > > > > > </activation>
> > > > > > > > > > > <build>
> > > > > > > > > > >
> > > > > > > > > > > <pluginManagement>
> > > > > > > > > > >
> > > > > > > > > > > <plugins>
> > > > > > > > > > >
> > > > > > > > > > > <plugin>
> > > > > > > > > > >
> > > > > > > > > > > <groupId>org.apache.maven.plugins</groupId>
> > > > > > > > > > > <artifactId>maven-javadoc-plugin</artifactId>
> > > > > > > > > > >
> > > > > > > > > > > <configuration>
> > > > > > > > > > >
> > > > > > > > > > >
> > > <additionalparam>--allow-script-in-comments</additionalparam>
> > > > > > > > > > >
> > > > > > > > > > > </configuration>
> > > > > > > > > > >
> > > > > > > > > > > </plugin>
> > > > > > > > > > >
> > > > > > > > > > > </plugins>
> > > > > > > > > > >
> > > > > > > > > > > </pluginManagement>
> > > > > > > > > > >
> > > > > > > > > > > </build>
> > > > > > > > > > >
> > > > > > > > > > > </profile>
> > > > > > > > > > >
> > > > > > > > > > > A similar solution is described here:
> > > > > > >
> > > > >
> > > >
> > >
> >
> https://stackoverflow.com/questions/15886209/maven-is-not-working-in-java-
> > > > >
> > > > > > 8-when-javadoc-tags-are-incomplete>
> > > > > > > > > > > WDYT?
> > > > > > > > > > >
> > > > > > > > > > > > For me the build of
> > > > > > >
> > > > > > >
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/wicket/7.11.0/apache-wicket-7.11.0.
> > > > > > > tar.gz>
> > > > > > > > > > > > fails with:
> > > > > > > > > > > >
> > > > > > > > > > > > [INFO]
> > > > > > > >
> > > > > > > >
> > > > >
> > >
> ------------------------------------------------------------------------
> > > > > > > >
> > > > > > > > > > > > [INFO] BUILD FAILURE
> > > > > > > > > > > > [INFO]
> > > > > > > >
> > > > > > > >
> > > > >
> > >
> ------------------------------------------------------------------------
> > > > > > > >
> > > > > > > > > > > > [INFO] Total time: 11.773 s
> > > > > > > > > > > > [INFO] Finished at: 2018-11-25T20:44:37+02:00
> > > > > > > > > > > > [INFO]
> > > > > > > >
> > > > > > > >
> > > > >
> > >
> ------------------------------------------------------------------------
> > > > > > > >
> > > > > > > > > > > > [ERROR] Failed to execute goal
> > > > > > > > > > > >
> > org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:jar
> > > > > > > > > > >
> > > > > > > > > > > (attach-javadocs)
> > > > > > > > > > >
> > > > > > > > > > > > on project wicket-util: MavenReportException: Error
> > while
> > > > > > > >
> > > > > > > > generating
> > > > > > > >
> > > > > > > > > > > > Javadoc:
> > > > > > > > > > > > [ERROR] Exit code: 1 - javadoc: error - invalid flag:
> > > > > > > > > > > > --allow-script-in-comments
> > > > > > > > > > > > [ERROR]
> > > > > > > > > > > > [ERROR] Command line was:
> > > > > /home/martin/devel/java-7/bin/javadoc
> > > > > > > > > > >
> > > > > > > > > > > -J-Xmx256m
> > > > > > > > > > >
> > > > > > > > > > > > -J-Xms128m @options @packages
> > > > > > > > > > > > [ERROR]
> > > > > > > > > > > > [ERROR] Refer to the generated Javadoc files in
> > > > > > > > > > > >
> > > '/tmp/w711/apache-wicket-7.11.0/wicket-util/target/apidocs'
> > > > > dir.
> > > > > > > > > > > >
> > > > > > > > > > > > My JDK 7 doesn't like the the newly added javadoc
> > > argument.
> > > > > > > > > > > >
> > > > > > > > > > > > java version "1.7.0_72"
> > > > > > > > > > > > Java(TM) SE Runtime Environment (build 1.7.0_72-b14)
> > > > > > > > > > > > Java HotSpot(TM) 64-Bit Server VM (build 24.72-b04,
> > mixed
> > > > > mode)
> > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > > > On Fri, Nov 23, 2018 at 3:50 PM Andrea Del Bene <
> > > > > > > > >
> > > > > > > > > an.delbene@gmail.com>
> > > > > > > > >
> > > > > > > > > > > > wrote:
> > > > > > > > > > > >> This is a vote to release Apache Wicket 7.11.0
> > > > > > > > > > > >>
> > > > > > > > > > > >> Please download the source distributions found in
> our
> > > > > staging
> > > > > > >
> > > > > > > area
> > > > > > >
> > > > > > > > > > > >> linked below.
> > > > > > > > > > > >>
> > > > > > > > > > > >> I have included the signatures for both the source
> > > > archives.
> > > > > > >
> > > > > > > This
> > > > > > >
> > > > > > > > > vote
> > > > > > > > >
> > > > > > > > > > > >> lasts for 72 hours minimum.
> > > > > > > > > > > >>
> > > > > > > > > > > >> [ ] Yes, release Apache Wicket 7.11.0
> > > > > > > > > > > >> [ ] No, don't release Apache Wicket 7.11.0, because
> > ...
> > > > > > > > > > > >>
> > > > > > > > > > > >> Distributions, changelog, keys and signatures can be
> > > found
> > > > > at:
> > > > > > > > > > > >>
> > > https://dist.apache.org/repos/dist/dev/wicket/7.11.0
> > > > > > > > > > > >>
> > > > > > > > > > > >> Staging repository:
> > > > > > > >
> > > > >
> > >
> https://repository.apache.org/content/repositories/orgapachewicket-1115
> > > > > > > >
> > > > > > > > > > > >> The binaries are available in the above link, as
> are a
> > > > > staging
> > > > > > > > > > > >> repository for Maven. Typically the vote is on the
> > > source,
> > > > > but
> > > > > > > > >
> > > > > > > > > should
> > > > > > > > >
> > > > > > > > > > > >> you find a problem with one of the binaries, please
> > let
> > > me
> > > > > > >
> > > > > > > know, I
> > > > > > >
> > > > > > > > > can
> > > > > > > > >
> > > > > > > > > > > >> re-roll them some way or the other.
> > > > > > > > > > > >>
> > > > > > > > > > > >> Staging git repository data:
> > > > > > > > > > > >> Repository: git@github.com:
> bitstorm/wicket.git
> > > > > > > > > > > >> Branch: build/wicket-7.11.0
> > > > > > > > > > > >> Release tag: rel/wicket-7.11.0
> > > > > > > >
> > > > > > > >
> > > > >
> > >
> ========================================================================
> > > > > > > >
> > > > > > > > > > > >> The signatures for the source release
> artefacts:
> > > > > > > > > > > >> Signature for apache-wicket-7.11.0.zip:
> > > > > > > > > > > >> -----BEGIN PGP SIGNATURE-----
> > > > > > > > > > > >>
> > > > > > > > > > > >>
> > > > > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qj
> > > > > > > > > > > >> T
> > > > > > > > > > > >>
> > > > > VuEHeQ//VlvFvtQYKtD0e9Qcu1vmpvoVlV58ZKPrYBuTQO9oRE72VDIbr5q4kE+
> > > > > > > > > > > >> /
> > > > > > > > > > > >>
> > > > > cwA8Wh1dHlichyGb3U1wQ3NAoYZaqukb00bv9H+GqOQCFCa//zOSohb34yQC7e8
> > > > > > > > > > > >> z
> > > > > > > > > > > >>
> > > > > hfCCANcJtAhHihn2zeapysPCp5Pfsyq7UHUQHqaJiZKRq31EeePV6laT+7+J/IP
> > > > > > > > > > > >> V
> > > > > > > > > > > >>
> > > > > 6eV0Ow5QAkGXrwpv/i9vTscF620HWoT4iJxPXJatnDqwKeFQwM3Zpak6KOsKHtW
> > > > > > > > > > > >> F
> > > > > > > > > > > >>
> > > > > Wn8KZcDNhZcsI/vaWW9KtndPDl2kTvo8n/ZdPyAoPTZMcAPULcyZT75VxiPRV8K
> > > > > > > > > > > >> y
> > > > > > > > > > > >>
> > > > > kQT/lFhnLQgbnfaGbfNwgIWybYt9tJ6JHjqt+xtSg+IBXM1aCY6bI5xqP43dS2x
> > > > > > > > > > > >> E
> > > > > > > > > > > >>
> > > > > yuvTq4Z3UcS1jGVr4wiCwOEqVw2ZRQcioXDeDDAD0qZXbRkUi9tImkIx5k7ICxN
> > > > > > > > > > > >> u
> > > > > > > > > > > >>
> > > > > 4uAYI3QrMK1QU/QteUJwZnJFDlvDQyx4FshkKePRHrlZJ5N73G4u2ChF1XDO0e5
> > > > > > > > > > > >> c
> > > > > > > > > > > >>
> > > > > NESit9hqIS3Dz3eXExt/0mQDTMWIMzdopb7R9/uVIZtCMNV618cUvuutZYGrvSd
> > > > > > > > > > > >> 9
> > > > > > > > > > > >>
> > > > > 390+Z8fWoB1VroZumbOVbwE8DlsiN7YoNwTVEm1CESTavJw5dNcZnXumY3KWtay
> > > > > > > > > > > >> e
> > > > > > > > > > > >> BDoN+YEQdTeVvOs2s+CAwjMXVBIxGp2KfY4eXZlis16D8SUVifA=
> > > > > > > > > > > >> =WU+g
> > > > > > > > > > > >> -----END PGP SIGNATURE-----
> > > > > > > > > > > >>
> > > > > > > > > > > >> Signature for apache-wicket-7.11.0.tar.gz:
> > > > > > > > > > > >> -----BEGIN PGP SIGNATURE-----
> > > > > > > > > > > >>
> > > > > > > > > > > >>
> > > > > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qj
> > > > > > > > > > > >> T
> > > > > > > > > > > >>
> > > > > VuG/SA//dX5ZJ/kLVy2pl2Wcqeo9nAiHGSLPjkhIdQQ5y4clGtKpyydb1pBtwNT
> > > > > > > > > > > >> p
> > > > > > > > > > > >>
> > > > > ENMO/wNWeFEvphRM6KcA1D+z15FMZxCicuOc9JwbWCVnfujQFJF5dK3WX+nnJgX
> > > > > > > > > > > >> 1
> > > > > > > > > > > >>
> > > > > WyuxHvhxDnjUT3lFjGECfkoiua1yVh20QUzEcqC9S2ReqyREitjGKrh7sGWx+WC
> > > > > > > > > > > >> M
> > > > > > > > > > > >>
> > > > > 2ls7pE6cXkuIjkNZP49f8LwyTIs4epK+4lkgPvgf5YgcBOVZNXK4BJ4nR74Fdr4
> > > > > > > > > > > >> 9
> > > > > > > > > > > >>
> > > > > qeRILeflhEk6vIK6a7quVeICnQ7bocku0wtnuy53xbipHSkcj6GwmE9bK3z+exa
> > > > > > > > > > > >> 3
> > > > > > > > > > > >>
> > > > > Djg11GaqdNo1U3awmK+n3nOOBlbq1B0zwTjvAeK2m9eCwbE8W6TP2/U7mFaqCH5
> > > > > > > > > > > >> u
> > > > > > > > > > > >>
> > > > > e4hR84kTYXJ9f65URDyAZTcORRIfF1z8edEqGkVH2uI/P3U+Nwx7969PabQEWjM
> > > > > > > > > > > >> 6
> > > > > > > > > > > >>
> > > > > NCrnvaDnTpiQuIJ/4AVLtDOPEnWiN/Zd/ooE7q1TWx7GeF0/hsfAM3nN/u7o0Io
> > > > > > > > > > > >> W
> > > > > > > > > > > >>
> > > > > MKPxodnPa4cX2549n/grUYsHG9PN0hKIVSk4b3O1kHZL4rFqxh1SzyAIi5UEeyh
> > > > > > > > > > > >> D
> > > > > > > > > > > >>
> > > > > sZARZfw/XC8j3rrd4eL9FjOgNvz75lhRZuuWCqIuBhrUVGrtJ1tFoQf5WL/EopJ
> > > > > > > > > > > >> d
> > > > > > > > > > > >> 9qI6Bh1ltlAWz39mxW/w6AW5LQmAA+SBAAsZS5Lx5lwwx6LxzI0=
> > > > > > > > > > > >> =rLlH
> > > > > > > > > > > >> -----END PGP SIGNATURE-----
> > > > > > > >
> > > > > > > >
> > > > >
> > >
> ========================================================================
> > > > > > > >
> > > > > > > > > > > >> CHANGELOG for 7.11.0:
> > > > > > > > > > > >> ** Bug
> > > > > > > > > > > >>
> > > > > > > > > > > >> * [WICKET-6473] - Double slash break 404page
> > > > > > > > > > > >> * [WICKET-6533] - Error while parsing xml using
> > > > > AjaxButton
> > > > > > > > > > > >> * [WICKET-6546] - CssContentHeaderItem comments
> > CSS
> > > > > code
> > > > > > >
> > > > > > > with
> > > > > > >
> > > > > > > > > > HTML
> > > > > > > > > >
> > > > > > > > > > > >> comments
> > > > > > > > > > > >>
> > > > > > > > > > > >> * [WICKET-6551] - LazyInitProxyFactory doesn't
> > work
> > > > > > >
> > > > > > > correctly
> > > > > > >
> > > > > > > > > at
> > > > > > > > >
> > > > > > > > > > > >> Weblogic
> > > > > > > > > > > >>
> > > > > > > > > > > >> * [WICKET-6553] - SelectOptions doesn't
> > html-encode
> > > > > option
> > > > > > > > >
> > > > > > > > > values
> > > > > > > > >
> > > > > > > > > > > >> * [WICKET-6564] - PageStoreManager#clear() does
> > not
> > > > > > > >
> > > > > > > > completely
> > > > > > > >
> > > > > > > > > > > clear
> > > > > > > > > > >
> > > > > > > > > > > >> * [WICKET-6568] - Wicket fails / does not
> encode
> > > > > request
> > > > > > > >
> > > > > > > > header
> > > > > > > >
> > > > > > > > > > > >> values in AjaxCalls
> > > > > > > > > > > >>
> > > > > > > > > > > >> * [WICKET-6586] - Broken JavaScript due to fix
> > > > > charsetName
> > > > > > >
> > > > > > > in
> > > > > > >
> > > > > > > > > > > >> JavaScriptPackageResource
> > > > > > > > > > > >>
> > > > > > > > > > > >> * [WICKET-6589] - ClientInfo fails with
> > > > > > >
> > > > > > > NumberFormatException
> > > > > > >
> > > > > > > > > for
> > > > > > > > >
> > > > > > > > > > > >> unusual browser versions
> > > > > > > > > > > >>
> > > > > > > > > > > >> * [WICKET-6604] - Ajax repaint is not correctly
> > > > handled
> > > > > > >
> > > > > > > when
> > > > > > >
> > > > > > > > > > > >> component being repainted has an enclosure
> associated
> > > with
> > > > > it
> > > > > > >
> > > > > > > and
> > > > > > >
> > > > > > > > is
> > > > > > > >
> > > > > > > > > > > >> not a child of the enclosure
> > > > > > > > > > > >>
> > > > > > > > > > > >> * [WICKET-6614] - AbstractRangeValidator looks
> up
> > > > > string
> > > > > > >
> > > > > > > with
> > > > > > >
> > > > > > > > > the
> > > > > > > > >
> > > > > > > > > > > >> wrong key if locale is Turkish
> > > > > > > > > > > >>
> > > > > > > > > > > >> ** Improvement
> > > > > > > > > > > >>
> > > > > > > > > > > >> * [WICKET-6527] - no possibility to override
> > fixed
> > > > html
> > > > > > > > >
> > > > > > > > > appended
> > > > > > > > >
> > > > > > > > > > > >> directly to response by FilterForm
> > > > > > > > > > > >>
> > > > > > > > > > > >> * [WICKET-6605] - Allow AjaxFallbackButton to
> be
> > > > > stateless
> > > > > > > > > > > >>
> > > > > > > > > > > >> ** Task
> > > > > > > > > > > >>
> > > > > > > > > > > >> * [WICKET-6594] - JavaDoc of
> > > redirectToInterceptPage
> > > > in
> > > > > > > > >
> > > > > > > > > Component
> > > > > > > > >
> > > > > > > > > > > >> urges to use redirectTo method when in a constructor
> > > > > > > > > >
> > > > > > > > > > --
> > > > > > > > > > WBR
> > > > > > > > > > Maxim aka solomax
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > Andrea Del Bene.
> > > > > > > > > Apache Wicket committer.
> > > > > > > >
> > > > > > > > --
> > > > > > > > WBR
> > > > > > > > Maxim aka solomax
> > > > > > >
> > > > > > > --
> > > > > > > Andrea Del Bene.
> > > > > > > Apache Wicket committer.
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > >
> > > > --
> > > > WBR
> > > > Maxim aka solomax
> > > >
> > >
> > >
> > > --
> > > Andrea Del Bene.
> > > Apache Wicket committer.
> > >
> >
> >
> > --
> > WBR
> > Maxim aka solomax
> >
>
>
> --
> Andrea Del Bene.
> Apache Wicket committer.
>
--
WBR
Maxim aka solomax
Re: [VOTE] Release Apache Wicket 7.11.0
Posted by Andrea Del Bene <an...@gmail.com>.
+1 Looks fair to me!
On Mon, Nov 26, 2018 at 12:23 PM Maxim Solodovnik <so...@gmail.com>
wrote:
> Latest OpenJdk7 available is 7u95
> I guess it is near to impossible to get update for java7 these days.
>
> maybe we should add some instructions to documentation and leave the build
> as it is now
> So wicket-7 build should work for most of the devs?
>
> On Mon, 26 Nov 2018 at 18:19, Andrea Del Bene <an...@gmail.com>
> wrote:
>
> > Ok, I did further tests for this problem, but I think that is even more
> > complicated than we thought. As I said in previous email (see JDK release
> > note below) the new policy about JavaDoc has been introduced at a certain
> > point in all the three JDK available at that time: 6, 7 and 8. So even
> if
> > I had JDK 7 as default distribution on my machine build, with the current
> > wicket-7.x branch building process will fail if my JDK is '1.7.0_131-b12'
> > or newer, requiring to have the this blessed --allow-script-in-comments
> > parameter set as additional parameter.
> > And I guess we could have the same problem releasing Wicket 6.30.0.
> >
> >
> https://www.oracle.com/technetwork/java/javase/8u121-relnotes-3315208.html
> >
> > On Mon, Nov 26, 2018 at 11:40 AM Maxim Solodovnik <so...@gmail.com>
> > wrote:
> >
> > > Actually it is implemented this way in wicket-7.x HEAD right now ...
> > >
> > > On Mon, 26 Nov 2018 at 17:36, Emond Papegaaij <
> > emond.papegaaij@topicus.nl>
> > > wrote:
> > >
> > > > As Wicket 7 is supposed to be built with jdk7, why not simply add the
> > > > profile
> > > > but not enable it by default when on jdk8? If you want build with
> jdk8
> > > (or
> > > > higher), you can enable the profile on the command line.
> > > >
> > > > Best regards,
> > > > Emond
> > > >
> > > > On maandag 26 november 2018 10:43:55 CET Maxim Solodovnik wrote:
> > > > > Hello Andrea,
> > > > >
> > > > > "extend the existing java8 profile activating it by default if our
> > > > default
> > > > > JDK is 1.8 or higher" will break toolchains build,
> > > > > Here are the logs
> > > > >
> > > >
> > >
> >
> https://ci.apache.org/builders/wicket-branch-7.x/builds/500/steps/compile/lo
> > > > > gs/stdio (I
> > > > > already tried it)
> > > > >
> > > > > On Mon, 26 Nov 2018 at 16:40, Andrea Del Bene <
> an.delbene@gmail.com>
> > > > wrote:
> > > > > > Hi all,
> > > > > >
> > > > > > following the discussion about the issues related to the building
> > of
> > > > > > 7.11.0
> > > > > > candidate, I suggest to do the following actions:
> > > > > >
> > > > > > -cancel this vote
> > > > > > -remove the flag '--allow-script-in-comments' from JavaDoc plugin
> > > > > > configuration
> > > > > > -extend the existing java8 profile activating it by default if
> our
> > > > default
> > > > > > JDK is 1.8 or higher (with expresion '[1.8,)'). I now this
> solution
> > > > won't
> > > > > > work for all 1.8 versions out there, but it should with most
> recent
> > > > > > versions of it. Honestly I can't find a better solution to make
> > > > everybody
> > > > > > happy. This solution will NOT work only if somebody is using an
> > > > outdated
> > > > > > version of JDK 1.8 as default JDK, but it should be ok in all the
> > > other
> > > > > > cases.
> > > > > > -...any suggestions?
> > > > > >
> > > > > >
> > > > > >
> > > > > > On Mon, Nov 26, 2018 at 10:09 AM Maxim Solodovnik <
> > > > solomax666@gmail.com>
> > > > > >
> > > > > > wrote:
> > > > > > > The error is something like:
> > > > > > > "Invalid parameter --allow-script-in-comments" and javadoc will
> > > fail
> > > > > > >
> > > > > > > It looks like java8 profile is activated, I was sure it
> shouldn't
> > > > since
> > > > > > > java7 was selected using toolchains ...
> > > > > > >
> > > > > > > On Mon, 26 Nov 2018 at 15:54, Andrea Del Bene <
> > > an.delbene@gmail.com>
> > > > > > >
> > > > > > > wrote:
> > > > > > > > Hi Maxim
> > > > > > > >
> > > > > > > > On Mon, Nov 26, 2018 at 4:29 AM Maxim Solodovnik <
> > > > solomax666@gmail.com
> > > > > > > >
> > > > > > > > wrote:
> > > > > > > > > Hello Andrea,
> > > > > > > > >
> > > > > > > > > according to my tests this is not working if toolchains
> > plugin
> > > is
> > > > > >
> > > > > > being
> > > > > >
> > > > > > > > > used, i.e.:
> > > > > > > > > 1) java8 is set on the machine as default
> > > > > > > > > 2) -Pbuildbot is used to activate java7 build
> > > > > > > > > Result: java8 profile will be activated
> > > > > > > >
> > > > > > > > that's quite strange. Do you remember which error did you
> get
> > > with
> > > > > >
> > > > > > this
> > > > > >
> > > > > > > > combination? I've searched through old mails but I didn't
> find
> > > it.
> > > > > > >
> > > > > > > Anyway,
> > > > > > >
> > > > > > > > flag '--allow-script-in-comments' is supported in JDK 8 only
> > > > starting
> > > > > > >
> > > > > > > from
> > > > > > >
> > > > > > > > u121:
> > > > > >
> > > >
> > >
> >
> https://www.oracle.com/technetwork/java/javase/8u121-relnotes-3315208.html
> > > > > >
> > > > > > > > > On Mon, 26 Nov 2018 at 04:22, Andrea Del Bene <
> > > > an.delbene@gmail.com>
> > > > > > > > >
> > > > > > > > > wrote:
> > > > > > > > > > I see that Maxim has already addressed this problem with
> > > > > >
> > > > > > WICKET-6615,
> > > > > >
> > > > > > > > or
> > > > > > > >
> > > > > > > > > > at least he partially did it. We should use a profile
> > which
> > > is
> > > > > > > > > > automatically activated when the JDK used to run Maven is
> > >=
> > > > 1.8 .
> > > > > > > > > >
> > > > > > > > > > Something like this:
> > > > > > > > > > <profile>
> > > > > > > > > >
> > > > > > > > > > <id>java8</id>
> > > > > > > > > > <activation>
> > > > > > > > > >
> > > > > > > > > > <jdk>[1.8,)</jdk>
> > > > > > > > > >
> > > > > > > > > > </activation>
> > > > > > > > > > <build>
> > > > > > > > > >
> > > > > > > > > > <pluginManagement>
> > > > > > > > > >
> > > > > > > > > > <plugins>
> > > > > > > > > >
> > > > > > > > > > <plugin>
> > > > > > > > > >
> > > > > > > > > > <groupId>org.apache.maven.plugins</groupId>
> > > > > > > > > > <artifactId>maven-javadoc-plugin</artifactId>
> > > > > > > > > >
> > > > > > > > > > <configuration>
> > > > > > > > > >
> > > > > > > > > >
> > <additionalparam>--allow-script-in-comments</additionalparam>
> > > > > > > > > >
> > > > > > > > > > </configuration>
> > > > > > > > > >
> > > > > > > > > > </plugin>
> > > > > > > > > >
> > > > > > > > > > </plugins>
> > > > > > > > > >
> > > > > > > > > > </pluginManagement>
> > > > > > > > > >
> > > > > > > > > > </build>
> > > > > > > > > >
> > > > > > > > > > </profile>
> > > > > > > > > >
> > > > > > > > > > A similar solution is described here:
> > > > > >
> > > >
> > >
> >
> https://stackoverflow.com/questions/15886209/maven-is-not-working-in-java-
> > > >
> > > > > 8-when-javadoc-tags-are-incomplete>
> > > > > > > > > > WDYT?
> > > > > > > > > >
> > > > > > > > > > > For me the build of
> > > > > >
> > > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/wicket/7.11.0/apache-wicket-7.11.0.
> > > > > > tar.gz>
> > > > > > > > > > > fails with:
> > > > > > > > > > >
> > > > > > > > > > > [INFO]
> > > > > > >
> > > > > > >
> > > >
> > ------------------------------------------------------------------------
> > > > > > >
> > > > > > > > > > > [INFO] BUILD FAILURE
> > > > > > > > > > > [INFO]
> > > > > > >
> > > > > > >
> > > >
> > ------------------------------------------------------------------------
> > > > > > >
> > > > > > > > > > > [INFO] Total time: 11.773 s
> > > > > > > > > > > [INFO] Finished at: 2018-11-25T20:44:37+02:00
> > > > > > > > > > > [INFO]
> > > > > > >
> > > > > > >
> > > >
> > ------------------------------------------------------------------------
> > > > > > >
> > > > > > > > > > > [ERROR] Failed to execute goal
> > > > > > > > > > >
> org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:jar
> > > > > > > > > >
> > > > > > > > > > (attach-javadocs)
> > > > > > > > > >
> > > > > > > > > > > on project wicket-util: MavenReportException: Error
> while
> > > > > > >
> > > > > > > generating
> > > > > > >
> > > > > > > > > > > Javadoc:
> > > > > > > > > > > [ERROR] Exit code: 1 - javadoc: error - invalid flag:
> > > > > > > > > > > --allow-script-in-comments
> > > > > > > > > > > [ERROR]
> > > > > > > > > > > [ERROR] Command line was:
> > > > /home/martin/devel/java-7/bin/javadoc
> > > > > > > > > >
> > > > > > > > > > -J-Xmx256m
> > > > > > > > > >
> > > > > > > > > > > -J-Xms128m @options @packages
> > > > > > > > > > > [ERROR]
> > > > > > > > > > > [ERROR] Refer to the generated Javadoc files in
> > > > > > > > > > >
> > '/tmp/w711/apache-wicket-7.11.0/wicket-util/target/apidocs'
> > > > dir.
> > > > > > > > > > >
> > > > > > > > > > > My JDK 7 doesn't like the the newly added javadoc
> > argument.
> > > > > > > > > > >
> > > > > > > > > > > java version "1.7.0_72"
> > > > > > > > > > > Java(TM) SE Runtime Environment (build 1.7.0_72-b14)
> > > > > > > > > > > Java HotSpot(TM) 64-Bit Server VM (build 24.72-b04,
> mixed
> > > > mode)
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > On Fri, Nov 23, 2018 at 3:50 PM Andrea Del Bene <
> > > > > > > >
> > > > > > > > an.delbene@gmail.com>
> > > > > > > >
> > > > > > > > > > > wrote:
> > > > > > > > > > >> This is a vote to release Apache Wicket 7.11.0
> > > > > > > > > > >>
> > > > > > > > > > >> Please download the source distributions found in our
> > > > staging
> > > > > >
> > > > > > area
> > > > > >
> > > > > > > > > > >> linked below.
> > > > > > > > > > >>
> > > > > > > > > > >> I have included the signatures for both the source
> > > archives.
> > > > > >
> > > > > > This
> > > > > >
> > > > > > > > vote
> > > > > > > >
> > > > > > > > > > >> lasts for 72 hours minimum.
> > > > > > > > > > >>
> > > > > > > > > > >> [ ] Yes, release Apache Wicket 7.11.0
> > > > > > > > > > >> [ ] No, don't release Apache Wicket 7.11.0, because
> ...
> > > > > > > > > > >>
> > > > > > > > > > >> Distributions, changelog, keys and signatures can be
> > found
> > > > at:
> > > > > > > > > > >>
> > https://dist.apache.org/repos/dist/dev/wicket/7.11.0
> > > > > > > > > > >>
> > > > > > > > > > >> Staging repository:
> > > > > > >
> > > >
> > https://repository.apache.org/content/repositories/orgapachewicket-1115
> > > > > > >
> > > > > > > > > > >> The binaries are available in the above link, as are a
> > > > staging
> > > > > > > > > > >> repository for Maven. Typically the vote is on the
> > source,
> > > > but
> > > > > > > >
> > > > > > > > should
> > > > > > > >
> > > > > > > > > > >> you find a problem with one of the binaries, please
> let
> > me
> > > > > >
> > > > > > know, I
> > > > > >
> > > > > > > > can
> > > > > > > >
> > > > > > > > > > >> re-roll them some way or the other.
> > > > > > > > > > >>
> > > > > > > > > > >> Staging git repository data:
> > > > > > > > > > >> Repository: git@github.com:bitstorm/wicket.git
> > > > > > > > > > >> Branch: build/wicket-7.11.0
> > > > > > > > > > >> Release tag: rel/wicket-7.11.0
> > > > > > >
> > > > > > >
> > > >
> > ========================================================================
> > > > > > >
> > > > > > > > > > >> The signatures for the source release artefacts:
> > > > > > > > > > >> Signature for apache-wicket-7.11.0.zip:
> > > > > > > > > > >> -----BEGIN PGP SIGNATURE-----
> > > > > > > > > > >>
> > > > > > > > > > >>
> > > > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qj
> > > > > > > > > > >> T
> > > > > > > > > > >>
> > > > VuEHeQ//VlvFvtQYKtD0e9Qcu1vmpvoVlV58ZKPrYBuTQO9oRE72VDIbr5q4kE+
> > > > > > > > > > >> /
> > > > > > > > > > >>
> > > > cwA8Wh1dHlichyGb3U1wQ3NAoYZaqukb00bv9H+GqOQCFCa//zOSohb34yQC7e8
> > > > > > > > > > >> z
> > > > > > > > > > >>
> > > > hfCCANcJtAhHihn2zeapysPCp5Pfsyq7UHUQHqaJiZKRq31EeePV6laT+7+J/IP
> > > > > > > > > > >> V
> > > > > > > > > > >>
> > > > 6eV0Ow5QAkGXrwpv/i9vTscF620HWoT4iJxPXJatnDqwKeFQwM3Zpak6KOsKHtW
> > > > > > > > > > >> F
> > > > > > > > > > >>
> > > > Wn8KZcDNhZcsI/vaWW9KtndPDl2kTvo8n/ZdPyAoPTZMcAPULcyZT75VxiPRV8K
> > > > > > > > > > >> y
> > > > > > > > > > >>
> > > > kQT/lFhnLQgbnfaGbfNwgIWybYt9tJ6JHjqt+xtSg+IBXM1aCY6bI5xqP43dS2x
> > > > > > > > > > >> E
> > > > > > > > > > >>
> > > > yuvTq4Z3UcS1jGVr4wiCwOEqVw2ZRQcioXDeDDAD0qZXbRkUi9tImkIx5k7ICxN
> > > > > > > > > > >> u
> > > > > > > > > > >>
> > > > 4uAYI3QrMK1QU/QteUJwZnJFDlvDQyx4FshkKePRHrlZJ5N73G4u2ChF1XDO0e5
> > > > > > > > > > >> c
> > > > > > > > > > >>
> > > > NESit9hqIS3Dz3eXExt/0mQDTMWIMzdopb7R9/uVIZtCMNV618cUvuutZYGrvSd
> > > > > > > > > > >> 9
> > > > > > > > > > >>
> > > > 390+Z8fWoB1VroZumbOVbwE8DlsiN7YoNwTVEm1CESTavJw5dNcZnXumY3KWtay
> > > > > > > > > > >> e
> > > > > > > > > > >> BDoN+YEQdTeVvOs2s+CAwjMXVBIxGp2KfY4eXZlis16D8SUVifA=
> > > > > > > > > > >> =WU+g
> > > > > > > > > > >> -----END PGP SIGNATURE-----
> > > > > > > > > > >>
> > > > > > > > > > >> Signature for apache-wicket-7.11.0.tar.gz:
> > > > > > > > > > >> -----BEGIN PGP SIGNATURE-----
> > > > > > > > > > >>
> > > > > > > > > > >>
> > > > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qj
> > > > > > > > > > >> T
> > > > > > > > > > >>
> > > > VuG/SA//dX5ZJ/kLVy2pl2Wcqeo9nAiHGSLPjkhIdQQ5y4clGtKpyydb1pBtwNT
> > > > > > > > > > >> p
> > > > > > > > > > >>
> > > > ENMO/wNWeFEvphRM6KcA1D+z15FMZxCicuOc9JwbWCVnfujQFJF5dK3WX+nnJgX
> > > > > > > > > > >> 1
> > > > > > > > > > >>
> > > > WyuxHvhxDnjUT3lFjGECfkoiua1yVh20QUzEcqC9S2ReqyREitjGKrh7sGWx+WC
> > > > > > > > > > >> M
> > > > > > > > > > >>
> > > > 2ls7pE6cXkuIjkNZP49f8LwyTIs4epK+4lkgPvgf5YgcBOVZNXK4BJ4nR74Fdr4
> > > > > > > > > > >> 9
> > > > > > > > > > >>
> > > > qeRILeflhEk6vIK6a7quVeICnQ7bocku0wtnuy53xbipHSkcj6GwmE9bK3z+exa
> > > > > > > > > > >> 3
> > > > > > > > > > >>
> > > > Djg11GaqdNo1U3awmK+n3nOOBlbq1B0zwTjvAeK2m9eCwbE8W6TP2/U7mFaqCH5
> > > > > > > > > > >> u
> > > > > > > > > > >>
> > > > e4hR84kTYXJ9f65URDyAZTcORRIfF1z8edEqGkVH2uI/P3U+Nwx7969PabQEWjM
> > > > > > > > > > >> 6
> > > > > > > > > > >>
> > > > NCrnvaDnTpiQuIJ/4AVLtDOPEnWiN/Zd/ooE7q1TWx7GeF0/hsfAM3nN/u7o0Io
> > > > > > > > > > >> W
> > > > > > > > > > >>
> > > > MKPxodnPa4cX2549n/grUYsHG9PN0hKIVSk4b3O1kHZL4rFqxh1SzyAIi5UEeyh
> > > > > > > > > > >> D
> > > > > > > > > > >>
> > > > sZARZfw/XC8j3rrd4eL9FjOgNvz75lhRZuuWCqIuBhrUVGrtJ1tFoQf5WL/EopJ
> > > > > > > > > > >> d
> > > > > > > > > > >> 9qI6Bh1ltlAWz39mxW/w6AW5LQmAA+SBAAsZS5Lx5lwwx6LxzI0=
> > > > > > > > > > >> =rLlH
> > > > > > > > > > >> -----END PGP SIGNATURE-----
> > > > > > >
> > > > > > >
> > > >
> > ========================================================================
> > > > > > >
> > > > > > > > > > >> CHANGELOG for 7.11.0:
> > > > > > > > > > >> ** Bug
> > > > > > > > > > >>
> > > > > > > > > > >> * [WICKET-6473] - Double slash break 404page
> > > > > > > > > > >> * [WICKET-6533] - Error while parsing xml using
> > > > AjaxButton
> > > > > > > > > > >> * [WICKET-6546] - CssContentHeaderItem comments
> CSS
> > > > code
> > > > > >
> > > > > > with
> > > > > >
> > > > > > > > > HTML
> > > > > > > > >
> > > > > > > > > > >> comments
> > > > > > > > > > >>
> > > > > > > > > > >> * [WICKET-6551] - LazyInitProxyFactory doesn't
> work
> > > > > >
> > > > > > correctly
> > > > > >
> > > > > > > > at
> > > > > > > >
> > > > > > > > > > >> Weblogic
> > > > > > > > > > >>
> > > > > > > > > > >> * [WICKET-6553] - SelectOptions doesn't
> html-encode
> > > > option
> > > > > > > >
> > > > > > > > values
> > > > > > > >
> > > > > > > > > > >> * [WICKET-6564] - PageStoreManager#clear() does
> not
> > > > > > >
> > > > > > > completely
> > > > > > >
> > > > > > > > > > clear
> > > > > > > > > >
> > > > > > > > > > >> * [WICKET-6568] - Wicket fails / does not encode
> > > > request
> > > > > > >
> > > > > > > header
> > > > > > >
> > > > > > > > > > >> values in AjaxCalls
> > > > > > > > > > >>
> > > > > > > > > > >> * [WICKET-6586] - Broken JavaScript due to fix
> > > > charsetName
> > > > > >
> > > > > > in
> > > > > >
> > > > > > > > > > >> JavaScriptPackageResource
> > > > > > > > > > >>
> > > > > > > > > > >> * [WICKET-6589] - ClientInfo fails with
> > > > > >
> > > > > > NumberFormatException
> > > > > >
> > > > > > > > for
> > > > > > > >
> > > > > > > > > > >> unusual browser versions
> > > > > > > > > > >>
> > > > > > > > > > >> * [WICKET-6604] - Ajax repaint is not correctly
> > > handled
> > > > > >
> > > > > > when
> > > > > >
> > > > > > > > > > >> component being repainted has an enclosure associated
> > with
> > > > it
> > > > > >
> > > > > > and
> > > > > >
> > > > > > > is
> > > > > > >
> > > > > > > > > > >> not a child of the enclosure
> > > > > > > > > > >>
> > > > > > > > > > >> * [WICKET-6614] - AbstractRangeValidator looks up
> > > > string
> > > > > >
> > > > > > with
> > > > > >
> > > > > > > > the
> > > > > > > >
> > > > > > > > > > >> wrong key if locale is Turkish
> > > > > > > > > > >>
> > > > > > > > > > >> ** Improvement
> > > > > > > > > > >>
> > > > > > > > > > >> * [WICKET-6527] - no possibility to override
> fixed
> > > html
> > > > > > > >
> > > > > > > > appended
> > > > > > > >
> > > > > > > > > > >> directly to response by FilterForm
> > > > > > > > > > >>
> > > > > > > > > > >> * [WICKET-6605] - Allow AjaxFallbackButton to be
> > > > stateless
> > > > > > > > > > >>
> > > > > > > > > > >> ** Task
> > > > > > > > > > >>
> > > > > > > > > > >> * [WICKET-6594] - JavaDoc of
> > redirectToInterceptPage
> > > in
> > > > > > > >
> > > > > > > > Component
> > > > > > > >
> > > > > > > > > > >> urges to use redirectTo method when in a constructor
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > WBR
> > > > > > > > > Maxim aka solomax
> > > > > > > >
> > > > > > > > --
> > > > > > > > Andrea Del Bene.
> > > > > > > > Apache Wicket committer.
> > > > > > >
> > > > > > > --
> > > > > > > WBR
> > > > > > > Maxim aka solomax
> > > > > >
> > > > > > --
> > > > > > Andrea Del Bene.
> > > > > > Apache Wicket committer.
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > > --
> > > WBR
> > > Maxim aka solomax
> > >
> >
> >
> > --
> > Andrea Del Bene.
> > Apache Wicket committer.
> >
>
>
> --
> WBR
> Maxim aka solomax
>
--
Andrea Del Bene.
Apache Wicket committer.
Re: [VOTE] Release Apache Wicket 7.11.0
Posted by Maxim Solodovnik <so...@gmail.com>.
Latest OpenJdk7 available is 7u95
I guess it is near to impossible to get update for java7 these days.
maybe we should add some instructions to documentation and leave the build
as it is now
So wicket-7 build should work for most of the devs?
On Mon, 26 Nov 2018 at 18:19, Andrea Del Bene <an...@gmail.com> wrote:
> Ok, I did further tests for this problem, but I think that is even more
> complicated than we thought. As I said in previous email (see JDK release
> note below) the new policy about JavaDoc has been introduced at a certain
> point in all the three JDK available at that time: 6, 7 and 8. So even if
> I had JDK 7 as default distribution on my machine build, with the current
> wicket-7.x branch building process will fail if my JDK is '1.7.0_131-b12'
> or newer, requiring to have the this blessed --allow-script-in-comments
> parameter set as additional parameter.
> And I guess we could have the same problem releasing Wicket 6.30.0.
>
> https://www.oracle.com/technetwork/java/javase/8u121-relnotes-3315208.html
>
> On Mon, Nov 26, 2018 at 11:40 AM Maxim Solodovnik <so...@gmail.com>
> wrote:
>
> > Actually it is implemented this way in wicket-7.x HEAD right now ...
> >
> > On Mon, 26 Nov 2018 at 17:36, Emond Papegaaij <
> emond.papegaaij@topicus.nl>
> > wrote:
> >
> > > As Wicket 7 is supposed to be built with jdk7, why not simply add the
> > > profile
> > > but not enable it by default when on jdk8? If you want build with jdk8
> > (or
> > > higher), you can enable the profile on the command line.
> > >
> > > Best regards,
> > > Emond
> > >
> > > On maandag 26 november 2018 10:43:55 CET Maxim Solodovnik wrote:
> > > > Hello Andrea,
> > > >
> > > > "extend the existing java8 profile activating it by default if our
> > > default
> > > > JDK is 1.8 or higher" will break toolchains build,
> > > > Here are the logs
> > > >
> > >
> >
> https://ci.apache.org/builders/wicket-branch-7.x/builds/500/steps/compile/lo
> > > > gs/stdio (I
> > > > already tried it)
> > > >
> > > > On Mon, 26 Nov 2018 at 16:40, Andrea Del Bene <an...@gmail.com>
> > > wrote:
> > > > > Hi all,
> > > > >
> > > > > following the discussion about the issues related to the building
> of
> > > > > 7.11.0
> > > > > candidate, I suggest to do the following actions:
> > > > >
> > > > > -cancel this vote
> > > > > -remove the flag '--allow-script-in-comments' from JavaDoc plugin
> > > > > configuration
> > > > > -extend the existing java8 profile activating it by default if our
> > > default
> > > > > JDK is 1.8 or higher (with expresion '[1.8,)'). I now this solution
> > > won't
> > > > > work for all 1.8 versions out there, but it should with most recent
> > > > > versions of it. Honestly I can't find a better solution to make
> > > everybody
> > > > > happy. This solution will NOT work only if somebody is using an
> > > outdated
> > > > > version of JDK 1.8 as default JDK, but it should be ok in all the
> > other
> > > > > cases.
> > > > > -...any suggestions?
> > > > >
> > > > >
> > > > >
> > > > > On Mon, Nov 26, 2018 at 10:09 AM Maxim Solodovnik <
> > > solomax666@gmail.com>
> > > > >
> > > > > wrote:
> > > > > > The error is something like:
> > > > > > "Invalid parameter --allow-script-in-comments" and javadoc will
> > fail
> > > > > >
> > > > > > It looks like java8 profile is activated, I was sure it shouldn't
> > > since
> > > > > > java7 was selected using toolchains ...
> > > > > >
> > > > > > On Mon, 26 Nov 2018 at 15:54, Andrea Del Bene <
> > an.delbene@gmail.com>
> > > > > >
> > > > > > wrote:
> > > > > > > Hi Maxim
> > > > > > >
> > > > > > > On Mon, Nov 26, 2018 at 4:29 AM Maxim Solodovnik <
> > > solomax666@gmail.com
> > > > > > >
> > > > > > > wrote:
> > > > > > > > Hello Andrea,
> > > > > > > >
> > > > > > > > according to my tests this is not working if toolchains
> plugin
> > is
> > > > >
> > > > > being
> > > > >
> > > > > > > > used, i.e.:
> > > > > > > > 1) java8 is set on the machine as default
> > > > > > > > 2) -Pbuildbot is used to activate java7 build
> > > > > > > > Result: java8 profile will be activated
> > > > > > >
> > > > > > > that's quite strange. Do you remember which error did you get
> > with
> > > > >
> > > > > this
> > > > >
> > > > > > > combination? I've searched through old mails but I didn't find
> > it.
> > > > > >
> > > > > > Anyway,
> > > > > >
> > > > > > > flag '--allow-script-in-comments' is supported in JDK 8 only
> > > starting
> > > > > >
> > > > > > from
> > > > > >
> > > > > > > u121:
> > > > >
> > >
> >
> https://www.oracle.com/technetwork/java/javase/8u121-relnotes-3315208.html
> > > > >
> > > > > > > > On Mon, 26 Nov 2018 at 04:22, Andrea Del Bene <
> > > an.delbene@gmail.com>
> > > > > > > >
> > > > > > > > wrote:
> > > > > > > > > I see that Maxim has already addressed this problem with
> > > > >
> > > > > WICKET-6615,
> > > > >
> > > > > > > or
> > > > > > >
> > > > > > > > > at least he partially did it. We should use a profile
> which
> > is
> > > > > > > > > automatically activated when the JDK used to run Maven is
> >=
> > > 1.8 .
> > > > > > > > >
> > > > > > > > > Something like this:
> > > > > > > > > <profile>
> > > > > > > > >
> > > > > > > > > <id>java8</id>
> > > > > > > > > <activation>
> > > > > > > > >
> > > > > > > > > <jdk>[1.8,)</jdk>
> > > > > > > > >
> > > > > > > > > </activation>
> > > > > > > > > <build>
> > > > > > > > >
> > > > > > > > > <pluginManagement>
> > > > > > > > >
> > > > > > > > > <plugins>
> > > > > > > > >
> > > > > > > > > <plugin>
> > > > > > > > >
> > > > > > > > > <groupId>org.apache.maven.plugins</groupId>
> > > > > > > > > <artifactId>maven-javadoc-plugin</artifactId>
> > > > > > > > >
> > > > > > > > > <configuration>
> > > > > > > > >
> > > > > > > > >
> <additionalparam>--allow-script-in-comments</additionalparam>
> > > > > > > > >
> > > > > > > > > </configuration>
> > > > > > > > >
> > > > > > > > > </plugin>
> > > > > > > > >
> > > > > > > > > </plugins>
> > > > > > > > >
> > > > > > > > > </pluginManagement>
> > > > > > > > >
> > > > > > > > > </build>
> > > > > > > > >
> > > > > > > > > </profile>
> > > > > > > > >
> > > > > > > > > A similar solution is described here:
> > > > >
> > >
> >
> https://stackoverflow.com/questions/15886209/maven-is-not-working-in-java-
> > >
> > > > 8-when-javadoc-tags-are-incomplete>
> > > > > > > > > WDYT?
> > > > > > > > >
> > > > > > > > > > For me the build of
> > > > >
> > > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/wicket/7.11.0/apache-wicket-7.11.0.
> > > > > tar.gz>
> > > > > > > > > > fails with:
> > > > > > > > > >
> > > > > > > > > > [INFO]
> > > > > >
> > > > > >
> > >
> ------------------------------------------------------------------------
> > > > > >
> > > > > > > > > > [INFO] BUILD FAILURE
> > > > > > > > > > [INFO]
> > > > > >
> > > > > >
> > >
> ------------------------------------------------------------------------
> > > > > >
> > > > > > > > > > [INFO] Total time: 11.773 s
> > > > > > > > > > [INFO] Finished at: 2018-11-25T20:44:37+02:00
> > > > > > > > > > [INFO]
> > > > > >
> > > > > >
> > >
> ------------------------------------------------------------------------
> > > > > >
> > > > > > > > > > [ERROR] Failed to execute goal
> > > > > > > > > > org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:jar
> > > > > > > > >
> > > > > > > > > (attach-javadocs)
> > > > > > > > >
> > > > > > > > > > on project wicket-util: MavenReportException: Error while
> > > > > >
> > > > > > generating
> > > > > >
> > > > > > > > > > Javadoc:
> > > > > > > > > > [ERROR] Exit code: 1 - javadoc: error - invalid flag:
> > > > > > > > > > --allow-script-in-comments
> > > > > > > > > > [ERROR]
> > > > > > > > > > [ERROR] Command line was:
> > > /home/martin/devel/java-7/bin/javadoc
> > > > > > > > >
> > > > > > > > > -J-Xmx256m
> > > > > > > > >
> > > > > > > > > > -J-Xms128m @options @packages
> > > > > > > > > > [ERROR]
> > > > > > > > > > [ERROR] Refer to the generated Javadoc files in
> > > > > > > > > >
> '/tmp/w711/apache-wicket-7.11.0/wicket-util/target/apidocs'
> > > dir.
> > > > > > > > > >
> > > > > > > > > > My JDK 7 doesn't like the the newly added javadoc
> argument.
> > > > > > > > > >
> > > > > > > > > > java version "1.7.0_72"
> > > > > > > > > > Java(TM) SE Runtime Environment (build 1.7.0_72-b14)
> > > > > > > > > > Java HotSpot(TM) 64-Bit Server VM (build 24.72-b04, mixed
> > > mode)
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > On Fri, Nov 23, 2018 at 3:50 PM Andrea Del Bene <
> > > > > > >
> > > > > > > an.delbene@gmail.com>
> > > > > > >
> > > > > > > > > > wrote:
> > > > > > > > > >> This is a vote to release Apache Wicket 7.11.0
> > > > > > > > > >>
> > > > > > > > > >> Please download the source distributions found in our
> > > staging
> > > > >
> > > > > area
> > > > >
> > > > > > > > > >> linked below.
> > > > > > > > > >>
> > > > > > > > > >> I have included the signatures for both the source
> > archives.
> > > > >
> > > > > This
> > > > >
> > > > > > > vote
> > > > > > >
> > > > > > > > > >> lasts for 72 hours minimum.
> > > > > > > > > >>
> > > > > > > > > >> [ ] Yes, release Apache Wicket 7.11.0
> > > > > > > > > >> [ ] No, don't release Apache Wicket 7.11.0, because ...
> > > > > > > > > >>
> > > > > > > > > >> Distributions, changelog, keys and signatures can be
> found
> > > at:
> > > > > > > > > >>
> https://dist.apache.org/repos/dist/dev/wicket/7.11.0
> > > > > > > > > >>
> > > > > > > > > >> Staging repository:
> > > > > >
> > >
> https://repository.apache.org/content/repositories/orgapachewicket-1115
> > > > > >
> > > > > > > > > >> The binaries are available in the above link, as are a
> > > staging
> > > > > > > > > >> repository for Maven. Typically the vote is on the
> source,
> > > but
> > > > > > >
> > > > > > > should
> > > > > > >
> > > > > > > > > >> you find a problem with one of the binaries, please let
> me
> > > > >
> > > > > know, I
> > > > >
> > > > > > > can
> > > > > > >
> > > > > > > > > >> re-roll them some way or the other.
> > > > > > > > > >>
> > > > > > > > > >> Staging git repository data:
> > > > > > > > > >> Repository: git@github.com:bitstorm/wicket.git
> > > > > > > > > >> Branch: build/wicket-7.11.0
> > > > > > > > > >> Release tag: rel/wicket-7.11.0
> > > > > >
> > > > > >
> > >
> ========================================================================
> > > > > >
> > > > > > > > > >> The signatures for the source release artefacts:
> > > > > > > > > >> Signature for apache-wicket-7.11.0.zip:
> > > > > > > > > >> -----BEGIN PGP SIGNATURE-----
> > > > > > > > > >>
> > > > > > > > > >>
> > > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qj
> > > > > > > > > >> T
> > > > > > > > > >>
> > > VuEHeQ//VlvFvtQYKtD0e9Qcu1vmpvoVlV58ZKPrYBuTQO9oRE72VDIbr5q4kE+
> > > > > > > > > >> /
> > > > > > > > > >>
> > > cwA8Wh1dHlichyGb3U1wQ3NAoYZaqukb00bv9H+GqOQCFCa//zOSohb34yQC7e8
> > > > > > > > > >> z
> > > > > > > > > >>
> > > hfCCANcJtAhHihn2zeapysPCp5Pfsyq7UHUQHqaJiZKRq31EeePV6laT+7+J/IP
> > > > > > > > > >> V
> > > > > > > > > >>
> > > 6eV0Ow5QAkGXrwpv/i9vTscF620HWoT4iJxPXJatnDqwKeFQwM3Zpak6KOsKHtW
> > > > > > > > > >> F
> > > > > > > > > >>
> > > Wn8KZcDNhZcsI/vaWW9KtndPDl2kTvo8n/ZdPyAoPTZMcAPULcyZT75VxiPRV8K
> > > > > > > > > >> y
> > > > > > > > > >>
> > > kQT/lFhnLQgbnfaGbfNwgIWybYt9tJ6JHjqt+xtSg+IBXM1aCY6bI5xqP43dS2x
> > > > > > > > > >> E
> > > > > > > > > >>
> > > yuvTq4Z3UcS1jGVr4wiCwOEqVw2ZRQcioXDeDDAD0qZXbRkUi9tImkIx5k7ICxN
> > > > > > > > > >> u
> > > > > > > > > >>
> > > 4uAYI3QrMK1QU/QteUJwZnJFDlvDQyx4FshkKePRHrlZJ5N73G4u2ChF1XDO0e5
> > > > > > > > > >> c
> > > > > > > > > >>
> > > NESit9hqIS3Dz3eXExt/0mQDTMWIMzdopb7R9/uVIZtCMNV618cUvuutZYGrvSd
> > > > > > > > > >> 9
> > > > > > > > > >>
> > > 390+Z8fWoB1VroZumbOVbwE8DlsiN7YoNwTVEm1CESTavJw5dNcZnXumY3KWtay
> > > > > > > > > >> e
> > > > > > > > > >> BDoN+YEQdTeVvOs2s+CAwjMXVBIxGp2KfY4eXZlis16D8SUVifA=
> > > > > > > > > >> =WU+g
> > > > > > > > > >> -----END PGP SIGNATURE-----
> > > > > > > > > >>
> > > > > > > > > >> Signature for apache-wicket-7.11.0.tar.gz:
> > > > > > > > > >> -----BEGIN PGP SIGNATURE-----
> > > > > > > > > >>
> > > > > > > > > >>
> > > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qj
> > > > > > > > > >> T
> > > > > > > > > >>
> > > VuG/SA//dX5ZJ/kLVy2pl2Wcqeo9nAiHGSLPjkhIdQQ5y4clGtKpyydb1pBtwNT
> > > > > > > > > >> p
> > > > > > > > > >>
> > > ENMO/wNWeFEvphRM6KcA1D+z15FMZxCicuOc9JwbWCVnfujQFJF5dK3WX+nnJgX
> > > > > > > > > >> 1
> > > > > > > > > >>
> > > WyuxHvhxDnjUT3lFjGECfkoiua1yVh20QUzEcqC9S2ReqyREitjGKrh7sGWx+WC
> > > > > > > > > >> M
> > > > > > > > > >>
> > > 2ls7pE6cXkuIjkNZP49f8LwyTIs4epK+4lkgPvgf5YgcBOVZNXK4BJ4nR74Fdr4
> > > > > > > > > >> 9
> > > > > > > > > >>
> > > qeRILeflhEk6vIK6a7quVeICnQ7bocku0wtnuy53xbipHSkcj6GwmE9bK3z+exa
> > > > > > > > > >> 3
> > > > > > > > > >>
> > > Djg11GaqdNo1U3awmK+n3nOOBlbq1B0zwTjvAeK2m9eCwbE8W6TP2/U7mFaqCH5
> > > > > > > > > >> u
> > > > > > > > > >>
> > > e4hR84kTYXJ9f65URDyAZTcORRIfF1z8edEqGkVH2uI/P3U+Nwx7969PabQEWjM
> > > > > > > > > >> 6
> > > > > > > > > >>
> > > NCrnvaDnTpiQuIJ/4AVLtDOPEnWiN/Zd/ooE7q1TWx7GeF0/hsfAM3nN/u7o0Io
> > > > > > > > > >> W
> > > > > > > > > >>
> > > MKPxodnPa4cX2549n/grUYsHG9PN0hKIVSk4b3O1kHZL4rFqxh1SzyAIi5UEeyh
> > > > > > > > > >> D
> > > > > > > > > >>
> > > sZARZfw/XC8j3rrd4eL9FjOgNvz75lhRZuuWCqIuBhrUVGrtJ1tFoQf5WL/EopJ
> > > > > > > > > >> d
> > > > > > > > > >> 9qI6Bh1ltlAWz39mxW/w6AW5LQmAA+SBAAsZS5Lx5lwwx6LxzI0=
> > > > > > > > > >> =rLlH
> > > > > > > > > >> -----END PGP SIGNATURE-----
> > > > > >
> > > > > >
> > >
> ========================================================================
> > > > > >
> > > > > > > > > >> CHANGELOG for 7.11.0:
> > > > > > > > > >> ** Bug
> > > > > > > > > >>
> > > > > > > > > >> * [WICKET-6473] - Double slash break 404page
> > > > > > > > > >> * [WICKET-6533] - Error while parsing xml using
> > > AjaxButton
> > > > > > > > > >> * [WICKET-6546] - CssContentHeaderItem comments CSS
> > > code
> > > > >
> > > > > with
> > > > >
> > > > > > > > HTML
> > > > > > > >
> > > > > > > > > >> comments
> > > > > > > > > >>
> > > > > > > > > >> * [WICKET-6551] - LazyInitProxyFactory doesn't work
> > > > >
> > > > > correctly
> > > > >
> > > > > > > at
> > > > > > >
> > > > > > > > > >> Weblogic
> > > > > > > > > >>
> > > > > > > > > >> * [WICKET-6553] - SelectOptions doesn't html-encode
> > > option
> > > > > > >
> > > > > > > values
> > > > > > >
> > > > > > > > > >> * [WICKET-6564] - PageStoreManager#clear() does not
> > > > > >
> > > > > > completely
> > > > > >
> > > > > > > > > clear
> > > > > > > > >
> > > > > > > > > >> * [WICKET-6568] - Wicket fails / does not encode
> > > request
> > > > > >
> > > > > > header
> > > > > >
> > > > > > > > > >> values in AjaxCalls
> > > > > > > > > >>
> > > > > > > > > >> * [WICKET-6586] - Broken JavaScript due to fix
> > > charsetName
> > > > >
> > > > > in
> > > > >
> > > > > > > > > >> JavaScriptPackageResource
> > > > > > > > > >>
> > > > > > > > > >> * [WICKET-6589] - ClientInfo fails with
> > > > >
> > > > > NumberFormatException
> > > > >
> > > > > > > for
> > > > > > >
> > > > > > > > > >> unusual browser versions
> > > > > > > > > >>
> > > > > > > > > >> * [WICKET-6604] - Ajax repaint is not correctly
> > handled
> > > > >
> > > > > when
> > > > >
> > > > > > > > > >> component being repainted has an enclosure associated
> with
> > > it
> > > > >
> > > > > and
> > > > >
> > > > > > is
> > > > > >
> > > > > > > > > >> not a child of the enclosure
> > > > > > > > > >>
> > > > > > > > > >> * [WICKET-6614] - AbstractRangeValidator looks up
> > > string
> > > > >
> > > > > with
> > > > >
> > > > > > > the
> > > > > > >
> > > > > > > > > >> wrong key if locale is Turkish
> > > > > > > > > >>
> > > > > > > > > >> ** Improvement
> > > > > > > > > >>
> > > > > > > > > >> * [WICKET-6527] - no possibility to override fixed
> > html
> > > > > > >
> > > > > > > appended
> > > > > > >
> > > > > > > > > >> directly to response by FilterForm
> > > > > > > > > >>
> > > > > > > > > >> * [WICKET-6605] - Allow AjaxFallbackButton to be
> > > stateless
> > > > > > > > > >>
> > > > > > > > > >> ** Task
> > > > > > > > > >>
> > > > > > > > > >> * [WICKET-6594] - JavaDoc of
> redirectToInterceptPage
> > in
> > > > > > >
> > > > > > > Component
> > > > > > >
> > > > > > > > > >> urges to use redirectTo method when in a constructor
> > > > > > > >
> > > > > > > > --
> > > > > > > > WBR
> > > > > > > > Maxim aka solomax
> > > > > > >
> > > > > > > --
> > > > > > > Andrea Del Bene.
> > > > > > > Apache Wicket committer.
> > > > > >
> > > > > > --
> > > > > > WBR
> > > > > > Maxim aka solomax
> > > > >
> > > > > --
> > > > > Andrea Del Bene.
> > > > > Apache Wicket committer.
> > >
> > >
> > >
> > >
> > >
> >
> > --
> > WBR
> > Maxim aka solomax
> >
>
>
> --
> Andrea Del Bene.
> Apache Wicket committer.
>
--
WBR
Maxim aka solomax
Re: [VOTE] Release Apache Wicket 7.11.0
Posted by Andrea Del Bene <an...@gmail.com>.
Ok, I did further tests for this problem, but I think that is even more
complicated than we thought. As I said in previous email (see JDK release
note below) the new policy about JavaDoc has been introduced at a certain
point in all the three JDK available at that time: 6, 7 and 8. So even if
I had JDK 7 as default distribution on my machine build, with the current
wicket-7.x branch building process will fail if my JDK is '1.7.0_131-b12'
or newer, requiring to have the this blessed --allow-script-in-comments
parameter set as additional parameter.
And I guess we could have the same problem releasing Wicket 6.30.0.
https://www.oracle.com/technetwork/java/javase/8u121-relnotes-3315208.html
On Mon, Nov 26, 2018 at 11:40 AM Maxim Solodovnik <so...@gmail.com>
wrote:
> Actually it is implemented this way in wicket-7.x HEAD right now ...
>
> On Mon, 26 Nov 2018 at 17:36, Emond Papegaaij <em...@topicus.nl>
> wrote:
>
> > As Wicket 7 is supposed to be built with jdk7, why not simply add the
> > profile
> > but not enable it by default when on jdk8? If you want build with jdk8
> (or
> > higher), you can enable the profile on the command line.
> >
> > Best regards,
> > Emond
> >
> > On maandag 26 november 2018 10:43:55 CET Maxim Solodovnik wrote:
> > > Hello Andrea,
> > >
> > > "extend the existing java8 profile activating it by default if our
> > default
> > > JDK is 1.8 or higher" will break toolchains build,
> > > Here are the logs
> > >
> >
> https://ci.apache.org/builders/wicket-branch-7.x/builds/500/steps/compile/lo
> > > gs/stdio (I
> > > already tried it)
> > >
> > > On Mon, 26 Nov 2018 at 16:40, Andrea Del Bene <an...@gmail.com>
> > wrote:
> > > > Hi all,
> > > >
> > > > following the discussion about the issues related to the building of
> > > > 7.11.0
> > > > candidate, I suggest to do the following actions:
> > > >
> > > > -cancel this vote
> > > > -remove the flag '--allow-script-in-comments' from JavaDoc plugin
> > > > configuration
> > > > -extend the existing java8 profile activating it by default if our
> > default
> > > > JDK is 1.8 or higher (with expresion '[1.8,)'). I now this solution
> > won't
> > > > work for all 1.8 versions out there, but it should with most recent
> > > > versions of it. Honestly I can't find a better solution to make
> > everybody
> > > > happy. This solution will NOT work only if somebody is using an
> > outdated
> > > > version of JDK 1.8 as default JDK, but it should be ok in all the
> other
> > > > cases.
> > > > -...any suggestions?
> > > >
> > > >
> > > >
> > > > On Mon, Nov 26, 2018 at 10:09 AM Maxim Solodovnik <
> > solomax666@gmail.com>
> > > >
> > > > wrote:
> > > > > The error is something like:
> > > > > "Invalid parameter --allow-script-in-comments" and javadoc will
> fail
> > > > >
> > > > > It looks like java8 profile is activated, I was sure it shouldn't
> > since
> > > > > java7 was selected using toolchains ...
> > > > >
> > > > > On Mon, 26 Nov 2018 at 15:54, Andrea Del Bene <
> an.delbene@gmail.com>
> > > > >
> > > > > wrote:
> > > > > > Hi Maxim
> > > > > >
> > > > > > On Mon, Nov 26, 2018 at 4:29 AM Maxim Solodovnik <
> > solomax666@gmail.com
> > > > > >
> > > > > > wrote:
> > > > > > > Hello Andrea,
> > > > > > >
> > > > > > > according to my tests this is not working if toolchains plugin
> is
> > > >
> > > > being
> > > >
> > > > > > > used, i.e.:
> > > > > > > 1) java8 is set on the machine as default
> > > > > > > 2) -Pbuildbot is used to activate java7 build
> > > > > > > Result: java8 profile will be activated
> > > > > >
> > > > > > that's quite strange. Do you remember which error did you get
> with
> > > >
> > > > this
> > > >
> > > > > > combination? I've searched through old mails but I didn't find
> it.
> > > > >
> > > > > Anyway,
> > > > >
> > > > > > flag '--allow-script-in-comments' is supported in JDK 8 only
> > starting
> > > > >
> > > > > from
> > > > >
> > > > > > u121:
> > > >
> >
> https://www.oracle.com/technetwork/java/javase/8u121-relnotes-3315208.html
> > > >
> > > > > > > On Mon, 26 Nov 2018 at 04:22, Andrea Del Bene <
> > an.delbene@gmail.com>
> > > > > > >
> > > > > > > wrote:
> > > > > > > > I see that Maxim has already addressed this problem with
> > > >
> > > > WICKET-6615,
> > > >
> > > > > > or
> > > > > >
> > > > > > > > at least he partially did it. We should use a profile which
> is
> > > > > > > > automatically activated when the JDK used to run Maven is >=
> > 1.8 .
> > > > > > > >
> > > > > > > > Something like this:
> > > > > > > > <profile>
> > > > > > > >
> > > > > > > > <id>java8</id>
> > > > > > > > <activation>
> > > > > > > >
> > > > > > > > <jdk>[1.8,)</jdk>
> > > > > > > >
> > > > > > > > </activation>
> > > > > > > > <build>
> > > > > > > >
> > > > > > > > <pluginManagement>
> > > > > > > >
> > > > > > > > <plugins>
> > > > > > > >
> > > > > > > > <plugin>
> > > > > > > >
> > > > > > > > <groupId>org.apache.maven.plugins</groupId>
> > > > > > > > <artifactId>maven-javadoc-plugin</artifactId>
> > > > > > > >
> > > > > > > > <configuration>
> > > > > > > >
> > > > > > > > <additionalparam>--allow-script-in-comments</additionalparam>
> > > > > > > >
> > > > > > > > </configuration>
> > > > > > > >
> > > > > > > > </plugin>
> > > > > > > >
> > > > > > > > </plugins>
> > > > > > > >
> > > > > > > > </pluginManagement>
> > > > > > > >
> > > > > > > > </build>
> > > > > > > >
> > > > > > > > </profile>
> > > > > > > >
> > > > > > > > A similar solution is described here:
> > > >
> >
> https://stackoverflow.com/questions/15886209/maven-is-not-working-in-java-
> >
> > > 8-when-javadoc-tags-are-incomplete>
> > > > > > > > WDYT?
> > > > > > > >
> > > > > > > > > For me the build of
> > > >
> > > >
> >
> https://dist.apache.org/repos/dist/dev/wicket/7.11.0/apache-wicket-7.11.0.
> > > > tar.gz>
> > > > > > > > > fails with:
> > > > > > > > >
> > > > > > > > > [INFO]
> > > > >
> > > > >
> > ------------------------------------------------------------------------
> > > > >
> > > > > > > > > [INFO] BUILD FAILURE
> > > > > > > > > [INFO]
> > > > >
> > > > >
> > ------------------------------------------------------------------------
> > > > >
> > > > > > > > > [INFO] Total time: 11.773 s
> > > > > > > > > [INFO] Finished at: 2018-11-25T20:44:37+02:00
> > > > > > > > > [INFO]
> > > > >
> > > > >
> > ------------------------------------------------------------------------
> > > > >
> > > > > > > > > [ERROR] Failed to execute goal
> > > > > > > > > org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:jar
> > > > > > > >
> > > > > > > > (attach-javadocs)
> > > > > > > >
> > > > > > > > > on project wicket-util: MavenReportException: Error while
> > > > >
> > > > > generating
> > > > >
> > > > > > > > > Javadoc:
> > > > > > > > > [ERROR] Exit code: 1 - javadoc: error - invalid flag:
> > > > > > > > > --allow-script-in-comments
> > > > > > > > > [ERROR]
> > > > > > > > > [ERROR] Command line was:
> > /home/martin/devel/java-7/bin/javadoc
> > > > > > > >
> > > > > > > > -J-Xmx256m
> > > > > > > >
> > > > > > > > > -J-Xms128m @options @packages
> > > > > > > > > [ERROR]
> > > > > > > > > [ERROR] Refer to the generated Javadoc files in
> > > > > > > > > '/tmp/w711/apache-wicket-7.11.0/wicket-util/target/apidocs'
> > dir.
> > > > > > > > >
> > > > > > > > > My JDK 7 doesn't like the the newly added javadoc argument.
> > > > > > > > >
> > > > > > > > > java version "1.7.0_72"
> > > > > > > > > Java(TM) SE Runtime Environment (build 1.7.0_72-b14)
> > > > > > > > > Java HotSpot(TM) 64-Bit Server VM (build 24.72-b04, mixed
> > mode)
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On Fri, Nov 23, 2018 at 3:50 PM Andrea Del Bene <
> > > > > >
> > > > > > an.delbene@gmail.com>
> > > > > >
> > > > > > > > > wrote:
> > > > > > > > >> This is a vote to release Apache Wicket 7.11.0
> > > > > > > > >>
> > > > > > > > >> Please download the source distributions found in our
> > staging
> > > >
> > > > area
> > > >
> > > > > > > > >> linked below.
> > > > > > > > >>
> > > > > > > > >> I have included the signatures for both the source
> archives.
> > > >
> > > > This
> > > >
> > > > > > vote
> > > > > >
> > > > > > > > >> lasts for 72 hours minimum.
> > > > > > > > >>
> > > > > > > > >> [ ] Yes, release Apache Wicket 7.11.0
> > > > > > > > >> [ ] No, don't release Apache Wicket 7.11.0, because ...
> > > > > > > > >>
> > > > > > > > >> Distributions, changelog, keys and signatures can be found
> > at:
> > > > > > > > >> https://dist.apache.org/repos/dist/dev/wicket/7.11.0
> > > > > > > > >>
> > > > > > > > >> Staging repository:
> > > > >
> > https://repository.apache.org/content/repositories/orgapachewicket-1115
> > > > >
> > > > > > > > >> The binaries are available in the above link, as are a
> > staging
> > > > > > > > >> repository for Maven. Typically the vote is on the source,
> > but
> > > > > >
> > > > > > should
> > > > > >
> > > > > > > > >> you find a problem with one of the binaries, please let me
> > > >
> > > > know, I
> > > >
> > > > > > can
> > > > > >
> > > > > > > > >> re-roll them some way or the other.
> > > > > > > > >>
> > > > > > > > >> Staging git repository data:
> > > > > > > > >> Repository: git@github.com:bitstorm/wicket.git
> > > > > > > > >> Branch: build/wicket-7.11.0
> > > > > > > > >> Release tag: rel/wicket-7.11.0
> > > > >
> > > > >
> > ========================================================================
> > > > >
> > > > > > > > >> The signatures for the source release artefacts:
> > > > > > > > >> Signature for apache-wicket-7.11.0.zip:
> > > > > > > > >> -----BEGIN PGP SIGNATURE-----
> > > > > > > > >>
> > > > > > > > >>
> > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qj
> > > > > > > > >> T
> > > > > > > > >>
> > VuEHeQ//VlvFvtQYKtD0e9Qcu1vmpvoVlV58ZKPrYBuTQO9oRE72VDIbr5q4kE+
> > > > > > > > >> /
> > > > > > > > >>
> > cwA8Wh1dHlichyGb3U1wQ3NAoYZaqukb00bv9H+GqOQCFCa//zOSohb34yQC7e8
> > > > > > > > >> z
> > > > > > > > >>
> > hfCCANcJtAhHihn2zeapysPCp5Pfsyq7UHUQHqaJiZKRq31EeePV6laT+7+J/IP
> > > > > > > > >> V
> > > > > > > > >>
> > 6eV0Ow5QAkGXrwpv/i9vTscF620HWoT4iJxPXJatnDqwKeFQwM3Zpak6KOsKHtW
> > > > > > > > >> F
> > > > > > > > >>
> > Wn8KZcDNhZcsI/vaWW9KtndPDl2kTvo8n/ZdPyAoPTZMcAPULcyZT75VxiPRV8K
> > > > > > > > >> y
> > > > > > > > >>
> > kQT/lFhnLQgbnfaGbfNwgIWybYt9tJ6JHjqt+xtSg+IBXM1aCY6bI5xqP43dS2x
> > > > > > > > >> E
> > > > > > > > >>
> > yuvTq4Z3UcS1jGVr4wiCwOEqVw2ZRQcioXDeDDAD0qZXbRkUi9tImkIx5k7ICxN
> > > > > > > > >> u
> > > > > > > > >>
> > 4uAYI3QrMK1QU/QteUJwZnJFDlvDQyx4FshkKePRHrlZJ5N73G4u2ChF1XDO0e5
> > > > > > > > >> c
> > > > > > > > >>
> > NESit9hqIS3Dz3eXExt/0mQDTMWIMzdopb7R9/uVIZtCMNV618cUvuutZYGrvSd
> > > > > > > > >> 9
> > > > > > > > >>
> > 390+Z8fWoB1VroZumbOVbwE8DlsiN7YoNwTVEm1CESTavJw5dNcZnXumY3KWtay
> > > > > > > > >> e
> > > > > > > > >> BDoN+YEQdTeVvOs2s+CAwjMXVBIxGp2KfY4eXZlis16D8SUVifA=
> > > > > > > > >> =WU+g
> > > > > > > > >> -----END PGP SIGNATURE-----
> > > > > > > > >>
> > > > > > > > >> Signature for apache-wicket-7.11.0.tar.gz:
> > > > > > > > >> -----BEGIN PGP SIGNATURE-----
> > > > > > > > >>
> > > > > > > > >>
> > iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qj
> > > > > > > > >> T
> > > > > > > > >>
> > VuG/SA//dX5ZJ/kLVy2pl2Wcqeo9nAiHGSLPjkhIdQQ5y4clGtKpyydb1pBtwNT
> > > > > > > > >> p
> > > > > > > > >>
> > ENMO/wNWeFEvphRM6KcA1D+z15FMZxCicuOc9JwbWCVnfujQFJF5dK3WX+nnJgX
> > > > > > > > >> 1
> > > > > > > > >>
> > WyuxHvhxDnjUT3lFjGECfkoiua1yVh20QUzEcqC9S2ReqyREitjGKrh7sGWx+WC
> > > > > > > > >> M
> > > > > > > > >>
> > 2ls7pE6cXkuIjkNZP49f8LwyTIs4epK+4lkgPvgf5YgcBOVZNXK4BJ4nR74Fdr4
> > > > > > > > >> 9
> > > > > > > > >>
> > qeRILeflhEk6vIK6a7quVeICnQ7bocku0wtnuy53xbipHSkcj6GwmE9bK3z+exa
> > > > > > > > >> 3
> > > > > > > > >>
> > Djg11GaqdNo1U3awmK+n3nOOBlbq1B0zwTjvAeK2m9eCwbE8W6TP2/U7mFaqCH5
> > > > > > > > >> u
> > > > > > > > >>
> > e4hR84kTYXJ9f65URDyAZTcORRIfF1z8edEqGkVH2uI/P3U+Nwx7969PabQEWjM
> > > > > > > > >> 6
> > > > > > > > >>
> > NCrnvaDnTpiQuIJ/4AVLtDOPEnWiN/Zd/ooE7q1TWx7GeF0/hsfAM3nN/u7o0Io
> > > > > > > > >> W
> > > > > > > > >>
> > MKPxodnPa4cX2549n/grUYsHG9PN0hKIVSk4b3O1kHZL4rFqxh1SzyAIi5UEeyh
> > > > > > > > >> D
> > > > > > > > >>
> > sZARZfw/XC8j3rrd4eL9FjOgNvz75lhRZuuWCqIuBhrUVGrtJ1tFoQf5WL/EopJ
> > > > > > > > >> d
> > > > > > > > >> 9qI6Bh1ltlAWz39mxW/w6AW5LQmAA+SBAAsZS5Lx5lwwx6LxzI0=
> > > > > > > > >> =rLlH
> > > > > > > > >> -----END PGP SIGNATURE-----
> > > > >
> > > > >
> > ========================================================================
> > > > >
> > > > > > > > >> CHANGELOG for 7.11.0:
> > > > > > > > >> ** Bug
> > > > > > > > >>
> > > > > > > > >> * [WICKET-6473] - Double slash break 404page
> > > > > > > > >> * [WICKET-6533] - Error while parsing xml using
> > AjaxButton
> > > > > > > > >> * [WICKET-6546] - CssContentHeaderItem comments CSS
> > code
> > > >
> > > > with
> > > >
> > > > > > > HTML
> > > > > > >
> > > > > > > > >> comments
> > > > > > > > >>
> > > > > > > > >> * [WICKET-6551] - LazyInitProxyFactory doesn't work
> > > >
> > > > correctly
> > > >
> > > > > > at
> > > > > >
> > > > > > > > >> Weblogic
> > > > > > > > >>
> > > > > > > > >> * [WICKET-6553] - SelectOptions doesn't html-encode
> > option
> > > > > >
> > > > > > values
> > > > > >
> > > > > > > > >> * [WICKET-6564] - PageStoreManager#clear() does not
> > > > >
> > > > > completely
> > > > >
> > > > > > > > clear
> > > > > > > >
> > > > > > > > >> * [WICKET-6568] - Wicket fails / does not encode
> > request
> > > > >
> > > > > header
> > > > >
> > > > > > > > >> values in AjaxCalls
> > > > > > > > >>
> > > > > > > > >> * [WICKET-6586] - Broken JavaScript due to fix
> > charsetName
> > > >
> > > > in
> > > >
> > > > > > > > >> JavaScriptPackageResource
> > > > > > > > >>
> > > > > > > > >> * [WICKET-6589] - ClientInfo fails with
> > > >
> > > > NumberFormatException
> > > >
> > > > > > for
> > > > > >
> > > > > > > > >> unusual browser versions
> > > > > > > > >>
> > > > > > > > >> * [WICKET-6604] - Ajax repaint is not correctly
> handled
> > > >
> > > > when
> > > >
> > > > > > > > >> component being repainted has an enclosure associated with
> > it
> > > >
> > > > and
> > > >
> > > > > is
> > > > >
> > > > > > > > >> not a child of the enclosure
> > > > > > > > >>
> > > > > > > > >> * [WICKET-6614] - AbstractRangeValidator looks up
> > string
> > > >
> > > > with
> > > >
> > > > > > the
> > > > > >
> > > > > > > > >> wrong key if locale is Turkish
> > > > > > > > >>
> > > > > > > > >> ** Improvement
> > > > > > > > >>
> > > > > > > > >> * [WICKET-6527] - no possibility to override fixed
> html
> > > > > >
> > > > > > appended
> > > > > >
> > > > > > > > >> directly to response by FilterForm
> > > > > > > > >>
> > > > > > > > >> * [WICKET-6605] - Allow AjaxFallbackButton to be
> > stateless
> > > > > > > > >>
> > > > > > > > >> ** Task
> > > > > > > > >>
> > > > > > > > >> * [WICKET-6594] - JavaDoc of redirectToInterceptPage
> in
> > > > > >
> > > > > > Component
> > > > > >
> > > > > > > > >> urges to use redirectTo method when in a constructor
> > > > > > >
> > > > > > > --
> > > > > > > WBR
> > > > > > > Maxim aka solomax
> > > > > >
> > > > > > --
> > > > > > Andrea Del Bene.
> > > > > > Apache Wicket committer.
> > > > >
> > > > > --
> > > > > WBR
> > > > > Maxim aka solomax
> > > >
> > > > --
> > > > Andrea Del Bene.
> > > > Apache Wicket committer.
> >
> >
> >
> >
> >
>
> --
> WBR
> Maxim aka solomax
>
--
Andrea Del Bene.
Apache Wicket committer.
Re: [VOTE] Release Apache Wicket 7.11.0
Posted by Maxim Solodovnik <so...@gmail.com>.
Actually it is implemented this way in wicket-7.x HEAD right now ...
On Mon, 26 Nov 2018 at 17:36, Emond Papegaaij <em...@topicus.nl>
wrote:
> As Wicket 7 is supposed to be built with jdk7, why not simply add the
> profile
> but not enable it by default when on jdk8? If you want build with jdk8 (or
> higher), you can enable the profile on the command line.
>
> Best regards,
> Emond
>
> On maandag 26 november 2018 10:43:55 CET Maxim Solodovnik wrote:
> > Hello Andrea,
> >
> > "extend the existing java8 profile activating it by default if our
> default
> > JDK is 1.8 or higher" will break toolchains build,
> > Here are the logs
> >
> https://ci.apache.org/builders/wicket-branch-7.x/builds/500/steps/compile/lo
> > gs/stdio (I
> > already tried it)
> >
> > On Mon, 26 Nov 2018 at 16:40, Andrea Del Bene <an...@gmail.com>
> wrote:
> > > Hi all,
> > >
> > > following the discussion about the issues related to the building of
> > > 7.11.0
> > > candidate, I suggest to do the following actions:
> > >
> > > -cancel this vote
> > > -remove the flag '--allow-script-in-comments' from JavaDoc plugin
> > > configuration
> > > -extend the existing java8 profile activating it by default if our
> default
> > > JDK is 1.8 or higher (with expresion '[1.8,)'). I now this solution
> won't
> > > work for all 1.8 versions out there, but it should with most recent
> > > versions of it. Honestly I can't find a better solution to make
> everybody
> > > happy. This solution will NOT work only if somebody is using an
> outdated
> > > version of JDK 1.8 as default JDK, but it should be ok in all the other
> > > cases.
> > > -...any suggestions?
> > >
> > >
> > >
> > > On Mon, Nov 26, 2018 at 10:09 AM Maxim Solodovnik <
> solomax666@gmail.com>
> > >
> > > wrote:
> > > > The error is something like:
> > > > "Invalid parameter --allow-script-in-comments" and javadoc will fail
> > > >
> > > > It looks like java8 profile is activated, I was sure it shouldn't
> since
> > > > java7 was selected using toolchains ...
> > > >
> > > > On Mon, 26 Nov 2018 at 15:54, Andrea Del Bene <an...@gmail.com>
> > > >
> > > > wrote:
> > > > > Hi Maxim
> > > > >
> > > > > On Mon, Nov 26, 2018 at 4:29 AM Maxim Solodovnik <
> solomax666@gmail.com
> > > > >
> > > > > wrote:
> > > > > > Hello Andrea,
> > > > > >
> > > > > > according to my tests this is not working if toolchains plugin is
> > >
> > > being
> > >
> > > > > > used, i.e.:
> > > > > > 1) java8 is set on the machine as default
> > > > > > 2) -Pbuildbot is used to activate java7 build
> > > > > > Result: java8 profile will be activated
> > > > >
> > > > > that's quite strange. Do you remember which error did you get with
> > >
> > > this
> > >
> > > > > combination? I've searched through old mails but I didn't find it.
> > > >
> > > > Anyway,
> > > >
> > > > > flag '--allow-script-in-comments' is supported in JDK 8 only
> starting
> > > >
> > > > from
> > > >
> > > > > u121:
> > >
> https://www.oracle.com/technetwork/java/javase/8u121-relnotes-3315208.html
> > >
> > > > > > On Mon, 26 Nov 2018 at 04:22, Andrea Del Bene <
> an.delbene@gmail.com>
> > > > > >
> > > > > > wrote:
> > > > > > > I see that Maxim has already addressed this problem with
> > >
> > > WICKET-6615,
> > >
> > > > > or
> > > > >
> > > > > > > at least he partially did it. We should use a profile which is
> > > > > > > automatically activated when the JDK used to run Maven is >=
> 1.8 .
> > > > > > >
> > > > > > > Something like this:
> > > > > > > <profile>
> > > > > > >
> > > > > > > <id>java8</id>
> > > > > > > <activation>
> > > > > > >
> > > > > > > <jdk>[1.8,)</jdk>
> > > > > > >
> > > > > > > </activation>
> > > > > > > <build>
> > > > > > >
> > > > > > > <pluginManagement>
> > > > > > >
> > > > > > > <plugins>
> > > > > > >
> > > > > > > <plugin>
> > > > > > >
> > > > > > > <groupId>org.apache.maven.plugins</groupId>
> > > > > > > <artifactId>maven-javadoc-plugin</artifactId>
> > > > > > >
> > > > > > > <configuration>
> > > > > > >
> > > > > > > <additionalparam>--allow-script-in-comments</additionalparam>
> > > > > > >
> > > > > > > </configuration>
> > > > > > >
> > > > > > > </plugin>
> > > > > > >
> > > > > > > </plugins>
> > > > > > >
> > > > > > > </pluginManagement>
> > > > > > >
> > > > > > > </build>
> > > > > > >
> > > > > > > </profile>
> > > > > > >
> > > > > > > A similar solution is described here:
> > >
> https://stackoverflow.com/questions/15886209/maven-is-not-working-in-java->
> > 8-when-javadoc-tags-are-incomplete>
> > > > > > > WDYT?
> > > > > > >
> > > > > > > > For me the build of
> > >
> > >
> https://dist.apache.org/repos/dist/dev/wicket/7.11.0/apache-wicket-7.11.0.
> > > tar.gz>
> > > > > > > > fails with:
> > > > > > > >
> > > > > > > > [INFO]
> > > >
> > > >
> ------------------------------------------------------------------------
> > > >
> > > > > > > > [INFO] BUILD FAILURE
> > > > > > > > [INFO]
> > > >
> > > >
> ------------------------------------------------------------------------
> > > >
> > > > > > > > [INFO] Total time: 11.773 s
> > > > > > > > [INFO] Finished at: 2018-11-25T20:44:37+02:00
> > > > > > > > [INFO]
> > > >
> > > >
> ------------------------------------------------------------------------
> > > >
> > > > > > > > [ERROR] Failed to execute goal
> > > > > > > > org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:jar
> > > > > > >
> > > > > > > (attach-javadocs)
> > > > > > >
> > > > > > > > on project wicket-util: MavenReportException: Error while
> > > >
> > > > generating
> > > >
> > > > > > > > Javadoc:
> > > > > > > > [ERROR] Exit code: 1 - javadoc: error - invalid flag:
> > > > > > > > --allow-script-in-comments
> > > > > > > > [ERROR]
> > > > > > > > [ERROR] Command line was:
> /home/martin/devel/java-7/bin/javadoc
> > > > > > >
> > > > > > > -J-Xmx256m
> > > > > > >
> > > > > > > > -J-Xms128m @options @packages
> > > > > > > > [ERROR]
> > > > > > > > [ERROR] Refer to the generated Javadoc files in
> > > > > > > > '/tmp/w711/apache-wicket-7.11.0/wicket-util/target/apidocs'
> dir.
> > > > > > > >
> > > > > > > > My JDK 7 doesn't like the the newly added javadoc argument.
> > > > > > > >
> > > > > > > > java version "1.7.0_72"
> > > > > > > > Java(TM) SE Runtime Environment (build 1.7.0_72-b14)
> > > > > > > > Java HotSpot(TM) 64-Bit Server VM (build 24.72-b04, mixed
> mode)
> > > > > > > >
> > > > > > > >
> > > > > > > > On Fri, Nov 23, 2018 at 3:50 PM Andrea Del Bene <
> > > > >
> > > > > an.delbene@gmail.com>
> > > > >
> > > > > > > > wrote:
> > > > > > > >> This is a vote to release Apache Wicket 7.11.0
> > > > > > > >>
> > > > > > > >> Please download the source distributions found in our
> staging
> > >
> > > area
> > >
> > > > > > > >> linked below.
> > > > > > > >>
> > > > > > > >> I have included the signatures for both the source archives.
> > >
> > > This
> > >
> > > > > vote
> > > > >
> > > > > > > >> lasts for 72 hours minimum.
> > > > > > > >>
> > > > > > > >> [ ] Yes, release Apache Wicket 7.11.0
> > > > > > > >> [ ] No, don't release Apache Wicket 7.11.0, because ...
> > > > > > > >>
> > > > > > > >> Distributions, changelog, keys and signatures can be found
> at:
> > > > > > > >> https://dist.apache.org/repos/dist/dev/wicket/7.11.0
> > > > > > > >>
> > > > > > > >> Staging repository:
> > > >
> https://repository.apache.org/content/repositories/orgapachewicket-1115
> > > >
> > > > > > > >> The binaries are available in the above link, as are a
> staging
> > > > > > > >> repository for Maven. Typically the vote is on the source,
> but
> > > > >
> > > > > should
> > > > >
> > > > > > > >> you find a problem with one of the binaries, please let me
> > >
> > > know, I
> > >
> > > > > can
> > > > >
> > > > > > > >> re-roll them some way or the other.
> > > > > > > >>
> > > > > > > >> Staging git repository data:
> > > > > > > >> Repository: git@github.com:bitstorm/wicket.git
> > > > > > > >> Branch: build/wicket-7.11.0
> > > > > > > >> Release tag: rel/wicket-7.11.0
> > > >
> > > >
> ========================================================================
> > > >
> > > > > > > >> The signatures for the source release artefacts:
> > > > > > > >> Signature for apache-wicket-7.11.0.zip:
> > > > > > > >> -----BEGIN PGP SIGNATURE-----
> > > > > > > >>
> > > > > > > >>
> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qj
> > > > > > > >> T
> > > > > > > >>
> VuEHeQ//VlvFvtQYKtD0e9Qcu1vmpvoVlV58ZKPrYBuTQO9oRE72VDIbr5q4kE+
> > > > > > > >> /
> > > > > > > >>
> cwA8Wh1dHlichyGb3U1wQ3NAoYZaqukb00bv9H+GqOQCFCa//zOSohb34yQC7e8
> > > > > > > >> z
> > > > > > > >>
> hfCCANcJtAhHihn2zeapysPCp5Pfsyq7UHUQHqaJiZKRq31EeePV6laT+7+J/IP
> > > > > > > >> V
> > > > > > > >>
> 6eV0Ow5QAkGXrwpv/i9vTscF620HWoT4iJxPXJatnDqwKeFQwM3Zpak6KOsKHtW
> > > > > > > >> F
> > > > > > > >>
> Wn8KZcDNhZcsI/vaWW9KtndPDl2kTvo8n/ZdPyAoPTZMcAPULcyZT75VxiPRV8K
> > > > > > > >> y
> > > > > > > >>
> kQT/lFhnLQgbnfaGbfNwgIWybYt9tJ6JHjqt+xtSg+IBXM1aCY6bI5xqP43dS2x
> > > > > > > >> E
> > > > > > > >>
> yuvTq4Z3UcS1jGVr4wiCwOEqVw2ZRQcioXDeDDAD0qZXbRkUi9tImkIx5k7ICxN
> > > > > > > >> u
> > > > > > > >>
> 4uAYI3QrMK1QU/QteUJwZnJFDlvDQyx4FshkKePRHrlZJ5N73G4u2ChF1XDO0e5
> > > > > > > >> c
> > > > > > > >>
> NESit9hqIS3Dz3eXExt/0mQDTMWIMzdopb7R9/uVIZtCMNV618cUvuutZYGrvSd
> > > > > > > >> 9
> > > > > > > >>
> 390+Z8fWoB1VroZumbOVbwE8DlsiN7YoNwTVEm1CESTavJw5dNcZnXumY3KWtay
> > > > > > > >> e
> > > > > > > >> BDoN+YEQdTeVvOs2s+CAwjMXVBIxGp2KfY4eXZlis16D8SUVifA=
> > > > > > > >> =WU+g
> > > > > > > >> -----END PGP SIGNATURE-----
> > > > > > > >>
> > > > > > > >> Signature for apache-wicket-7.11.0.tar.gz:
> > > > > > > >> -----BEGIN PGP SIGNATURE-----
> > > > > > > >>
> > > > > > > >>
> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qj
> > > > > > > >> T
> > > > > > > >>
> VuG/SA//dX5ZJ/kLVy2pl2Wcqeo9nAiHGSLPjkhIdQQ5y4clGtKpyydb1pBtwNT
> > > > > > > >> p
> > > > > > > >>
> ENMO/wNWeFEvphRM6KcA1D+z15FMZxCicuOc9JwbWCVnfujQFJF5dK3WX+nnJgX
> > > > > > > >> 1
> > > > > > > >>
> WyuxHvhxDnjUT3lFjGECfkoiua1yVh20QUzEcqC9S2ReqyREitjGKrh7sGWx+WC
> > > > > > > >> M
> > > > > > > >>
> 2ls7pE6cXkuIjkNZP49f8LwyTIs4epK+4lkgPvgf5YgcBOVZNXK4BJ4nR74Fdr4
> > > > > > > >> 9
> > > > > > > >>
> qeRILeflhEk6vIK6a7quVeICnQ7bocku0wtnuy53xbipHSkcj6GwmE9bK3z+exa
> > > > > > > >> 3
> > > > > > > >>
> Djg11GaqdNo1U3awmK+n3nOOBlbq1B0zwTjvAeK2m9eCwbE8W6TP2/U7mFaqCH5
> > > > > > > >> u
> > > > > > > >>
> e4hR84kTYXJ9f65URDyAZTcORRIfF1z8edEqGkVH2uI/P3U+Nwx7969PabQEWjM
> > > > > > > >> 6
> > > > > > > >>
> NCrnvaDnTpiQuIJ/4AVLtDOPEnWiN/Zd/ooE7q1TWx7GeF0/hsfAM3nN/u7o0Io
> > > > > > > >> W
> > > > > > > >>
> MKPxodnPa4cX2549n/grUYsHG9PN0hKIVSk4b3O1kHZL4rFqxh1SzyAIi5UEeyh
> > > > > > > >> D
> > > > > > > >>
> sZARZfw/XC8j3rrd4eL9FjOgNvz75lhRZuuWCqIuBhrUVGrtJ1tFoQf5WL/EopJ
> > > > > > > >> d
> > > > > > > >> 9qI6Bh1ltlAWz39mxW/w6AW5LQmAA+SBAAsZS5Lx5lwwx6LxzI0=
> > > > > > > >> =rLlH
> > > > > > > >> -----END PGP SIGNATURE-----
> > > >
> > > >
> ========================================================================
> > > >
> > > > > > > >> CHANGELOG for 7.11.0:
> > > > > > > >> ** Bug
> > > > > > > >>
> > > > > > > >> * [WICKET-6473] - Double slash break 404page
> > > > > > > >> * [WICKET-6533] - Error while parsing xml using
> AjaxButton
> > > > > > > >> * [WICKET-6546] - CssContentHeaderItem comments CSS
> code
> > >
> > > with
> > >
> > > > > > HTML
> > > > > >
> > > > > > > >> comments
> > > > > > > >>
> > > > > > > >> * [WICKET-6551] - LazyInitProxyFactory doesn't work
> > >
> > > correctly
> > >
> > > > > at
> > > > >
> > > > > > > >> Weblogic
> > > > > > > >>
> > > > > > > >> * [WICKET-6553] - SelectOptions doesn't html-encode
> option
> > > > >
> > > > > values
> > > > >
> > > > > > > >> * [WICKET-6564] - PageStoreManager#clear() does not
> > > >
> > > > completely
> > > >
> > > > > > > clear
> > > > > > >
> > > > > > > >> * [WICKET-6568] - Wicket fails / does not encode
> request
> > > >
> > > > header
> > > >
> > > > > > > >> values in AjaxCalls
> > > > > > > >>
> > > > > > > >> * [WICKET-6586] - Broken JavaScript due to fix
> charsetName
> > >
> > > in
> > >
> > > > > > > >> JavaScriptPackageResource
> > > > > > > >>
> > > > > > > >> * [WICKET-6589] - ClientInfo fails with
> > >
> > > NumberFormatException
> > >
> > > > > for
> > > > >
> > > > > > > >> unusual browser versions
> > > > > > > >>
> > > > > > > >> * [WICKET-6604] - Ajax repaint is not correctly handled
> > >
> > > when
> > >
> > > > > > > >> component being repainted has an enclosure associated with
> it
> > >
> > > and
> > >
> > > > is
> > > >
> > > > > > > >> not a child of the enclosure
> > > > > > > >>
> > > > > > > >> * [WICKET-6614] - AbstractRangeValidator looks up
> string
> > >
> > > with
> > >
> > > > > the
> > > > >
> > > > > > > >> wrong key if locale is Turkish
> > > > > > > >>
> > > > > > > >> ** Improvement
> > > > > > > >>
> > > > > > > >> * [WICKET-6527] - no possibility to override fixed html
> > > > >
> > > > > appended
> > > > >
> > > > > > > >> directly to response by FilterForm
> > > > > > > >>
> > > > > > > >> * [WICKET-6605] - Allow AjaxFallbackButton to be
> stateless
> > > > > > > >>
> > > > > > > >> ** Task
> > > > > > > >>
> > > > > > > >> * [WICKET-6594] - JavaDoc of redirectToInterceptPage in
> > > > >
> > > > > Component
> > > > >
> > > > > > > >> urges to use redirectTo method when in a constructor
> > > > > >
> > > > > > --
> > > > > > WBR
> > > > > > Maxim aka solomax
> > > > >
> > > > > --
> > > > > Andrea Del Bene.
> > > > > Apache Wicket committer.
> > > >
> > > > --
> > > > WBR
> > > > Maxim aka solomax
> > >
> > > --
> > > Andrea Del Bene.
> > > Apache Wicket committer.
>
>
>
>
>
--
WBR
Maxim aka solomax
Re: [VOTE] Release Apache Wicket 7.11.0
Posted by Emond Papegaaij <em...@topicus.nl>.
As Wicket 7 is supposed to be built with jdk7, why not simply add the profile
but not enable it by default when on jdk8? If you want build with jdk8 (or
higher), you can enable the profile on the command line.
Best regards,
Emond
On maandag 26 november 2018 10:43:55 CET Maxim Solodovnik wrote:
> Hello Andrea,
>
> "extend the existing java8 profile activating it by default if our default
> JDK is 1.8 or higher" will break toolchains build,
> Here are the logs
> https://ci.apache.org/builders/wicket-branch-7.x/builds/500/steps/compile/lo
> gs/stdio (I
> already tried it)
>
> On Mon, 26 Nov 2018 at 16:40, Andrea Del Bene <an...@gmail.com> wrote:
> > Hi all,
> >
> > following the discussion about the issues related to the building of
> > 7.11.0
> > candidate, I suggest to do the following actions:
> >
> > -cancel this vote
> > -remove the flag '--allow-script-in-comments' from JavaDoc plugin
> > configuration
> > -extend the existing java8 profile activating it by default if our default
> > JDK is 1.8 or higher (with expresion '[1.8,)'). I now this solution won't
> > work for all 1.8 versions out there, but it should with most recent
> > versions of it. Honestly I can't find a better solution to make everybody
> > happy. This solution will NOT work only if somebody is using an outdated
> > version of JDK 1.8 as default JDK, but it should be ok in all the other
> > cases.
> > -...any suggestions?
> >
> >
> >
> > On Mon, Nov 26, 2018 at 10:09 AM Maxim Solodovnik <so...@gmail.com>
> >
> > wrote:
> > > The error is something like:
> > > "Invalid parameter --allow-script-in-comments" and javadoc will fail
> > >
> > > It looks like java8 profile is activated, I was sure it shouldn't since
> > > java7 was selected using toolchains ...
> > >
> > > On Mon, 26 Nov 2018 at 15:54, Andrea Del Bene <an...@gmail.com>
> > >
> > > wrote:
> > > > Hi Maxim
> > > >
> > > > On Mon, Nov 26, 2018 at 4:29 AM Maxim Solodovnik <solomax666@gmail.com
> > > >
> > > > wrote:
> > > > > Hello Andrea,
> > > > >
> > > > > according to my tests this is not working if toolchains plugin is
> >
> > being
> >
> > > > > used, i.e.:
> > > > > 1) java8 is set on the machine as default
> > > > > 2) -Pbuildbot is used to activate java7 build
> > > > > Result: java8 profile will be activated
> > > >
> > > > that's quite strange. Do you remember which error did you get with
> >
> > this
> >
> > > > combination? I've searched through old mails but I didn't find it.
> > >
> > > Anyway,
> > >
> > > > flag '--allow-script-in-comments' is supported in JDK 8 only starting
> > >
> > > from
> > >
> > > > u121:
> > https://www.oracle.com/technetwork/java/javase/8u121-relnotes-3315208.html
> >
> > > > > On Mon, 26 Nov 2018 at 04:22, Andrea Del Bene <an...@gmail.com>
> > > > >
> > > > > wrote:
> > > > > > I see that Maxim has already addressed this problem with
> >
> > WICKET-6615,
> >
> > > > or
> > > >
> > > > > > at least he partially did it. We should use a profile which is
> > > > > > automatically activated when the JDK used to run Maven is >= 1.8 .
> > > > > >
> > > > > > Something like this:
> > > > > > <profile>
> > > > > >
> > > > > > <id>java8</id>
> > > > > > <activation>
> > > > > >
> > > > > > <jdk>[1.8,)</jdk>
> > > > > >
> > > > > > </activation>
> > > > > > <build>
> > > > > >
> > > > > > <pluginManagement>
> > > > > >
> > > > > > <plugins>
> > > > > >
> > > > > > <plugin>
> > > > > >
> > > > > > <groupId>org.apache.maven.plugins</groupId>
> > > > > > <artifactId>maven-javadoc-plugin</artifactId>
> > > > > >
> > > > > > <configuration>
> > > > > >
> > > > > > <additionalparam>--allow-script-in-comments</additionalparam>
> > > > > >
> > > > > > </configuration>
> > > > > >
> > > > > > </plugin>
> > > > > >
> > > > > > </plugins>
> > > > > >
> > > > > > </pluginManagement>
> > > > > >
> > > > > > </build>
> > > > > >
> > > > > > </profile>
> > > > > >
> > > > > > A similar solution is described here:
> > https://stackoverflow.com/questions/15886209/maven-is-not-working-in-java-> > 8-when-javadoc-tags-are-incomplete>
> > > > > > WDYT?
> > > > > >
> > > > > > > For me the build of
> >
> > https://dist.apache.org/repos/dist/dev/wicket/7.11.0/apache-wicket-7.11.0.
> > tar.gz>
> > > > > > > fails with:
> > > > > > >
> > > > > > > [INFO]
> > >
> > > ------------------------------------------------------------------------
> > >
> > > > > > > [INFO] BUILD FAILURE
> > > > > > > [INFO]
> > >
> > > ------------------------------------------------------------------------
> > >
> > > > > > > [INFO] Total time: 11.773 s
> > > > > > > [INFO] Finished at: 2018-11-25T20:44:37+02:00
> > > > > > > [INFO]
> > >
> > > ------------------------------------------------------------------------
> > >
> > > > > > > [ERROR] Failed to execute goal
> > > > > > > org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:jar
> > > > > >
> > > > > > (attach-javadocs)
> > > > > >
> > > > > > > on project wicket-util: MavenReportException: Error while
> > >
> > > generating
> > >
> > > > > > > Javadoc:
> > > > > > > [ERROR] Exit code: 1 - javadoc: error - invalid flag:
> > > > > > > --allow-script-in-comments
> > > > > > > [ERROR]
> > > > > > > [ERROR] Command line was: /home/martin/devel/java-7/bin/javadoc
> > > > > >
> > > > > > -J-Xmx256m
> > > > > >
> > > > > > > -J-Xms128m @options @packages
> > > > > > > [ERROR]
> > > > > > > [ERROR] Refer to the generated Javadoc files in
> > > > > > > '/tmp/w711/apache-wicket-7.11.0/wicket-util/target/apidocs' dir.
> > > > > > >
> > > > > > > My JDK 7 doesn't like the the newly added javadoc argument.
> > > > > > >
> > > > > > > java version "1.7.0_72"
> > > > > > > Java(TM) SE Runtime Environment (build 1.7.0_72-b14)
> > > > > > > Java HotSpot(TM) 64-Bit Server VM (build 24.72-b04, mixed mode)
> > > > > > >
> > > > > > >
> > > > > > > On Fri, Nov 23, 2018 at 3:50 PM Andrea Del Bene <
> > > >
> > > > an.delbene@gmail.com>
> > > >
> > > > > > > wrote:
> > > > > > >> This is a vote to release Apache Wicket 7.11.0
> > > > > > >>
> > > > > > >> Please download the source distributions found in our staging
> >
> > area
> >
> > > > > > >> linked below.
> > > > > > >>
> > > > > > >> I have included the signatures for both the source archives.
> >
> > This
> >
> > > > vote
> > > >
> > > > > > >> lasts for 72 hours minimum.
> > > > > > >>
> > > > > > >> [ ] Yes, release Apache Wicket 7.11.0
> > > > > > >> [ ] No, don't release Apache Wicket 7.11.0, because ...
> > > > > > >>
> > > > > > >> Distributions, changelog, keys and signatures can be found at:
> > > > > > >> https://dist.apache.org/repos/dist/dev/wicket/7.11.0
> > > > > > >>
> > > > > > >> Staging repository:
> > > https://repository.apache.org/content/repositories/orgapachewicket-1115
> > >
> > > > > > >> The binaries are available in the above link, as are a staging
> > > > > > >> repository for Maven. Typically the vote is on the source, but
> > > >
> > > > should
> > > >
> > > > > > >> you find a problem with one of the binaries, please let me
> >
> > know, I
> >
> > > > can
> > > >
> > > > > > >> re-roll them some way or the other.
> > > > > > >>
> > > > > > >> Staging git repository data:
> > > > > > >> Repository: git@github.com:bitstorm/wicket.git
> > > > > > >> Branch: build/wicket-7.11.0
> > > > > > >> Release tag: rel/wicket-7.11.0
> > >
> > > ========================================================================
> > >
> > > > > > >> The signatures for the source release artefacts:
> > > > > > >> Signature for apache-wicket-7.11.0.zip:
> > > > > > >> -----BEGIN PGP SIGNATURE-----
> > > > > > >>
> > > > > > >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qj
> > > > > > >> T
> > > > > > >> VuEHeQ//VlvFvtQYKtD0e9Qcu1vmpvoVlV58ZKPrYBuTQO9oRE72VDIbr5q4kE+
> > > > > > >> /
> > > > > > >> cwA8Wh1dHlichyGb3U1wQ3NAoYZaqukb00bv9H+GqOQCFCa//zOSohb34yQC7e8
> > > > > > >> z
> > > > > > >> hfCCANcJtAhHihn2zeapysPCp5Pfsyq7UHUQHqaJiZKRq31EeePV6laT+7+J/IP
> > > > > > >> V
> > > > > > >> 6eV0Ow5QAkGXrwpv/i9vTscF620HWoT4iJxPXJatnDqwKeFQwM3Zpak6KOsKHtW
> > > > > > >> F
> > > > > > >> Wn8KZcDNhZcsI/vaWW9KtndPDl2kTvo8n/ZdPyAoPTZMcAPULcyZT75VxiPRV8K
> > > > > > >> y
> > > > > > >> kQT/lFhnLQgbnfaGbfNwgIWybYt9tJ6JHjqt+xtSg+IBXM1aCY6bI5xqP43dS2x
> > > > > > >> E
> > > > > > >> yuvTq4Z3UcS1jGVr4wiCwOEqVw2ZRQcioXDeDDAD0qZXbRkUi9tImkIx5k7ICxN
> > > > > > >> u
> > > > > > >> 4uAYI3QrMK1QU/QteUJwZnJFDlvDQyx4FshkKePRHrlZJ5N73G4u2ChF1XDO0e5
> > > > > > >> c
> > > > > > >> NESit9hqIS3Dz3eXExt/0mQDTMWIMzdopb7R9/uVIZtCMNV618cUvuutZYGrvSd
> > > > > > >> 9
> > > > > > >> 390+Z8fWoB1VroZumbOVbwE8DlsiN7YoNwTVEm1CESTavJw5dNcZnXumY3KWtay
> > > > > > >> e
> > > > > > >> BDoN+YEQdTeVvOs2s+CAwjMXVBIxGp2KfY4eXZlis16D8SUVifA=
> > > > > > >> =WU+g
> > > > > > >> -----END PGP SIGNATURE-----
> > > > > > >>
> > > > > > >> Signature for apache-wicket-7.11.0.tar.gz:
> > > > > > >> -----BEGIN PGP SIGNATURE-----
> > > > > > >>
> > > > > > >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qj
> > > > > > >> T
> > > > > > >> VuG/SA//dX5ZJ/kLVy2pl2Wcqeo9nAiHGSLPjkhIdQQ5y4clGtKpyydb1pBtwNT
> > > > > > >> p
> > > > > > >> ENMO/wNWeFEvphRM6KcA1D+z15FMZxCicuOc9JwbWCVnfujQFJF5dK3WX+nnJgX
> > > > > > >> 1
> > > > > > >> WyuxHvhxDnjUT3lFjGECfkoiua1yVh20QUzEcqC9S2ReqyREitjGKrh7sGWx+WC
> > > > > > >> M
> > > > > > >> 2ls7pE6cXkuIjkNZP49f8LwyTIs4epK+4lkgPvgf5YgcBOVZNXK4BJ4nR74Fdr4
> > > > > > >> 9
> > > > > > >> qeRILeflhEk6vIK6a7quVeICnQ7bocku0wtnuy53xbipHSkcj6GwmE9bK3z+exa
> > > > > > >> 3
> > > > > > >> Djg11GaqdNo1U3awmK+n3nOOBlbq1B0zwTjvAeK2m9eCwbE8W6TP2/U7mFaqCH5
> > > > > > >> u
> > > > > > >> e4hR84kTYXJ9f65URDyAZTcORRIfF1z8edEqGkVH2uI/P3U+Nwx7969PabQEWjM
> > > > > > >> 6
> > > > > > >> NCrnvaDnTpiQuIJ/4AVLtDOPEnWiN/Zd/ooE7q1TWx7GeF0/hsfAM3nN/u7o0Io
> > > > > > >> W
> > > > > > >> MKPxodnPa4cX2549n/grUYsHG9PN0hKIVSk4b3O1kHZL4rFqxh1SzyAIi5UEeyh
> > > > > > >> D
> > > > > > >> sZARZfw/XC8j3rrd4eL9FjOgNvz75lhRZuuWCqIuBhrUVGrtJ1tFoQf5WL/EopJ
> > > > > > >> d
> > > > > > >> 9qI6Bh1ltlAWz39mxW/w6AW5LQmAA+SBAAsZS5Lx5lwwx6LxzI0=
> > > > > > >> =rLlH
> > > > > > >> -----END PGP SIGNATURE-----
> > >
> > > ========================================================================
> > >
> > > > > > >> CHANGELOG for 7.11.0:
> > > > > > >> ** Bug
> > > > > > >>
> > > > > > >> * [WICKET-6473] - Double slash break 404page
> > > > > > >> * [WICKET-6533] - Error while parsing xml using AjaxButton
> > > > > > >> * [WICKET-6546] - CssContentHeaderItem comments CSS code
> >
> > with
> >
> > > > > HTML
> > > > >
> > > > > > >> comments
> > > > > > >>
> > > > > > >> * [WICKET-6551] - LazyInitProxyFactory doesn't work
> >
> > correctly
> >
> > > > at
> > > >
> > > > > > >> Weblogic
> > > > > > >>
> > > > > > >> * [WICKET-6553] - SelectOptions doesn't html-encode option
> > > >
> > > > values
> > > >
> > > > > > >> * [WICKET-6564] - PageStoreManager#clear() does not
> > >
> > > completely
> > >
> > > > > > clear
> > > > > >
> > > > > > >> * [WICKET-6568] - Wicket fails / does not encode request
> > >
> > > header
> > >
> > > > > > >> values in AjaxCalls
> > > > > > >>
> > > > > > >> * [WICKET-6586] - Broken JavaScript due to fix charsetName
> >
> > in
> >
> > > > > > >> JavaScriptPackageResource
> > > > > > >>
> > > > > > >> * [WICKET-6589] - ClientInfo fails with
> >
> > NumberFormatException
> >
> > > > for
> > > >
> > > > > > >> unusual browser versions
> > > > > > >>
> > > > > > >> * [WICKET-6604] - Ajax repaint is not correctly handled
> >
> > when
> >
> > > > > > >> component being repainted has an enclosure associated with it
> >
> > and
> >
> > > is
> > >
> > > > > > >> not a child of the enclosure
> > > > > > >>
> > > > > > >> * [WICKET-6614] - AbstractRangeValidator looks up string
> >
> > with
> >
> > > > the
> > > >
> > > > > > >> wrong key if locale is Turkish
> > > > > > >>
> > > > > > >> ** Improvement
> > > > > > >>
> > > > > > >> * [WICKET-6527] - no possibility to override fixed html
> > > >
> > > > appended
> > > >
> > > > > > >> directly to response by FilterForm
> > > > > > >>
> > > > > > >> * [WICKET-6605] - Allow AjaxFallbackButton to be stateless
> > > > > > >>
> > > > > > >> ** Task
> > > > > > >>
> > > > > > >> * [WICKET-6594] - JavaDoc of redirectToInterceptPage in
> > > >
> > > > Component
> > > >
> > > > > > >> urges to use redirectTo method when in a constructor
> > > > >
> > > > > --
> > > > > WBR
> > > > > Maxim aka solomax
> > > >
> > > > --
> > > > Andrea Del Bene.
> > > > Apache Wicket committer.
> > >
> > > --
> > > WBR
> > > Maxim aka solomax
> >
> > --
> > Andrea Del Bene.
> > Apache Wicket committer.
Re: [VOTE] Release Apache Wicket 7.11.0
Posted by Maxim Solodovnik <so...@gmail.com>.
Hello Andrea,
"extend the existing java8 profile activating it by default if our default
JDK is 1.8 or higher" will break toolchains build,
Here are the logs
https://ci.apache.org/builders/wicket-branch-7.x/builds/500/steps/compile/logs/stdio
(I
already tried it)
On Mon, 26 Nov 2018 at 16:40, Andrea Del Bene <an...@gmail.com> wrote:
> Hi all,
>
> following the discussion about the issues related to the building of 7.11.0
> candidate, I suggest to do the following actions:
>
> -cancel this vote
> -remove the flag '--allow-script-in-comments' from JavaDoc plugin
> configuration
> -extend the existing java8 profile activating it by default if our default
> JDK is 1.8 or higher (with expresion '[1.8,)'). I now this solution won't
> work for all 1.8 versions out there, but it should with most recent
> versions of it. Honestly I can't find a better solution to make everybody
> happy. This solution will NOT work only if somebody is using an outdated
> version of JDK 1.8 as default JDK, but it should be ok in all the other
> cases.
> -...any suggestions?
>
>
>
> On Mon, Nov 26, 2018 at 10:09 AM Maxim Solodovnik <so...@gmail.com>
> wrote:
>
> > The error is something like:
> > "Invalid parameter --allow-script-in-comments" and javadoc will fail
> >
> > It looks like java8 profile is activated, I was sure it shouldn't since
> > java7 was selected using toolchains ...
> >
> > On Mon, 26 Nov 2018 at 15:54, Andrea Del Bene <an...@gmail.com>
> > wrote:
> >
> > > Hi Maxim
> > >
> > > On Mon, Nov 26, 2018 at 4:29 AM Maxim Solodovnik <solomax666@gmail.com
> >
> > > wrote:
> > >
> > > > Hello Andrea,
> > > >
> > > > according to my tests this is not working if toolchains plugin is
> being
> > > > used, i.e.:
> > > > 1) java8 is set on the machine as default
> > > > 2) -Pbuildbot is used to activate java7 build
> > > > Result: java8 profile will be activated
> > > >
> > > >
> > > >
> > > that's quite strange. Do you remember which error did you get with
> this
> > > combination? I've searched through old mails but I didn't find it.
> > Anyway,
> > > flag '--allow-script-in-comments' is supported in JDK 8 only starting
> > from
> > > u121:
> > >
> > >
> >
> https://www.oracle.com/technetwork/java/javase/8u121-relnotes-3315208.html
> > >
> > >
> > > > On Mon, 26 Nov 2018 at 04:22, Andrea Del Bene <an...@gmail.com>
> > > > wrote:
> > > >
> > > > > I see that Maxim has already addressed this problem with
> WICKET-6615,
> > > or
> > > > > at least he partially did it. We should use a profile which is
> > > > > automatically activated when the JDK used to run Maven is >= 1.8 .
> > > > > Something like this:
> > > > >
> > > > > <profile>
> > > > > <id>java8</id>
> > > > > <activation>
> > > > > <jdk>[1.8,)</jdk>
> > > > > </activation>
> > > > > <build>
> > > > > <pluginManagement>
> > > > > <plugins>
> > > > > <plugin>
> > > > > <groupId>org.apache.maven.plugins</groupId>
> > > > > <artifactId>maven-javadoc-plugin</artifactId>
> > > > > <configuration>
> > > > > <additionalparam>--allow-script-in-comments</additionalparam>
> > > > > </configuration>
> > > > > </plugin>
> > > > > </plugins>
> > > > > </pluginManagement>
> > > > > </build>
> > > > > </profile>
> > > > >
> > > > > A similar solution is described here:
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
> https://stackoverflow.com/questions/15886209/maven-is-not-working-in-java-8-when-javadoc-tags-are-incomplete
> > > > >
> > > > > WDYT?
> > > > >
> > > > >
> > > > > > For me the build of
> > > > > >
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/wicket/7.11.0/apache-wicket-7.11.0.tar.gz
> > > > > > fails with:
> > > > > >
> > > > > > [INFO]
> > > > > >
> > > >
> > ------------------------------------------------------------------------
> > > > > > [INFO] BUILD FAILURE
> > > > > > [INFO]
> > > > > >
> > > >
> > ------------------------------------------------------------------------
> > > > > > [INFO] Total time: 11.773 s
> > > > > > [INFO] Finished at: 2018-11-25T20:44:37+02:00
> > > > > > [INFO]
> > > > > >
> > > >
> > ------------------------------------------------------------------------
> > > > > > [ERROR] Failed to execute goal
> > > > > > org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:jar
> > > > > (attach-javadocs)
> > > > > > on project wicket-util: MavenReportException: Error while
> > generating
> > > > > > Javadoc:
> > > > > > [ERROR] Exit code: 1 - javadoc: error - invalid flag:
> > > > > > --allow-script-in-comments
> > > > > > [ERROR]
> > > > > > [ERROR] Command line was: /home/martin/devel/java-7/bin/javadoc
> > > > > -J-Xmx256m
> > > > > > -J-Xms128m @options @packages
> > > > > > [ERROR]
> > > > > > [ERROR] Refer to the generated Javadoc files in
> > > > > > '/tmp/w711/apache-wicket-7.11.0/wicket-util/target/apidocs' dir.
> > > > > >
> > > > > > My JDK 7 doesn't like the the newly added javadoc argument.
> > > > > >
> > > > > > java version "1.7.0_72"
> > > > > > Java(TM) SE Runtime Environment (build 1.7.0_72-b14)
> > > > > > Java HotSpot(TM) 64-Bit Server VM (build 24.72-b04, mixed mode)
> > > > > >
> > > > > >
> > > > > > On Fri, Nov 23, 2018 at 3:50 PM Andrea Del Bene <
> > > an.delbene@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > >> This is a vote to release Apache Wicket 7.11.0
> > > > > >>
> > > > > >> Please download the source distributions found in our staging
> area
> > > > > >> linked below.
> > > > > >>
> > > > > >> I have included the signatures for both the source archives.
> This
> > > vote
> > > > > >> lasts for 72 hours minimum.
> > > > > >>
> > > > > >> [ ] Yes, release Apache Wicket 7.11.0
> > > > > >> [ ] No, don't release Apache Wicket 7.11.0, because ...
> > > > > >>
> > > > > >> Distributions, changelog, keys and signatures can be found at:
> > > > > >>
> > > > > >> https://dist.apache.org/repos/dist/dev/wicket/7.11.0
> > > > > >>
> > > > > >> Staging repository:
> > > > > >>
> > > > > >>
> > > > > >>
> > > >
> > https://repository.apache.org/content/repositories/orgapachewicket-1115
> > > > > >>
> > > > > >> The binaries are available in the above link, as are a staging
> > > > > >> repository for Maven. Typically the vote is on the source, but
> > > should
> > > > > >> you find a problem with one of the binaries, please let me
> know, I
> > > can
> > > > > >> re-roll them some way or the other.
> > > > > >>
> > > > > >> Staging git repository data:
> > > > > >>
> > > > > >> Repository: git@github.com:bitstorm/wicket.git
> > > > > >> Branch: build/wicket-7.11.0
> > > > > >> Release tag: rel/wicket-7.11.0
> > > > > >>
> > > > > >>
> > > > > >>
> > > >
> > ========================================================================
> > > > > >>
> > > > > >> The signatures for the source release artefacts:
> > > > > >>
> > > > > >>
> > > > > >> Signature for apache-wicket-7.11.0.zip:
> > > > > >>
> > > > > >> -----BEGIN PGP SIGNATURE-----
> > > > > >>
> > > > > >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
> > > > > >> VuEHeQ//VlvFvtQYKtD0e9Qcu1vmpvoVlV58ZKPrYBuTQO9oRE72VDIbr5q4kE+/
> > > > > >> cwA8Wh1dHlichyGb3U1wQ3NAoYZaqukb00bv9H+GqOQCFCa//zOSohb34yQC7e8z
> > > > > >> hfCCANcJtAhHihn2zeapysPCp5Pfsyq7UHUQHqaJiZKRq31EeePV6laT+7+J/IPV
> > > > > >> 6eV0Ow5QAkGXrwpv/i9vTscF620HWoT4iJxPXJatnDqwKeFQwM3Zpak6KOsKHtWF
> > > > > >> Wn8KZcDNhZcsI/vaWW9KtndPDl2kTvo8n/ZdPyAoPTZMcAPULcyZT75VxiPRV8Ky
> > > > > >> kQT/lFhnLQgbnfaGbfNwgIWybYt9tJ6JHjqt+xtSg+IBXM1aCY6bI5xqP43dS2xE
> > > > > >> yuvTq4Z3UcS1jGVr4wiCwOEqVw2ZRQcioXDeDDAD0qZXbRkUi9tImkIx5k7ICxNu
> > > > > >> 4uAYI3QrMK1QU/QteUJwZnJFDlvDQyx4FshkKePRHrlZJ5N73G4u2ChF1XDO0e5c
> > > > > >> NESit9hqIS3Dz3eXExt/0mQDTMWIMzdopb7R9/uVIZtCMNV618cUvuutZYGrvSd9
> > > > > >> 390+Z8fWoB1VroZumbOVbwE8DlsiN7YoNwTVEm1CESTavJw5dNcZnXumY3KWtaye
> > > > > >> BDoN+YEQdTeVvOs2s+CAwjMXVBIxGp2KfY4eXZlis16D8SUVifA=
> > > > > >> =WU+g
> > > > > >> -----END PGP SIGNATURE-----
> > > > > >>
> > > > > >> Signature for apache-wicket-7.11.0.tar.gz:
> > > > > >>
> > > > > >> -----BEGIN PGP SIGNATURE-----
> > > > > >>
> > > > > >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
> > > > > >> VuG/SA//dX5ZJ/kLVy2pl2Wcqeo9nAiHGSLPjkhIdQQ5y4clGtKpyydb1pBtwNTp
> > > > > >> ENMO/wNWeFEvphRM6KcA1D+z15FMZxCicuOc9JwbWCVnfujQFJF5dK3WX+nnJgX1
> > > > > >> WyuxHvhxDnjUT3lFjGECfkoiua1yVh20QUzEcqC9S2ReqyREitjGKrh7sGWx+WCM
> > > > > >> 2ls7pE6cXkuIjkNZP49f8LwyTIs4epK+4lkgPvgf5YgcBOVZNXK4BJ4nR74Fdr49
> > > > > >> qeRILeflhEk6vIK6a7quVeICnQ7bocku0wtnuy53xbipHSkcj6GwmE9bK3z+exa3
> > > > > >> Djg11GaqdNo1U3awmK+n3nOOBlbq1B0zwTjvAeK2m9eCwbE8W6TP2/U7mFaqCH5u
> > > > > >> e4hR84kTYXJ9f65URDyAZTcORRIfF1z8edEqGkVH2uI/P3U+Nwx7969PabQEWjM6
> > > > > >> NCrnvaDnTpiQuIJ/4AVLtDOPEnWiN/Zd/ooE7q1TWx7GeF0/hsfAM3nN/u7o0IoW
> > > > > >> MKPxodnPa4cX2549n/grUYsHG9PN0hKIVSk4b3O1kHZL4rFqxh1SzyAIi5UEeyhD
> > > > > >> sZARZfw/XC8j3rrd4eL9FjOgNvz75lhRZuuWCqIuBhrUVGrtJ1tFoQf5WL/EopJd
> > > > > >> 9qI6Bh1ltlAWz39mxW/w6AW5LQmAA+SBAAsZS5Lx5lwwx6LxzI0=
> > > > > >> =rLlH
> > > > > >> -----END PGP SIGNATURE-----
> > > > > >>
> > > > > >>
> > > >
> > ========================================================================
> > > > > >>
> > > > > >> CHANGELOG for 7.11.0:
> > > > > >>
> > > > > >> ** Bug
> > > > > >>
> > > > > >> * [WICKET-6473] - Double slash break 404page
> > > > > >> * [WICKET-6533] - Error while parsing xml using AjaxButton
> > > > > >> * [WICKET-6546] - CssContentHeaderItem comments CSS code
> with
> > > > HTML
> > > > > >> comments
> > > > > >> * [WICKET-6551] - LazyInitProxyFactory doesn't work
> correctly
> > > at
> > > > > >> Weblogic
> > > > > >> * [WICKET-6553] - SelectOptions doesn't html-encode option
> > > values
> > > > > >> * [WICKET-6564] - PageStoreManager#clear() does not
> > completely
> > > > > clear
> > > > > >> * [WICKET-6568] - Wicket fails / does not encode request
> > header
> > > > > >> values in AjaxCalls
> > > > > >> * [WICKET-6586] - Broken JavaScript due to fix charsetName
> in
> > > > > >> JavaScriptPackageResource
> > > > > >> * [WICKET-6589] - ClientInfo fails with
> NumberFormatException
> > > for
> > > > > >> unusual browser versions
> > > > > >> * [WICKET-6604] - Ajax repaint is not correctly handled
> when
> > > > > >> component being repainted has an enclosure associated with it
> and
> > is
> > > > > >> not a child of the enclosure
> > > > > >> * [WICKET-6614] - AbstractRangeValidator looks up string
> with
> > > the
> > > > > >> wrong key if locale is Turkish
> > > > > >>
> > > > > >> ** Improvement
> > > > > >>
> > > > > >> * [WICKET-6527] - no possibility to override fixed html
> > > appended
> > > > > >> directly to response by FilterForm
> > > > > >> * [WICKET-6605] - Allow AjaxFallbackButton to be stateless
> > > > > >>
> > > > > >> ** Task
> > > > > >>
> > > > > >> * [WICKET-6594] - JavaDoc of redirectToInterceptPage in
> > > Component
> > > > > >> urges to use redirectTo method when in a constructor
> > > > > >>
> > > > >
> > > >
> > > >
> > > > --
> > > > WBR
> > > > Maxim aka solomax
> > > >
> > >
> > >
> > > --
> > > Andrea Del Bene.
> > > Apache Wicket committer.
> > >
> >
> >
> > --
> > WBR
> > Maxim aka solomax
> >
>
>
> --
> Andrea Del Bene.
> Apache Wicket committer.
>
--
WBR
Maxim aka solomax
Re: [VOTE] Release Apache Wicket 7.11.0
Posted by Andrea Del Bene <an...@gmail.com>.
Hi all,
following the discussion about the issues related to the building of 7.11.0
candidate, I suggest to do the following actions:
-cancel this vote
-remove the flag '--allow-script-in-comments' from JavaDoc plugin
configuration
-extend the existing java8 profile activating it by default if our default
JDK is 1.8 or higher (with expresion '[1.8,)'). I now this solution won't
work for all 1.8 versions out there, but it should with most recent
versions of it. Honestly I can't find a better solution to make everybody
happy. This solution will NOT work only if somebody is using an outdated
version of JDK 1.8 as default JDK, but it should be ok in all the other
cases.
-...any suggestions?
On Mon, Nov 26, 2018 at 10:09 AM Maxim Solodovnik <so...@gmail.com>
wrote:
> The error is something like:
> "Invalid parameter --allow-script-in-comments" and javadoc will fail
>
> It looks like java8 profile is activated, I was sure it shouldn't since
> java7 was selected using toolchains ...
>
> On Mon, 26 Nov 2018 at 15:54, Andrea Del Bene <an...@gmail.com>
> wrote:
>
> > Hi Maxim
> >
> > On Mon, Nov 26, 2018 at 4:29 AM Maxim Solodovnik <so...@gmail.com>
> > wrote:
> >
> > > Hello Andrea,
> > >
> > > according to my tests this is not working if toolchains plugin is being
> > > used, i.e.:
> > > 1) java8 is set on the machine as default
> > > 2) -Pbuildbot is used to activate java7 build
> > > Result: java8 profile will be activated
> > >
> > >
> > >
> > that's quite strange. Do you remember which error did you get with this
> > combination? I've searched through old mails but I didn't find it.
> Anyway,
> > flag '--allow-script-in-comments' is supported in JDK 8 only starting
> from
> > u121:
> >
> >
> https://www.oracle.com/technetwork/java/javase/8u121-relnotes-3315208.html
> >
> >
> > > On Mon, 26 Nov 2018 at 04:22, Andrea Del Bene <an...@gmail.com>
> > > wrote:
> > >
> > > > I see that Maxim has already addressed this problem with WICKET-6615,
> > or
> > > > at least he partially did it. We should use a profile which is
> > > > automatically activated when the JDK used to run Maven is >= 1.8 .
> > > > Something like this:
> > > >
> > > > <profile>
> > > > <id>java8</id>
> > > > <activation>
> > > > <jdk>[1.8,)</jdk>
> > > > </activation>
> > > > <build>
> > > > <pluginManagement>
> > > > <plugins>
> > > > <plugin>
> > > > <groupId>org.apache.maven.plugins</groupId>
> > > > <artifactId>maven-javadoc-plugin</artifactId>
> > > > <configuration>
> > > > <additionalparam>--allow-script-in-comments</additionalparam>
> > > > </configuration>
> > > > </plugin>
> > > > </plugins>
> > > > </pluginManagement>
> > > > </build>
> > > > </profile>
> > > >
> > > > A similar solution is described here:
> > > >
> > > >
> > > >
> > >
> >
> https://stackoverflow.com/questions/15886209/maven-is-not-working-in-java-8-when-javadoc-tags-are-incomplete
> > > >
> > > > WDYT?
> > > >
> > > >
> > > > > For me the build of
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/wicket/7.11.0/apache-wicket-7.11.0.tar.gz
> > > > > fails with:
> > > > >
> > > > > [INFO]
> > > > >
> > >
> ------------------------------------------------------------------------
> > > > > [INFO] BUILD FAILURE
> > > > > [INFO]
> > > > >
> > >
> ------------------------------------------------------------------------
> > > > > [INFO] Total time: 11.773 s
> > > > > [INFO] Finished at: 2018-11-25T20:44:37+02:00
> > > > > [INFO]
> > > > >
> > >
> ------------------------------------------------------------------------
> > > > > [ERROR] Failed to execute goal
> > > > > org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:jar
> > > > (attach-javadocs)
> > > > > on project wicket-util: MavenReportException: Error while
> generating
> > > > > Javadoc:
> > > > > [ERROR] Exit code: 1 - javadoc: error - invalid flag:
> > > > > --allow-script-in-comments
> > > > > [ERROR]
> > > > > [ERROR] Command line was: /home/martin/devel/java-7/bin/javadoc
> > > > -J-Xmx256m
> > > > > -J-Xms128m @options @packages
> > > > > [ERROR]
> > > > > [ERROR] Refer to the generated Javadoc files in
> > > > > '/tmp/w711/apache-wicket-7.11.0/wicket-util/target/apidocs' dir.
> > > > >
> > > > > My JDK 7 doesn't like the the newly added javadoc argument.
> > > > >
> > > > > java version "1.7.0_72"
> > > > > Java(TM) SE Runtime Environment (build 1.7.0_72-b14)
> > > > > Java HotSpot(TM) 64-Bit Server VM (build 24.72-b04, mixed mode)
> > > > >
> > > > >
> > > > > On Fri, Nov 23, 2018 at 3:50 PM Andrea Del Bene <
> > an.delbene@gmail.com>
> > > > > wrote:
> > > > >
> > > > >> This is a vote to release Apache Wicket 7.11.0
> > > > >>
> > > > >> Please download the source distributions found in our staging area
> > > > >> linked below.
> > > > >>
> > > > >> I have included the signatures for both the source archives. This
> > vote
> > > > >> lasts for 72 hours minimum.
> > > > >>
> > > > >> [ ] Yes, release Apache Wicket 7.11.0
> > > > >> [ ] No, don't release Apache Wicket 7.11.0, because ...
> > > > >>
> > > > >> Distributions, changelog, keys and signatures can be found at:
> > > > >>
> > > > >> https://dist.apache.org/repos/dist/dev/wicket/7.11.0
> > > > >>
> > > > >> Staging repository:
> > > > >>
> > > > >>
> > > > >>
> > >
> https://repository.apache.org/content/repositories/orgapachewicket-1115
> > > > >>
> > > > >> The binaries are available in the above link, as are a staging
> > > > >> repository for Maven. Typically the vote is on the source, but
> > should
> > > > >> you find a problem with one of the binaries, please let me know, I
> > can
> > > > >> re-roll them some way or the other.
> > > > >>
> > > > >> Staging git repository data:
> > > > >>
> > > > >> Repository: git@github.com:bitstorm/wicket.git
> > > > >> Branch: build/wicket-7.11.0
> > > > >> Release tag: rel/wicket-7.11.0
> > > > >>
> > > > >>
> > > > >>
> > >
> ========================================================================
> > > > >>
> > > > >> The signatures for the source release artefacts:
> > > > >>
> > > > >>
> > > > >> Signature for apache-wicket-7.11.0.zip:
> > > > >>
> > > > >> -----BEGIN PGP SIGNATURE-----
> > > > >>
> > > > >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
> > > > >> VuEHeQ//VlvFvtQYKtD0e9Qcu1vmpvoVlV58ZKPrYBuTQO9oRE72VDIbr5q4kE+/
> > > > >> cwA8Wh1dHlichyGb3U1wQ3NAoYZaqukb00bv9H+GqOQCFCa//zOSohb34yQC7e8z
> > > > >> hfCCANcJtAhHihn2zeapysPCp5Pfsyq7UHUQHqaJiZKRq31EeePV6laT+7+J/IPV
> > > > >> 6eV0Ow5QAkGXrwpv/i9vTscF620HWoT4iJxPXJatnDqwKeFQwM3Zpak6KOsKHtWF
> > > > >> Wn8KZcDNhZcsI/vaWW9KtndPDl2kTvo8n/ZdPyAoPTZMcAPULcyZT75VxiPRV8Ky
> > > > >> kQT/lFhnLQgbnfaGbfNwgIWybYt9tJ6JHjqt+xtSg+IBXM1aCY6bI5xqP43dS2xE
> > > > >> yuvTq4Z3UcS1jGVr4wiCwOEqVw2ZRQcioXDeDDAD0qZXbRkUi9tImkIx5k7ICxNu
> > > > >> 4uAYI3QrMK1QU/QteUJwZnJFDlvDQyx4FshkKePRHrlZJ5N73G4u2ChF1XDO0e5c
> > > > >> NESit9hqIS3Dz3eXExt/0mQDTMWIMzdopb7R9/uVIZtCMNV618cUvuutZYGrvSd9
> > > > >> 390+Z8fWoB1VroZumbOVbwE8DlsiN7YoNwTVEm1CESTavJw5dNcZnXumY3KWtaye
> > > > >> BDoN+YEQdTeVvOs2s+CAwjMXVBIxGp2KfY4eXZlis16D8SUVifA=
> > > > >> =WU+g
> > > > >> -----END PGP SIGNATURE-----
> > > > >>
> > > > >> Signature for apache-wicket-7.11.0.tar.gz:
> > > > >>
> > > > >> -----BEGIN PGP SIGNATURE-----
> > > > >>
> > > > >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
> > > > >> VuG/SA//dX5ZJ/kLVy2pl2Wcqeo9nAiHGSLPjkhIdQQ5y4clGtKpyydb1pBtwNTp
> > > > >> ENMO/wNWeFEvphRM6KcA1D+z15FMZxCicuOc9JwbWCVnfujQFJF5dK3WX+nnJgX1
> > > > >> WyuxHvhxDnjUT3lFjGECfkoiua1yVh20QUzEcqC9S2ReqyREitjGKrh7sGWx+WCM
> > > > >> 2ls7pE6cXkuIjkNZP49f8LwyTIs4epK+4lkgPvgf5YgcBOVZNXK4BJ4nR74Fdr49
> > > > >> qeRILeflhEk6vIK6a7quVeICnQ7bocku0wtnuy53xbipHSkcj6GwmE9bK3z+exa3
> > > > >> Djg11GaqdNo1U3awmK+n3nOOBlbq1B0zwTjvAeK2m9eCwbE8W6TP2/U7mFaqCH5u
> > > > >> e4hR84kTYXJ9f65URDyAZTcORRIfF1z8edEqGkVH2uI/P3U+Nwx7969PabQEWjM6
> > > > >> NCrnvaDnTpiQuIJ/4AVLtDOPEnWiN/Zd/ooE7q1TWx7GeF0/hsfAM3nN/u7o0IoW
> > > > >> MKPxodnPa4cX2549n/grUYsHG9PN0hKIVSk4b3O1kHZL4rFqxh1SzyAIi5UEeyhD
> > > > >> sZARZfw/XC8j3rrd4eL9FjOgNvz75lhRZuuWCqIuBhrUVGrtJ1tFoQf5WL/EopJd
> > > > >> 9qI6Bh1ltlAWz39mxW/w6AW5LQmAA+SBAAsZS5Lx5lwwx6LxzI0=
> > > > >> =rLlH
> > > > >> -----END PGP SIGNATURE-----
> > > > >>
> > > > >>
> > >
> ========================================================================
> > > > >>
> > > > >> CHANGELOG for 7.11.0:
> > > > >>
> > > > >> ** Bug
> > > > >>
> > > > >> * [WICKET-6473] - Double slash break 404page
> > > > >> * [WICKET-6533] - Error while parsing xml using AjaxButton
> > > > >> * [WICKET-6546] - CssContentHeaderItem comments CSS code with
> > > HTML
> > > > >> comments
> > > > >> * [WICKET-6551] - LazyInitProxyFactory doesn't work correctly
> > at
> > > > >> Weblogic
> > > > >> * [WICKET-6553] - SelectOptions doesn't html-encode option
> > values
> > > > >> * [WICKET-6564] - PageStoreManager#clear() does not
> completely
> > > > clear
> > > > >> * [WICKET-6568] - Wicket fails / does not encode request
> header
> > > > >> values in AjaxCalls
> > > > >> * [WICKET-6586] - Broken JavaScript due to fix charsetName in
> > > > >> JavaScriptPackageResource
> > > > >> * [WICKET-6589] - ClientInfo fails with NumberFormatException
> > for
> > > > >> unusual browser versions
> > > > >> * [WICKET-6604] - Ajax repaint is not correctly handled when
> > > > >> component being repainted has an enclosure associated with it and
> is
> > > > >> not a child of the enclosure
> > > > >> * [WICKET-6614] - AbstractRangeValidator looks up string with
> > the
> > > > >> wrong key if locale is Turkish
> > > > >>
> > > > >> ** Improvement
> > > > >>
> > > > >> * [WICKET-6527] - no possibility to override fixed html
> > appended
> > > > >> directly to response by FilterForm
> > > > >> * [WICKET-6605] - Allow AjaxFallbackButton to be stateless
> > > > >>
> > > > >> ** Task
> > > > >>
> > > > >> * [WICKET-6594] - JavaDoc of redirectToInterceptPage in
> > Component
> > > > >> urges to use redirectTo method when in a constructor
> > > > >>
> > > >
> > >
> > >
> > > --
> > > WBR
> > > Maxim aka solomax
> > >
> >
> >
> > --
> > Andrea Del Bene.
> > Apache Wicket committer.
> >
>
>
> --
> WBR
> Maxim aka solomax
>
--
Andrea Del Bene.
Apache Wicket committer.
Re: [VOTE] Release Apache Wicket 7.11.0
Posted by Maxim Solodovnik <so...@gmail.com>.
The error is something like:
"Invalid parameter --allow-script-in-comments" and javadoc will fail
It looks like java8 profile is activated, I was sure it shouldn't since
java7 was selected using toolchains ...
On Mon, 26 Nov 2018 at 15:54, Andrea Del Bene <an...@gmail.com> wrote:
> Hi Maxim
>
> On Mon, Nov 26, 2018 at 4:29 AM Maxim Solodovnik <so...@gmail.com>
> wrote:
>
> > Hello Andrea,
> >
> > according to my tests this is not working if toolchains plugin is being
> > used, i.e.:
> > 1) java8 is set on the machine as default
> > 2) -Pbuildbot is used to activate java7 build
> > Result: java8 profile will be activated
> >
> >
> >
> that's quite strange. Do you remember which error did you get with this
> combination? I've searched through old mails but I didn't find it. Anyway,
> flag '--allow-script-in-comments' is supported in JDK 8 only starting from
> u121:
>
> https://www.oracle.com/technetwork/java/javase/8u121-relnotes-3315208.html
>
>
> > On Mon, 26 Nov 2018 at 04:22, Andrea Del Bene <an...@gmail.com>
> > wrote:
> >
> > > I see that Maxim has already addressed this problem with WICKET-6615,
> or
> > > at least he partially did it. We should use a profile which is
> > > automatically activated when the JDK used to run Maven is >= 1.8 .
> > > Something like this:
> > >
> > > <profile>
> > > <id>java8</id>
> > > <activation>
> > > <jdk>[1.8,)</jdk>
> > > </activation>
> > > <build>
> > > <pluginManagement>
> > > <plugins>
> > > <plugin>
> > > <groupId>org.apache.maven.plugins</groupId>
> > > <artifactId>maven-javadoc-plugin</artifactId>
> > > <configuration>
> > > <additionalparam>--allow-script-in-comments</additionalparam>
> > > </configuration>
> > > </plugin>
> > > </plugins>
> > > </pluginManagement>
> > > </build>
> > > </profile>
> > >
> > > A similar solution is described here:
> > >
> > >
> > >
> >
> https://stackoverflow.com/questions/15886209/maven-is-not-working-in-java-8-when-javadoc-tags-are-incomplete
> > >
> > > WDYT?
> > >
> > >
> > > > For me the build of
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/wicket/7.11.0/apache-wicket-7.11.0.tar.gz
> > > > fails with:
> > > >
> > > > [INFO]
> > > >
> > ------------------------------------------------------------------------
> > > > [INFO] BUILD FAILURE
> > > > [INFO]
> > > >
> > ------------------------------------------------------------------------
> > > > [INFO] Total time: 11.773 s
> > > > [INFO] Finished at: 2018-11-25T20:44:37+02:00
> > > > [INFO]
> > > >
> > ------------------------------------------------------------------------
> > > > [ERROR] Failed to execute goal
> > > > org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:jar
> > > (attach-javadocs)
> > > > on project wicket-util: MavenReportException: Error while generating
> > > > Javadoc:
> > > > [ERROR] Exit code: 1 - javadoc: error - invalid flag:
> > > > --allow-script-in-comments
> > > > [ERROR]
> > > > [ERROR] Command line was: /home/martin/devel/java-7/bin/javadoc
> > > -J-Xmx256m
> > > > -J-Xms128m @options @packages
> > > > [ERROR]
> > > > [ERROR] Refer to the generated Javadoc files in
> > > > '/tmp/w711/apache-wicket-7.11.0/wicket-util/target/apidocs' dir.
> > > >
> > > > My JDK 7 doesn't like the the newly added javadoc argument.
> > > >
> > > > java version "1.7.0_72"
> > > > Java(TM) SE Runtime Environment (build 1.7.0_72-b14)
> > > > Java HotSpot(TM) 64-Bit Server VM (build 24.72-b04, mixed mode)
> > > >
> > > >
> > > > On Fri, Nov 23, 2018 at 3:50 PM Andrea Del Bene <
> an.delbene@gmail.com>
> > > > wrote:
> > > >
> > > >> This is a vote to release Apache Wicket 7.11.0
> > > >>
> > > >> Please download the source distributions found in our staging area
> > > >> linked below.
> > > >>
> > > >> I have included the signatures for both the source archives. This
> vote
> > > >> lasts for 72 hours minimum.
> > > >>
> > > >> [ ] Yes, release Apache Wicket 7.11.0
> > > >> [ ] No, don't release Apache Wicket 7.11.0, because ...
> > > >>
> > > >> Distributions, changelog, keys and signatures can be found at:
> > > >>
> > > >> https://dist.apache.org/repos/dist/dev/wicket/7.11.0
> > > >>
> > > >> Staging repository:
> > > >>
> > > >>
> > > >>
> > https://repository.apache.org/content/repositories/orgapachewicket-1115
> > > >>
> > > >> The binaries are available in the above link, as are a staging
> > > >> repository for Maven. Typically the vote is on the source, but
> should
> > > >> you find a problem with one of the binaries, please let me know, I
> can
> > > >> re-roll them some way or the other.
> > > >>
> > > >> Staging git repository data:
> > > >>
> > > >> Repository: git@github.com:bitstorm/wicket.git
> > > >> Branch: build/wicket-7.11.0
> > > >> Release tag: rel/wicket-7.11.0
> > > >>
> > > >>
> > > >>
> > ========================================================================
> > > >>
> > > >> The signatures for the source release artefacts:
> > > >>
> > > >>
> > > >> Signature for apache-wicket-7.11.0.zip:
> > > >>
> > > >> -----BEGIN PGP SIGNATURE-----
> > > >>
> > > >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
> > > >> VuEHeQ//VlvFvtQYKtD0e9Qcu1vmpvoVlV58ZKPrYBuTQO9oRE72VDIbr5q4kE+/
> > > >> cwA8Wh1dHlichyGb3U1wQ3NAoYZaqukb00bv9H+GqOQCFCa//zOSohb34yQC7e8z
> > > >> hfCCANcJtAhHihn2zeapysPCp5Pfsyq7UHUQHqaJiZKRq31EeePV6laT+7+J/IPV
> > > >> 6eV0Ow5QAkGXrwpv/i9vTscF620HWoT4iJxPXJatnDqwKeFQwM3Zpak6KOsKHtWF
> > > >> Wn8KZcDNhZcsI/vaWW9KtndPDl2kTvo8n/ZdPyAoPTZMcAPULcyZT75VxiPRV8Ky
> > > >> kQT/lFhnLQgbnfaGbfNwgIWybYt9tJ6JHjqt+xtSg+IBXM1aCY6bI5xqP43dS2xE
> > > >> yuvTq4Z3UcS1jGVr4wiCwOEqVw2ZRQcioXDeDDAD0qZXbRkUi9tImkIx5k7ICxNu
> > > >> 4uAYI3QrMK1QU/QteUJwZnJFDlvDQyx4FshkKePRHrlZJ5N73G4u2ChF1XDO0e5c
> > > >> NESit9hqIS3Dz3eXExt/0mQDTMWIMzdopb7R9/uVIZtCMNV618cUvuutZYGrvSd9
> > > >> 390+Z8fWoB1VroZumbOVbwE8DlsiN7YoNwTVEm1CESTavJw5dNcZnXumY3KWtaye
> > > >> BDoN+YEQdTeVvOs2s+CAwjMXVBIxGp2KfY4eXZlis16D8SUVifA=
> > > >> =WU+g
> > > >> -----END PGP SIGNATURE-----
> > > >>
> > > >> Signature for apache-wicket-7.11.0.tar.gz:
> > > >>
> > > >> -----BEGIN PGP SIGNATURE-----
> > > >>
> > > >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
> > > >> VuG/SA//dX5ZJ/kLVy2pl2Wcqeo9nAiHGSLPjkhIdQQ5y4clGtKpyydb1pBtwNTp
> > > >> ENMO/wNWeFEvphRM6KcA1D+z15FMZxCicuOc9JwbWCVnfujQFJF5dK3WX+nnJgX1
> > > >> WyuxHvhxDnjUT3lFjGECfkoiua1yVh20QUzEcqC9S2ReqyREitjGKrh7sGWx+WCM
> > > >> 2ls7pE6cXkuIjkNZP49f8LwyTIs4epK+4lkgPvgf5YgcBOVZNXK4BJ4nR74Fdr49
> > > >> qeRILeflhEk6vIK6a7quVeICnQ7bocku0wtnuy53xbipHSkcj6GwmE9bK3z+exa3
> > > >> Djg11GaqdNo1U3awmK+n3nOOBlbq1B0zwTjvAeK2m9eCwbE8W6TP2/U7mFaqCH5u
> > > >> e4hR84kTYXJ9f65URDyAZTcORRIfF1z8edEqGkVH2uI/P3U+Nwx7969PabQEWjM6
> > > >> NCrnvaDnTpiQuIJ/4AVLtDOPEnWiN/Zd/ooE7q1TWx7GeF0/hsfAM3nN/u7o0IoW
> > > >> MKPxodnPa4cX2549n/grUYsHG9PN0hKIVSk4b3O1kHZL4rFqxh1SzyAIi5UEeyhD
> > > >> sZARZfw/XC8j3rrd4eL9FjOgNvz75lhRZuuWCqIuBhrUVGrtJ1tFoQf5WL/EopJd
> > > >> 9qI6Bh1ltlAWz39mxW/w6AW5LQmAA+SBAAsZS5Lx5lwwx6LxzI0=
> > > >> =rLlH
> > > >> -----END PGP SIGNATURE-----
> > > >>
> > > >>
> > ========================================================================
> > > >>
> > > >> CHANGELOG for 7.11.0:
> > > >>
> > > >> ** Bug
> > > >>
> > > >> * [WICKET-6473] - Double slash break 404page
> > > >> * [WICKET-6533] - Error while parsing xml using AjaxButton
> > > >> * [WICKET-6546] - CssContentHeaderItem comments CSS code with
> > HTML
> > > >> comments
> > > >> * [WICKET-6551] - LazyInitProxyFactory doesn't work correctly
> at
> > > >> Weblogic
> > > >> * [WICKET-6553] - SelectOptions doesn't html-encode option
> values
> > > >> * [WICKET-6564] - PageStoreManager#clear() does not completely
> > > clear
> > > >> * [WICKET-6568] - Wicket fails / does not encode request header
> > > >> values in AjaxCalls
> > > >> * [WICKET-6586] - Broken JavaScript due to fix charsetName in
> > > >> JavaScriptPackageResource
> > > >> * [WICKET-6589] - ClientInfo fails with NumberFormatException
> for
> > > >> unusual browser versions
> > > >> * [WICKET-6604] - Ajax repaint is not correctly handled when
> > > >> component being repainted has an enclosure associated with it and is
> > > >> not a child of the enclosure
> > > >> * [WICKET-6614] - AbstractRangeValidator looks up string with
> the
> > > >> wrong key if locale is Turkish
> > > >>
> > > >> ** Improvement
> > > >>
> > > >> * [WICKET-6527] - no possibility to override fixed html
> appended
> > > >> directly to response by FilterForm
> > > >> * [WICKET-6605] - Allow AjaxFallbackButton to be stateless
> > > >>
> > > >> ** Task
> > > >>
> > > >> * [WICKET-6594] - JavaDoc of redirectToInterceptPage in
> Component
> > > >> urges to use redirectTo method when in a constructor
> > > >>
> > >
> >
> >
> > --
> > WBR
> > Maxim aka solomax
> >
>
>
> --
> Andrea Del Bene.
> Apache Wicket committer.
>
--
WBR
Maxim aka solomax
Re: [VOTE] Release Apache Wicket 7.11.0
Posted by Andrea Del Bene <an...@gmail.com>.
Hi Maxim
On Mon, Nov 26, 2018 at 4:29 AM Maxim Solodovnik <so...@gmail.com>
wrote:
> Hello Andrea,
>
> according to my tests this is not working if toolchains plugin is being
> used, i.e.:
> 1) java8 is set on the machine as default
> 2) -Pbuildbot is used to activate java7 build
> Result: java8 profile will be activated
>
>
>
that's quite strange. Do you remember which error did you get with this
combination? I've searched through old mails but I didn't find it. Anyway,
flag '--allow-script-in-comments' is supported in JDK 8 only starting from
u121:
https://www.oracle.com/technetwork/java/javase/8u121-relnotes-3315208.html
> On Mon, 26 Nov 2018 at 04:22, Andrea Del Bene <an...@gmail.com>
> wrote:
>
> > I see that Maxim has already addressed this problem with WICKET-6615, or
> > at least he partially did it. We should use a profile which is
> > automatically activated when the JDK used to run Maven is >= 1.8 .
> > Something like this:
> >
> > <profile>
> > <id>java8</id>
> > <activation>
> > <jdk>[1.8,)</jdk>
> > </activation>
> > <build>
> > <pluginManagement>
> > <plugins>
> > <plugin>
> > <groupId>org.apache.maven.plugins</groupId>
> > <artifactId>maven-javadoc-plugin</artifactId>
> > <configuration>
> > <additionalparam>--allow-script-in-comments</additionalparam>
> > </configuration>
> > </plugin>
> > </plugins>
> > </pluginManagement>
> > </build>
> > </profile>
> >
> > A similar solution is described here:
> >
> >
> >
> https://stackoverflow.com/questions/15886209/maven-is-not-working-in-java-8-when-javadoc-tags-are-incomplete
> >
> > WDYT?
> >
> >
> > > For me the build of
> > >
> >
> https://dist.apache.org/repos/dist/dev/wicket/7.11.0/apache-wicket-7.11.0.tar.gz
> > > fails with:
> > >
> > > [INFO]
> > >
> ------------------------------------------------------------------------
> > > [INFO] BUILD FAILURE
> > > [INFO]
> > >
> ------------------------------------------------------------------------
> > > [INFO] Total time: 11.773 s
> > > [INFO] Finished at: 2018-11-25T20:44:37+02:00
> > > [INFO]
> > >
> ------------------------------------------------------------------------
> > > [ERROR] Failed to execute goal
> > > org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:jar
> > (attach-javadocs)
> > > on project wicket-util: MavenReportException: Error while generating
> > > Javadoc:
> > > [ERROR] Exit code: 1 - javadoc: error - invalid flag:
> > > --allow-script-in-comments
> > > [ERROR]
> > > [ERROR] Command line was: /home/martin/devel/java-7/bin/javadoc
> > -J-Xmx256m
> > > -J-Xms128m @options @packages
> > > [ERROR]
> > > [ERROR] Refer to the generated Javadoc files in
> > > '/tmp/w711/apache-wicket-7.11.0/wicket-util/target/apidocs' dir.
> > >
> > > My JDK 7 doesn't like the the newly added javadoc argument.
> > >
> > > java version "1.7.0_72"
> > > Java(TM) SE Runtime Environment (build 1.7.0_72-b14)
> > > Java HotSpot(TM) 64-Bit Server VM (build 24.72-b04, mixed mode)
> > >
> > >
> > > On Fri, Nov 23, 2018 at 3:50 PM Andrea Del Bene <an...@gmail.com>
> > > wrote:
> > >
> > >> This is a vote to release Apache Wicket 7.11.0
> > >>
> > >> Please download the source distributions found in our staging area
> > >> linked below.
> > >>
> > >> I have included the signatures for both the source archives. This vote
> > >> lasts for 72 hours minimum.
> > >>
> > >> [ ] Yes, release Apache Wicket 7.11.0
> > >> [ ] No, don't release Apache Wicket 7.11.0, because ...
> > >>
> > >> Distributions, changelog, keys and signatures can be found at:
> > >>
> > >> https://dist.apache.org/repos/dist/dev/wicket/7.11.0
> > >>
> > >> Staging repository:
> > >>
> > >>
> > >>
> https://repository.apache.org/content/repositories/orgapachewicket-1115
> > >>
> > >> The binaries are available in the above link, as are a staging
> > >> repository for Maven. Typically the vote is on the source, but should
> > >> you find a problem with one of the binaries, please let me know, I can
> > >> re-roll them some way or the other.
> > >>
> > >> Staging git repository data:
> > >>
> > >> Repository: git@github.com:bitstorm/wicket.git
> > >> Branch: build/wicket-7.11.0
> > >> Release tag: rel/wicket-7.11.0
> > >>
> > >>
> > >>
> ========================================================================
> > >>
> > >> The signatures for the source release artefacts:
> > >>
> > >>
> > >> Signature for apache-wicket-7.11.0.zip:
> > >>
> > >> -----BEGIN PGP SIGNATURE-----
> > >>
> > >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
> > >> VuEHeQ//VlvFvtQYKtD0e9Qcu1vmpvoVlV58ZKPrYBuTQO9oRE72VDIbr5q4kE+/
> > >> cwA8Wh1dHlichyGb3U1wQ3NAoYZaqukb00bv9H+GqOQCFCa//zOSohb34yQC7e8z
> > >> hfCCANcJtAhHihn2zeapysPCp5Pfsyq7UHUQHqaJiZKRq31EeePV6laT+7+J/IPV
> > >> 6eV0Ow5QAkGXrwpv/i9vTscF620HWoT4iJxPXJatnDqwKeFQwM3Zpak6KOsKHtWF
> > >> Wn8KZcDNhZcsI/vaWW9KtndPDl2kTvo8n/ZdPyAoPTZMcAPULcyZT75VxiPRV8Ky
> > >> kQT/lFhnLQgbnfaGbfNwgIWybYt9tJ6JHjqt+xtSg+IBXM1aCY6bI5xqP43dS2xE
> > >> yuvTq4Z3UcS1jGVr4wiCwOEqVw2ZRQcioXDeDDAD0qZXbRkUi9tImkIx5k7ICxNu
> > >> 4uAYI3QrMK1QU/QteUJwZnJFDlvDQyx4FshkKePRHrlZJ5N73G4u2ChF1XDO0e5c
> > >> NESit9hqIS3Dz3eXExt/0mQDTMWIMzdopb7R9/uVIZtCMNV618cUvuutZYGrvSd9
> > >> 390+Z8fWoB1VroZumbOVbwE8DlsiN7YoNwTVEm1CESTavJw5dNcZnXumY3KWtaye
> > >> BDoN+YEQdTeVvOs2s+CAwjMXVBIxGp2KfY4eXZlis16D8SUVifA=
> > >> =WU+g
> > >> -----END PGP SIGNATURE-----
> > >>
> > >> Signature for apache-wicket-7.11.0.tar.gz:
> > >>
> > >> -----BEGIN PGP SIGNATURE-----
> > >>
> > >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
> > >> VuG/SA//dX5ZJ/kLVy2pl2Wcqeo9nAiHGSLPjkhIdQQ5y4clGtKpyydb1pBtwNTp
> > >> ENMO/wNWeFEvphRM6KcA1D+z15FMZxCicuOc9JwbWCVnfujQFJF5dK3WX+nnJgX1
> > >> WyuxHvhxDnjUT3lFjGECfkoiua1yVh20QUzEcqC9S2ReqyREitjGKrh7sGWx+WCM
> > >> 2ls7pE6cXkuIjkNZP49f8LwyTIs4epK+4lkgPvgf5YgcBOVZNXK4BJ4nR74Fdr49
> > >> qeRILeflhEk6vIK6a7quVeICnQ7bocku0wtnuy53xbipHSkcj6GwmE9bK3z+exa3
> > >> Djg11GaqdNo1U3awmK+n3nOOBlbq1B0zwTjvAeK2m9eCwbE8W6TP2/U7mFaqCH5u
> > >> e4hR84kTYXJ9f65URDyAZTcORRIfF1z8edEqGkVH2uI/P3U+Nwx7969PabQEWjM6
> > >> NCrnvaDnTpiQuIJ/4AVLtDOPEnWiN/Zd/ooE7q1TWx7GeF0/hsfAM3nN/u7o0IoW
> > >> MKPxodnPa4cX2549n/grUYsHG9PN0hKIVSk4b3O1kHZL4rFqxh1SzyAIi5UEeyhD
> > >> sZARZfw/XC8j3rrd4eL9FjOgNvz75lhRZuuWCqIuBhrUVGrtJ1tFoQf5WL/EopJd
> > >> 9qI6Bh1ltlAWz39mxW/w6AW5LQmAA+SBAAsZS5Lx5lwwx6LxzI0=
> > >> =rLlH
> > >> -----END PGP SIGNATURE-----
> > >>
> > >>
> ========================================================================
> > >>
> > >> CHANGELOG for 7.11.0:
> > >>
> > >> ** Bug
> > >>
> > >> * [WICKET-6473] - Double slash break 404page
> > >> * [WICKET-6533] - Error while parsing xml using AjaxButton
> > >> * [WICKET-6546] - CssContentHeaderItem comments CSS code with
> HTML
> > >> comments
> > >> * [WICKET-6551] - LazyInitProxyFactory doesn't work correctly at
> > >> Weblogic
> > >> * [WICKET-6553] - SelectOptions doesn't html-encode option values
> > >> * [WICKET-6564] - PageStoreManager#clear() does not completely
> > clear
> > >> * [WICKET-6568] - Wicket fails / does not encode request header
> > >> values in AjaxCalls
> > >> * [WICKET-6586] - Broken JavaScript due to fix charsetName in
> > >> JavaScriptPackageResource
> > >> * [WICKET-6589] - ClientInfo fails with NumberFormatException for
> > >> unusual browser versions
> > >> * [WICKET-6604] - Ajax repaint is not correctly handled when
> > >> component being repainted has an enclosure associated with it and is
> > >> not a child of the enclosure
> > >> * [WICKET-6614] - AbstractRangeValidator looks up string with the
> > >> wrong key if locale is Turkish
> > >>
> > >> ** Improvement
> > >>
> > >> * [WICKET-6527] - no possibility to override fixed html appended
> > >> directly to response by FilterForm
> > >> * [WICKET-6605] - Allow AjaxFallbackButton to be stateless
> > >>
> > >> ** Task
> > >>
> > >> * [WICKET-6594] - JavaDoc of redirectToInterceptPage in Component
> > >> urges to use redirectTo method when in a constructor
> > >>
> >
>
>
> --
> WBR
> Maxim aka solomax
>
--
Andrea Del Bene.
Apache Wicket committer.
Re: [VOTE] Release Apache Wicket 7.11.0
Posted by Maxim Solodovnik <so...@gmail.com>.
Hello Andrea,
according to my tests this is not working if toolchains plugin is being
used, i.e.:
1) java8 is set on the machine as default
2) -Pbuildbot is used to activate java7 build
Result: java8 profile will be activated
On Mon, 26 Nov 2018 at 04:22, Andrea Del Bene <an...@gmail.com> wrote:
> I see that Maxim has already addressed this problem with WICKET-6615, or
> at least he partially did it. We should use a profile which is
> automatically activated when the JDK used to run Maven is >= 1.8 .
> Something like this:
>
> <profile>
> <id>java8</id>
> <activation>
> <jdk>[1.8,)</jdk>
> </activation>
> <build>
> <pluginManagement>
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-javadoc-plugin</artifactId>
> <configuration>
> <additionalparam>--allow-script-in-comments</additionalparam>
> </configuration>
> </plugin>
> </plugins>
> </pluginManagement>
> </build>
> </profile>
>
> A similar solution is described here:
>
>
> https://stackoverflow.com/questions/15886209/maven-is-not-working-in-java-8-when-javadoc-tags-are-incomplete
>
> WDYT?
>
>
> > For me the build of
> >
> https://dist.apache.org/repos/dist/dev/wicket/7.11.0/apache-wicket-7.11.0.tar.gz
> > fails with:
> >
> > [INFO]
> > ------------------------------------------------------------------------
> > [INFO] BUILD FAILURE
> > [INFO]
> > ------------------------------------------------------------------------
> > [INFO] Total time: 11.773 s
> > [INFO] Finished at: 2018-11-25T20:44:37+02:00
> > [INFO]
> > ------------------------------------------------------------------------
> > [ERROR] Failed to execute goal
> > org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:jar
> (attach-javadocs)
> > on project wicket-util: MavenReportException: Error while generating
> > Javadoc:
> > [ERROR] Exit code: 1 - javadoc: error - invalid flag:
> > --allow-script-in-comments
> > [ERROR]
> > [ERROR] Command line was: /home/martin/devel/java-7/bin/javadoc
> -J-Xmx256m
> > -J-Xms128m @options @packages
> > [ERROR]
> > [ERROR] Refer to the generated Javadoc files in
> > '/tmp/w711/apache-wicket-7.11.0/wicket-util/target/apidocs' dir.
> >
> > My JDK 7 doesn't like the the newly added javadoc argument.
> >
> > java version "1.7.0_72"
> > Java(TM) SE Runtime Environment (build 1.7.0_72-b14)
> > Java HotSpot(TM) 64-Bit Server VM (build 24.72-b04, mixed mode)
> >
> >
> > On Fri, Nov 23, 2018 at 3:50 PM Andrea Del Bene <an...@gmail.com>
> > wrote:
> >
> >> This is a vote to release Apache Wicket 7.11.0
> >>
> >> Please download the source distributions found in our staging area
> >> linked below.
> >>
> >> I have included the signatures for both the source archives. This vote
> >> lasts for 72 hours minimum.
> >>
> >> [ ] Yes, release Apache Wicket 7.11.0
> >> [ ] No, don't release Apache Wicket 7.11.0, because ...
> >>
> >> Distributions, changelog, keys and signatures can be found at:
> >>
> >> https://dist.apache.org/repos/dist/dev/wicket/7.11.0
> >>
> >> Staging repository:
> >>
> >>
> >> https://repository.apache.org/content/repositories/orgapachewicket-1115
> >>
> >> The binaries are available in the above link, as are a staging
> >> repository for Maven. Typically the vote is on the source, but should
> >> you find a problem with one of the binaries, please let me know, I can
> >> re-roll them some way or the other.
> >>
> >> Staging git repository data:
> >>
> >> Repository: git@github.com:bitstorm/wicket.git
> >> Branch: build/wicket-7.11.0
> >> Release tag: rel/wicket-7.11.0
> >>
> >>
> >> ========================================================================
> >>
> >> The signatures for the source release artefacts:
> >>
> >>
> >> Signature for apache-wicket-7.11.0.zip:
> >>
> >> -----BEGIN PGP SIGNATURE-----
> >>
> >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
> >> VuEHeQ//VlvFvtQYKtD0e9Qcu1vmpvoVlV58ZKPrYBuTQO9oRE72VDIbr5q4kE+/
> >> cwA8Wh1dHlichyGb3U1wQ3NAoYZaqukb00bv9H+GqOQCFCa//zOSohb34yQC7e8z
> >> hfCCANcJtAhHihn2zeapysPCp5Pfsyq7UHUQHqaJiZKRq31EeePV6laT+7+J/IPV
> >> 6eV0Ow5QAkGXrwpv/i9vTscF620HWoT4iJxPXJatnDqwKeFQwM3Zpak6KOsKHtWF
> >> Wn8KZcDNhZcsI/vaWW9KtndPDl2kTvo8n/ZdPyAoPTZMcAPULcyZT75VxiPRV8Ky
> >> kQT/lFhnLQgbnfaGbfNwgIWybYt9tJ6JHjqt+xtSg+IBXM1aCY6bI5xqP43dS2xE
> >> yuvTq4Z3UcS1jGVr4wiCwOEqVw2ZRQcioXDeDDAD0qZXbRkUi9tImkIx5k7ICxNu
> >> 4uAYI3QrMK1QU/QteUJwZnJFDlvDQyx4FshkKePRHrlZJ5N73G4u2ChF1XDO0e5c
> >> NESit9hqIS3Dz3eXExt/0mQDTMWIMzdopb7R9/uVIZtCMNV618cUvuutZYGrvSd9
> >> 390+Z8fWoB1VroZumbOVbwE8DlsiN7YoNwTVEm1CESTavJw5dNcZnXumY3KWtaye
> >> BDoN+YEQdTeVvOs2s+CAwjMXVBIxGp2KfY4eXZlis16D8SUVifA=
> >> =WU+g
> >> -----END PGP SIGNATURE-----
> >>
> >> Signature for apache-wicket-7.11.0.tar.gz:
> >>
> >> -----BEGIN PGP SIGNATURE-----
> >>
> >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
> >> VuG/SA//dX5ZJ/kLVy2pl2Wcqeo9nAiHGSLPjkhIdQQ5y4clGtKpyydb1pBtwNTp
> >> ENMO/wNWeFEvphRM6KcA1D+z15FMZxCicuOc9JwbWCVnfujQFJF5dK3WX+nnJgX1
> >> WyuxHvhxDnjUT3lFjGECfkoiua1yVh20QUzEcqC9S2ReqyREitjGKrh7sGWx+WCM
> >> 2ls7pE6cXkuIjkNZP49f8LwyTIs4epK+4lkgPvgf5YgcBOVZNXK4BJ4nR74Fdr49
> >> qeRILeflhEk6vIK6a7quVeICnQ7bocku0wtnuy53xbipHSkcj6GwmE9bK3z+exa3
> >> Djg11GaqdNo1U3awmK+n3nOOBlbq1B0zwTjvAeK2m9eCwbE8W6TP2/U7mFaqCH5u
> >> e4hR84kTYXJ9f65URDyAZTcORRIfF1z8edEqGkVH2uI/P3U+Nwx7969PabQEWjM6
> >> NCrnvaDnTpiQuIJ/4AVLtDOPEnWiN/Zd/ooE7q1TWx7GeF0/hsfAM3nN/u7o0IoW
> >> MKPxodnPa4cX2549n/grUYsHG9PN0hKIVSk4b3O1kHZL4rFqxh1SzyAIi5UEeyhD
> >> sZARZfw/XC8j3rrd4eL9FjOgNvz75lhRZuuWCqIuBhrUVGrtJ1tFoQf5WL/EopJd
> >> 9qI6Bh1ltlAWz39mxW/w6AW5LQmAA+SBAAsZS5Lx5lwwx6LxzI0=
> >> =rLlH
> >> -----END PGP SIGNATURE-----
> >>
> >> ========================================================================
> >>
> >> CHANGELOG for 7.11.0:
> >>
> >> ** Bug
> >>
> >> * [WICKET-6473] - Double slash break 404page
> >> * [WICKET-6533] - Error while parsing xml using AjaxButton
> >> * [WICKET-6546] - CssContentHeaderItem comments CSS code with HTML
> >> comments
> >> * [WICKET-6551] - LazyInitProxyFactory doesn't work correctly at
> >> Weblogic
> >> * [WICKET-6553] - SelectOptions doesn't html-encode option values
> >> * [WICKET-6564] - PageStoreManager#clear() does not completely
> clear
> >> * [WICKET-6568] - Wicket fails / does not encode request header
> >> values in AjaxCalls
> >> * [WICKET-6586] - Broken JavaScript due to fix charsetName in
> >> JavaScriptPackageResource
> >> * [WICKET-6589] - ClientInfo fails with NumberFormatException for
> >> unusual browser versions
> >> * [WICKET-6604] - Ajax repaint is not correctly handled when
> >> component being repainted has an enclosure associated with it and is
> >> not a child of the enclosure
> >> * [WICKET-6614] - AbstractRangeValidator looks up string with the
> >> wrong key if locale is Turkish
> >>
> >> ** Improvement
> >>
> >> * [WICKET-6527] - no possibility to override fixed html appended
> >> directly to response by FilterForm
> >> * [WICKET-6605] - Allow AjaxFallbackButton to be stateless
> >>
> >> ** Task
> >>
> >> * [WICKET-6594] - JavaDoc of redirectToInterceptPage in Component
> >> urges to use redirectTo method when in a constructor
> >>
>
--
WBR
Maxim aka solomax
Re: [VOTE] Release Apache Wicket 7.11.0
Posted by Maxim Solodovnik <so...@gmail.com>.
I have added `java8` profile so it is possible to build wicket7 with java8
Java7 is unavailable on Ubuntu18, so java8 is the only option to test
Somehow I'm unable to build using java7 on both ubuntu16 and ubuntu18
(please see steps and details below)
Same time `mvn clean install -Pbuildbot` works for me
I totally don't understand what is wrong, and I don't want to spend more
time on this (let it be `mvn clean install -Pbuildbot` on my machine :)))
export JAVA_HOME=/usr/lib/jvm/java-7-openjdk-amd64
export PATH=$JAVA_HOME/bin:$PATH
*mvn -version*
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-18T01:33:14+07:00)
Maven home: /opt/maven
Java version: 1.7.0_95, vendor: Oracle Corporation, runtime:
/usr/lib/jvm/java-7-openjdk-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-139-generic", arch: "amd64", family:
"unix"
[INFO] Scanning for projects...
Downloading from central:
https://repo.maven.apache.org/maven2/org/apache/maven/wagon/wagon-ssh-external/2.6/wagon-ssh-external-2.6.pom
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] Unresolveable build extension: Plugin
org.apache.maven.wagon:wagon-ssh-external:2.6 or one of its dependencies
could not be resolved: Failed to read artifact descriptor for
org.apache.maven.wagon:wagon-ssh-external:jar:2.6 @
@
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR] The project org.apache.wicket:wicket-parent:7.11.0-SNAPSHOT
(/home/solomax/work/wicket/wicket/pom.xml) has 1 error
[ERROR] Unresolveable build extension: Plugin
org.apache.maven.wagon:wagon-ssh-external:2.6 or one of its dependencies
could not be resolved: Failed to read artifact descriptor for
org.apache.maven.wagon:wagon-ssh-external:jar:2.6: Could not transfer
artifact org.apache.maven.wagon:wagon-ssh-external:pom:2.6 from/to central (
https://repo.maven.apache.org/maven2): Received fatal alert:
protocol_version -> [Help 2]
On Mon, 26 Nov 2018 at 14:52, Martin Grigorov <mg...@apache.org> wrote:
> I have 'mvn7' shell function just because I want to make sure that JDK 7 is
> being used for the build.
> And the build of the release source files fails with JDK7 !
>
> For me this release is broken.
> But I still want to understand why these changes to maven-javadoc-plugin
> and the new profiles are needed at all in 'wicket-7.x' branch.
> Do you use some newer version of OpenJDK 7 that introduced this problem ?
> I use my old Oracle JDK 1.7 build 1.7.0_72-b14 and the newly introduced
> changes break the build for me.
>
>
> On Sun, Nov 25, 2018 at 11:22 PM Andrea Del Bene <an...@gmail.com>
> wrote:
>
> > I see that Maxim has already addressed this problem with WICKET-6615, or
> > at least he partially did it. We should use a profile which is
> > automatically activated when the JDK used to run Maven is >= 1.8 .
> > Something like this:
> >
> > <profile>
> > <id>java8</id>
> > <activation>
> > <jdk>[1.8,)</jdk>
> > </activation>
> > <build>
> > <pluginManagement>
> > <plugins>
> > <plugin>
> > <groupId>org.apache.maven.plugins</groupId>
> > <artifactId>maven-javadoc-plugin</artifactId>
> > <configuration>
> > <additionalparam>--allow-script-in-comments</additionalparam>
> > </configuration>
> > </plugin>
> > </plugins>
> > </pluginManagement>
> > </build>
> > </profile>
> >
> > A similar solution is described here:
> >
> >
> >
> https://stackoverflow.com/questions/15886209/maven-is-not-working-in-java-8-when-javadoc-tags-are-incomplete
> >
> > WDYT?
> >
> >
> > > For me the build of
> > >
> >
> https://dist.apache.org/repos/dist/dev/wicket/7.11.0/apache-wicket-7.11.0.tar.gz
> > > fails with:
> > >
> > > [INFO]
> > >
> ------------------------------------------------------------------------
> > > [INFO] BUILD FAILURE
> > > [INFO]
> > >
> ------------------------------------------------------------------------
> > > [INFO] Total time: 11.773 s
> > > [INFO] Finished at: 2018-11-25T20:44:37+02:00
> > > [INFO]
> > >
> ------------------------------------------------------------------------
> > > [ERROR] Failed to execute goal
> > > org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:jar
> > (attach-javadocs)
> > > on project wicket-util: MavenReportException: Error while generating
> > > Javadoc:
> > > [ERROR] Exit code: 1 - javadoc: error - invalid flag:
> > > --allow-script-in-comments
> > > [ERROR]
> > > [ERROR] Command line was: /home/martin/devel/java-7/bin/javadoc
> > -J-Xmx256m
> > > -J-Xms128m @options @packages
> > > [ERROR]
> > > [ERROR] Refer to the generated Javadoc files in
> > > '/tmp/w711/apache-wicket-7.11.0/wicket-util/target/apidocs' dir.
> > >
> > > My JDK 7 doesn't like the the newly added javadoc argument.
> > >
> > > java version "1.7.0_72"
> > > Java(TM) SE Runtime Environment (build 1.7.0_72-b14)
> > > Java HotSpot(TM) 64-Bit Server VM (build 24.72-b04, mixed mode)
> > >
> > >
> > > On Fri, Nov 23, 2018 at 3:50 PM Andrea Del Bene <an...@gmail.com>
> > > wrote:
> > >
> > >> This is a vote to release Apache Wicket 7.11.0
> > >>
> > >> Please download the source distributions found in our staging area
> > >> linked below.
> > >>
> > >> I have included the signatures for both the source archives. This vote
> > >> lasts for 72 hours minimum.
> > >>
> > >> [ ] Yes, release Apache Wicket 7.11.0
> > >> [ ] No, don't release Apache Wicket 7.11.0, because ...
> > >>
> > >> Distributions, changelog, keys and signatures can be found at:
> > >>
> > >> https://dist.apache.org/repos/dist/dev/wicket/7.11.0
> > >>
> > >> Staging repository:
> > >>
> > >>
> > >>
> https://repository.apache.org/content/repositories/orgapachewicket-1115
> > >>
> > >> The binaries are available in the above link, as are a staging
> > >> repository for Maven. Typically the vote is on the source, but should
> > >> you find a problem with one of the binaries, please let me know, I can
> > >> re-roll them some way or the other.
> > >>
> > >> Staging git repository data:
> > >>
> > >> Repository: git@github.com:bitstorm/wicket.git
> > >> Branch: build/wicket-7.11.0
> > >> Release tag: rel/wicket-7.11.0
> > >>
> > >>
> > >>
> ========================================================================
> > >>
> > >> The signatures for the source release artefacts:
> > >>
> > >>
> > >> Signature for apache-wicket-7.11.0.zip:
> > >>
> > >> -----BEGIN PGP SIGNATURE-----
> > >>
> > >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
> > >> VuEHeQ//VlvFvtQYKtD0e9Qcu1vmpvoVlV58ZKPrYBuTQO9oRE72VDIbr5q4kE+/
> > >> cwA8Wh1dHlichyGb3U1wQ3NAoYZaqukb00bv9H+GqOQCFCa//zOSohb34yQC7e8z
> > >> hfCCANcJtAhHihn2zeapysPCp5Pfsyq7UHUQHqaJiZKRq31EeePV6laT+7+J/IPV
> > >> 6eV0Ow5QAkGXrwpv/i9vTscF620HWoT4iJxPXJatnDqwKeFQwM3Zpak6KOsKHtWF
> > >> Wn8KZcDNhZcsI/vaWW9KtndPDl2kTvo8n/ZdPyAoPTZMcAPULcyZT75VxiPRV8Ky
> > >> kQT/lFhnLQgbnfaGbfNwgIWybYt9tJ6JHjqt+xtSg+IBXM1aCY6bI5xqP43dS2xE
> > >> yuvTq4Z3UcS1jGVr4wiCwOEqVw2ZRQcioXDeDDAD0qZXbRkUi9tImkIx5k7ICxNu
> > >> 4uAYI3QrMK1QU/QteUJwZnJFDlvDQyx4FshkKePRHrlZJ5N73G4u2ChF1XDO0e5c
> > >> NESit9hqIS3Dz3eXExt/0mQDTMWIMzdopb7R9/uVIZtCMNV618cUvuutZYGrvSd9
> > >> 390+Z8fWoB1VroZumbOVbwE8DlsiN7YoNwTVEm1CESTavJw5dNcZnXumY3KWtaye
> > >> BDoN+YEQdTeVvOs2s+CAwjMXVBIxGp2KfY4eXZlis16D8SUVifA=
> > >> =WU+g
> > >> -----END PGP SIGNATURE-----
> > >>
> > >> Signature for apache-wicket-7.11.0.tar.gz:
> > >>
> > >> -----BEGIN PGP SIGNATURE-----
> > >>
> > >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
> > >> VuG/SA//dX5ZJ/kLVy2pl2Wcqeo9nAiHGSLPjkhIdQQ5y4clGtKpyydb1pBtwNTp
> > >> ENMO/wNWeFEvphRM6KcA1D+z15FMZxCicuOc9JwbWCVnfujQFJF5dK3WX+nnJgX1
> > >> WyuxHvhxDnjUT3lFjGECfkoiua1yVh20QUzEcqC9S2ReqyREitjGKrh7sGWx+WCM
> > >> 2ls7pE6cXkuIjkNZP49f8LwyTIs4epK+4lkgPvgf5YgcBOVZNXK4BJ4nR74Fdr49
> > >> qeRILeflhEk6vIK6a7quVeICnQ7bocku0wtnuy53xbipHSkcj6GwmE9bK3z+exa3
> > >> Djg11GaqdNo1U3awmK+n3nOOBlbq1B0zwTjvAeK2m9eCwbE8W6TP2/U7mFaqCH5u
> > >> e4hR84kTYXJ9f65URDyAZTcORRIfF1z8edEqGkVH2uI/P3U+Nwx7969PabQEWjM6
> > >> NCrnvaDnTpiQuIJ/4AVLtDOPEnWiN/Zd/ooE7q1TWx7GeF0/hsfAM3nN/u7o0IoW
> > >> MKPxodnPa4cX2549n/grUYsHG9PN0hKIVSk4b3O1kHZL4rFqxh1SzyAIi5UEeyhD
> > >> sZARZfw/XC8j3rrd4eL9FjOgNvz75lhRZuuWCqIuBhrUVGrtJ1tFoQf5WL/EopJd
> > >> 9qI6Bh1ltlAWz39mxW/w6AW5LQmAA+SBAAsZS5Lx5lwwx6LxzI0=
> > >> =rLlH
> > >> -----END PGP SIGNATURE-----
> > >>
> > >>
> ========================================================================
> > >>
> > >> CHANGELOG for 7.11.0:
> > >>
> > >> ** Bug
> > >>
> > >> * [WICKET-6473] - Double slash break 404page
> > >> * [WICKET-6533] - Error while parsing xml using AjaxButton
> > >> * [WICKET-6546] - CssContentHeaderItem comments CSS code with
> HTML
> > >> comments
> > >> * [WICKET-6551] - LazyInitProxyFactory doesn't work correctly at
> > >> Weblogic
> > >> * [WICKET-6553] - SelectOptions doesn't html-encode option values
> > >> * [WICKET-6564] - PageStoreManager#clear() does not completely
> > clear
> > >> * [WICKET-6568] - Wicket fails / does not encode request header
> > >> values in AjaxCalls
> > >> * [WICKET-6586] - Broken JavaScript due to fix charsetName in
> > >> JavaScriptPackageResource
> > >> * [WICKET-6589] - ClientInfo fails with NumberFormatException for
> > >> unusual browser versions
> > >> * [WICKET-6604] - Ajax repaint is not correctly handled when
> > >> component being repainted has an enclosure associated with it and is
> > >> not a child of the enclosure
> > >> * [WICKET-6614] - AbstractRangeValidator looks up string with the
> > >> wrong key if locale is Turkish
> > >>
> > >> ** Improvement
> > >>
> > >> * [WICKET-6527] - no possibility to override fixed html appended
> > >> directly to response by FilterForm
> > >> * [WICKET-6605] - Allow AjaxFallbackButton to be stateless
> > >>
> > >> ** Task
> > >>
> > >> * [WICKET-6594] - JavaDoc of redirectToInterceptPage in Component
> > >> urges to use redirectTo method when in a constructor
> > >>
> >
>
--
WBR
Maxim aka solomax
Re: [VOTE] Release Apache Wicket 7.11.0
Posted by Martin Grigorov <mg...@apache.org>.
I have 'mvn7' shell function just because I want to make sure that JDK 7 is
being used for the build.
And the build of the release source files fails with JDK7 !
For me this release is broken.
But I still want to understand why these changes to maven-javadoc-plugin
and the new profiles are needed at all in 'wicket-7.x' branch.
Do you use some newer version of OpenJDK 7 that introduced this problem ?
I use my old Oracle JDK 1.7 build 1.7.0_72-b14 and the newly introduced
changes break the build for me.
On Sun, Nov 25, 2018 at 11:22 PM Andrea Del Bene <an...@gmail.com>
wrote:
> I see that Maxim has already addressed this problem with WICKET-6615, or
> at least he partially did it. We should use a profile which is
> automatically activated when the JDK used to run Maven is >= 1.8 .
> Something like this:
>
> <profile>
> <id>java8</id>
> <activation>
> <jdk>[1.8,)</jdk>
> </activation>
> <build>
> <pluginManagement>
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-javadoc-plugin</artifactId>
> <configuration>
> <additionalparam>--allow-script-in-comments</additionalparam>
> </configuration>
> </plugin>
> </plugins>
> </pluginManagement>
> </build>
> </profile>
>
> A similar solution is described here:
>
>
> https://stackoverflow.com/questions/15886209/maven-is-not-working-in-java-8-when-javadoc-tags-are-incomplete
>
> WDYT?
>
>
> > For me the build of
> >
> https://dist.apache.org/repos/dist/dev/wicket/7.11.0/apache-wicket-7.11.0.tar.gz
> > fails with:
> >
> > [INFO]
> > ------------------------------------------------------------------------
> > [INFO] BUILD FAILURE
> > [INFO]
> > ------------------------------------------------------------------------
> > [INFO] Total time: 11.773 s
> > [INFO] Finished at: 2018-11-25T20:44:37+02:00
> > [INFO]
> > ------------------------------------------------------------------------
> > [ERROR] Failed to execute goal
> > org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:jar
> (attach-javadocs)
> > on project wicket-util: MavenReportException: Error while generating
> > Javadoc:
> > [ERROR] Exit code: 1 - javadoc: error - invalid flag:
> > --allow-script-in-comments
> > [ERROR]
> > [ERROR] Command line was: /home/martin/devel/java-7/bin/javadoc
> -J-Xmx256m
> > -J-Xms128m @options @packages
> > [ERROR]
> > [ERROR] Refer to the generated Javadoc files in
> > '/tmp/w711/apache-wicket-7.11.0/wicket-util/target/apidocs' dir.
> >
> > My JDK 7 doesn't like the the newly added javadoc argument.
> >
> > java version "1.7.0_72"
> > Java(TM) SE Runtime Environment (build 1.7.0_72-b14)
> > Java HotSpot(TM) 64-Bit Server VM (build 24.72-b04, mixed mode)
> >
> >
> > On Fri, Nov 23, 2018 at 3:50 PM Andrea Del Bene <an...@gmail.com>
> > wrote:
> >
> >> This is a vote to release Apache Wicket 7.11.0
> >>
> >> Please download the source distributions found in our staging area
> >> linked below.
> >>
> >> I have included the signatures for both the source archives. This vote
> >> lasts for 72 hours minimum.
> >>
> >> [ ] Yes, release Apache Wicket 7.11.0
> >> [ ] No, don't release Apache Wicket 7.11.0, because ...
> >>
> >> Distributions, changelog, keys and signatures can be found at:
> >>
> >> https://dist.apache.org/repos/dist/dev/wicket/7.11.0
> >>
> >> Staging repository:
> >>
> >>
> >> https://repository.apache.org/content/repositories/orgapachewicket-1115
> >>
> >> The binaries are available in the above link, as are a staging
> >> repository for Maven. Typically the vote is on the source, but should
> >> you find a problem with one of the binaries, please let me know, I can
> >> re-roll them some way or the other.
> >>
> >> Staging git repository data:
> >>
> >> Repository: git@github.com:bitstorm/wicket.git
> >> Branch: build/wicket-7.11.0
> >> Release tag: rel/wicket-7.11.0
> >>
> >>
> >> ========================================================================
> >>
> >> The signatures for the source release artefacts:
> >>
> >>
> >> Signature for apache-wicket-7.11.0.zip:
> >>
> >> -----BEGIN PGP SIGNATURE-----
> >>
> >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
> >> VuEHeQ//VlvFvtQYKtD0e9Qcu1vmpvoVlV58ZKPrYBuTQO9oRE72VDIbr5q4kE+/
> >> cwA8Wh1dHlichyGb3U1wQ3NAoYZaqukb00bv9H+GqOQCFCa//zOSohb34yQC7e8z
> >> hfCCANcJtAhHihn2zeapysPCp5Pfsyq7UHUQHqaJiZKRq31EeePV6laT+7+J/IPV
> >> 6eV0Ow5QAkGXrwpv/i9vTscF620HWoT4iJxPXJatnDqwKeFQwM3Zpak6KOsKHtWF
> >> Wn8KZcDNhZcsI/vaWW9KtndPDl2kTvo8n/ZdPyAoPTZMcAPULcyZT75VxiPRV8Ky
> >> kQT/lFhnLQgbnfaGbfNwgIWybYt9tJ6JHjqt+xtSg+IBXM1aCY6bI5xqP43dS2xE
> >> yuvTq4Z3UcS1jGVr4wiCwOEqVw2ZRQcioXDeDDAD0qZXbRkUi9tImkIx5k7ICxNu
> >> 4uAYI3QrMK1QU/QteUJwZnJFDlvDQyx4FshkKePRHrlZJ5N73G4u2ChF1XDO0e5c
> >> NESit9hqIS3Dz3eXExt/0mQDTMWIMzdopb7R9/uVIZtCMNV618cUvuutZYGrvSd9
> >> 390+Z8fWoB1VroZumbOVbwE8DlsiN7YoNwTVEm1CESTavJw5dNcZnXumY3KWtaye
> >> BDoN+YEQdTeVvOs2s+CAwjMXVBIxGp2KfY4eXZlis16D8SUVifA=
> >> =WU+g
> >> -----END PGP SIGNATURE-----
> >>
> >> Signature for apache-wicket-7.11.0.tar.gz:
> >>
> >> -----BEGIN PGP SIGNATURE-----
> >>
> >> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
> >> VuG/SA//dX5ZJ/kLVy2pl2Wcqeo9nAiHGSLPjkhIdQQ5y4clGtKpyydb1pBtwNTp
> >> ENMO/wNWeFEvphRM6KcA1D+z15FMZxCicuOc9JwbWCVnfujQFJF5dK3WX+nnJgX1
> >> WyuxHvhxDnjUT3lFjGECfkoiua1yVh20QUzEcqC9S2ReqyREitjGKrh7sGWx+WCM
> >> 2ls7pE6cXkuIjkNZP49f8LwyTIs4epK+4lkgPvgf5YgcBOVZNXK4BJ4nR74Fdr49
> >> qeRILeflhEk6vIK6a7quVeICnQ7bocku0wtnuy53xbipHSkcj6GwmE9bK3z+exa3
> >> Djg11GaqdNo1U3awmK+n3nOOBlbq1B0zwTjvAeK2m9eCwbE8W6TP2/U7mFaqCH5u
> >> e4hR84kTYXJ9f65URDyAZTcORRIfF1z8edEqGkVH2uI/P3U+Nwx7969PabQEWjM6
> >> NCrnvaDnTpiQuIJ/4AVLtDOPEnWiN/Zd/ooE7q1TWx7GeF0/hsfAM3nN/u7o0IoW
> >> MKPxodnPa4cX2549n/grUYsHG9PN0hKIVSk4b3O1kHZL4rFqxh1SzyAIi5UEeyhD
> >> sZARZfw/XC8j3rrd4eL9FjOgNvz75lhRZuuWCqIuBhrUVGrtJ1tFoQf5WL/EopJd
> >> 9qI6Bh1ltlAWz39mxW/w6AW5LQmAA+SBAAsZS5Lx5lwwx6LxzI0=
> >> =rLlH
> >> -----END PGP SIGNATURE-----
> >>
> >> ========================================================================
> >>
> >> CHANGELOG for 7.11.0:
> >>
> >> ** Bug
> >>
> >> * [WICKET-6473] - Double slash break 404page
> >> * [WICKET-6533] - Error while parsing xml using AjaxButton
> >> * [WICKET-6546] - CssContentHeaderItem comments CSS code with HTML
> >> comments
> >> * [WICKET-6551] - LazyInitProxyFactory doesn't work correctly at
> >> Weblogic
> >> * [WICKET-6553] - SelectOptions doesn't html-encode option values
> >> * [WICKET-6564] - PageStoreManager#clear() does not completely
> clear
> >> * [WICKET-6568] - Wicket fails / does not encode request header
> >> values in AjaxCalls
> >> * [WICKET-6586] - Broken JavaScript due to fix charsetName in
> >> JavaScriptPackageResource
> >> * [WICKET-6589] - ClientInfo fails with NumberFormatException for
> >> unusual browser versions
> >> * [WICKET-6604] - Ajax repaint is not correctly handled when
> >> component being repainted has an enclosure associated with it and is
> >> not a child of the enclosure
> >> * [WICKET-6614] - AbstractRangeValidator looks up string with the
> >> wrong key if locale is Turkish
> >>
> >> ** Improvement
> >>
> >> * [WICKET-6527] - no possibility to override fixed html appended
> >> directly to response by FilterForm
> >> * [WICKET-6605] - Allow AjaxFallbackButton to be stateless
> >>
> >> ** Task
> >>
> >> * [WICKET-6594] - JavaDoc of redirectToInterceptPage in Component
> >> urges to use redirectTo method when in a constructor
> >>
>
Re: [VOTE] Release Apache Wicket 7.11.0
Posted by Andrea Del Bene <an...@gmail.com>.
I see that Maxim has already addressed this problem with WICKET-6615, or
at least he partially did it. We should use a profile which is
automatically activated when the JDK used to run Maven is >= 1.8 .
Something like this:
<profile>
<id>java8</id>
<activation>
<jdk>[1.8,)</jdk>
</activation>
<build>
<pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<configuration>
<additionalparam>--allow-script-in-comments</additionalparam>
</configuration>
</plugin>
</plugins>
</pluginManagement>
</build>
</profile>
A similar solution is described here:
https://stackoverflow.com/questions/15886209/maven-is-not-working-in-java-8-when-javadoc-tags-are-incomplete
WDYT?
> For me the build of
> https://dist.apache.org/repos/dist/dev/wicket/7.11.0/apache-wicket-7.11.0.tar.gz
> fails with:
>
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 11.773 s
> [INFO] Finished at: 2018-11-25T20:44:37+02:00
> [INFO]
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:jar (attach-javadocs)
> on project wicket-util: MavenReportException: Error while generating
> Javadoc:
> [ERROR] Exit code: 1 - javadoc: error - invalid flag:
> --allow-script-in-comments
> [ERROR]
> [ERROR] Command line was: /home/martin/devel/java-7/bin/javadoc -J-Xmx256m
> -J-Xms128m @options @packages
> [ERROR]
> [ERROR] Refer to the generated Javadoc files in
> '/tmp/w711/apache-wicket-7.11.0/wicket-util/target/apidocs' dir.
>
> My JDK 7 doesn't like the the newly added javadoc argument.
>
> java version "1.7.0_72"
> Java(TM) SE Runtime Environment (build 1.7.0_72-b14)
> Java HotSpot(TM) 64-Bit Server VM (build 24.72-b04, mixed mode)
>
>
> On Fri, Nov 23, 2018 at 3:50 PM Andrea Del Bene <an...@gmail.com>
> wrote:
>
>> This is a vote to release Apache Wicket 7.11.0
>>
>> Please download the source distributions found in our staging area
>> linked below.
>>
>> I have included the signatures for both the source archives. This vote
>> lasts for 72 hours minimum.
>>
>> [ ] Yes, release Apache Wicket 7.11.0
>> [ ] No, don't release Apache Wicket 7.11.0, because ...
>>
>> Distributions, changelog, keys and signatures can be found at:
>>
>> https://dist.apache.org/repos/dist/dev/wicket/7.11.0
>>
>> Staging repository:
>>
>>
>> https://repository.apache.org/content/repositories/orgapachewicket-1115
>>
>> The binaries are available in the above link, as are a staging
>> repository for Maven. Typically the vote is on the source, but should
>> you find a problem with one of the binaries, please let me know, I can
>> re-roll them some way or the other.
>>
>> Staging git repository data:
>>
>> Repository: git@github.com:bitstorm/wicket.git
>> Branch: build/wicket-7.11.0
>> Release tag: rel/wicket-7.11.0
>>
>>
>> ========================================================================
>>
>> The signatures for the source release artefacts:
>>
>>
>> Signature for apache-wicket-7.11.0.zip:
>>
>> -----BEGIN PGP SIGNATURE-----
>>
>> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
>> VuEHeQ//VlvFvtQYKtD0e9Qcu1vmpvoVlV58ZKPrYBuTQO9oRE72VDIbr5q4kE+/
>> cwA8Wh1dHlichyGb3U1wQ3NAoYZaqukb00bv9H+GqOQCFCa//zOSohb34yQC7e8z
>> hfCCANcJtAhHihn2zeapysPCp5Pfsyq7UHUQHqaJiZKRq31EeePV6laT+7+J/IPV
>> 6eV0Ow5QAkGXrwpv/i9vTscF620HWoT4iJxPXJatnDqwKeFQwM3Zpak6KOsKHtWF
>> Wn8KZcDNhZcsI/vaWW9KtndPDl2kTvo8n/ZdPyAoPTZMcAPULcyZT75VxiPRV8Ky
>> kQT/lFhnLQgbnfaGbfNwgIWybYt9tJ6JHjqt+xtSg+IBXM1aCY6bI5xqP43dS2xE
>> yuvTq4Z3UcS1jGVr4wiCwOEqVw2ZRQcioXDeDDAD0qZXbRkUi9tImkIx5k7ICxNu
>> 4uAYI3QrMK1QU/QteUJwZnJFDlvDQyx4FshkKePRHrlZJ5N73G4u2ChF1XDO0e5c
>> NESit9hqIS3Dz3eXExt/0mQDTMWIMzdopb7R9/uVIZtCMNV618cUvuutZYGrvSd9
>> 390+Z8fWoB1VroZumbOVbwE8DlsiN7YoNwTVEm1CESTavJw5dNcZnXumY3KWtaye
>> BDoN+YEQdTeVvOs2s+CAwjMXVBIxGp2KfY4eXZlis16D8SUVifA=
>> =WU+g
>> -----END PGP SIGNATURE-----
>>
>> Signature for apache-wicket-7.11.0.tar.gz:
>>
>> -----BEGIN PGP SIGNATURE-----
>>
>> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
>> VuG/SA//dX5ZJ/kLVy2pl2Wcqeo9nAiHGSLPjkhIdQQ5y4clGtKpyydb1pBtwNTp
>> ENMO/wNWeFEvphRM6KcA1D+z15FMZxCicuOc9JwbWCVnfujQFJF5dK3WX+nnJgX1
>> WyuxHvhxDnjUT3lFjGECfkoiua1yVh20QUzEcqC9S2ReqyREitjGKrh7sGWx+WCM
>> 2ls7pE6cXkuIjkNZP49f8LwyTIs4epK+4lkgPvgf5YgcBOVZNXK4BJ4nR74Fdr49
>> qeRILeflhEk6vIK6a7quVeICnQ7bocku0wtnuy53xbipHSkcj6GwmE9bK3z+exa3
>> Djg11GaqdNo1U3awmK+n3nOOBlbq1B0zwTjvAeK2m9eCwbE8W6TP2/U7mFaqCH5u
>> e4hR84kTYXJ9f65URDyAZTcORRIfF1z8edEqGkVH2uI/P3U+Nwx7969PabQEWjM6
>> NCrnvaDnTpiQuIJ/4AVLtDOPEnWiN/Zd/ooE7q1TWx7GeF0/hsfAM3nN/u7o0IoW
>> MKPxodnPa4cX2549n/grUYsHG9PN0hKIVSk4b3O1kHZL4rFqxh1SzyAIi5UEeyhD
>> sZARZfw/XC8j3rrd4eL9FjOgNvz75lhRZuuWCqIuBhrUVGrtJ1tFoQf5WL/EopJd
>> 9qI6Bh1ltlAWz39mxW/w6AW5LQmAA+SBAAsZS5Lx5lwwx6LxzI0=
>> =rLlH
>> -----END PGP SIGNATURE-----
>>
>> ========================================================================
>>
>> CHANGELOG for 7.11.0:
>>
>> ** Bug
>>
>> * [WICKET-6473] - Double slash break 404page
>> * [WICKET-6533] - Error while parsing xml using AjaxButton
>> * [WICKET-6546] - CssContentHeaderItem comments CSS code with HTML
>> comments
>> * [WICKET-6551] - LazyInitProxyFactory doesn't work correctly at
>> Weblogic
>> * [WICKET-6553] - SelectOptions doesn't html-encode option values
>> * [WICKET-6564] - PageStoreManager#clear() does not completely clear
>> * [WICKET-6568] - Wicket fails / does not encode request header
>> values in AjaxCalls
>> * [WICKET-6586] - Broken JavaScript due to fix charsetName in
>> JavaScriptPackageResource
>> * [WICKET-6589] - ClientInfo fails with NumberFormatException for
>> unusual browser versions
>> * [WICKET-6604] - Ajax repaint is not correctly handled when
>> component being repainted has an enclosure associated with it and is
>> not a child of the enclosure
>> * [WICKET-6614] - AbstractRangeValidator looks up string with the
>> wrong key if locale is Turkish
>>
>> ** Improvement
>>
>> * [WICKET-6527] - no possibility to override fixed html appended
>> directly to response by FilterForm
>> * [WICKET-6605] - Allow AjaxFallbackButton to be stateless
>>
>> ** Task
>>
>> * [WICKET-6594] - JavaDoc of redirectToInterceptPage in Component
>> urges to use redirectTo method when in a constructor
>>
Re: [VOTE] Release Apache Wicket 7.11.0
Posted by Martin Grigorov <mg...@apache.org>.
For me the build of
https://dist.apache.org/repos/dist/dev/wicket/7.11.0/apache-wicket-7.11.0.tar.gz
fails with:
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 11.773 s
[INFO] Finished at: 2018-11-25T20:44:37+02:00
[INFO]
------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:2.10.4:jar (attach-javadocs)
on project wicket-util: MavenReportException: Error while generating
Javadoc:
[ERROR] Exit code: 1 - javadoc: error - invalid flag:
--allow-script-in-comments
[ERROR]
[ERROR] Command line was: /home/martin/devel/java-7/bin/javadoc -J-Xmx256m
-J-Xms128m @options @packages
[ERROR]
[ERROR] Refer to the generated Javadoc files in
'/tmp/w711/apache-wicket-7.11.0/wicket-util/target/apidocs' dir.
My JDK 7 doesn't like the the newly added javadoc argument.
java version "1.7.0_72"
Java(TM) SE Runtime Environment (build 1.7.0_72-b14)
Java HotSpot(TM) 64-Bit Server VM (build 24.72-b04, mixed mode)
On Fri, Nov 23, 2018 at 3:50 PM Andrea Del Bene <an...@gmail.com>
wrote:
> This is a vote to release Apache Wicket 7.11.0
>
> Please download the source distributions found in our staging area
> linked below.
>
> I have included the signatures for both the source archives. This vote
> lasts for 72 hours minimum.
>
> [ ] Yes, release Apache Wicket 7.11.0
> [ ] No, don't release Apache Wicket 7.11.0, because ...
>
> Distributions, changelog, keys and signatures can be found at:
>
> https://dist.apache.org/repos/dist/dev/wicket/7.11.0
>
> Staging repository:
>
>
> https://repository.apache.org/content/repositories/orgapachewicket-1115
>
> The binaries are available in the above link, as are a staging
> repository for Maven. Typically the vote is on the source, but should
> you find a problem with one of the binaries, please let me know, I can
> re-roll them some way or the other.
>
> Staging git repository data:
>
> Repository: git@github.com:bitstorm/wicket.git
> Branch: build/wicket-7.11.0
> Release tag: rel/wicket-7.11.0
>
>
> ========================================================================
>
> The signatures for the source release artefacts:
>
>
> Signature for apache-wicket-7.11.0.zip:
>
> -----BEGIN PGP SIGNATURE-----
>
> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
> VuEHeQ//VlvFvtQYKtD0e9Qcu1vmpvoVlV58ZKPrYBuTQO9oRE72VDIbr5q4kE+/
> cwA8Wh1dHlichyGb3U1wQ3NAoYZaqukb00bv9H+GqOQCFCa//zOSohb34yQC7e8z
> hfCCANcJtAhHihn2zeapysPCp5Pfsyq7UHUQHqaJiZKRq31EeePV6laT+7+J/IPV
> 6eV0Ow5QAkGXrwpv/i9vTscF620HWoT4iJxPXJatnDqwKeFQwM3Zpak6KOsKHtWF
> Wn8KZcDNhZcsI/vaWW9KtndPDl2kTvo8n/ZdPyAoPTZMcAPULcyZT75VxiPRV8Ky
> kQT/lFhnLQgbnfaGbfNwgIWybYt9tJ6JHjqt+xtSg+IBXM1aCY6bI5xqP43dS2xE
> yuvTq4Z3UcS1jGVr4wiCwOEqVw2ZRQcioXDeDDAD0qZXbRkUi9tImkIx5k7ICxNu
> 4uAYI3QrMK1QU/QteUJwZnJFDlvDQyx4FshkKePRHrlZJ5N73G4u2ChF1XDO0e5c
> NESit9hqIS3Dz3eXExt/0mQDTMWIMzdopb7R9/uVIZtCMNV618cUvuutZYGrvSd9
> 390+Z8fWoB1VroZumbOVbwE8DlsiN7YoNwTVEm1CESTavJw5dNcZnXumY3KWtaye
> BDoN+YEQdTeVvOs2s+CAwjMXVBIxGp2KfY4eXZlis16D8SUVifA=
> =WU+g
> -----END PGP SIGNATURE-----
>
> Signature for apache-wicket-7.11.0.tar.gz:
>
> -----BEGIN PGP SIGNATURE-----
>
> iQIzBAABCgAdFiEE0a6YZHC1pJw+aieyh48B+qjTVuEFAlv4ACwACgkQh48B+qjT
> VuG/SA//dX5ZJ/kLVy2pl2Wcqeo9nAiHGSLPjkhIdQQ5y4clGtKpyydb1pBtwNTp
> ENMO/wNWeFEvphRM6KcA1D+z15FMZxCicuOc9JwbWCVnfujQFJF5dK3WX+nnJgX1
> WyuxHvhxDnjUT3lFjGECfkoiua1yVh20QUzEcqC9S2ReqyREitjGKrh7sGWx+WCM
> 2ls7pE6cXkuIjkNZP49f8LwyTIs4epK+4lkgPvgf5YgcBOVZNXK4BJ4nR74Fdr49
> qeRILeflhEk6vIK6a7quVeICnQ7bocku0wtnuy53xbipHSkcj6GwmE9bK3z+exa3
> Djg11GaqdNo1U3awmK+n3nOOBlbq1B0zwTjvAeK2m9eCwbE8W6TP2/U7mFaqCH5u
> e4hR84kTYXJ9f65URDyAZTcORRIfF1z8edEqGkVH2uI/P3U+Nwx7969PabQEWjM6
> NCrnvaDnTpiQuIJ/4AVLtDOPEnWiN/Zd/ooE7q1TWx7GeF0/hsfAM3nN/u7o0IoW
> MKPxodnPa4cX2549n/grUYsHG9PN0hKIVSk4b3O1kHZL4rFqxh1SzyAIi5UEeyhD
> sZARZfw/XC8j3rrd4eL9FjOgNvz75lhRZuuWCqIuBhrUVGrtJ1tFoQf5WL/EopJd
> 9qI6Bh1ltlAWz39mxW/w6AW5LQmAA+SBAAsZS5Lx5lwwx6LxzI0=
> =rLlH
> -----END PGP SIGNATURE-----
>
> ========================================================================
>
> CHANGELOG for 7.11.0:
>
> ** Bug
>
> * [WICKET-6473] - Double slash break 404page
> * [WICKET-6533] - Error while parsing xml using AjaxButton
> * [WICKET-6546] - CssContentHeaderItem comments CSS code with HTML
> comments
> * [WICKET-6551] - LazyInitProxyFactory doesn't work correctly at
> Weblogic
> * [WICKET-6553] - SelectOptions doesn't html-encode option values
> * [WICKET-6564] - PageStoreManager#clear() does not completely clear
> * [WICKET-6568] - Wicket fails / does not encode request header
> values in AjaxCalls
> * [WICKET-6586] - Broken JavaScript due to fix charsetName in
> JavaScriptPackageResource
> * [WICKET-6589] - ClientInfo fails with NumberFormatException for
> unusual browser versions
> * [WICKET-6604] - Ajax repaint is not correctly handled when
> component being repainted has an enclosure associated with it and is
> not a child of the enclosure
> * [WICKET-6614] - AbstractRangeValidator looks up string with the
> wrong key if locale is Turkish
>
> ** Improvement
>
> * [WICKET-6527] - no possibility to override fixed html appended
> directly to response by FilterForm
> * [WICKET-6605] - Allow AjaxFallbackButton to be stateless
>
> ** Task
>
> * [WICKET-6594] - JavaDoc of redirectToInterceptPage in Component
> urges to use redirectTo method when in a constructor
>