You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/11/06 13:03:02 UTC
[GitHub] [dubbo-go-pixiu] nicktming opened a new pull request, #517: fix nil pointer
nicktming opened a new pull request, #517:
URL: https://github.com/apache/dubbo-go-pixiu/pull/517
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
fix some nil pointer
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks merged pull request #517: fix nil pointer
Posted by GitBox <gi...@apache.org>.
AlexStocks merged PR #517:
URL: https://github.com/apache/dubbo-go-pixiu/pull/517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #517: fix nil pointer
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #517:
URL: https://github.com/apache/dubbo-go-pixiu/pull/517#issuecomment-1304799998
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/517?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#517](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/517?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e69abd3) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/8dc4bd6f9635124388a8b71da8ed4b143afaab9e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8dc4bd6) will **decrease** coverage by `0.03%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## develop #517 +/- ##
===========================================
- Coverage 54.70% 54.67% -0.04%
===========================================
Files 666 666
Lines 77864 77865 +1
===========================================
- Hits 42596 42569 -27
- Misses 31631 31653 +22
- Partials 3637 3643 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/517?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pixiu/pkg/config/config\_load.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGl4aXUvcGtnL2NvbmZpZy9jb25maWdfbG9hZC5nbw==) | `44.53% <0.00%> (-0.38%)` | :arrow_down: |
| [pilot/pkg/serviceregistry/kube/controller/sync.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlsb3QvcGtnL3NlcnZpY2VyZWdpc3RyeS9rdWJlL2NvbnRyb2xsZXIvc3luYy5nbw==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
| [pkg/config/mesh/kubemesh/watcher.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9tZXNoL2t1YmVtZXNoL3dhdGNoZXIuZ28=) | `59.01% <0.00%> (-11.48%)` | :arrow_down: |
| [pkg/kube/inject/watcher.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvaW5qZWN0L3dhdGNoZXIuZ28=) | `48.14% <0.00%> (-8.65%)` | :arrow_down: |
| [pkg/kube/controllers/queue.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvY29udHJvbGxlcnMvcXVldWUuZ28=) | `55.22% <0.00%> (-7.47%)` | :arrow_down: |
| [pkg/istio-agent/xds\_proxy\_delta.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2lzdGlvLWFnZW50L3hkc19wcm94eV9kZWx0YS5nbw==) | `46.11% <0.00%> (-5.70%)` | :arrow_down: |
| [pilot/pkg/model/addressmap.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlsb3QvcGtnL21vZGVsL2FkZHJlc3NtYXAuZ28=) | `63.23% <0.00%> (-4.42%)` | :arrow_down: |
| [security/pkg/nodeagent/sds/sdsservice.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VjdXJpdHkvcGtnL25vZGVhZ2VudC9zZHMvc2Rzc2VydmljZS5nbw==) | `84.76% <0.00%> (-2.65%)` | :arrow_down: |
| [pilot/pkg/xds/adstest.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlsb3QvcGtnL3hkcy9hZHN0ZXN0Lmdv) | `66.66% <0.00%> (-1.52%)` | :arrow_down: |
| [.../pkg/serviceregistry/kube/controller/controller.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlsb3QvcGtnL3NlcnZpY2VyZWdpc3RyeS9rdWJlL2NvbnRyb2xsZXIvY29udHJvbGxlci5nbw==) | `71.92% <0.00%> (-0.61%)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/517/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org