You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/26 01:05:12 UTC
[GitHub] [spark] ueshin opened a new pull request #33097: [SPARK-35901][PYTHON] Refine type hints in pyspark.pandas.window
ueshin opened a new pull request #33097:
URL: https://github.com/apache/spark/pull/33097
### What changes were proposed in this pull request?
Refines type hints in `pyspark.pandas.window`.
Also, some refactoring is included to clean up the type hierarchy of `Rolling` and `Expanding`.
### Why are the changes needed?
We can use more strict type hints for functions in pyspark.pandas.window using the generic way.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33097: [SPARK-35901][PYTHON] Refine type hints in pyspark.pandas.window
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33097:
URL: https://github.com/apache/spark/pull/33097#issuecomment-869321504
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33097: [SPARK-35901][PYTHON] Refine type hints in pyspark.pandas.window
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33097:
URL: https://github.com/apache/spark/pull/33097#issuecomment-868930350
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44883/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33097: [SPARK-35901][PYTHON] Refine type hints in pyspark.pandas.window
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33097:
URL: https://github.com/apache/spark/pull/33097#issuecomment-868928627
**[Test build #140352 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140352/testReport)** for PR 33097 at commit [`53febc2`](https://github.com/apache/spark/commit/53febc20416506da2877a4e988ddad606859e732).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33097: [SPARK-35901][PYTHON] Refine type hints in pyspark.pandas.window
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33097:
URL: https://github.com/apache/spark/pull/33097#issuecomment-870198591
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140352/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33097: [SPARK-35901][PYTHON] Refine type hints in pyspark.pandas.window
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33097:
URL: https://github.com/apache/spark/pull/33097#issuecomment-868935705
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44883/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33097: [SPARK-35901][PYTHON] Refine type hints in pyspark.pandas.window
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33097:
URL: https://github.com/apache/spark/pull/33097#issuecomment-870198591
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140352/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33097: [SPARK-35901][PYTHON] Refine type hints in pyspark.pandas.window
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33097:
URL: https://github.com/apache/spark/pull/33097#issuecomment-868928627
**[Test build #140352 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140352/testReport)** for PR 33097 at commit [`53febc2`](https://github.com/apache/spark/commit/53febc20416506da2877a4e988ddad606859e732).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33097: [SPARK-35901][PYTHON] Refine type hints in pyspark.pandas.window
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33097:
URL: https://github.com/apache/spark/pull/33097#issuecomment-868934724
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44883/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33097: [SPARK-35901][PYTHON] Refine type hints in pyspark.pandas.window
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33097:
URL: https://github.com/apache/spark/pull/33097#issuecomment-868932228
**[Test build #140352 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140352/testReport)** for PR 33097 at commit [`53febc2`](https://github.com/apache/spark/commit/53febc20416506da2877a4e988ddad606859e732).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class RollingAndExpanding(Generic[T_Frame], metaclass=ABCMeta):`
* `class RollingLike(RollingAndExpanding[T_Frame]):`
* `class Rolling(RollingLike[T_Frame]):`
* `class RollingGroupby(RollingLike[T_Frame]):`
* `class ExpandingLike(RollingAndExpanding[T_Frame]):`
* `class Expanding(ExpandingLike[T_Frame]):`
* `class ExpandingGroupby(ExpandingLike[T_Frame]):`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33097: [SPARK-35901][PYTHON] Refine type hints in pyspark.pandas.window
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33097:
URL: https://github.com/apache/spark/pull/33097#issuecomment-868935705
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44883/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33097: [SPARK-35901][PYTHON] Refine type hints in pyspark.pandas.window
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33097:
URL: https://github.com/apache/spark/pull/33097#issuecomment-870198591
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140352/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33097: [SPARK-35901][PYTHON] Refine type hints in pyspark.pandas.window
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33097:
URL: https://github.com/apache/spark/pull/33097#issuecomment-870198591
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140352/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #33097: [SPARK-35901][PYTHON] Refine type hints in pyspark.pandas.window
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #33097:
URL: https://github.com/apache/spark/pull/33097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org