[GitHub] [incubator-yunikorn-core] wilfred-s commented on a change in pull request #200: [YUNIKORN-375] Use compatible Prometheus client library

[GitBox <gi...@apache.org>]

wilfred-s commented on a change in pull request #200:
URL: https://github.com/apache/incubator-yunikorn-core/pull/200#discussion_r478111135



##########
File path: go.mod
##########
@@ -23,15 +23,17 @@ go 1.12
 
 require (
 	github.com/apache/incubator-yunikorn-scheduler-interface v0.9.1-0.20200827013520-ec2f681ecb5b
+	github.com/beorn7/perks v1.0.1 // indirect
 	github.com/golang/protobuf v1.4.0 // indirect
 	github.com/gorilla/mux v1.7.3
 	github.com/kr/text v0.2.0 // indirect
 	github.com/looplab/fsm v0.1.0
 	github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e // indirect
 	github.com/pkg/errors v0.9.1 // indirect
-	github.com/prometheus/client_golang v1.4.0
+	github.com/prometheus/client_golang v0.9.2

Review comment:
       That is exactly what I was looking at. 0.9.2 is not the latest on the 0.9.x branch either, 0.9.4 is.
   We are downgrading to an almost 2 year old release which has had two updates on top.
   I can understand that we might need to stay at a pre 1.0 release due to breaking changes and k8s or etcd lagging behind but we should be at least at the latest 0.9.x release.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org