You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/03/23 11:29:10 UTC
[PR] Add test for reading back file created with FORMAT options [arrow-datafusion]
alamb opened a new pull request, #9753:
URL: https://github.com/apache/arrow-datafusion/pull/9753
## Which issue does this PR close?
Follow on to https://github.com/apache/arrow-datafusion/pull/9744
## Rationale for this change
The tests in https://github.com/apache/arrow-datafusion/pull/9744 show the syntax works, but doesn't verify that the format is actually used (rather than say, being ignored)
## What changes are included in this PR?
Add a test to write to a file with a non standard extension and then read it back
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
no, tests only
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add test for reading back file created with `COPY ... OPTIONS (FORMAT..)` options [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #9753:
URL: https://github.com/apache/arrow-datafusion/pull/9753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add test for reading back file created with `COPY ... OPTIONS (FORMAT..)` options [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #9753:
URL: https://github.com/apache/arrow-datafusion/pull/9753#issuecomment-2030496965
> Should we phase out this usage at some point, or continue to support both options going forward?
That is a good question. I filed https://github.com/apache/arrow-datafusion/issues/9905 to discuss. I don't have a strong opinion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add test for reading back file created with `COPY ... OPTIONS (FORMAT..)` options [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #9753:
URL: https://github.com/apache/arrow-datafusion/pull/9753#issuecomment-2027352845
@metesynnada here is another small PR with tests that I wonder if you have time to review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org