[GitHub] [incubator-superset] villebro commented on a change in pull request #8305: [SQL Lab] Improve autocomplete

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #8305: [SQL Lab] Improve autocomplete
URL: https://github.com/apache/incubator-superset/pull/8305#discussion_r329295149
 
 

 ##########
 File path: superset/assets/src/SqlLab/components/AceEditorWrapper.jsx
 ##########
 @@ -27,6 +27,11 @@ import { areArraysShallowEqual } from '../../reduxUtils';
 
 const langTools = ace.acequire('ace/ext/language_tools');
 
+const SQL_KEYWORD_AUTOCOMPLETE_SCORE = 100;
+const SCHEMA_AUTOCOMPLETE_SCORE = 60;
+const TABLE_AUTOCOMPLETE_SCORE = 55;
+const COLUMN_AUTOCOMPLETE_SCORE = 50;
 
 Review comment:
   When writing a query, one is probably spending more time autocompleting column names than table/schema names. Wondering if having a higher score for column names wrt schema/table names could result in a better user experience, too?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org