You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/28 15:01:21 UTC

[GitHub] [airflow] GregKarabinos opened a new pull request #17882: Update docker.rst

GregKarabinos opened a new pull request #17882:
URL: https://github.com/apache/airflow/pull/17882


   This didn't work on my 2019 Macbook 16 inch until I ran the Linux section.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17882: Update docker.rst

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17882:
URL: https://github.com/apache/airflow/pull/17882#issuecomment-909382455


   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on a change in pull request #17882: Update docker.rst

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #17882:
URL: https://github.com/apache/airflow/pull/17882#discussion_r697997278



##########
File path: docs/apache-airflow/start/docker.rst
##########
@@ -112,7 +112,7 @@ Initializing Environment
 
 Before starting Airflow for the first time, You need to prepare your environment, i.e. create the necessary files, directories and initialize the database.
 
-On **Linux**, the mounted volumes in container use the native Linux filesystem user/group permissions, so you have to make sure the container and host computer have matching file permissions.
+On **Linux and Mac**, the mounted volumes in container use the native Linux filesystem user/group permissions, so you have to make sure the container and host computer have matching file permissions.

Review comment:
       Right. Then I think this w
   
   ```suggestion
   On **all operating systems**, the quick-start needs to know your host user id and needs to have group id set to 0. You have to make sure to configure them for the docker-compose:
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on pull request #17882: Update docker.rst

Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #17882:
URL: https://github.com/apache/airflow/pull/17882#issuecomment-907689176


   > > Well. Actually the latest docker-compose already has it :)
   > > ```
   > >         if [[ -z "${AIRFLOW_UID}" ]]; then
   > >           echo -e "\033[1;31mERROR!!!: AIRFLOW_UID not set!\e[0m"
   > >           echo "Please follow these instructions to set AIRFLOW_UID and AIRFLOW_GID environment variables:
   > >             https://airflow.apache.org/docs/apache-airflow/stable/start/docker.html#initializing-environment"
   > >           exit 1
   > >         fi
   > > ```
   > 
   > @kaxil - did you use the latest one ?
   
   Yup:
   
   ```
   ❯ docker-compose up airflow-init
   WARNING: The AIRFLOW_UID variable is not set. Defaulting to a blank string.
   WARNING: The AIRFLOW_GID variable is not set. Defaulting to a blank string.
   start_redis_1 is up-to-date
   start_postgres_1 is up-to-date
   Recreating start_airflow-init_1 ... done
   Attaching to start_airflow-init_1
   airflow-init_1       | Traceback (most recent call last):
   airflow-init_1       |   File "/usr/local/lib/python3.9/pathlib.py", line 1313, in mkdir
   airflow-init_1       |     self._accessor.mkdir(self, mode)
   airflow-init_1       | PermissionError: [Errno 13] Permission denied: '/root/airflow'
   airflow-init_1       |
   airflow-init_1       | During handling of the above exception, another exception occurred:
   airflow-init_1       |
   airflow-init_1       | Traceback (most recent call last):
   airflow-init_1       |   File "/usr/local/bin/airflow", line 33, in <module>
   airflow-init_1       |     sys.exit(load_entry_point('apache-airflow', 'console_scripts', 'airflow')())
   airflow-init_1       |   File "/usr/local/bin/airflow", line 25, in importlib_load_entry_point
   airflow-init_1       |     return next(matches).load()
   airflow-init_1       |   File "/usr/local/lib/python3.9/importlib/metadata.py", line 77, in load
   airflow-init_1       |     module = import_module(match.group('module'))
   airflow-init_1       |   File "/usr/local/lib/python3.9/importlib/__init__.py", line 127, in import_module
   airflow-init_1       |     return _bootstrap._gcd_import(name[level:], package, level)
   airflow-init_1       |   File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
   airflow-init_1       |   File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
   airflow-init_1       |   File "<frozen importlib._bootstrap>", line 972, in _find_and_load_unlocked
   airflow-init_1       |   File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
   airflow-init_1       |   File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
   airflow-init_1       |   File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
   airflow-init_1       |   File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
   airflow-init_1       |   File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
   airflow-init_1       |   File "<frozen importlib._bootstrap_external>", line 850, in exec_module
   airflow-init_1       |   File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
   airflow-init_1       |   File "/opt/airflow/airflow/__init__.py", line 34, in <module>
   airflow-init_1       |     from airflow import settings
   airflow-init_1       |   File "/opt/airflow/airflow/settings.py", line 34, in <module>
   airflow-init_1       |     from airflow.configuration import AIRFLOW_HOME, WEBSERVER_CONFIG, conf  # NOQA F401
   airflow-init_1       |   File "/opt/airflow/airflow/configuration.py", line 1114, in <module>
   airflow-init_1       |     conf = initialize_config()
   airflow-init_1       |   File "/opt/airflow/airflow/configuration.py", line 834, in initialize_config
   airflow-init_1       |     pathlib.Path(AIRFLOW_HOME).mkdir(parents=True, exist_ok=True)
   airflow-init_1       |   File "/usr/local/lib/python3.9/pathlib.py", line 1322, in mkdir
   airflow-init_1       |     if not exist_ok or not self.is_dir():
   airflow-init_1       |   File "/usr/local/lib/python3.9/pathlib.py", line 1429, in is_dir
   airflow-init_1       |     return S_ISDIR(self.stat().st_mode)
   airflow-init_1       |   File "/usr/local/lib/python3.9/pathlib.py", line 1222, in stat
   airflow-init_1       |     return self._accessor.stat(self)
   airflow-init_1       | PermissionError: [Errno 13] Permission denied: '/root/airflow'
   airflow-init_1       | ERROR!!!: AIRFLOW_UID not set!
   airflow-init_1       | Please follow these instructions to set AIRFLOW_UID and AIRFLOW_GID environment variables:
   airflow-init_1       |     https://airflow.apache.org/docs/apache-airflow/stable/start/docker.html#initializing-environment
   start_airflow-init_1 exited with code 1
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on pull request #17882: Update docker.rst

Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #17882:
URL: https://github.com/apache/airflow/pull/17882#issuecomment-907683804


   > How come? What errors did you get? This should not be needed in general for Mac.
   
   I can reproduce the error on Mac.
   
   ```
   ❯ docker-compose up airflow-init
   WARNING: The AIRFLOW_UID variable is not set. Defaulting to a blank string.
   WARNING: The AIRFLOW_GID variable is not set. Defaulting to a blank string.
   Creating network "start_default" with the default driver
   Creating volume "start_postgres-db-volume" with default driver
   ERROR: no such image: apache/airflow:|version|: invalid reference format
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #17882: Update docker.rst

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17882:
URL: https://github.com/apache/airflow/pull/17882#issuecomment-907640013


   How come? What errors did you get? This should not be needed in general for Mac.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #17882: Update docker.rst

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17882:
URL: https://github.com/apache/airflow/pull/17882#issuecomment-909382544


   The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil edited a comment on pull request #17882: Update docker.rst

Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #17882:
URL: https://github.com/apache/airflow/pull/17882#issuecomment-907683804


   > How come? What errors did you get? This should not be needed in general for Mac.
   
   I can reproduce the error on Mac.
   
   ```
   ❯ docker-compose up airflow-init
   WARNING: The AIRFLOW_UID variable is not set. Defaulting to a blank string.
   WARNING: The AIRFLOW_GID variable is not set. Defaulting to a blank string.
   Creating network "start_default" with the default driver
   Creating volume "start_postgres-db-volume" with default driver
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #17882: Update docker.rst

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17882:
URL: https://github.com/apache/airflow/pull/17882#issuecomment-909202987


   Merging it with my changes now :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #17882: Update docker.rst

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17882:
URL: https://github.com/apache/airflow/pull/17882#issuecomment-907686010


   Well. Actually the latest docker-compose already has it :) 
   ```
           if [[ -z "${AIRFLOW_UID}" ]]; then
             echo -e "\033[1;31mERROR!!!: AIRFLOW_UID not set!\e[0m"
             echo "Please follow these instructions to set AIRFLOW_UID and AIRFLOW_GID environment variables:
               https://airflow.apache.org/docs/apache-airflow/stable/start/docker.html#initializing-environment"
             exit 1
           fi
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on a change in pull request #17882: Update docker.rst

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #17882:
URL: https://github.com/apache/airflow/pull/17882#discussion_r699294924



##########
File path: docs/apache-airflow/start/docker.rst
##########
@@ -112,7 +112,7 @@ Initializing Environment
 
 Before starting Airflow for the first time, You need to prepare your environment, i.e. create the necessary files, directories and initialize the database.
 
-On **Linux**, the mounted volumes in container use the native Linux filesystem user/group permissions, so you have to make sure the container and host computer have matching file permissions.
+On **all operating systems**, the quick-start needs to know your host user id and needs to have group id set to 0. You have to make sure to configure them for the docker-compose:

Review comment:
       ```suggestion
   On **all operating systems**, the quick-start needs to know your host user id and needs to have group id set to ``0``. You have to make sure to configure them for the docker-compose:
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on a change in pull request #17882: Update docker.rst

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #17882:
URL: https://github.com/apache/airflow/pull/17882#discussion_r699294924



##########
File path: docs/apache-airflow/start/docker.rst
##########
@@ -112,7 +112,7 @@ Initializing Environment
 
 Before starting Airflow for the first time, You need to prepare your environment, i.e. create the necessary files, directories and initialize the database.
 
-On **Linux**, the mounted volumes in container use the native Linux filesystem user/group permissions, so you have to make sure the container and host computer have matching file permissions.
+On **all operating systems**, the quick-start needs to know your host user id and needs to have group id set to 0. You have to make sure to configure them for the docker-compose:

Review comment:
       ```suggestion
   On **all operating systems**, the quick-start needs to know your host user id and needs to have group id set to ``0``. You have to make sure to configure them for the docker-compose:
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #17882: Update docker.rst

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17882:
URL: https://github.com/apache/airflow/pull/17882#issuecomment-907685596


   I see... Actually we should then likely FAIL the whole thing if they are not set :). Even if is not strictly needed, It might reduce the "VARIABILITY" and will better "guide" the users to follow the exact 'quick-start steps". I will merge that one an add error in this 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on a change in pull request #17882: Update docker.rst

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #17882:
URL: https://github.com/apache/airflow/pull/17882#discussion_r697997356



##########
File path: docs/apache-airflow/start/docker.rst
##########
@@ -112,7 +112,7 @@ Initializing Environment
 
 Before starting Airflow for the first time, You need to prepare your environment, i.e. create the necessary files, directories and initialize the database.
 
-On **Linux**, the mounted volumes in container use the native Linux filesystem user/group permissions, so you have to make sure the container and host computer have matching file permissions.
+On **Linux and Mac**, the mounted volumes in container use the native Linux filesystem user/group permissions, so you have to make sure the container and host computer have matching file permissions.

Review comment:
       This one reflects better the current state then :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #17882: Update docker.rst

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17882:
URL: https://github.com/apache/airflow/pull/17882#issuecomment-909202987


   Merging it with my changes now :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #17882: Update docker.rst

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17882:
URL: https://github.com/apache/airflow/pull/17882#issuecomment-909202987


   Merging it with my changes now :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17882: Update docker.rst

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17882:
URL: https://github.com/apache/airflow/pull/17882#issuecomment-909382455


   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #17882: Update docker.rst

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17882:
URL: https://github.com/apache/airflow/pull/17882#issuecomment-909382544


   The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk merged pull request #17882: Update docker.rst

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17882:
URL: https://github.com/apache/airflow/pull/17882


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #17882: Update docker.rst

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17882:
URL: https://github.com/apache/airflow/pull/17882#issuecomment-907686142


   > Well. Actually the latest docker-compose already has it :)
   > 
   > ```
   >         if [[ -z "${AIRFLOW_UID}" ]]; then
   >           echo -e "\033[1;31mERROR!!!: AIRFLOW_UID not set!\e[0m"
   >           echo "Please follow these instructions to set AIRFLOW_UID and AIRFLOW_GID environment variables:
   >             https://airflow.apache.org/docs/apache-airflow/stable/start/docker.html#initializing-environment"
   >           exit 1
   >         fi
   > ```
   
   @kaxil  - did you use the latest one ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on a change in pull request #17882: Update docker.rst

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #17882:
URL: https://github.com/apache/airflow/pull/17882#discussion_r699294924



##########
File path: docs/apache-airflow/start/docker.rst
##########
@@ -112,7 +112,7 @@ Initializing Environment
 
 Before starting Airflow for the first time, You need to prepare your environment, i.e. create the necessary files, directories and initialize the database.
 
-On **Linux**, the mounted volumes in container use the native Linux filesystem user/group permissions, so you have to make sure the container and host computer have matching file permissions.
+On **all operating systems**, the quick-start needs to know your host user id and needs to have group id set to 0. You have to make sure to configure them for the docker-compose:

Review comment:
       ```suggestion
   On **all operating systems**, the quick-start needs to know your host user id and needs to have group id set to ``0``. You have to make sure to configure them for the docker-compose:
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk merged pull request #17882: Update docker.rst

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17882:
URL: https://github.com/apache/airflow/pull/17882


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17882: Update docker.rst

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17882:
URL: https://github.com/apache/airflow/pull/17882#issuecomment-907638449


   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
   Apache Airflow is a community-driven project and together we are making it better 🚀.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org