[GitHub] [iceberg] rdblue commented on a diff in pull request #4941: Core: Use Table Partitioning sort with manual Sort Order in Rewrite Data Files

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #4941:
URL: https://github.com/apache/iceberg/pull/4941#discussion_r916063285


##########
core/src/main/java/org/apache/iceberg/actions/SortStrategy.java:
##########
@@ -48,7 +49,7 @@ public abstract class SortStrategy extends BinPackStrategy {
    * @return this for method chaining
    */
   public SortStrategy sortOrder(SortOrder order) {
-    this.sortOrder = order;
+    this.sortOrder = SortOrderUtil.buildSortOrder(table(), order);

Review Comment:
   Yes, this does happen. We can technically suppress the second occurrence of `X`, but it seems minor to me since it is just going to make the sort use a bit more data. I think this is something that we can clean up in `buildSortOrder` in the future, after this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org