[jira] [Commented] (SHINDIG-1920) Don't force cache time-to-lives on responses with an error status

["Stanton Sievers (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13672506#comment-13672506 ] 

Stanton Sievers commented on SHINDIG-1920:
------------------------------------------

https://reviews.apache.org/r/11584/
                
> Don't force cache time-to-lives on responses with an error status
> -----------------------------------------------------------------
>
>                 Key: SHINDIG-1920
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1920
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 2.5.0-beta6
>            Reporter: Stanton Sievers
>            Assignee: Stanton Sievers
>             Fix For: 2.5.0
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> org.apache.shindig.gadgets.DefaultGadgetSpecFactory and org.apache.shindig.gadgets.DefaultMessageBundleFactory utilize a property in shindig.properties (shindig.cache.xml.refreshInterval) to force the RequestPipeline/Fetcher layer to cache specs and message bundles for a set amount of time, regardless of the cache headers on the response.  This also forces the cache ttl in the case that the response is an error instead of using the "shindig.cache.http.negativeCacheTtl" value in shindig.properties, which defaults to one minute.
> I'd rather we always use the negativeCacheTtl in this case and ignore the forced cache ttl

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira