You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/08 07:20:15 UTC

[GitHub] [spark] MaxGekk commented on pull request #29972: [SPARK-33081][SQL] Support ALTER TABLE in JDBC v2 Table Catalog: update type and nullability of columns (DB2 dialect)

MaxGekk commented on pull request #29972:
URL: https://github.com/apache/spark/pull/29972#issuecomment-705382761


   > For example, DB2 doesn't have a STRING type. It uses CHAR and VARCHAR.
   
   You could define a type in the common trait like `StrType`, and override in the Oracle and DB2 test suites.
   
   > Oracle allows update column data type from INTEGER to STRING, but DB2 doesn't allow update column data type from INTEGER to VARCHAR.
   
   ohh, I think we can remove such checks because:
   - I don't see any reasons to test DBMS behavior in Spark's tests
   - The checks doesn't improve test coverage. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org