You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/12/20 16:00:00 UTC
[jira] [Commented] (WW-4995) Enhancement for s:set tag to improve
tag body whitespace control.
[ https://issues.apache.org/jira/browse/WW-4995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725970#comment-16725970 ]
ASF subversion and git services commented on WW-4995:
-----------------------------------------------------
Commit 6f176cc5a7ee90efe9b3dfbe477d18c2245ea583 in struts's branch refs/heads/struts-2-5-x from JCgH4164838Gh792C124B5
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=6f176cc ]
Enhancement for s:set tag for 2.5.x to allow better tag body whitespace control. (#296)
WW-4995 Add trimBody attribute to set tag
> Enhancement for s:set tag to improve tag body whitespace control.
> -----------------------------------------------------------------
>
> Key: WW-4995
> URL: https://issues.apache.org/jira/browse/WW-4995
> Project: Struts 2
> Issue Type: Improvement
> Components: Core Tags
> Affects Versions: 2.5.18
> Environment: All environments.
> Reporter: James Chaplin
> Priority: Minor
> Labels: pull-request-available
> Fix For: 2.5.19
>
>
> Hello Apache Struts Team.
> The current s:set tag performs an automatic _trim()_ on any body content used (when using the <s:set>something</s:set> style with a body).
> The current behaviour limits white-space control for the text body passed to the s:set tag (and makes assigning a single-or-muliple-character whitespace set - e.g. " " impossible via the tag body)..
> A proposed improvement is to introduce two optional attributes to the s:set tag which will permit the following:
> * Allow an override to prevent the trim() from happening (helps to preserve existing whitespace)..
> * Allow the optional removal of all line-breaks from the tag body content (to allow vertical collapsing of tag body content without impacting anything else).
> There is a PR available with a proposed implementation for the enhancement. I believe having this additional flexibility will be beneficial for some JSP content generation scenarios.
> Please review and advise if this minor enhancement can be considered for inclusion in 2.5.19 (and then ported forward for 2.6).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)