[jira] [Commented] (OFBIZ-11167) Use Codenarc to test Groovy code

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17711426#comment-17711426 ] 

ASF subversion and git services commented on OFBIZ-11167:
---------------------------------------------------------

Commit 5d2301637f0f48ccdcdc4ad412698485c81fd39d in ofbiz-framework's branch refs/heads/trunk from Gil Portenseigne
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=5d2301637f ]

Codenarc integration rebased (#618)

Implemented : Use Codenarc to test Groovy code (OFBIZ-11167)

Add gradle Codenarc plugin integration with a set of rules to be checked.

Every groovy files of ofbiz-framework where checked and fixed to comply with the
rules.

Codenarc plugin configuration includes max priority violation threshold for the
three levels, to allow the build to pass with plugins that were not fixed
regarding the configured codenarc rules.

Many Thanks to Daniel Watford, Jacques Le Roux for the code review organisation
and for the review
Thanks to Nicolas Malin and Leila Mekika for their review.



> Use Codenarc to test Groovy code
> --------------------------------
>
>                 Key: OFBIZ-11167
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11167
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: framework
>            Reporter: Jacques Le Roux
>            Assignee: Gil Portenseigne
>            Priority: Minor
>         Attachments: OFBIZ-11167.patch, main.html, test.html
>
>
> Thread of community discussion about the rules to implement : https://www.mail-archive.com/search?l=dev%40ofbiz.apache.org&q=subject:%22Codenarc+integration%2C+rules+to+use.%22&o=newest&f=1
>  
> Now that we use Groovy more and more, I think we should really have a look a Codenarc
> [https://docs.gradle.org/current/userguide/codenarc_plugin.html]
> We already discussed it at [https://markmail.org/message/uigcpnxqgizhd2oi] and [https://markmail.org/message/rp6njoiohkkiodbe]
> We know it's a crucial task but not an easy but rather a long term one
> Here are some interesting links (before I delete my FF tabs group about it)
> [http://codenarc.sourceforge.net/codenarc-other-tools-frameworks.html]
> [http://codenarc.sourceforge.net/codenarc-creating-ruleset.html]
> [https://github.com/gradle/gradle/tree/master/config]
> [https://stackoverflow.com/questions/14358471/how-to-generate-codenarc-report-for-main-and-test-classes-using-different-rule-s]
> [https://mrhaki.blogspot.com/2011/01/gradle-goodness-use-groovy-ruleset-file.html]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)