Re: [PR] [SPARK-46958][SQL] Add missing timezone to coerce default values [spark]

["yaooqinn (via GitHub)" <gi...@apache.org>]

yaooqinn commented on code in PR #45000:
URL: https://github.com/apache/spark/pull/45000#discussion_r1477172195


##########
sql/core/src/test/scala/org/apache/spark/sql/ResolveDefaultColumnsSuite.scala:
##########
@@ -182,14 +182,14 @@ class ResolveDefaultColumnsSuite extends QueryTest with SharedSparkSession {
             "actualType" -> "\"STRING\""))
         checkError(
           exception = intercept[AnalysisException] {
-            sql("create table demos.test_ts_other (a timestamp default '2022-01-02') using parquet")

Review Comment:
   The original test seems incorrect as the expression `a timestamp default '2022-01-02'` is actually valid, which meets the requirement of fitting within the narrower typ



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org