You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/08 09:07:30 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #12521: [FLINK-18152][Depl] Fail fast in JM scripts if memory configuration failed
tillrohrmann commented on a change in pull request #12521:
URL: https://github.com/apache/flink/pull/12521#discussion_r436553652
##########
File path: flink-dist/src/main/flink-bin/bin/standalone-job.sh
##########
@@ -40,6 +40,10 @@ if [[ $STARTSTOP == "start" ]] || [[ $STARTSTOP == "start-foreground" ]]; then
# Add cluster entry point specific JVM options
export FLINK_ENV_JAVA_OPTS="${FLINK_ENV_JAVA_OPTS} ${FLINK_ENV_JAVA_OPTS_JM}"
parseJmJvmArgsAndExportLogs "${ARGS[@]}"
+ if [[ $? -ne 0 ]]; then
+ echo "[ERROR] Could not get JVM parameters and dynamic configurations properly."
+ exit 1
+ fi
Review comment:
Same here.
##########
File path: flink-dist/src/main/flink-bin/bin/jobmanager.sh
##########
@@ -40,6 +40,10 @@ if [[ $STARTSTOP == "start" ]] || [[ $STARTSTOP == "start-foreground" ]]; then
# Add JobManager-specific JVM options
export FLINK_ENV_JAVA_OPTS="${FLINK_ENV_JAVA_OPTS} ${FLINK_ENV_JAVA_OPTS_JM}"
parseJmJvmArgsAndExportLogs "${ARGS[@]}"
+ if [[ $? -ne 0 ]]; then
+ echo "[ERROR] Could not get JVM parameters and dynamic configurations properly."
+ exit 1
+ fi
Review comment:
Isn't this a bit redundant given that we do the check in `parseJmJvmArgsAndExportLogs`?
##########
File path: flink-dist/src/main/flink-bin/mesos-bin/mesos-jobmanager.sh
##########
@@ -27,6 +27,10 @@ bin=$(cd "${bin}" || exit; pwd)
. "${bin}"/config.sh
parseJmJvmArgsAndExportLogs "${ARGS[@]}"
+if [[ $? -ne 0 ]]; then
+ echo "[ERROR] Could not get JVM parameters and dynamic configurations properly."
+ exit 1
+fi
Review comment:
And here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org