You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@any23.apache.org by lewismc <gi...@git.apache.org> on 2018/08/25 18:08:51 UTC
[GitHub] any23 pull request #120: ANY23-393 Any23 master to build under JDK 10.X
GitHub user lewismc opened a pull request:
https://github.com/apache/any23/pull/120
ANY23-393 Any23 master to build under JDK 10.X
Issue addresses build under following environment
```
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T11:33:14-07:00)
Maven home: /usr/local/Cellar/maven/3.5.4/libexec
Java version: 10.0.2, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk-10.0.2.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "Mac"
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lewismc/any23 ANY23-393
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/any23/pull/120.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #120
----
commit 537c6e4d2594de8cdcc3cd68862eb2efed9232c0
Author: Lewis John McGibbney <le...@...>
Date: 2018-08-25T18:07:53Z
ANY23-393 Any23 master to build under JDK 10.X
----
---
[GitHub] any23 issue #120: ANY23-393 Any23 master to build under JDK 10.X
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/120
@HansBrende thanks for review, from what I remember, this is not packaged with Tomcat9 anymore, which is what users should be using to deploy the Any23 WAR.
---
[GitHub] any23 issue #120: ANY23-393 Any23 master to build under JDK 10.X
Posted by HansBrende <gi...@git.apache.org>.
Github user HansBrende commented on the issue:
https://github.com/apache/any23/pull/120
@lewismc +1. Just out of curiosity, what is the new `javax.xml.bind:jaxb-api` dependency for?
---
[GitHub] any23 issue #120: ANY23-393 Any23 master to build under JDK 10.X
Posted by jgrzebyta <gi...@git.apache.org>.
Github user jgrzebyta commented on the issue:
https://github.com/apache/any23/pull/120
@lewismc Thanks. For me it's ok.
---
[GitHub] any23 issue #120: ANY23-393 Any23 master to build under JDK 10.X
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/120
@jgrzebyta good question.
I previously used JDK 8 and Any23 was building absolutely fine. I experienced no issues.
When I upgraded, the issues started... hence this PR.
---
[GitHub] any23 issue #120: ANY23-393 Any23 master to build under JDK 10.X
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/120
Any comments folks?
---
[GitHub] any23 issue #120: ANY23-393 Any23 master to build under JDK 10.X
Posted by jgrzebyta <gi...@git.apache.org>.
Github user jgrzebyta commented on the issue:
https://github.com/apache/any23/pull/120
@lewismc What about java-8? Will java-10 binary be the official one?
---
[GitHub] any23 pull request #120: ANY23-393 Any23 master to build under JDK 10.X
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/any23/pull/120
---