You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2021/05/18 21:02:55 UTC
[GitHub] [thrift] elludraon opened a new pull request #2394: THRIFT-5417: Fix Lua compiler omitting default values in Lua service functions
elludraon opened a new pull request #2394:
URL: https://github.com/apache/thrift/pull/2394
<!-- Explain the changes in the pull request below: -->
Add missing default argument values for service client functions in generated Lua code.
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but preferred)
- [ ] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2394: THRIFT-5417: Fix Lua compiler omitting default values in Lua service functions
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2394:
URL: https://github.com/apache/thrift/pull/2394#issuecomment-845458015
> ... how to solve this?
We have a mailing list. Actually we have two mailing lists. I'd recommend to ask there, it seems too offtopic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] elludraon removed a comment on pull request #2394: THRIFT-5417: Fix Lua compiler omitting default values in Lua service functions
Posted by GitBox <gi...@apache.org>.
elludraon removed a comment on pull request #2394:
URL: https://github.com/apache/thrift/pull/2394#issuecomment-845462620
@Jens-G - Can you merge this? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] huzhao37 commented on pull request #2394: THRIFT-5417: Fix Lua compiler omitting default values in Lua service functions
Posted by GitBox <gi...@apache.org>.
huzhao37 commented on pull request #2394:
URL: https://github.com/apache/thrift/pull/2394#issuecomment-844876600
当我使用Compact协议编解码复杂结构体时，调用初始化，给其中一个简单的string类型赋值，然后编码，得到buffer，再解码，发现string类型的字段的值没有了，如果把复杂结构体里的其他复杂字段初始化，就不会有这个问题，这个怎么解决呢？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] elludraon commented on pull request #2394: THRIFT-5417: Fix Lua compiler omitting default values in Lua service functions
Posted by GitBox <gi...@apache.org>.
elludraon commented on pull request #2394:
URL: https://github.com/apache/thrift/pull/2394#issuecomment-845462620
@Jens-G - Can you merge this? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] huzhao37 edited a comment on pull request #2394: THRIFT-5417: Fix Lua compiler omitting default values in Lua service functions
Posted by GitBox <gi...@apache.org>.
huzhao37 edited a comment on pull request #2394:
URL: https://github.com/apache/thrift/pull/2394#issuecomment-844876600
When I use Compact protocol to codec complex structures, I call initialize, assign a value to one of the simple string types, then encode, get buffer, and then decode, I find that the value of the field of string type is missing, if I initialize other complex fields in the complex structure, I won't have this problem, how to solve this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2394: THRIFT-5417: Fix Lua compiler omitting default values in Lua service functions
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2394:
URL: https://github.com/apache/thrift/pull/2394#issuecomment-843803877
That's the case for a lot of them, not just Lua. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G closed pull request #2394: THRIFT-5417: Fix Lua compiler omitting default values in Lua service functions
Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2394:
URL: https://github.com/apache/thrift/pull/2394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org