You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by bryancall <gi...@git.apache.org> on 2016/08/30 21:58:50 UTC
[GitHub] trafficserver pull request #946: TS-4767: Add warning for Linux AIO build op...
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/946
TS-4767: Add warning for Linux AIO build option
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4767
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/946.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #946
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #946: TS-4767: Add warning for Linux AIO build option
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/946
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/646/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #946: TS-4767: Add warning for Linux AIO build option
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/946
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/649/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #946: TS-4767: Add warning for Linux AIO build option
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/946
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/542/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #946: TS-4767: Add warning for Linux AIO build op...
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/946
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #946: TS-4767: Add warning for Linux AIO build option
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/946
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/620/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #946: TS-4767: Add warning for Linux AIO build option
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/946
@jpeach
I don't think it is necessary to give a warning when running configure since the user has to give the option to add Linux AIO support with experimental in the name (--enable-linux-native-aio-EXPERIMENTAL).
I did add a warning in traffic_sever is a good idea and it has been added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #946: TS-4767: Add warning for Linux AIO build option
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/946
\U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #946: TS-4767: Add warning for Linux AIO build option
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/946
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/648/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #946: TS-4767: Add warning for Linux AIO build option
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/946
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/647/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #946: TS-4767: Add warning for Linux AIO build option
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/946
I think the message would be more legible with ``AC_MSG_WARN``. For example:
```
AS_IF([test "x$enable_linux_native_aio" = "xyes"], [
AC_MSG_WARN([Linux AIO will burn down your house])
...
```
Also, should we log a warning on startup?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #946: TS-4767: Add warning for Linux AIO build op...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/946#discussion_r77069088
--- Diff: configure.ac ---
@@ -1293,13 +1293,13 @@ AS_IF([test "x$enable_posix_cap" != "xno"],
AC_SUBST(use_posix_cap)
#
-# If the OS is linux, we can use the '--enable-linux-native-aio' option to
+# If the OS is linux, we can use the '--enable-linux-native-aio-EXPERIMENTAL' option to
# replace the aio thread mode. Effective only on the linux system.
#
AC_MSG_CHECKING([whether to enable Linux native AIO])
-AC_ARG_ENABLE([linux-native-aio],
- [AS_HELP_STRING([--enable-linux-native-aio], [enable native Linux AIO support @<:@default=no@:>@])],
+AC_ARG_ENABLE([linux-native-aio-EXPERIMENTAL],
--- End diff --
I'm ok with this, but it seems a little "loud" :-). Maybe just
--enable-experimental-linux-native-aio
This will still disable this for those package managers that have been using the old configure option.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #946: TS-4767: Add warning for Linux AIO build option
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/946
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/543/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #946: TS-4767: Add warning for Linux AIO build option
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/946
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/544/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #946: TS-4767: Add warning for Linux AIO build option
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/946
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/724/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---