You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Vyacheslav Koptilin (Jira)" <ji...@apache.org> on 2021/07/30 09:27:00 UTC
[jira] [Commented] (IGNITE-15210) @AfterEach and @BeforeEach must
not be private
[ https://issues.apache.org/jira/browse/IGNITE-15210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390444#comment-17390444 ]
Vyacheslav Koptilin commented on IGNITE-15210:
----------------------------------------------
Hello [~alapin],
Thanks for the catch! The patch looks good to me.
> @AfterEach and @BeforeEach must not be private
> ----------------------------------------------
>
> Key: IGNITE-15210
> URL: https://issues.apache.org/jira/browse/IGNITE-15210
> Project: Ignite
> Issue Type: Bug
> Reporter: Alexander Lapin
> Assignee: Alexander Lapin
> Priority: Blocker
> Labels: ignite-3
> Fix For: 3.0.0-alpha3
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> According to [https://junit.org/junit5/docs/5.0.0/api/org/junit/jupiter/api/BeforeEach.html] and [https://junit.org/junit5/docs/5.0.0/api/org/junit/jupiter/api/AfterEach.html|https://junit.org/junit5/docs/5.0.0/api/org/junit/jupiter/api/BeforeEach.html] both setUp and tearDown methods must not be private, however they are in some cases in our code.
> Despite the fact that private seems to work fine, it's still better to follow documentation recommendations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)