[GitHub] [superset] hughhhh commented on a diff in pull request #23356: fix: table schema permissions

["hughhhh (via GitHub)" <gi...@apache.org>]

hughhhh commented on code in PR #23356:
URL: https://github.com/apache/superset/pull/23356#discussion_r1136090137


##########
superset/security/manager.py:
##########
@@ -1823,8 +1823,14 @@ def raise_for_access(
                 return
 
             if query:
+                # if no schema is specified, use the database default; in the future we
+                # should pass the query schema to the SQLAlchemy URI so that it's set as
+                # the default one.
+                with database.get_sqla_engine_with_context() as engine:

Review Comment:
   use inspect with context:
   https://github.com/apache/superset/blob/75899cbe2475c7fc34aff91bb332e703b5dbadd9/superset/models/core.py#L687
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org