[GitHub] [spark] grundprinzip commented on a diff in pull request #42009: [SPARK-44422][CONNECT] Spark Connect fine grained interrupt

["grundprinzip (via GitHub)" <gi...@apache.org>]

grundprinzip commented on code in PR #42009:
URL: https://github.com/apache/spark/pull/42009#discussion_r1266441534


##########
connector/connect/common/src/main/protobuf/spark/connect/base.proto:
##########
@@ -616,13 +632,31 @@ message InterruptRequest {
   enum InterruptType {
     INTERRUPT_TYPE_UNSPECIFIED = 0;
 
-    // Interrupt all running executions within session with provided session_id.
+    // Interrupt all running executions within the session with the provided session_id.
     INTERRUPT_TYPE_ALL = 1;
+
+    // Interrupt all running executions within the session with the provided operation_tag.
+    INTERRUPT_TYPE_TAG = 2;
+
+    // Interrupt the running execution within the session with the provided operation_id.
+    INTERRUPT_TYPE_ID = 3;

Review Comment:
   INTERRUPT_TYPE_OP_ID?



##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/ExecuteHolder.scala:
##########
@@ -86,4 +94,24 @@ private[connect] class ExecuteHolder(
   def interrupt(): Unit = {
     runner.interrupt()
   }
+
+  def tagToSparkJobTag(tag: String): String = {

Review Comment:
   Doc on what this is used for?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org