You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/03/01 11:39:32 UTC

[GitHub] [accumulo] slackwinner commented on a change in pull request #1910: Adding JShell Accumulo Feature

slackwinner commented on a change in pull request #1910:
URL: https://github.com/apache/accumulo/pull/1910#discussion_r584643716



##########
File path: assemble/bin/accumulo
##########
@@ -58,6 +58,18 @@ function main() {
     echo "$CLASSPATH"
     exit 0
   fi
+  
+  # Set up path variable for default import config file
+  export jShellPath="$conf/jshell-init.jsh"
+  

Review comment:
       @ctubbsii Thank you for the helpful improvements/suggestions. This code review is helping me understand bash scripting in general. I'll apply these improvements and push a revised copy soon. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org