You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by st...@apache.org on 2013/12/02 15:46:11 UTC
svn commit: r1547035 - /subversion/trunk/subversion/tests/svn_test_main.c
Author: stefan2
Date: Mon Dec 2 14:46:11 2013
New Revision: 1547035
URL: http://svn.apache.org/r1547035
Log:
* subversion/tests/svn_test_main.c
(main): Allow for testing compatibility with 1.7 and 1.8.
Modified:
subversion/trunk/subversion/tests/svn_test_main.c
Modified: subversion/trunk/subversion/tests/svn_test_main.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/svn_test_main.c?rev=1547035&r1=1547034&r2=1547035&view=diff
==============================================================================
--- subversion/trunk/subversion/tests/svn_test_main.c (original)
+++ subversion/trunk/subversion/tests/svn_test_main.c Mon Dec 2 14:46:11 2013
@@ -788,7 +788,7 @@ main(int argc, const char *argv[])
exit(1);
}
if ((opts.server_minor_version < 3)
- || (opts.server_minor_version > 6))
+ || (opts.server_minor_version > 8))
{
fprintf(stderr, "FAIL: Invalid minor version given\n");
exit(1);
Re: svn commit: r1547035 - /subversion/trunk/subversion/tests/svn_test_main.c
Posted by Stefan Fuhrmann <st...@wandisco.com>.
On Mon, Jan 20, 2014 at 10:08 PM, Ben Reser <be...@reser.org> wrote:
> On 1/20/14, 1:05 PM, Ben Reser wrote:
> > On 12/2/13, 6:46 AM, stefan2@apache.org wrote:
> >> Author: stefan2
> >> Date: Mon Dec 2 14:46:11 2013
> >> New Revision: 1547035
> >>
> >> URL: http://svn.apache.org/r1547035
> >> Log:
> >> * subversion/tests/svn_test_main.c
> >> (main): Allow for testing compatibility with 1.7 and 1.8.
> >>
> >> Modified:
> >> subversion/trunk/subversion/tests/svn_test_main.c
> >>
> >> Modified: subversion/trunk/subversion/tests/svn_test_main.c
> >> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/svn_test_main.c?rev=1547035&r1=1547034&r2=1547035&view=diff
> >>
> ==============================================================================
> >> --- subversion/trunk/subversion/tests/svn_test_main.c (original)
> >> +++ subversion/trunk/subversion/tests/svn_test_main.c Mon Dec 2
> 14:46:11 2013
> >> @@ -788,7 +788,7 @@ main(int argc, const char *argv[])
> >> exit(1);
> >> }
> >> if ((opts.server_minor_version < 3)
> >> - || (opts.server_minor_version > 6))
> >> + || (opts.server_minor_version > 8))
> >
> > Shouldn't this be opts.server_minor_version >= SVN_VER_MINOR so we don't
> have
> > to remember to update this everytime? Doesn't help if we change the
> major, but
> > the code already has that issue.
>
> I guess there was a following in r1547035 that would have made it >
> SVN_VER_MINOR.
>
> Good point. Fixed in r1559869.
-- Stefan^2.
Re: svn commit: r1547035 - /subversion/trunk/subversion/tests/svn_test_main.c
Posted by Stefan Fuhrmann <st...@wandisco.com>.
On Mon, Jan 20, 2014 at 10:08 PM, Ben Reser <be...@reser.org> wrote:
> On 1/20/14, 1:05 PM, Ben Reser wrote:
> > On 12/2/13, 6:46 AM, stefan2@apache.org wrote:
> >> Author: stefan2
> >> Date: Mon Dec 2 14:46:11 2013
> >> New Revision: 1547035
> >>
> >> URL: http://svn.apache.org/r1547035
> >> Log:
> >> * subversion/tests/svn_test_main.c
> >> (main): Allow for testing compatibility with 1.7 and 1.8.
> >>
> >> Modified:
> >> subversion/trunk/subversion/tests/svn_test_main.c
> >>
> >> Modified: subversion/trunk/subversion/tests/svn_test_main.c
> >> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/svn_test_main.c?rev=1547035&r1=1547034&r2=1547035&view=diff
> >>
> ==============================================================================
> >> --- subversion/trunk/subversion/tests/svn_test_main.c (original)
> >> +++ subversion/trunk/subversion/tests/svn_test_main.c Mon Dec 2
> 14:46:11 2013
> >> @@ -788,7 +788,7 @@ main(int argc, const char *argv[])
> >> exit(1);
> >> }
> >> if ((opts.server_minor_version < 3)
> >> - || (opts.server_minor_version > 6))
> >> + || (opts.server_minor_version > 8))
> >
> > Shouldn't this be opts.server_minor_version >= SVN_VER_MINOR so we don't
> have
> > to remember to update this everytime? Doesn't help if we change the
> major, but
> > the code already has that issue.
>
> I guess there was a following in r1547035 that would have made it >
> SVN_VER_MINOR.
>
> Good point. Fixed in r1559869.
-- Stefan^2.
Re: svn commit: r1547035 - /subversion/trunk/subversion/tests/svn_test_main.c
Posted by Ben Reser <be...@reser.org>.
On 1/20/14, 1:05 PM, Ben Reser wrote:
> On 12/2/13, 6:46 AM, stefan2@apache.org wrote:
>> Author: stefan2
>> Date: Mon Dec 2 14:46:11 2013
>> New Revision: 1547035
>>
>> URL: http://svn.apache.org/r1547035
>> Log:
>> * subversion/tests/svn_test_main.c
>> (main): Allow for testing compatibility with 1.7 and 1.8.
>>
>> Modified:
>> subversion/trunk/subversion/tests/svn_test_main.c
>>
>> Modified: subversion/trunk/subversion/tests/svn_test_main.c
>> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/svn_test_main.c?rev=1547035&r1=1547034&r2=1547035&view=diff
>> ==============================================================================
>> --- subversion/trunk/subversion/tests/svn_test_main.c (original)
>> +++ subversion/trunk/subversion/tests/svn_test_main.c Mon Dec 2 14:46:11 2013
>> @@ -788,7 +788,7 @@ main(int argc, const char *argv[])
>> exit(1);
>> }
>> if ((opts.server_minor_version < 3)
>> - || (opts.server_minor_version > 6))
>> + || (opts.server_minor_version > 8))
>
> Shouldn't this be opts.server_minor_version >= SVN_VER_MINOR so we don't have
> to remember to update this everytime? Doesn't help if we change the major, but
> the code already has that issue.
I guess there was a following in r1547035 that would have made it > SVN_VER_MINOR.
Re: svn commit: r1547035 - /subversion/trunk/subversion/tests/svn_test_main.c
Posted by Ben Reser <be...@reser.org>.
On 1/20/14, 1:05 PM, Ben Reser wrote:
> On 12/2/13, 6:46 AM, stefan2@apache.org wrote:
>> Author: stefan2
>> Date: Mon Dec 2 14:46:11 2013
>> New Revision: 1547035
>>
>> URL: http://svn.apache.org/r1547035
>> Log:
>> * subversion/tests/svn_test_main.c
>> (main): Allow for testing compatibility with 1.7 and 1.8.
>>
>> Modified:
>> subversion/trunk/subversion/tests/svn_test_main.c
>>
>> Modified: subversion/trunk/subversion/tests/svn_test_main.c
>> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/svn_test_main.c?rev=1547035&r1=1547034&r2=1547035&view=diff
>> ==============================================================================
>> --- subversion/trunk/subversion/tests/svn_test_main.c (original)
>> +++ subversion/trunk/subversion/tests/svn_test_main.c Mon Dec 2 14:46:11 2013
>> @@ -788,7 +788,7 @@ main(int argc, const char *argv[])
>> exit(1);
>> }
>> if ((opts.server_minor_version < 3)
>> - || (opts.server_minor_version > 6))
>> + || (opts.server_minor_version > 8))
>
> Shouldn't this be opts.server_minor_version >= SVN_VER_MINOR so we don't have
> to remember to update this everytime? Doesn't help if we change the major, but
> the code already has that issue.
I guess there was a following in r1547035 that would have made it > SVN_VER_MINOR.
Re: svn commit: r1547035 - /subversion/trunk/subversion/tests/svn_test_main.c
Posted by Ben Reser <be...@reser.org>.
On 12/2/13, 6:46 AM, stefan2@apache.org wrote:
> Author: stefan2
> Date: Mon Dec 2 14:46:11 2013
> New Revision: 1547035
>
> URL: http://svn.apache.org/r1547035
> Log:
> * subversion/tests/svn_test_main.c
> (main): Allow for testing compatibility with 1.7 and 1.8.
>
> Modified:
> subversion/trunk/subversion/tests/svn_test_main.c
>
> Modified: subversion/trunk/subversion/tests/svn_test_main.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/svn_test_main.c?rev=1547035&r1=1547034&r2=1547035&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/tests/svn_test_main.c (original)
> +++ subversion/trunk/subversion/tests/svn_test_main.c Mon Dec 2 14:46:11 2013
> @@ -788,7 +788,7 @@ main(int argc, const char *argv[])
> exit(1);
> }
> if ((opts.server_minor_version < 3)
> - || (opts.server_minor_version > 6))
> + || (opts.server_minor_version > 8))
Shouldn't this be opts.server_minor_version >= SVN_VER_MINOR so we don't have
to remember to update this everytime? Doesn't help if we change the major, but
the code already has that issue.
Re: svn commit: r1547035 - /subversion/trunk/subversion/tests/svn_test_main.c
Posted by Ben Reser <be...@reser.org>.
On 12/2/13, 6:46 AM, stefan2@apache.org wrote:
> Author: stefan2
> Date: Mon Dec 2 14:46:11 2013
> New Revision: 1547035
>
> URL: http://svn.apache.org/r1547035
> Log:
> * subversion/tests/svn_test_main.c
> (main): Allow for testing compatibility with 1.7 and 1.8.
>
> Modified:
> subversion/trunk/subversion/tests/svn_test_main.c
>
> Modified: subversion/trunk/subversion/tests/svn_test_main.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/svn_test_main.c?rev=1547035&r1=1547034&r2=1547035&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/tests/svn_test_main.c (original)
> +++ subversion/trunk/subversion/tests/svn_test_main.c Mon Dec 2 14:46:11 2013
> @@ -788,7 +788,7 @@ main(int argc, const char *argv[])
> exit(1);
> }
> if ((opts.server_minor_version < 3)
> - || (opts.server_minor_version > 6))
> + || (opts.server_minor_version > 8))
Shouldn't this be opts.server_minor_version >= SVN_VER_MINOR so we don't have
to remember to update this everytime? Doesn't help if we change the major, but
the code already has that issue.