You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by "zmdstr (GitHub)" <gi...@apache.org> on 2019/03/30 14:44:37 UTC

[GitHub] [incubator-dubbo-admin] zmdstr opened pull request #352: refactor:fix comment


[ Full content available at: https://github.com/apache/incubator-dubbo-admin/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-admin] codecov-io commented on issue #352: refactor:fix comment

Posted by "codecov-io (GitHub)" <gi...@apache.org>.

# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/352?src=pr&el=h1) Report
> Merging [#352](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/352?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-admin/commit/74a9c5726469dd3a253be16109cd2ddb3a58a982?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/352/graphs/tree.svg?width=650&token=fYsc8RuDGB&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/352?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##             develop     #352   +/-   ##
==========================================
  Coverage      22.37%   22.37%           
- Complexity       289      290    +1     
==========================================
  Files             76       76           
  Lines           3142     3142           
  Branches         526      526           
==========================================
  Hits             703      703           
  Misses          2364     2364           
  Partials          75       75
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/352?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ache/dubbo/admin/service/impl/AbstractService.java](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/352/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9zZXJ2aWNlL2ltcGwvQWJzdHJhY3RTZXJ2aWNlLmphdmE=) | `66.66% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: |
| [.../dubbo/admin/service/impl/ProviderServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/352/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9zZXJ2aWNlL2ltcGwvUHJvdmlkZXJTZXJ2aWNlSW1wbC5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...che/dubbo/admin/service/impl/RouteServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/352/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9zZXJ2aWNlL2ltcGwvUm91dGVTZXJ2aWNlSW1wbC5qYXZh) | `40.79% <ø> (ø)` | `13 <0> (ø)` | :arrow_down: |
| [.../dubbo/admin/service/impl/OverrideServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/352/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9zZXJ2aWNlL2ltcGwvT3ZlcnJpZGVTZXJ2aWNlSW1wbC5qYXZh) | `0.57% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/352?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/352?src=pr&el=footer). Last update [74a9c57...c486fe4](https://codecov.io/gh/apache/incubator-dubbo-admin/pull/352?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo-admin/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-admin] kexianjun commented on issue #352: refactor:fix comment

Posted by "kexianjun (GitHub)" <gi...@apache.org>.

So can we close this issue?

[ Full content available at: https://github.com/apache/incubator-dubbo-admin/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-admin] kezhenxu94 commented on issue #352: refactor:fix comment

Posted by "kezhenxu94 (GitHub)" <gi...@apache.org>.

> @kezhenxu94 agree

@zmdstr Well then, can you just remove the JavaDoc or write some helpful JavaDoc for those classes?

[ Full content available at: https://github.com/apache/incubator-dubbo-admin/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-admin] zmdstr commented on issue #352: refactor:fix comment

Posted by "zmdstr (GitHub)" <gi...@apache.org>.

@kezhenxu94 agree

[ Full content available at: https://github.com/apache/incubator-dubbo-admin/pull/352 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org