You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ka...@apache.org on 2015/03/16 23:38:03 UTC
cordova-lib git commit: CB-8670 Error when set engine name to
"cordova-windows" in plugin.xml
Repository: cordova-lib
Updated Branches:
refs/heads/master ea788e101 -> 41835f40f
CB-8670 Error when set engine name to "cordova-windows" in plugin.xml
If you create an engine element with name="cordova-windows" in plugin.xml, like this:
<engines>
<engine name="cordova-windows" version=">=3.8.0" />
</engines>
You will get an error when you add the plugin:
TypeError: Cannot call method 'indexOf' of undefined
at ...\cordova-lib\src\plugman\install.js:232:45
Github: close #185
Project: http://git-wip-us.apache.org/repos/asf/cordova-lib/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-lib/commit/41835f40
Tree: http://git-wip-us.apache.org/repos/asf/cordova-lib/tree/41835f40
Diff: http://git-wip-us.apache.org/repos/asf/cordova-lib/diff/41835f40
Branch: refs/heads/master
Commit: 41835f40f62b5682edbb505697f250ea836bab50
Parents: ea788e1
Author: Tim Barham <ti...@microsoft.com>
Authored: Fri Mar 13 22:25:03 2015 +1000
Committer: Mark Koudritsky <ka...@gmail.com>
Committed: Mon Mar 16 18:35:40 2015 -0400
----------------------------------------------------------------------
cordova-lib/src/plugman/util/default-engines.js | 2 ++
1 file changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/41835f40/cordova-lib/src/plugman/util/default-engines.js
----------------------------------------------------------------------
diff --git a/cordova-lib/src/plugman/util/default-engines.js b/cordova-lib/src/plugman/util/default-engines.js
index 80efe30..16b5b33 100644
--- a/cordova-lib/src/plugman/util/default-engines.js
+++ b/cordova-lib/src/plugman/util/default-engines.js
@@ -35,6 +35,8 @@ module.exports = function(project_dir){
{ 'platform':'wp8', 'scriptSrc': path.join(project_dir,'cordova','version') },
'cordova-windows8':
{ 'platform':'windows8', 'scriptSrc': path.join(project_dir,'cordova','version') },
+ 'cordova-windows':
+ { 'platform':'windows', 'scriptSrc': path.join(project_dir,'cordova','version') },
'apple-xcode' :
{ 'platform':'ios', 'scriptSrc': path.join(project_dir,'cordova','apple_xcode_version') },
'apple-ios' :
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org