You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/01/09 22:57:20 UTC

[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #426: HDDS-2864. TestOMDbCheckpointServlet fails due to real Recon

adoroszlai opened a new pull request #426: HDDS-2864. TestOMDbCheckpointServlet fails due to real Recon
URL: https://github.com/apache/hadoop-ozone/pull/426
 
 
   ## What changes were proposed in this pull request?
   
   `TestOMDbCheckpointServlet` verifies that no checkspoints have been taken before it invokes the servlet.  However, the same servlet is used by the actual Recon server in the mini cluster (added [very recently](https://github.com/apache/hadoop-ozone/commit/8748498b8)).
   
   This PR proposes to remove the assertions about initial state, as they are not strictly necessary to validate behavior.
   
   https://issues.apache.org/jira/browse/HDDS-2864
   
   ## How was this patch tested?
   
   Ran the test locally, as well as on branch with integration tests enabled:
   
   ```
   Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.033 s - in org.apache.hadoop.ozone.om.TestOMDbCheckpointServlet
   ```
   
   https://github.com/adoroszlai/hadoop-ozone/runs/382195722

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] elek closed pull request #426: HDDS-2864. TestOMDbCheckpointServlet fails due to real Recon

Posted by GitBox <gi...@apache.org>.
elek closed pull request #426: HDDS-2864. TestOMDbCheckpointServlet fails due to real Recon
URL: https://github.com/apache/hadoop-ozone/pull/426
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] adoroszlai commented on issue #426: HDDS-2864. TestOMDbCheckpointServlet fails due to real Recon

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #426: HDDS-2864. TestOMDbCheckpointServlet fails due to real Recon
URL: https://github.com/apache/hadoop-ozone/pull/426#issuecomment-577661813
 
 
   Thanks @avijayanhwx and @elek for reviews, and @elek for committing it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] adoroszlai commented on issue #426: HDDS-2864. TestOMDbCheckpointServlet fails due to real Recon

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #426: HDDS-2864. TestOMDbCheckpointServlet fails due to real Recon
URL: https://github.com/apache/hadoop-ozone/pull/426#issuecomment-577650655
 
 
   Added checkpoints counter in `OMMetrics` to make the test a bit more strict.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] adoroszlai commented on issue #426: HDDS-2864. TestOMDbCheckpointServlet fails due to real Recon

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #426: HDDS-2864. TestOMDbCheckpointServlet fails due to real Recon
URL: https://github.com/apache/hadoop-ozone/pull/426#issuecomment-572914394
 
 
   @avijayanhwx @swagle please review

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] avijayanhwx commented on issue #426: HDDS-2864. TestOMDbCheckpointServlet fails due to real Recon

Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on issue #426: HDDS-2864. TestOMDbCheckpointServlet fails due to real Recon
URL: https://github.com/apache/hadoop-ozone/pull/426#issuecomment-574859112
 
 
   LGTM +1. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org