You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/03/06 07:34:04 UTC
Review Request 65915: Validated Docker info exists when container's
type is DOCKER.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65915/
-----------------------------------------------------------
Review request for mesos and Gilbert Song.
Bugs: MESOS-8640
https://issues.apache.org/jira/browse/MESOS-8640
Repository: mesos
Description
-------
Validated Docker info exists when container's type is DOCKER.
Diffs
-----
src/common/validation.cpp bad9ea8a712162ba24a9a8ada02fe6cbe48f5c80
Diff: https://reviews.apache.org/r/65915/diff/1/
Testing
-------
This patch will make the test `TaskGroupValidationTest.TaskUsesDockerContainerInfo` fails, I fix it in a subsequent patch: https://reviews.apache.org/r/65916
Thanks,
Qian Zhang
Re: Review Request 65915: Validated Docker info exists when
container's type is DOCKER.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65915/#review199053
-----------------------------------------------------------
Fix it, then Ship it!
src/common/validation.cpp
Lines 273 (patched)
<https://reviews.apache.org/r/65915/#comment279351>
DockerInfo 'docker' is not set for DOCKER typed ContainerInfo.
- Gilbert Song
On March 5, 2018, 11:34 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65915/
> -----------------------------------------------------------
>
> (Updated March 5, 2018, 11:34 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-8640
> https://issues.apache.org/jira/browse/MESOS-8640
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Validated Docker info exists when container's type is DOCKER.
>
>
> Diffs
> -----
>
> src/common/validation.cpp bad9ea8a712162ba24a9a8ada02fe6cbe48f5c80
>
>
> Diff: https://reviews.apache.org/r/65915/diff/1/
>
>
> Testing
> -------
>
> This patch will make the test `TaskGroupValidationTest.TaskUsesDockerContainerInfo` fails, I fix it in a subsequent patch: https://reviews.apache.org/r/65916
>
>
> Thanks,
>
> Qian Zhang
>
>