You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:15:49 UTC

[GitHub] [airflow] ashb commented on pull request #16397: Don't run tests for deprecated method on DAG class

ashb commented on pull request #16397:
URL: https://github.com/apache/airflow/pull/16397#issuecomment-859929720


   In the general terms you are right, but in this case the function is very simple:
   
   ```python
           dag_ids = dag_ids or [self.dag_id]
           query = session.query(DagRun).filter(DagRun.dag_id.in_(dag_ids))
           if start_date:
               query = query.filter(DagRun.execution_date >= start_date)
           if end_date:
               query = query.filter(DagRun.execution_date <= end_date)
           query.update({DagRun.state: state}, synchronize_session='fetch')
   ```
   
   I've been on a bit of a kick to remove warnings from the test suite tonight. I could have just captured the deprecation warning for this test in hindsight. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org