You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/04/02 07:45:09 UTC
Re: Review Request 45217: Implemented docker volume driver isolator
interface.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45217/
-----------------------------------------------------------
(Updated 四月 2, 2016, 5:45 a.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013
Repository: mesos
Description
-------
Implemented docker volume driver isolator interface.
Diffs (updated)
-----
src/CMakeLists.txt ff225c0d51a32b03a1b5f2ba31718ec2305c7ced
src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2
src/slave/containerizer/mesos/isolators/docker/dvd/dvd.hpp PRE-CREATION
src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/45217/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 45217: Implemented docker volume driver isolator
interface.
Posted by Guangya Liu <gy...@gmail.com>.
> On 四月 4, 2016, 11:01 p.m., Gilbert Song wrote:
> > src/Makefile.am, line 860
> > <https://reviews.apache.org/r/45217/diff/4/?file=1322987#file1322987line860>
> >
> > Could you move it below runtime.cpp?
>
> Guangya Liu wrote:
> There are some files such as spec.proto, dvd_client.cpp, dvd_client.hpp, dvd.cpp, dvd.hpp etc, I want to put them into ta single folder to make it clear, comments?
It was moved to docker/volume
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45217/#review126794
-----------------------------------------------------------
On 四月 13, 2016, 3:18 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45217/
> -----------------------------------------------------------
>
> (Updated 四月 13, 2016, 3:18 a.m.)
>
>
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
>
>
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented docker volume driver isolator interface.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041
> src/Makefile.am a8f68316c5d4d4c82d99363535a97fa5b1caafc5
> src/slave/containerizer/mesos/isolators/docker/dvd/dvd.hpp PRE-CREATION
> src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45217/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45217: Implemented docker volume driver isolator
interface.
Posted by Guangya Liu <gy...@gmail.com>.
> On 四月 4, 2016, 11:01 p.m., Gilbert Song wrote:
> > src/Makefile.am, line 860
> > <https://reviews.apache.org/r/45217/diff/4/?file=1322987#file1322987line860>
> >
> > Could you move it below runtime.cpp?
There are some files such as spec.proto, dvd_client.cpp, dvd_client.hpp, dvd.cpp, dvd.hpp etc, I want to put them into ta single folder to make it clear, comments?
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45217/#review126794
-----------------------------------------------------------
On 四月 2, 2016, 5:45 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45217/
> -----------------------------------------------------------
>
> (Updated 四月 2, 2016, 5:45 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented docker volume driver isolator interface.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt ff225c0d51a32b03a1b5f2ba31718ec2305c7ced
> src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2
> src/slave/containerizer/mesos/isolators/docker/dvd/dvd.hpp PRE-CREATION
> src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45217/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45217: Implemented docker volume driver isolator
interface.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45217/#review126794
-----------------------------------------------------------
src/Makefile.am (line 860)
<https://reviews.apache.org/r/45217/#comment189874>
Could you move it below runtime.cpp?
src/Makefile.am (line 882)
<https://reviews.apache.org/r/45217/#comment189875>
ditto.
src/slave/containerizer/mesos/isolators/docker/dvd/dvd.hpp (line 26)
<https://reviews.apache.org/r/45217/#comment189876>
Could we add a brief comment above? Thanks.
- Gilbert Song
On April 1, 2016, 10:45 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45217/
> -----------------------------------------------------------
>
> (Updated April 1, 2016, 10:45 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented docker volume driver isolator interface.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt ff225c0d51a32b03a1b5f2ba31718ec2305c7ced
> src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2
> src/slave/containerizer/mesos/isolators/docker/dvd/dvd.hpp PRE-CREATION
> src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45217/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45217: Implemented docker volume driver isolator
interface.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45217/#review128919
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On April 13, 2016, 5:32 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45217/
> -----------------------------------------------------------
>
> (Updated April 13, 2016, 5:32 p.m.)
>
>
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
>
>
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented docker volume driver isolator interface.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041
> src/Makefile.am a8f68316c5d4d4c82d99363535a97fa5b1caafc5
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp PRE-CREATION
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45217/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45217: Implemented docker volume driver isolator
interface.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45217/#review128985
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On April 14, 2016, 12:32 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45217/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 12:32 a.m.)
>
>
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
>
>
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented docker volume driver isolator interface.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041
> src/Makefile.am a8f68316c5d4d4c82d99363535a97fa5b1caafc5
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp PRE-CREATION
> src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45217/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45217: Implemented docker volume driver isolator
interface.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45217/
-----------------------------------------------------------
(Updated 四月 14, 2016, 12:32 a.m.)
Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013
Repository: mesos
Description
-------
Implemented docker volume driver isolator interface.
Diffs (updated)
-----
src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041
src/Makefile.am a8f68316c5d4d4c82d99363535a97fa5b1caafc5
src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp PRE-CREATION
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/45217/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 45217: Implemented docker volume driver isolator
interface.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45217/
-----------------------------------------------------------
(Updated 四月 13, 2016, 10:29 p.m.)
Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013
Repository: mesos
Description
-------
Implemented docker volume driver isolator interface.
Diffs (updated)
-----
src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041
src/Makefile.am a8f68316c5d4d4c82d99363535a97fa5b1caafc5
src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp PRE-CREATION
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/45217/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 45217: Implemented docker volume driver isolator
interface.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45217/#review128721
-----------------------------------------------------------
Fix it, then Ship it!
src/CMakeLists.txt (line 143)
<https://reviews.apache.org/r/45217/#comment192186>
let's call it docker/volume isolator and put it under docker/volume/isolator.hpp|cpp
src/slave/containerizer/mesos/isolators/docker/dvd/dvd.hpp (line 25)
<https://reviews.apache.org/r/45217/#comment192187>
Kill one line here.
src/slave/containerizer/mesos/isolators/docker/dvd/dvd.hpp (line 30)
<https://reviews.apache.org/r/45217/#comment192188>
Let's call it `DockerVolumeIsolatorProcess`
- Jie Yu
On April 13, 2016, 3:18 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45217/
> -----------------------------------------------------------
>
> (Updated April 13, 2016, 3:18 a.m.)
>
>
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
>
>
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented docker volume driver isolator interface.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041
> src/Makefile.am a8f68316c5d4d4c82d99363535a97fa5b1caafc5
> src/slave/containerizer/mesos/isolators/docker/dvd/dvd.hpp PRE-CREATION
> src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45217/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45217: Implemented docker volume driver isolator
interface.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45217/
-----------------------------------------------------------
(Updated 四月 13, 2016, 3:18 a.m.)
Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013
Repository: mesos
Description
-------
Implemented docker volume driver isolator interface.
Diffs (updated)
-----
src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041
src/Makefile.am a8f68316c5d4d4c82d99363535a97fa5b1caafc5
src/slave/containerizer/mesos/isolators/docker/dvd/dvd.hpp PRE-CREATION
src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/45217/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu